[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression
Hello dwmw2, or anyone else affected, Accepted network-manager into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/network- manager/1.10.6-2ubuntu1.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: network-manager (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags removed: verification-done verification-done-bionic ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1754671 Title: Full-tunnel VPN DNS leakage regression To manage notifications about this bug go to: https://bugs.launchpad.net/network-manager/+bug/1754671/+subscriptions -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Bug 1806269] Re: nm-connection-editor crashes when trying to modify connection without gnome-keyring installed
Hello TJ, or anyone else affected, Accepted network-manager-applet into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source /network-manager-applet/1.8.10-2ubuntu3 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: network-manager-applet (Ubuntu Bionic) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Network- manager, which is subscribed to Network Manager Applet. https://bugs.launchpad.net/bugs/1806269 Title: nm-connection-editor crashes when trying to modify connection without gnome-keyring installed To manage notifications about this bug go to: https://bugs.launchpad.net/network-manager-applet/+bug/1806269/+subscriptions -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Bug 1718931] Re: No VPN autoconnect
@Mathieu, the issue described here was fixed, it's probably best to open a new bug (& upstream as well if possible) with a full journal log and description of your issue -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1718931 Title: No VPN autoconnect To manage notifications about this bug go to: https://bugs.launchpad.net/network-manager/+bug/1718931/+subscriptions -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic
Marco Trevisan (Treviño) has proposed merging
~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic into
~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic.
Commit message:
Sync VCS with packaging
Requested reviews:
Ubuntu Server Dev import team (usd-import-team)
Related bugs:
Bug #1767817 in nautilus (Ubuntu): "Full text search does not work"
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1767817
For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/nautilus/+git/nautilus/+merge/374710
--
Your team Ubuntu Desktop is subscribed to branch
~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic.
diff --git a/debian/changelog b/debian/changelog
index 17553e8..ad6d1f5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+nautilus (1:3.26.4-0~ubuntu18.04.4) bionic; urgency=medium
+
+ * d/p/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch:
+- update the patch to fix a logic error in the code which made tracker
+ never being used even if it's installed (lp: #1767817)
+
+ -- Sebastien Bacher Wed, 06 Mar 2019 17:31:08 +0100
+
nautilus (1:3.26.4-0~ubuntu18.04.3) bionic; urgency=medium
* debian/patches/git_captions_order.patch
diff --git a/debian/patches/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch b/debian/patches/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch
index 4cc55ed..d24e83c 100644
--- a/debian/patches/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch
+++ b/debian/patches/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch
@@ -6,10 +6,10 @@ Subject: tracker-search-engine: don't start it if not available on system
src/nautilus-search-engine-tracker.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
-diff --git a/src/nautilus-search-engine-tracker.c b/src/nautilus-search-engine-tracker.c
-index 8885ca4..050716d 100644
a/src/nautilus-search-engine-tracker.c
-+++ b/src/nautilus-search-engine-tracker.c
+Index: nautilus-3.26.4/src/nautilus-search-engine-tracker.c
+===
+--- nautilus-3.26.4.orig/src/nautilus-search-engine-tracker.c
nautilus-3.26.4/src/nautilus-search-engine-tracker.c
@@ -42,6 +42,7 @@ struct _NautilusSearchEngineTracker
gboolean query_pending;
GQueue *hits_pending;
@@ -18,7 +18,7 @@ index 8885ca4..050716d 100644
gboolean recursive;
gboolean fts_enabled;
-@@ -304,8 +305,15 @@ nautilus_search_engine_tracker_start (NautilusSearchProvider *provider)
+@@ -304,8 +305,15 @@ nautilus_search_engine_tracker_start (Na
return;
}
@@ -35,7 +35,7 @@ index 8885ca4..050716d 100644
tracker->query_pending = TRUE;
g_object_notify (G_OBJECT (provider), "running");
-@@ -471,6 +479,9 @@ nautilus_search_engine_tracker_set_query (NautilusSearchProvider *provider,
+@@ -471,6 +479,9 @@ nautilus_search_engine_tracker_set_query
g_clear_object (>query);
@@ -45,7 +45,7 @@ index 8885ca4..050716d 100644
tracker->query = g_object_ref (query);
tracker->recursive = is_recursive_search (NAUTILUS_SEARCH_ENGINE_TYPE_INDEXED,
nautilus_query_get_recursive (query),
-@@ -539,16 +550,21 @@ static void
+@@ -539,16 +550,23 @@ static void
nautilus_search_engine_tracker_init (NautilusSearchEngineTracker *engine)
{
GError *error = NULL;
@@ -54,8 +54,10 @@ index 8885ca4..050716d 100644
-engine->hits_pending = g_queue_new ();
-
-engine->connection = tracker_sparql_connection_get (NULL, );
-+if (!tracker_available)
++if (tracker_available)
+engine->connection = tracker_sparql_connection_get (NULL, );
++else
++return;
if (error)
{
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-xubuntu-cancel-search into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic
Ok, I've finally rebased this. -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/358477 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic-xubuntu-cancel-search into ~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic
Marco Trevisan (Treviño) has proposed merging
~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic-xubuntu-cancel-search into
~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic with
~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic as a prerequisite.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1756826 in nautilus (Ubuntu): "hangs when remote search provider
performs expensive operation"
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1756826
Bug #1767817 in nautilus (Ubuntu): "Full text search does not work"
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1767817
For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/nautilus/+git/nautilus/+merge/374711
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic-xubuntu-cancel-search into
~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic.
diff --git a/debian/changelog b/debian/changelog
index ad6d1f5..abea57d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+nautilus (1:3.26.4-0~ubuntu18.04.5) bionic; urgency=medium
+
+ * d/p/ubuntu/shell-search-provider-implement-XUbuntuCancel-to-request-.patch:
+- shell-search-provider: implement XUbuntuCancel to request pending search
+ cancellation from gnome-shell (LP: #1756826)
+
+ -- Marco Trevisan (Treviño) Fri, 25 Oct 2019 05:38:04 +0200
+
nautilus (1:3.26.4-0~ubuntu18.04.4) bionic; urgency=medium
* d/p/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch:
diff --git a/debian/patches/series b/debian/patches/series
index 9417da4..3ec0d73 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -26,3 +26,4 @@ appstream-compulsory.patch
nautilusgtkplacesview-show-error-if-volume-is-not-mo.patch
file-view-Always-unset-pending_selection-after-freeing-it.patch
git_captions_order.patch
+ubuntu/shell-search-provider-implement-XUbuntuCancel-to-request-.patch
diff --git a/debian/patches/ubuntu/shell-search-provider-implement-XUbuntuCancel-to-request-.patch b/debian/patches/ubuntu/shell-search-provider-implement-XUbuntuCancel-to-request-.patch
new file mode 100644
index 000..85fa0c2
--- /dev/null
+++ b/debian/patches/ubuntu/shell-search-provider-implement-XUbuntuCancel-to-request-.patch
@@ -0,0 +1,213 @@
+From: =?utf-8?b?Ik1hcmNvIFRyZXZpc2FuIChUcmV2acOxbyki?=
+Date: Tue, 28 Aug 2018 01:44:49 +0200
+Subject: shell-search-provider: implement XUbuntuCancel to request search
+ cancellation
+
+Stop search and Metadata fetching on XUbuntuCancel dbus method call.
+Only allow this if the caller is the same who triggered the actual event.
+
+Bug-GNOME: https://gitlab.gnome.org/GNOME/gnome-shell/issues/183
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/bionic/+source/nautilus/+bug/1756826
+Forwarded: not-needed
+---
+ data/shell-search-provider-dbus-interfaces.xml | 1 +
+ src/nautilus-shell-search-provider.c | 96 +++---
+ 2 files changed, 88 insertions(+), 9 deletions(-)
+
+diff --git a/data/shell-search-provider-dbus-interfaces.xml b/data/shell-search-provider-dbus-interfaces.xml
+index f6840e2..4529c1e 100644
+--- a/data/shell-search-provider-dbus-interfaces.xml
b/data/shell-search-provider-dbus-interfaces.xml
+@@ -40,5 +40,6 @@
+
+
+
++
+
+
+diff --git a/src/nautilus-shell-search-provider.c b/src/nautilus-shell-search-provider.c
+index ffc2b7f..58864d6 100644
+--- a/src/nautilus-shell-search-provider.c
b/src/nautilus-shell-search-provider.c
+@@ -60,6 +60,7 @@ struct _NautilusShellSearchProvider
+
+ PendingSearch *current_search;
+
++GList *metas_requests;
+ GHashTable *metas_cache;
+ };
+
+@@ -143,11 +144,25 @@ pending_search_finish (PendingSearch *search,
+ }
+
+ static void
+-cancel_current_search (NautilusShellSearchProvider *self)
++cancel_current_search (NautilusShellSearchProvider *self,
++ gboolean ignore_partial_results)
+ {
+-if (self->current_search != NULL)
++PendingSearch *search = self->current_search;
++
++if (search != NULL)
+ {
+-nautilus_search_provider_stop (NAUTILUS_SEARCH_PROVIDER (self->current_search->engine));
++g_debug ("*** Cancel current search");
++
++nautilus_search_provider_stop (NAUTILUS_SEARCH_PROVIDER (search->engine));
++
++if (ignore_partial_results)
++{
++g_signal_handlers_disconnect_by_data (G_OBJECT (search->engine),
++ search);
++
++pending_search_finish (search, search->invocation,
++ g_variant_new ("(as)", NULL));
++}
+ }
+ }
+
+@@ -451,7 +466,7 @@ execute_search (NautilusShellSearchProvider *self,
+ NautilusQuery *query;
+ PendingSearch *pending_search;
+
+-cancel_current_search (self);
++cancel_current_search (self, FALSE);
+
+ /* don't attempt searches for a single
[Merge] ~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic-xubuntu-cancel-search into ~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic
The proposal to merge ~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic-xubuntu-cancel-search into ~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~3v1n0/ubuntu/+source/nautilus/+git/nautilus/+merge/354346 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic-xubuntu-cancel-search into ~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~3v1n0/ubuntu/+source/mutter:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master
Marco Trevisan (Treviño) has proposed merging
~3v1n0/ubuntu/+source/mutter:ubuntu/master into
~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/mutter/+git/mutter/+merge/374693
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~3v1n0/ubuntu/+source/mutter:ubuntu/master into
~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master.
diff --git a/clutter/clutter/clutter-actor-private.h b/clutter/clutter/clutter-actor-private.h
index 119ec42..fa2d4c3 100644
--- a/clutter/clutter/clutter-actor-private.h
+++ b/clutter/clutter/clutter-actor-private.h
@@ -274,6 +274,9 @@ void_clutter_actor_set_enable_paint_unmapped
void_clutter_actor_set_has_pointer (ClutterActor *self,
gboolean has_pointer);
+void_clutter_actor_set_has_key_focus(ClutterActor *self,
+ gboolean has_key_focus);
+
void_clutter_actor_queue_redraw_with_clip (ClutterActor *self,
ClutterRedrawFlagsflags,
const ClutterPaintVolume *clip_volume);
diff --git a/clutter/clutter/clutter-actor.c b/clutter/clutter/clutter-actor.c
index e763291..ecf9a59 100644
--- a/clutter/clutter/clutter-actor.c
+++ b/clutter/clutter/clutter-actor.c
@@ -835,6 +835,7 @@ struct _ClutterActorPrivate
guint enable_model_view_transform : 1;
guint enable_paint_unmapped : 1;
guint has_pointer : 1;
+ guint has_key_focus : 1;
guint propagated_one_redraw : 1;
guint paint_volume_valid : 1;
guint last_paint_volume_valid : 1;
@@ -1692,6 +1693,20 @@ clutter_actor_is_mapped (ClutterActor *self)
}
static void
+maybe_unset_key_focus (ClutterActor *self)
+{
+ ClutterActor *stage;
+
+ if (!self->priv->has_key_focus)
+return;
+
+ stage = _clutter_actor_get_stage_internal (self);
+
+ if (stage)
+clutter_stage_set_key_focus (CLUTTER_STAGE (stage), NULL);
+}
+
+static void
clutter_actor_real_unmap (ClutterActor *self)
{
ClutterActorPrivate *priv = self->priv;
@@ -1724,17 +1739,7 @@ clutter_actor_real_unmap (ClutterActor *self)
/* relinquish keyboard focus if we were unmapped while owning it */
if (!CLUTTER_ACTOR_IS_TOPLEVEL (self))
-{
- ClutterStage *stage;
-
- stage = CLUTTER_STAGE (_clutter_actor_get_stage_internal (self));
-
- if (stage != NULL &&
- clutter_stage_get_key_focus (stage) == self)
-{
- clutter_stage_set_key_focus (stage, NULL);
-}
-}
+maybe_unset_key_focus (self);
}
/**
@@ -6064,6 +6069,8 @@ clutter_actor_dispose (GObject *object)
object->ref_count,
g_type_name (G_OBJECT_TYPE (self)));
+ maybe_unset_key_focus (self);
+
/* Stop the emission of any property change */
g_object_freeze_notify (object);
@@ -15979,6 +15986,9 @@ clutter_actor_grab_key_focus (ClutterActor *self)
g_return_if_fail (CLUTTER_IS_ACTOR (self));
+ if (self->priv->has_key_focus)
+return;
+
stage = _clutter_actor_get_stage_internal (self);
if (stage != NULL)
clutter_stage_set_key_focus (CLUTTER_STAGE (stage), self);
@@ -16768,6 +16778,23 @@ _clutter_actor_set_has_pointer (ClutterActor *self,
}
}
+void
+_clutter_actor_set_has_key_focus (ClutterActor *self,
+ gboolean has_key_focus)
+{
+ ClutterActorPrivate *priv = self->priv;
+
+ if (priv->has_key_focus != has_key_focus)
+{
+ priv->has_key_focus = has_key_focus;
+
+ if (has_key_focus)
+g_signal_emit (self, actor_signals[KEY_FOCUS_IN], 0);
+ else
+g_signal_emit (self, actor_signals[KEY_FOCUS_OUT], 0);
+}
+}
+
/**
* clutter_actor_get_text_direction:
* @self: a #ClutterActor
@@ -17616,15 +17643,9 @@ clutter_actor_clear_effects (ClutterActor *self)
gboolean
clutter_actor_has_key_focus (ClutterActor *self)
{
- ClutterActor *stage;
-
g_return_val_if_fail (CLUTTER_IS_ACTOR (self), FALSE);
- stage = _clutter_actor_get_stage_internal (self);
- if (stage == NULL)
-return FALSE;
-
- return clutter_stage_get_key_focus (CLUTTER_STAGE (stage)) == self;
+ return self->priv->has_key_focus;
}
static gboolean
diff --git a/clutter/clutter/clutter-shader-effect.c b/clutter/clutter/clutter-shader-effect.c
index a5ae1ee..c659dab 100644
--- a/clutter/clutter/clutter-shader-effect.c
+++ b/clutter/clutter/clutter-shader-effect.c
@@ -500,6 +500,7 @@
