[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression

2019-11-03 Thread Dariusz Gadomski 
I have just run the test case from this bug description on the bionic-proposed 
version 1.10.6-2ubuntu1.2.
tcpdump does not show any leak of the VPN-specific queries. I have not observed 
other issues in my tests.

** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Network-
manager, which is subscribed to NetworkManager.
https://bugs.launchpad.net/bugs/1754671

Title:
  Full-tunnel VPN DNS leakage regression

To manage notifications about this bug go to:
https://bugs.launchpad.net/network-manager/+bug/1754671/+subscriptions

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop

[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression

2019-10-11 Thread Dariusz Gadomski 
I have backported what was listed as nm-1-10 fix for the bug in the upstream 
bugzilla [1].
I have also applied fixes for bug #1825946 and bug #1790098 to it.

[1]
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1e486a721de1fec76c81bfc461671a7fbdae531b

After testing this build for some time (available at ppa:dgadomski
/network-manager) I haven't found any problems.

@Till I'd appreciate you having a look at it. Thanks!

** Patch added: "bionic_network-manager_1.10.6-2ubuntu1.2.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1754671/+attachment/5296236/+files/bionic_network-manager_1.10.6-2ubuntu1.2.debdiff

-- 
You received this bug notification because you are a member of Network-
manager, which is subscribed to NetworkManager.
https://bugs.launchpad.net/bugs/1754671

Title:
  Full-tunnel VPN DNS leakage regression

To manage notifications about this bug go to:
https://bugs.launchpad.net/network-manager/+bug/1754671/+subscriptions

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop

Re: [Merge] lp:~dgadomski/unity-settings-daemon/lp1755490 into lp:unity-settings-daemon

2018-11-15 Thread Dariusz Gadomski 
It needs a separate fix for mutter [1]. I've prepared a patch for it [2]. It 
has been accepted, but I was told to wait until 3.32 due to introducing a new 
translation string.

[1] https://gitlab.gnome.org/GNOME/mutter/issues/292
[2] https://gitlab.gnome.org/GNOME/mutter/merge_requests/223
-- 
https://code.launchpad.net/~dgadomski/unity-settings-daemon/lp1755490/+merge/346885
Your team Unity Settings Daemon Development Team is subscribed to branch 
lp:unity-settings-daemon.

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop

[Merge] ~dgadomski/ubuntu/+source/gdm3/+git/lp1782152:unblock-sigusr1 into ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic

2018-08-15 Thread Dariusz Gadomski 
Dariusz Gadomski has proposed merging 
~dgadomski/ubuntu/+source/gdm3/+git/lp1782152:unblock-sigusr1 into 
~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic.

Commit message:
[ Alberto Milone ]
  * ubuntu_nvidia_prime.patch:
- Run scripts for Prime before and after Gdm sessions (LP: #1778011).
[ Dariusz Gadomski ]
  * debian/patches/unblock-sigusr1.patch:
- Unblock SIGUSR1 before PAM. (LP: #1782152)


Requested reviews:
  Ubuntu Desktop (ubuntu-desktop)
Related bugs:
  Bug #1778011 in nvidia-prime (Ubuntu): "SRU: PRIME Power Saving mode draws 
too much power"
  https://bugs.launchpad.net/ubuntu/+source/nvidia-prime/+bug/1778011
  Bug #1782152 in gdm3 (Ubuntu): "GDM blocks SIGUSR1 used in PAM scripts"
  https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1782152

For more details, see:
https://code.launchpad.net/~dgadomski/ubuntu/+source/gdm3/+git/lp1782152/+merge/353089

Rebased on top of 3.28.3.
-- 
Your team Ubuntu Desktop is requested to review the proposed merge of 
~dgadomski/ubuntu/+source/gdm3/+git/lp1782152:unblock-sigusr1 into 
~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic.
diff --git a/debian/patches/series b/debian/patches/series
index 8a5cba3..ed7aa6c 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -11,3 +11,4 @@ revert_override_LANG_with_accountservices.patch
 ubuntu_config_error_dialog.patch
 ubuntu_dont_set_language_env.patch
 ubuntu_prefer_ubuntu_session_fallback.patch
+unblock-sigusr1.patch
diff --git a/debian/patches/ubuntu_nvidia_prime.patch b/debian/patches/ubuntu_nvidia_prime.patch
index d2588b1..bf60c76 100644
--- a/debian/patches/ubuntu_nvidia_prime.patch
+++ b/debian/patches/ubuntu_nvidia_prime.patch
@@ -1,24 +1,25 @@
 From: Tim Lunn 
 Date: Sat, 22 Mar 2014 10:23:12 +1100
-Subject: Add hook to run prime-offload (as root) move Prime helpers into the
- gdm-x-session wrapper
-
++Subject: Add hooks to run prime scripts (as root) before and after a
++ gdm-session
+ 
++This allows enabling and disabling the dGPU on log out.
 ---
- common/gdm-common.c|  2 +-
- daemon/gdm-display.c   |  1 +
- daemon/gdm-x-session.c | 10 ++
- data/Makefile.am   | 24 
- data/Prime |  6 ++
- data/PrimeOff  |  6 ++
+ common/gdm-common.c|2 +-
+ daemon/gdm-session.c   |6 ++
+ daemon/gdm-x-session.c |5 +
+ data/Makefile.am   |   24 
+ data/Prime |6 ++
+ data/PrimeOff  |6 ++
  6 files changed, 48 insertions(+), 1 deletion(-)
  create mode 100644 data/Prime
  create mode 100644 data/PrimeOff
 
-Index: gdm3-3.26.0/common/gdm-common.c
+Index: gdm3-3.28.2/common/gdm-common.c
 ===
 gdm3-3.26.0.orig/common/gdm-common.c	2017-09-14 08:24:10.584748891 -0400
-+++ gdm3-3.26.0/common/gdm-common.c	2017-09-14 08:24:10.580748834 -0400
-@@ -677,7 +677,7 @@ gdm_run_script (const char *dir,
+--- gdm3-3.28.2.orig/common/gdm-common.c
 gdm3-3.28.2/common/gdm-common.c
+@@ -706,7 +706,7 @@
  goto out;
  }
  
@@ -27,23 +28,28 @@ Index: gdm3-3.26.0/common/gdm-common.c
display_name,
display_hostname,
display_x11_authority_file);
-Index: gdm3-3.26.0/daemon/gdm-x-session.c
+Index: gdm3-3.28.2/daemon/gdm-session.c
 ===
 gdm3-3.26.0.orig/daemon/gdm-x-session.c	2017-09-14 08:24:10.584748891 -0400
-+++ gdm3-3.26.0/daemon/gdm-x-session.c	2017-09-14 08:24:10.580748834 -0400
-@@ -172,6 +172,11 @@ on_x_server_finished (GSubprocess  *subp
- if (cancelled) {
- goto out;
- }
-+gdm_run_script (GDMCONFDIR "/PrimeOff", "root",
-+   state->display_name,
-+   NULL, /* hostname */
-+   state->auth_file);
+--- gdm3-3.28.2.orig/daemon/gdm-session.c
 gdm3-3.28.2/daemon/gdm-session.c
+@@ -2865,6 +2865,12 @@
+ 
+ g_list_free_full (self->priv->outside_connections, g_object_unref);
+ self->priv->outside_connections = NULL;
 +
++/* Run PrimeOff after the session is closed */
++gdm_run_script (GDMCONFDIR "/PrimeOff", "root",
++NULL,
++NULL,
++NULL);
+ }
  
- if (g_subprocess_get_if_exited (subprocess)) {
- int exit_status;
-@@ -614,6 +619,11 @@ spawn_session (State*state,
+ void
+Index: gdm3-3.28.2/daemon/gdm-x-session.c
+===
+--- gdm3-3.28.2.orig/daemon/gdm-x-session.c
 gdm3-3.28.2/daemon/gdm-x-session.c
+@@ -614,6 +614,11 @@
  
  g_debug ("Running X session");
  
@@ -55,11 +61,11 @@

[Merge] ~dgadomski/ubuntu/+source/gdm3/+git/lp1782152:bionic into ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic

2018-08-14 Thread Dariusz Gadomski 
Dariusz Gadomski has proposed merging 
~dgadomski/ubuntu/+source/gdm3/+git/lp1782152:bionic into 
~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic.

Commit message:
[ Alberto Milone ]
* ubuntu_nvidia_prime.patch:
  - Run scripts for Prime before and after Gdm sessions (LP: #1778011).

[ Dariusz Gadomski ]
* debian/patches/unblock-sigusr1.patch:
  - Unblock SIGUSR1 before PAM. (LP: #1782152)

Requested reviews:
  Ubuntu Desktop (ubuntu-desktop)
Related bugs:
  Bug #1778011 in nvidia-prime (Ubuntu): "SRU: PRIME Power Saving mode draws 
too much power"
  https://bugs.launchpad.net/ubuntu/+source/nvidia-prime/+bug/1778011
  Bug #1782152 in gdm3 (Ubuntu): "GDM blocks SIGUSR1 used in PAM scripts"
  https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1782152

For more details, see:
https://code.launchpad.net/~dgadomski/ubuntu/+source/gdm3/+git/lp1782152/+merge/352976
-- 
Your team Ubuntu Desktop is requested to review the proposed merge of 
~dgadomski/ubuntu/+source/gdm3/+git/lp1782152:bionic into 
~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic.
diff --git a/debian/changelog b/debian/changelog
index 9908170..d8bac21 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,15 @@
+gdm3 (3.28.2-0ubuntu1.4) bionic; urgency=medium
+
+  [ Alberto Milone ]
+  * ubuntu_nvidia_prime.patch:
+- Run scripts for Prime before and after Gdm sessions (LP: #1778011).
+
+  [ Dariusz Gadomski ]
+  * debian/patches/unblock-sigusr1.patch:
+- Unblock SIGUSR1 before PAM. (LP: #1782152)
+
+ -- Dariusz Gadomski   Mon, 13 Aug 2018 14:37:55 +0200
+
 gdm3 (3.28.2-0ubuntu1.3) bionic; urgency=medium
 
   * debian/patches/daemon-gdm-session-record.c-open-close-the-utmp-database.patch:
diff --git a/debian/patches/series b/debian/patches/series
index cad9b06..2044149 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -25,3 +25,4 @@ revert_override_LANG_with_accountservices.patch
 ubuntu_config_error_dialog.patch
 ubuntu_dont_set_language_env.patch
 ubuntu_prefer_ubuntu_session_fallback.patch
+unblock-sigusr1.patch
diff --git a/debian/patches/ubuntu_nvidia_prime.patch b/debian/patches/ubuntu_nvidia_prime.patch
index d2588b1..bf60c76 100644
--- a/debian/patches/ubuntu_nvidia_prime.patch
+++ b/debian/patches/ubuntu_nvidia_prime.patch
@@ -1,24 +1,25 @@
 From: Tim Lunn 
 Date: Sat, 22 Mar 2014 10:23:12 +1100
-Subject: Add hook to run prime-offload (as root) move Prime helpers into the
- gdm-x-session wrapper
-
++Subject: Add hooks to run prime scripts (as root) before and after a
++ gdm-session
+ 
++This allows enabling and disabling the dGPU on log out.
 ---
- common/gdm-common.c|  2 +-
- daemon/gdm-display.c   |  1 +
- daemon/gdm-x-session.c | 10 ++
- data/Makefile.am   | 24 
- data/Prime |  6 ++
- data/PrimeOff  |  6 ++
+ common/gdm-common.c|2 +-
+ daemon/gdm-session.c   |6 ++
+ daemon/gdm-x-session.c |5 +
+ data/Makefile.am   |   24 
+ data/Prime |6 ++
+ data/PrimeOff  |6 ++
  6 files changed, 48 insertions(+), 1 deletion(-)
  create mode 100644 data/Prime
  create mode 100644 data/PrimeOff
 
-Index: gdm3-3.26.0/common/gdm-common.c
+Index: gdm3-3.28.2/common/gdm-common.c
 ===
 gdm3-3.26.0.orig/common/gdm-common.c	2017-09-14 08:24:10.584748891 -0400
-+++ gdm3-3.26.0/common/gdm-common.c	2017-09-14 08:24:10.580748834 -0400
-@@ -677,7 +677,7 @@ gdm_run_script (const char *dir,
+--- gdm3-3.28.2.orig/common/gdm-common.c
 gdm3-3.28.2/common/gdm-common.c
+@@ -706,7 +706,7 @@
  goto out;
  }
  
@@ -27,23 +28,28 @@ Index: gdm3-3.26.0/common/gdm-common.c
display_name,
display_hostname,
display_x11_authority_file);
-Index: gdm3-3.26.0/daemon/gdm-x-session.c
+Index: gdm3-3.28.2/daemon/gdm-session.c
 ===
 gdm3-3.26.0.orig/daemon/gdm-x-session.c	2017-09-14 08:24:10.584748891 -0400
-+++ gdm3-3.26.0/daemon/gdm-x-session.c	2017-09-14 08:24:10.580748834 -0400
-@@ -172,6 +172,11 @@ on_x_server_finished (GSubprocess  *subp
- if (cancelled) {
- goto out;
- }
-+gdm_run_script (GDMCONFDIR "/PrimeOff", "root",
-+   state->display_name,
-+   NULL, /* hostname */
-+   state->auth_file);
+--- gdm3-3.28.2.orig/daemon/gdm-session.c
 gdm3-3.28.2/daemon/gdm-session.c
+@@ -2865,6 +2865,12 @@
+ 
+ g_list_free_full (self->priv->outside_connections, g_object_unref);
+ self->priv->outside_connections = NULL;
 +
++/* Run PrimeOff after the session is closed */
++gdm_run_script (GDMCONFDIR "/PrimeOff", &q

Protocol-specific mount flags for nautilus

2015-03-03 Thread Dariusz Gadomski 
Hello everyone,

I am dealing with the following usecase: a user who extensively utilizes
ACLs needs access to a number of smb shares. He accesses them via nautilus.
The problem is that by default nautilus doesn't use any mount flags that
could be useful in this case (i.e. user_xattr,acl) preventing execution of
any ACL rules. The needed options would always be the same for the same
kind of a share.

There is a bug regarding this problem [1], but the outcome was that the UI
for this would be to complicated to cover all possible options.

My idea is to somehow store the raw mount options (as an ENV variable or a
gsettings key) for a specific protocol (smb in this case) and use those
options for the given type of share whenever needed.

I would highly appreciate any hints of what should I consider when
implementing such change. Do you see any risks or unwanted consequences of
this approach?

[1] https://bugzilla.gnome.org/show_bug.cgi?id=585423

Thanks,
Dariusz
-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop