Re: [Merge] ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic
Review: Approve Thanks Marco! -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/354330 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic
The proposal to merge ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/354330 -- Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic
The proposal to merge ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/354330 -- Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic
Generally we do not like unnecessary changes carried by SRUs and normally this could be a potential reason for rejection. But generally gnome packages are covered by the Gnome MRE so in overall there's much more flexibility what can be released as part of the SRU (new upstream microreleases themselves don't really qualify as 'minimal set of changes'). Not sure if I was reading the git diff properly and if I saw all the debian/ changes that have been introduced as part of the merge with Debian, but with my SRU hat on I'd say it should be ok for some unrelated, safe noise with a new microrelease. -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/354330 Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic
Please get a +1 by the SRU team members (!= from the release team) and then, I'll approve it :) -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/354330 Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic
I asked Seb at the time and since the diff on debian/* was just few lines, he said it was ok. Then I noticed the clutter of the generated files, but in general should be something that is fine to go once release team is informed. -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/354330 Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic
Do we really want to merge with Debian for a SRU? This sounds like against the "minimal set of changes" that a SRU should have and may be rejected by the SRU team. Otherwise, +1 on the changes themselves for me, but before acking, please check with the SRU team. -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/354330 Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic
The proposal to merge ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic has been updated. Description changed to: Lots of garbage as per upstream changes (coming from debian merge), compare actual packaging changes with git diff ubuntu/1%3.28.1-1ubuntu1 debian For more details, see: https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/354330 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
