Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic

2018-11-12 Thread Iain Lane
Review: Approve

thanks!

please keep working to get those fixes upstream

I guess the revert should be reverted - can you propose an MP for that please?
-- 
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/358010
Your team Ubuntu Desktop is subscribed to branch 
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic.

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop


[Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic

2018-11-12 Thread noreply
The proposal to merge ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into 
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/358010
-- 
Your team Ubuntu Desktop is requested to review the proposed merge of 
~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into 
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic.

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop


[Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic

2018-11-06 Thread Treviño
The proposal to merge ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into 
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic has been updated.

Description changed to:

Reverting XUbuntuCancel patches, we will do them soon after this

For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/358010
-- 
Your team Ubuntu Desktop is requested to review the proposed merge of 
~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into 
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic.

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop


Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic

2018-11-06 Thread Daniel van Vugt
Review: Approve

The green stuff looks good to me.

I have no opinion on the red parts.
-- 
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/358010
Your team Ubuntu Desktop is requested to review the proposed merge of 
~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into 
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic.

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop


[Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic

2018-10-31 Thread Treviño
Marco Trevisan (Treviño) has proposed merging 
~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into 
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic with 
~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-touch-two-clicks-fix as a 
prerequisite.

Requested reviews:
  Ubuntu Desktop (ubuntu-desktop)
Related bugs:
  Bug #1725312 in gnome-shell (Ubuntu): "gnome-shell crashed with SIGSEGV in 
st_widget_style_changed() from st_scroll_view_style_changed()"
  https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1725312
  Bug #1739931 in gnome-shell (Ubuntu): "Separator lines in shell popup menus 
are too faint to see"
  https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1739931
  Bug #1743058 in gnome-shell (Ubuntu): "Input field height changes slightly 
when entering in st password fields."
  https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1743058
  Bug #1745888 in gnome-shell (Ubuntu): "Two instances of a program launch 
whenever you touch a favorites icon"
  https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1745888

For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/358010
-- 
Your team Ubuntu Desktop is requested to review the proposed merge of 
~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic-sru3 into 
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic.
diff --git a/debian/changelog b/debian/changelog
index c6ad925..c43929d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,16 +1,13 @@
 gnome-shell (3.28.3-0ubuntu0.18.04.3) UNRELEASED; urgency=medium
 
-  * d/p/search-Cancel-search-provider-operations-on-clear.patch,
-d/p/search-Ignore-search-provider-results-metas-if-search-is-.patch,
-d/p/viewSelector-Cancel-search-on-overview-hidden.patch,
-d/p/ubuntu/search-call-XUbuntuCancel-method-on-providers-when-no-dat.patch:
-- Add support for cancelling remote search providers when the overlay
-  is closed (and actually stop searches when requested from UI, LP: #1756826)
   * debian/ubuntu.css:
 - use defined color for menu separators (LP: #1739931)
 - set StEntry minimun height to work properly with Ubuntu font (LP: #1743058)
   * debian/patches/st-button-Ignore-pointer-emulated-touch-events.patch:
 - Don't emit two click events on touch under X11 (LP: #1745888)
+  * d/p/st-scroll-view-Handle-the-case-where-scrollbars-are-NULL.patch,
+d/p/st-scroll-view-Remove-scrollbars-references-on-dispose.patch:
+- Handle NULL scroll bars in st-scroll-view (LP: #1725312)
 
  -- Marco Trevisan (Treviño)   Wed, 03 Oct 2018 00:50:42 +0200
 
diff --git a/debian/patches/search-Cancel-search-provider-operations-on-clear.patch b/debian/patches/search-Cancel-search-provider-operations-on-clear.patch
deleted file mode 100644
index 052ee8a..000
--- a/debian/patches/search-Cancel-search-provider-operations-on-clear.patch
+++ /dev/null
@@ -1,29 +0,0 @@
-From: =?utf-8?b?Ik1hcmNvIFRyZXZpc2FuIChUcmV2acOxbyki?= 
-Date: Thu, 23 Aug 2018 18:14:38 +0200
-Subject: search: Cancel search provider operations on clear
-
-Ensure that the search provider operations (just getResultMetas requests in the
-current implementation) in progress are properly cancelled when we clear the UI,
-otherwise returned results might still be added when not needed.
-
-This is triggered for each provider by the SearchResults reset.
-
-Bug-GNOME: https://gitlab.gnome.org/GNOME/gnome-shell/issues/183
-Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/bionic/+source/gnome-shell/+bug/1756826
-Forwarded: https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/205

- js/ui/search.js | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/js/ui/search.js b/js/ui/search.js
-index 1fb54b4..804be95 100644
 a/js/ui/search.js
-+++ b/js/ui/search.js
-@@ -192,6 +192,7 @@ var SearchResultsBase = new Lang.Class({
- },
- 
- clear() {
-+this._cancellable.cancel();
- for (let resultId in this._resultDisplays)
- this._resultDisplays[resultId].actor.destroy();
- this._resultDisplays = {};
diff --git a/debian/patches/search-Ignore-search-provider-results-metas-if-search-is-.patch b/debian/patches/search-Ignore-search-provider-results-metas-if-search-is-.patch
deleted file mode 100644
index 27645a5..000
--- a/debian/patches/search-Ignore-search-provider-results-metas-if-search-is-.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From: =?utf-8?b?Ik1hcmNvIFRyZXZpc2FuIChUcmV2acOxbyki?= 
-Date: Thu, 30 Aug 2018 07:11:24 +0200
-Subject: search: Ignore search provider results metas if search is cancelled
-
-Call updateSearch callback with no results when the search provider has been
-cancelled, without doing any logging.
-
-Bug-GNOME: https://gitlab.gnome.org/GNOME/gnome-shell/issues/183
-Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/bionic/+source/gnome-shell/+bug/1756826
-Forwarded: https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/205

- js/ui