Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
Review: Approve continuous-integration PASSED: Continuous integration, rev:e76b07fb22e475f9bc22b02c7824e951a10a9c96 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/390/ Executed test runs: SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/423 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/423 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/423 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/423 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1215 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/957 None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1003/console Click here to trigger a rebuild: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/390/rebuild -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/368284 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c5de2c6c3dd962dcd8ccba2d9749b2e048354dac https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/388/ Executed test runs: FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/421/console SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/421 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/421 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/421 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1213 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/955 None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1001/console Click here to trigger a rebuild: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/388/rebuild -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/368284 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
Review: Approve continuous-integration PASSED: Continuous integration, rev:8a5c6f56d85f951f479192a3596ecb63c6fe3611 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/389/ Executed test runs: SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/422 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/422 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/422 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/422 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1214 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/956 None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1002/console Click here to trigger a rebuild: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/389/rebuild -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/368284 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:f8c29a5afb8fff7c79de8a079deb6896bf4c28f2 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/387/ Executed test runs: FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/420/console SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/420 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/420 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/420 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1212 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/954 None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1000/console Click here to trigger a rebuild: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/387/rebuild -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/368284 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:f8c29a5afb8fff7c79de8a079deb6896bf4c28f2 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/385/ Executed test runs: FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/418/console SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/418 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/418 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/418 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1210 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/952 None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/998/console Click here to trigger a rebuild: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/385/rebuild -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/368284 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:9226cba7432fe640ff3933f6711e119879ea00c6 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/383/ Executed test runs: FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/416/console SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/416 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/416 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/416 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1208 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/950 None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/996/console Click here to trigger a rebuild: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/383/rebuild -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/368284 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:f8c29a5afb8fff7c79de8a079deb6896bf4c28f2 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/386/ Executed test runs: FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/419/console SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/419 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/419 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/419 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1211 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/953 None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/999/console Click here to trigger a rebuild: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/386/rebuild -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/368284 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:f8c29a5afb8fff7c79de8a079deb6896bf4c28f2 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/384/ Executed test runs: FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/417/console SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/417 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/417 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/417 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1209 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/951 None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/997/console Click here to trigger a rebuild: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/384/rebuild -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/368284 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
I'm not clear if this commit is temporary or not? Did you mean to check this in so that you could test your CI changes, or are these changes intended to be permanent so that we can build the snap using CI? Do we disable a similar set of tests in the old HWE nm build too? If these changes are intended to be permanent, please add some more detail to your commit message. Something like: snap: disable tests that fail lp builds Some advanced integration tests (e.g. bonding, teaming, ...) that are trigged by 'make test' fail when NM is built by launchpad. -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/367987 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
Review: Approve continuous-integration PASSED: Continuous integration, rev:fac4a6e925fc19ade02642f77901e60a1c362294 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/378/ Executed test runs: SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/411 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/411 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/411 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/411 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1203 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/945 None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/991/console Click here to trigger a rebuild: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/378/rebuild -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/367987 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c2fba4bc55e6f882d5e7a1ca96bde09f075ba515 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/377/ Executed test runs: FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/410/console FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/410/console FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/410/console FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/410/console SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1202 SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/944 None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/990/console Click here to trigger a rebuild: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/377/rebuild -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/367987 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10
It is permanent, otherwise the snap fails the build from launchpad. Yes, we did disable a few tests in the UC16 NM snap. I have re-worked the commit to be more specific. -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/367987 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
