Re: Package: hsqldb-server; Version: 1.8.0.8-1ubuntu1; Description: Java SQL database server

2008-01-17 Thread Mathias Gug
Hi Tim,

On Sat, Jan 12, 2008 at 07:21:24PM +0100, T. Friske wrote:
 i found an error in the init script /etc/init.d/hsqldb-server. You find the 
 changes I made attached as a patch file.

Could you file a bug report in launchpad [1] and attach your patch to it ?

[1]: https://bugs.launchpad.net/ubuntu/+source/hsqldb/+filebug

Thank you,

--
Mathias

-- 
Ubuntu-devel-discuss mailing list
Ubuntu-devel-discuss@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-discuss


Package: hsqldb-server; Version: 1.8.0.8-1ubuntu1; Description: Java SQL database server

2008-01-12 Thread T. Friske

Hi,

i found an error in the init script /etc/init.d/hsqldb-server. You find the 
changes I made attached as a patch file.

The command /etc/init.d/hsqldb-server status reports that the HSQL server is not running altough the process id in 
/var/run/hsqldb/server.pid is active. This happened due to the missing parameter $type in is_running. It should be 
is_running $type.


The second problem I discovered comes up when you say /etc/init.d/hsqldb-server stop. With a urlid of just 
jdbc:hsqldb:hsql://localhost I get a java.lang.RuntimeException saying that the database alias could not be found. 
Altough the command still closes all databases down, I made a slight modification to the function run_shutdown. (See 
patch file)


Hope this helps.


Best regards,
Tim Friske
--- ../hsqldb-server	2008-01-12 12:51:28.0 +0100
+++ hsqldb-server	2008-01-12 19:07:17.0 +0100
@@ -64,8 +64,11 @@
 run_shutdown()
 {
 	local servertype=$1
-
-	hsqldb-sqltool --rcfile /etc/hsqldb/sqltool.rc --sql SHUTDOWN; localhost-${servertype}-sa /dev/null
+local urlids=$(grep -E -m 10 '^[:blank:]*urlid' sqltool.rc | cut -d ' ' -f2 -)
+local each
+for each in $urlids; do
+	hsqldb-sqltool --rcfile /etc/hsqldb/sqltool.rc --sql SHUTDOWN; $each /dev/null
+done
 }
 
 
@@ -134,7 +137,7 @@
 status)
 	status=0
 	for type in server webserver; do
-		is_running
+		is_running $type
 		typestatus=$?
 		if [ $typestatus -eq 0 ]; then
 			log_success_msg HSQLDB $type is running.
-- 
Ubuntu-devel-discuss mailing list
Ubuntu-devel-discuss@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-discuss