[Bug 1504354] Re: Invalid memory access on ap_server_config_defines
I apparently forogt to actually attach the config fragment that reproduces the problem. ** Attachment added: "Configuration fragment for test case" https://bugs.launchpad.net/ubuntu/trusty/+source/apache2/+bug/1504354/+attachment/4497261/+files/ifdefine-test.conf -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1504354 Title: Invalid memory access on ap_server_config_defines To manage notifications about this bug go to: https://bugs.launchpad.net/apache2/+bug/1504354/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1504354] Re: Invalid memory access on ap_server_config_defines
apache 2 2.4.7-1ubuntu4.8 (in trusty-proposed) both passes the test case and fixes my original problem. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1504354 Title: Invalid memory access on ap_server_config_defines To manage notifications about this bug go to: https://bugs.launchpad.net/apache2/+bug/1504354/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1504354] Re: Invalid memory access on ap_server_config_defines
On Tue, 2015-10-13 at 11:00 +, Robie Basak wrote: > Fix -D[efined] or [d] variables lifetime across restarts. This > fixes incorrect processing of configuration files on reload (LP: > #1504354). > > If you let me know that you're happy with that text then I can just > change it when I upload - no need for you to submit another debdiff. That sounds fine; thanks. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1504354 Title: Invalid memory access on ap_server_config_defines To manage notifications about this bug go to: https://bugs.launchpad.net/apache2/+bug/1504354/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1445914] Re: Secure web socket proxy does not work in Apache 2.4.7
2.4.7-1ubuntu4.7 fixes my problem. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1445914 Title: Secure web socket proxy does not work in Apache 2.4.7 To manage notifications about this bug go to: https://bugs.launchpad.net/apache2/+bug/1445914/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1504354] [NEW] Invalid memory access on ap_server_config_defines
Public bug reported:
A bug in the Apache2 HTTP server results in invalid memory references
in the ap_server_config_defines array after a graceful restart. This
can result in server config variables defined by means of the Define
directive appearing to be undefined after a graceful restart. This
can cause incorrect processing of configuration files. It can also
cause the server to exit due to invalid configuration, even though
the configtest prior to reload succeeded.
This bug was reported upstream against Apache 2.4.6 and 2.4.10. It
appears in the 2.4.7-1ubuntu4.7 found in trusty-proposed, but was
fixed in 2.4.12 and so does not appear in wily.
This is upstream PR 56008 and 57328.
[Test Case]
- apt-get install apache2
- Copy ifdefine-test.conf (attached) to /etc/apache2/sites-available
- a2ensite ifdefine-test.conf
- service apache2 restart
- Observe that http:///foo.html returns the default page
(same as http:///)
- service apache2 reload
- Examine /var/log/apache2/error.log; observe the warning message
"Config variable ${TEST2} is not defined"
- Observe that http:///foo.html now returns a 404.
With the bug fixed, the warning message will not appear, and the
foo.html URL will continue to work after the reload.
[Regression Potential]
Low.
The change is textually small (one line), but has a significant effect:
it ensures that a fresh copy is made of the array containing defined
variables each time the config file is read. Without this, on reloads
the original array (containing variables defined on the command line)
is modified directly, causing it to contain string pointers that will
become invalid when the configuration memory pool is released.
The patch only changes what happens when the configuration pool is
released, avoiding leaking memory references across successive reads
of the config file. As such, it is unlikely have any negative effect
on processing of the configuration, and extremely unlikely to have any
effect on operations once the server configuration has been read.
This change was applied upstream in December, 2014 and appears in the
upstream 2.4.12 release, which is in wily. The patch also appears in
2.4.10-10+deb8u2, which has been in Debian stable for about 5 weeks.
** Affects: apache2
Importance: Unknown
Status: Unknown
** Affects: apache2 (Ubuntu)
Importance: Undecided
Status: New
** Bug watch added: bz.apache.org/bugzilla/ #57328
https://bz.apache.org/bugzilla/show_bug.cgi?id=57328
** Also affects: apache2 via
https://bz.apache.org/bugzilla/show_bug.cgi?id=57328
Importance: Unknown
Status: Unknown
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to apache2 in Ubuntu.
https://bugs.launchpad.net/bugs/1504354
Title:
Invalid memory access on ap_server_config_defines
To manage notifications about this bug go to:
https://bugs.launchpad.net/apache2/+bug/1504354/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1504354] Re: Invalid memory access on ap_server_config_defines
** Patch added: "debdiff containing the upstream patch" https://bugs.launchpad.net/apache2/+bug/1504354/+attachment/4489268/+files/server_config_defines.debdiff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to apache2 in Ubuntu. https://bugs.launchpad.net/bugs/1504354 Title: Invalid memory access on ap_server_config_defines To manage notifications about this bug go to: https://bugs.launchpad.net/apache2/+bug/1504354/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1445914] Re: Secure web socket proxy does not work in Apache 2.4.7
Try this one. Note I omitted the Author tag. It's not clear to me that it's intended to name the author of the upstream patch, which in any case is available in the upstream bug, the upstream commit, and the debian/changelog entry. I myself have no authorship stake in this patch. Note that while the upstream commit also patches the CHANGES file, I've omitted that, because the addition is to a section (Changes with Apache 2.5.0) that doesn't exist in 2.4.7. This file doesn't appear to make it into any binary packages in any event. ** Patch added: "wstunnel-ssl-002.debdiff" https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1445914/+attachment/4465275/+files/wstunnel-ssl-002.debdiff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1445914 Title: Secure web socket proxy does not work in Apache 2.4.7 To manage notifications about this bug go to: https://bugs.launchpad.net/apache2/+bug/1445914/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1445914] Re: Secure web socket proxy does not work in Apache 2.4.7
The upstream patch (see attached debdiff) corrects the problem for me, for an internal test case that is unfortunately too complex to share. ** Patch added: "debdiff containing the upstream patch" https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1445914/+attachment/4460591/+files/wstunnel-ssl.debdiff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1445914 Title: Secure web socket proxy does not work in Apache 2.4.7 To manage notifications about this bug go to: https://bugs.launchpad.net/apache2/+bug/1445914/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 575458] Re: /etc/dhcp3/dhclient-exit-hooks.d/ntp breaks local NTP server (patch)
The following patch fixes the problem by *not* replacing ntp servers with an address beginning with 127. No, it doesn't. It masks the problem by removing only servers with a name or address that starts with something other than a '1', followed by something other than a '2', followed by something other than a '7', followed by a dot. For example, with your patch, the following entries are no longer removed: server 0.ubuntu.pool.ntp.org server 1.ubuntu.pool.ntp.org server 2.ubuntu.pool.ntp.org server 3.ubuntu.pool.ntp.org server 127.1.2.3 server clock-1.cs.cmu.edu ... but this is: server ntp.ubuntu.com Unfortunately, this means that several of the server entries in the default /etc/ntp.conf are no longer removed. As a result, an unmodified machine booting on a network where DHCP provides a list of local NTP servers gets the local servers plus four from pool.ntp.org. A better answer here would be to find a proper solution to #374896, such that locally-added entries can be retained when desired (and only then!), and use that for refclock entries (127.*) as well. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in Ubuntu. https://bugs.launchpad.net/bugs/575458 Title: /etc/dhcp3/dhclient-exit-hooks.d/ntp breaks local NTP server (patch) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ntp/+bug/575458/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
