[Bug 1044837] Re: vmbuilder should accept an empty destination directory
** Changed in: vm-builder (Ubuntu) Status: Incomplete = Opinion -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in Ubuntu. https://bugs.launchpad.net/bugs/1044837 Title: vmbuilder should accept an empty destination directory To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/vm-builder/+bug/1044837/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1044837] Re: vmbuilder should accept an empty destination directory
Thanks. That is what I thought you were asking for. There are several downsides to your proposal as I see it: 1. having extra files in the destination directory which were not created by vmbuilder will be more confusing, 2. 'if something does not work (due to permissions or other issues), blame the admin and let him clean up the mess' generally does not work out from a future-bug-resolution point of view. I've marked the bug Opinion as I do see your point of view. If you'd like to submit a patch to implement the behavior you describe (only when the rmdir fails), I will accept the patch. ** Changed in: vm-builder (Ubuntu) Importance: Low = Wishlist -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in Ubuntu. https://bugs.launchpad.net/bugs/1044837 Title: vmbuilder should accept an empty destination directory To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/vm-builder/+bug/1044837/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1044837] Re: vmbuilder should accept an empty destination directory
Sorry for the unclear description of the bug. The manpage says: -o, --overwrite Force overwrite of destination directory if it already exist. [default: False] But apparently vmbuilder does not overwrite it. It tries to delete it (which fails with mountpoints) and then recreates it, that's a different action. Why go through the hassle of deleting and recreating it if you can just dump in any file by any name, since you got the permission from the admin that everything in there can be overwritten? Another point: If I know what files are going to be created (*.qcow2 by default), then I expect to be able to create some files in there if I know that the names do not conflict. Currently these files will be lost for no reason that I see. I just see no reason for removing the directory beforehand, as this can cause errors like I have gotten. And it counteracts the use of mountpoints whereever you want. The reason that I do not use /srv/kvm/mysql/mysql is that /srv/kvm is a big filesystem already containing severall VM disk images which are following /srv/kvm/*/*.qcow2. Adding a subdirectory here would require me to migrate all other VMs to ensure that the same mask works for all VM disk images. To avoid that I currently install the VMs to a subdirectory and move the files afterwards, which requires me to edit the domain config, of course. I consider that unnecessary, if vmbuilder would accept -o as just dump anything you want into that directory. if something does not work (due to permissions or other issues), blame the admin and let him clean up the mess. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in Ubuntu. https://bugs.launchpad.net/bugs/1044837 Title: vmbuilder should accept an empty destination directory To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/vm-builder/+bug/1044837/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1044837] Re: vmbuilder should accept an empty destination directory
Thanks for reporting this bug. Adding such a check seems to complicate the existing check for little real gain. If /srv/kvm/mysql is a mount point, is there a reason why you could not use '/srv/kvm/mysql/mysql' as the target directory? (If your use case isn't easily solved that way, then I'm open to it, but otherwise I prefer not to) ** Changed in: vm-builder (Ubuntu) Status: New = Incomplete ** Changed in: vm-builder (Ubuntu) Importance: Undecided = Low -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in Ubuntu. https://bugs.launchpad.net/bugs/1044837 Title: vmbuilder should accept an empty destination directory To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/vm-builder/+bug/1044837/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
