[Bug 1389849] Re: sudo service lxc-net restart does not reload dnsmasq when there is a container running

2015-11-09 Thread Stéphane Graber
root@dakara:~# ps aux | grep lxc-dnsm
lxc-dns+1551  0.0  0.0  28204  1096 ?SOct31   0:18 dnsmasq -u 
lxc-dnsmasq --strict-order --bind-interfaces --pid-file=/run/lxc/dnsmasq.pid 
--listen-address 10.0.3.1 --dhcp-range 10.0.3.2,10.0.3.254 --dhcp-lease-max=253 
--dhcp-no-override --except-interface=lo --interface=lxcbr0 
--dhcp-leasefile=/var/lib/misc/dnsmasq.lxcbr0.leases --dhcp-authoritative 
--dhcp-range=2607:f2c0:f00f:2760::1,ra-only --listen-address 
2607:f2c0:f00f:2760::1
root 1697815  0.0  0.0  11780   940 pts/33   S+   13:14   0:00 grep 
--color=auto lxc-dnsm
root@dakara:~# brctl show
bridge name bridge id   STP enabled interfaces
lxcbr0  8000.fe443b4e3bcb   no  veth3O4O1Q
vethKVIT3V
vethXEK7VF
root@dakara:~# restart lxc-net
lxc-net start/running
root@dakara:~# ps aux | grep lxc-dnsm
lxc-dns+ 1697873  0.0  0.0  28204   976 ?S13:15   0:00 dnsmasq -u 
lxc-dnsmasq --strict-order --bind-interfaces --pid-file=/run/lxc/dnsmasq.pid 
--listen-address 10.0.3.1 --dhcp-range 10.0.3.2,10.0.3.254 --dhcp-lease-max=253 
--dhcp-no-override --except-interface=lo --interface=lxcbr0 
--dhcp-leasefile=/var/lib/misc/dnsmasq.lxcbr0.leases --dhcp-authoritative 
--dhcp-range=2607:f2c0:f00f:2760::1,ra-only --listen-address 
2607:f2c0:f00f:2760::1
root 1697877  0.0  0.0  11776   940 pts/33   R+   13:15   0:00 grep 
--color=auto lxc-dnsm

** Changed in: lxc (Ubuntu)
   Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to lxc in Ubuntu.
https://bugs.launchpad.net/bugs/1389849

Title:
  sudo service lxc-net restart does not reload dnsmasq when there is a
  container running

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1389849/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1389849] Re: sudo service lxc-net restart does not reload dnsmasq when there is a container running

2015-05-30 Thread JoaoCC
Hi,
In the /etc/init/lxc-net.conf file, in the post-stop script, shouldn't the 
bridge be stopped before removing it?

In the pre-start section you have:
ifconfig ${LXC_BRIDGE} down || true
brctl delbr ${LXC_BRIDGE} || true

but in the post-stop you only have
brctl delbr ${LXC_BRIDGE}

I noticed this because an error message is logged in one of the specific logs.
Thx

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to lxc in Ubuntu.
https://bugs.launchpad.net/bugs/1389849

Title:
  sudo service lxc-net restart does not reload dnsmasq when there is a
  container running

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1389849/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


Re: [Bug 1389849] Re: sudo service lxc-net restart does not reload dnsmasq when there is a container running

2014-11-21 Thread Serge Hallyn
Well, lxc-net doesn't support instances - yet :)

But you're right we dont' need that at this point.  My point was that your
example didn't seem to have dnsmasq at all.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to lxc in Ubuntu.
https://bugs.launchpad.net/bugs/1389849

Title:
  sudo service lxc-net restart does not reload dnsmasq when there is a
  container running

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1389849/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1389849] Re: sudo service lxc-net restart does not reload dnsmasq when there is a container running

2014-11-20 Thread Serge Hallyn
Thanks - the solution in your comment #1 would be good, if it was
accompanied by a /etc/init/lxc-dnsmasq.conf which had 'start on started
lxc-net; stop on stopping lxc-net; instance $BRIDGE

** Changed in: lxc (Ubuntu)
   Importance: Undecided = Low

** Changed in: lxc (Ubuntu)
   Status: New = Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to lxc in Ubuntu.
https://bugs.launchpad.net/bugs/1389849

Title:
  sudo service lxc-net restart does not reload dnsmasq when there is a
  container running

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1389849/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1389849] Re: sudo service lxc-net restart does not reload dnsmasq when there is a container running

2014-11-20 Thread Adam Ryczkowski
Why would you need other instances of the service lxc-dnsmasq? The lxc-
net doesn't support instances - there could be only max. one bridge at
any given time, and I believe setting two dnsmasq servers on the same
network interface would cause conflict.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to lxc in Ubuntu.
https://bugs.launchpad.net/bugs/1389849

Title:
  sudo service lxc-net restart does not reload dnsmasq when there is a
  container running

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1389849/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1389849] Re: sudo service lxc-net restart does not reload dnsmasq when there is a container running

2014-11-06 Thread Adam Ryczkowski
There is also a little more advanced solution, that claims to be
compatible with systemd as well: https://github.com/CameronNemo/lxc-net

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to lxc in Ubuntu.
https://bugs.launchpad.net/bugs/1389849

Title:
  sudo service lxc-net restart does not reload dnsmasq when there is a
  container running

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1389849/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1389849] Re: sudo service lxc-net restart does not reload dnsmasq when there is a container running

2014-11-05 Thread Adam Ryczkowski
After consulting with Serge Hallyn, the original author of the upstart
script that governs creation of the lxc-net bridge, I came up with the
following solution:

1. Turn off all lxc containers and the lxc-net (sudo service lxc-net stop)
2. Remove (or move away) the file /etc/init/lxc-net.conf
3. Create the file /etc/init/lxc-net.conf with the following contents:

description lxc network
author Serge Hallyn serge.hal...@canonical.com

start on starting lxc
stop on stopped lxc

env USE_LXC_BRIDGE=true
env LXC_BRIDGE=lxcbr0
env LXC_ADDR=10.0.3.1
env LXC_NETMASK=255.255.255.0
env LXC_NETWORK=10.0.3.0/24
env varrun=/run/lxc
env LXC_DOMAIN=

pre-start script
[ -f /etc/default/lxc ]  . /etc/default/lxc

[ x$USE_LXC_BRIDGE = xtrue ] || { stop; exit 0; }

use_iptables_lock=-w
iptables -w -L -n  /dev/null 21 || use_iptables_lock=
cleanup() {
# dnsmasq failed to start, clean up the bridge
iptables $use_iptables_lock -D INPUT -i ${LXC_BRIDGE} -p udp --dport 67 
-j ACCEPT
iptables $use_iptables_lock -D INPUT -i ${LXC_BRIDGE} -p tcp --dport 67 
-j ACCEPT
iptables $use_iptables_lock -D INPUT -i ${LXC_BRIDGE} -p udp --dport 53 
-j ACCEPT
iptables $use_iptables_lock -D INPUT -i ${LXC_BRIDGE} -p tcp --dport 53 
-j ACCEPT
iptables $use_iptables_lock -D FORWARD -i ${LXC_BRIDGE} -j ACCEPT
iptables $use_iptables_lock -D FORWARD -o ${LXC_BRIDGE} -j ACCEPT
iptables $use_iptables_lock -t nat -D POSTROUTING -s ${LXC_NETWORK} ! 
-d ${LXC_NETWORK} -j MASQUERADE || true
iptables $use_iptables_lock -t mangle -D POSTROUTING -o ${LXC_BRIDGE} 
-p udp -m udp --dport 68 -j CHECKSUM --checksum-fill
ifconfig ${LXC_BRIDGE} down || true
brctl delbr ${LXC_BRIDGE} || true
}
if [ -d /sys/class/net/${LXC_BRIDGE} ]; then
if [ ! -f ${varrun}/network_up ]; then
# bridge exists, but we didn't start it
stop;
fi
exit 0;
fi

# set up the lxc network
brctl addbr ${LXC_BRIDGE} || { echo Missing bridge support in kernel; 
stop; exit 0; }
echo 1  /proc/sys/net/ipv4/ip_forward
mkdir -p ${varrun}
ifconfig ${LXC_BRIDGE} ${LXC_ADDR} netmask ${LXC_NETMASK} up
iptables $use_iptables_lock -I INPUT -i ${LXC_BRIDGE} -p udp --dport 67 -j 
ACCEPT
iptables $use_iptables_lock -I INPUT -i ${LXC_BRIDGE} -p tcp --dport 67 -j 
ACCEPT
iptables $use_iptables_lock -I INPUT -i ${LXC_BRIDGE} -p udp --dport 53 -j 
ACCEPT
iptables $use_iptables_lock -I INPUT -i ${LXC_BRIDGE} -p tcp --dport 53 -j 
ACCEPT
iptables $use_iptables_lock -I FORWARD -i ${LXC_BRIDGE} -j ACCEPT
iptables $use_iptables_lock -I FORWARD -o ${LXC_BRIDGE} -j ACCEPT
iptables $use_iptables_lock -t nat -A POSTROUTING -s ${LXC_NETWORK} ! -d 
${LXC_NETWORK} -j MASQUERADE
iptables $use_iptables_lock -t mangle -A POSTROUTING -o ${LXC_BRIDGE} -p 
udp -m udp --dport 68 -j CHECKSUM --checksum-fill

touch ${varrun}/network_up
end script

post-stop script
[ -f /etc/default/lxc ]  . /etc/default/lxc
[ -f ${varrun}/network_up ] || exit 0;
# if $LXC_BRIDGE has attached interfaces, don't shut it down
ls /sys/class/net/${LXC_BRIDGE}/brif/*  /dev/null 21  exit 0;

if [ -d /sys/class/net/${LXC_BRIDGE} ]; then
use_iptables_lock=-w
iptables -w -L -n  /dev/null 21 || use_iptables_lock=
ifconfig ${LXC_BRIDGE} down
iptables $use_iptables_lock -D INPUT -i ${LXC_BRIDGE} -p udp --dport 67 
-j ACCEPT
iptables $use_iptables_lock -D INPUT -i ${LXC_BRIDGE} -p tcp --dport 67 
-j ACCEPT
iptables $use_iptables_lock -D INPUT -i ${LXC_BRIDGE} -p udp --dport 53 
-j ACCEPT
iptables $use_iptables_lock -D INPUT -i ${LXC_BRIDGE} -p tcp --dport 53 
-j ACCEPT
iptables $use_iptables_lock -D FORWARD -i ${LXC_BRIDGE} -j ACCEPT
iptables $use_iptables_lock -D FORWARD -o ${LXC_BRIDGE} -j ACCEPT
iptables $use_iptables_lock -t nat -D POSTROUTING -s ${LXC_NETWORK} ! 
-d ${LXC_NETWORK} -j MASQUERADE || true
iptables $use_iptables_lock -t mangle -D POSTROUTING -o ${LXC_BRIDGE} 
-p udp -m udp --dport 68 -j CHECKSUM --checksum-fill
pid=`cat ${varrun}/dnsmasq.pid 2/dev/null`  kill -9 $pid || true
rm -f ${varrun}/dnsmasq.pid
brctl delbr ${LXC_BRIDGE}
fi
rm -f ${varrun}/network_up
end script

4. Create the file /etc/init/lxc-dnsmasq.conf with the following
contents:

description lxc dnsmasq service
author Adam Ryczkowski, ispired by Serge Hallyn serge.hal...@canonical.com

expect fork

start on started lxc-net
stop on stopped lxc-net

env USE_LXC_BRIDGE=true
env LXC_BRIDGE=lxcbr0
env LXC_ADDR=10.0.3.1
env LXC_NETMASK=255.255.255.0
env LXC_NETWORK=10.0.3.0/24
env LXC_DHCP_RANGE=10.0.3.2,10.0.3.254
env LXC_DHCP_MAX=253
env LXC_DHCP_CONFILE=
env varrun=/run/lxc-dnsmasq
env LXC_DOMAIN=

pre-start script
[ -f /etc/default/lxc ]  . /etc/default/lxc

[ x$USE_LXC_BRIDGE = xtrue ] || { stop; exit 0; }

if [ !