[Bug 1558336] Re: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty
** Changed in: juju-mongodb (Ubuntu) Status: Incomplete => New -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1558336 Title: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1558336/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1558336] Re: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty
Hi Robie. > In override_dh_clean, rm -rf /tmp/go-build* will interfere with other Thank you for calling this out. I have removed it. It is not needed. > Other notes (I can fix up): The rules were written to work for wily and trusty. I look forward to removing the work arounds or using a better technique. My hope is that when officially backporting packages to wily and trusty, only the control file will change. > No need for override_dh_strip any more (golang-go produced binaries can > now be stripped according to bug 1318027). When fixed, can remove > lintian overrides. Maybe best to leave for now as we're short on time, > but can leave a bug open to do later. > > No need for override_dh_builddeb since xz is default on Xenial, or are > you leaving this for backporting ease? If so, then do we know xz will > work as far back as you want to backport? I think this is needed to trusty. > debian/copyright looks superficially OK to me, and I'm happy that Curtis > can maintain these accurately. Leaving it for the AA to review once. > Same with debian/missing-sources. Good job on identifying that this was > required and taking care of it. > > Embedded dependencies: I see 10 bundled dependencies, and four -dev > packages which presumably override them (cannot check due to lack of > build, see below). Are the others acceptable to AAs to bundle? I have reviewed the build logs for my trials on xenial, wily, and trusty. Only the trusty built with all the embedded go packages. > Changelog should close LP bug. Changelog arch reference is presumably > superseded now as we're bulding Arch: any? Oops, yes a bullet point needs to be removed, Done. > I'm not sure where to get the orig tarball and there is no debian/watch > file. /me hangs head in shame. I didn't commit the watch file. It is not in the tree. > Cannot (easily) check lintian without orig tarball. > Cannot (easily) build test without orig tarball. So I basically just > reviewed the debian/ directory by looking at it only. It is nice and > small and easy to review - thanks. I recreate the tarfile when creating the source package. The quickest command is bzr bd S -- -uc -us Attached is a diff of the changes made per the review ** Patch added: "diff from review 1" https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1558336/+attachment/4618684/+files/juju-mongo-tools3.2-review1.diff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1558336 Title: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1558336/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1558336] Re: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty
> In override_dh_clean, rm -rf /tmp/go-build* will interfere with other concurrent builds. We shouldn't stomp on the system like this. I'm not sure the build should leave anything in /tmp at all. Maybe use TMPDIR to make it use somewhere else, then clean that? Is there a standard pattern for this that we can use? This needs addressing please. ** Changed in: juju-mongodb (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1558336 Title: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1558336/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1558336] Re: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty
I reviewed ~sinzui/ubuntu/xenial/juju-mongo-tools3.2/xenial-mongo-tools3.2 revno 19 for upload. Summary: looks good, one thing to fix in debian/rules, then I can make the other changes and am happy to upload. Good job sending the syscall patch upstream. I appreciate the dep3 header telling me the status. In override_dh_clean, rm -rf /tmp/go-build* will interfere with other concurrent builds. We shouldn't stomp on the system like this. I'm not sure the build should leave anything in /tmp at all. Maybe use TMPDIR to make it use somewhere else, then clean that? Is there a standard pattern for this that we can use? Other notes (I can fix up): No need for override_dh_strip any more (golang-go produced binaries can now be stripped according to bug 1318027). When fixed, can remove lintian overrides. Maybe best to leave for now as we're short on time, but can leave a bug open to do later. No need for override_dh_builddeb since xz is default on Xenial, or are you leaving this for backporting ease? If so, then do we know xz will work as far back as you want to backport? debian/copyright looks superficially OK to me, and I'm happy that Curtis can maintain these accurately. Leaving it for the AA to review once. Same with debian/missing-sources. Good job on identifying that this was required and taking care of it. Embedded dependencies: I see 10 bundled dependencies, and four -dev packages which presumably override them (cannot check due to lack of build, see below). Are the others acceptable to AAs to bundle? Changelog should close LP bug. Changelog arch reference is presumably superseded now as we're bulding Arch: any? I'm not sure where to get the orig tarball and there is no debian/watch file. Cannot (easily) check lintian without orig tarball. Cannot (easily) build test without orig tarball. So I basically just reviewed the debian/ directory by looking at it only. It is nice and small and easy to review - thanks. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1558336 Title: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1558336/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1558336] Re: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty
(some way to verify the orig tarball against upstream would be good, too - I don't see a debian/watch file) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1558336 Title: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1558336/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1558336] Re: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty
I presume (with mgz) that the bzr branch is what I'm reviewing/uploading, as opposed to those diffs applied to the upstream source? Where can I find the orig tarball for this, please? -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1558336 Title: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1558336/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1558336] Re: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty
A diff of the missing sources added to debian/. ** Patch added: "juju-mongo-tools3.2-missing-sources.diff" https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1558336/+attachment/4601655/+files/juju-mongo-tools3.2-missing-sources.diff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1558336 Title: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1558336/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1558336] Re: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty
*** This is an automated message *** This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs- packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist. ** Changed in: juju-mongodb (Ubuntu) Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1558336 Title: [needs-packaging] juju-mongo-tools3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1558336/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
