[Bug 1735158] Re: FTBFS with gcc7

[Andreas Hasenack]

The packages built, so obviously the FTBFS fix is applied. Marking as
verified.

** Tags removed: verification-needed-artful
** Tags added: verification-done-artful

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to iproute2 in Ubuntu.
https://bugs.launchpad.net/bugs/1735158

Title:
  FTBFS with gcc7

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1735158/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1735158] Re: FTBFS with gcc7

[Andreas Hasenack]

I checked debian sid, and the build succeeds there. The code is using
UINT16_MAX in the same place (tc/tc_core.c), and that file is not
including stdint.h

UINT16_MAX is only used in tc/tc_core.c:
$ grep UINT16_MAX -r .
./tc/tc_core.c: if ((sz >> s->size_log) > UINT16_MAX) {
./.pc/ftbfs.diff/tc/tc_core.c:  if ((sz >> s->size_log) > UINT16_MAX) {


UINT16_MAX is only defined in stdint.h:
$ grep UINT16_MAX -r /usr/include
/usr/include/stdint.h:# define UINT16_MAX   (65535)

There are no patches defining UINT16_MAX or including stdint.h in
debian/patches.

Build flags (dpkg-buildflags) in ubuntu and sid are the same.

Without digging deeper, I don't know why the build succeeds there.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to iproute2 in Ubuntu.
https://bugs.launchpad.net/bugs/1735158

Title:
  FTBFS with gcc7

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1735158/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1735158] Re: FTBFS with gcc7

[Andreas Hasenack]

commit ae717baf15fb4d30749ada3948d9445892bac239
Author: Khem Raj 
Date:   Sat May 20 14:28:46 2017 -0700

tc: include stdint.h explicitly for UINT16_MAX

Fixes
| tc_core.c:190:29: error: 'UINT16_MAX' undeclared (first use in this 
function); did you mean '__INT16_MAX__'?
|if ((sz >> s->size_log) > UINT16_MAX) {
|  ^~

Signed-off-by: Khem Raj 

diff --git a/tc/tc_core.c b/tc/tc_core.c
index 7bbe0d73..821b741b 100644
--- a/tc/tc_core.c
+++ b/tc/tc_core.c
@@ -12,6 +12,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 


** Changed in: iproute2 (Ubuntu)
 Assignee: (unassigned) => Andreas Hasenack (ahasenack)

** Changed in: iproute2 (Ubuntu)
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to iproute2 in Ubuntu.
https://bugs.launchpad.net/bugs/1735158

Title:
  FTBFS with gcc7

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1735158/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs