[Bug 387189] Re: /dev/null corrupted (/dev/null.1)
** Branch linked: lp:~davewalker/ubuntu/lucid/logrotate/lp387189 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to apache2 in ubuntu. https://bugs.launchpad.net/bugs/387189 Title: logrotate incorrectly rotates /dev/null to /dev/null.1 -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 387189] Re: /dev/null corrupted (/dev/null.1)
** Changed in: logrotate (Ubuntu) Assignee: (unassigned) = Canonical Server Team (canonical-server) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to apache2 in ubuntu. https://bugs.launchpad.net/bugs/387189 Title: /dev/null corrupted (/dev/null.1) -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 387189] Re: /dev/null corrupted (/dev/null.1)
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to apache2 in ubuntu. https://bugs.launchpad.net/bugs/387189 Title: /dev/null corrupted (/dev/null.1) -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 387189] Re: /dev/null corrupted (/dev/null.1)
This is a logrotate issue and happens if the specified logfile directory (in this case /var/log/apache2) does not exist and the postrotate script contains a closing '}'. Therefore I don't think Jonathan's patch would fix the issue completely. The full info is at http://bugs.debian.org/cgi- bin/bugreport.cgi?bug=571033 and https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/392532 The patch is included in logrotate 3.7.8-5 and newer. ** Bug watch added: Debian Bug tracker #571033 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=571033 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to apache2 in ubuntu. https://bugs.launchpad.net/bugs/387189 Title: /dev/null corrupted (/dev/null.1) -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 387189] Re: /dev/null corrupted (/dev/null.1)
OK. Do we have a test case for which my patch fails?
If the remaining issue is that my patch contains a closing '}', that is
easily solved, because the {} around the variable name are only there
for style reasons, and are not required.
Here is a modified patch without the {} . Is there a test case for
which this one fails?
If this issue is deemed significant enough to SRU for Hardy and Lucid,
then it seems easier to me to get a small patch to one script accepted,
than to get a newer version of logrotate accepted.
Is it better to backport the logrotate patch? To do both the logrotate
patch *and* fix the apache2 logrotate script?
** Patch added: modified patch that contains no brackets
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/387189/+attachment/1818595/+files/logrotate-apache2-no-brackets.diff
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to apache2 in ubuntu.
https://bugs.launchpad.net/bugs/387189
Title:
/dev/null corrupted (/dev/null.1)
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 387189] Re: /dev/null corrupted (/dev/null.1)
Based on comments #24 and #25 it looks like this is an Apache issue, so I've added apache2 - apache2 maintainers please have a look because it's got quite an impact. Dave ** Also affects: apache2 (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to apache2 in ubuntu. https://bugs.launchpad.net/bugs/387189 Title: /dev/null corrupted (/dev/null.1) -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 387189] Re: /dev/null corrupted (/dev/null.1)
It seems to me a patch to /etc/logrotate.d/apache2 is the simplest solution. The attached diff tries to solve the issue and also be more readable, breaking the one complex line involving backticks into three shorter simpler lines, no backticks needed. There are a lot of cases to test this with, and I doubt I have yet tested all of them... with and without a full apache2 installation, with and without apache running, with and without making changes to the envvars file to put the PID file elsewhere... Anyway, here is a patch that looks sane to me. Comments welcomed, testing even more welcomed :) ** Patch added: Patch to postrotate script within /etc/logrotate.d/apache2 https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/387189/+attachment/1816129/+files/logrotate-apache2.diff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to apache2 in ubuntu. https://bugs.launchpad.net/bugs/387189 Title: /dev/null corrupted (/dev/null.1) -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
