[Bug 527860] Re: Init script always returns 0
** Changed in: puppet (Ubuntu) Status: Confirmed = In Progress ** Changed in: puppet (Ubuntu) Assignee: (unassigned) = Mathias Gug (mathiaz) -- Init script always returns 0 https://bugs.launchpad.net/bugs/527860 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 527860] Re: Init script always returns 0
This bug was fixed in the package puppet - 0.25.4-2ubuntu3 --- puppet (0.25.4-2ubuntu3) lucid; urgency=low [ Angel Abad ] * Fix return codes puppetmaster.init and puppet.init (LP: #527860) [ Mathias Gug ] * debian/puppet-common.postrm: only remove puppet directories if they're empty on package purge. * etckeeper integration: + debian/README.Debian: add a note about etckeeper integration. + debian/control: suggest etckeeper. -- Mathias Gug math...@ubuntu.com Thu, 11 Mar 2010 12:42:32 -0500 ** Changed in: puppet (Ubuntu) Status: In Progress = Fix Released -- Init script always returns 0 https://bugs.launchpad.net/bugs/527860 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 527860] Re: Init script always returns 0
Updated proposed branch for merge. Thanks -- Init script always returns 0 https://bugs.launchpad.net/bugs/527860 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 527860] Re: Init script always returns 0
I proposed a branch merge with patch applied. Thanks! ** Branch linked: lp:~angel-abad/ubuntu/lucid/puppet/fix-527860 -- Init script always returns 0 https://bugs.launchpad.net/bugs/527860 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 527860] Re: Init script always returns 0
@Simon: I think your patch is incomplete: in puppet.init, start, stop and restart will always return 0 (since you get the return value of log_end_msg 0 which happens to always be 0. I think changing those to log_end_msg $? should do it... Maybe you can validate all calls to puppet.init and update your branch accordingly ? -- Init script always returns 0 https://bugs.launchpad.net/bugs/527860 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 527860] Re: Init script always returns 0
@Thierry: you are absolutely right. I did the patch only for puppetmaster without paying attention to restart exit code. Strangely, the puppetmaster script does use log_end_msg $? for start and stop already but the puppet script doesn't. I'll attach the 2 new patches. Thanks for your review. ** Patch added: Return a valid code (puppet client) http://launchpadlibrarian.net/40655180/puppet.init.script.patch -- Init script always returns 0 https://bugs.launchpad.net/bugs/527860 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 527860] Re: Init script always returns 0
** Patch added: Return a valid code (puppetmaster) http://launchpadlibrarian.net/40655185/puppetmaster.init.script.patch -- Init script always returns 0 https://bugs.launchpad.net/bugs/527860 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 527860] Re: Init script always returns 0
Thanks for the patch ill take a look at this for lucid. Regards chuck ** Changed in: puppet (Ubuntu) Importance: Undecided = Wishlist ** Changed in: puppet (Ubuntu) Status: New = Confirmed -- Init script always returns 0 https://bugs.launchpad.net/bugs/527860 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
