[Bug 612975] Re: Please convert init scripts to upstart.
** Changed in: dhcp3 (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to dhcp3 in Ubuntu. https://bugs.launchpad.net/bugs/612975 Title: Please convert init scripts to upstart. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 612975] Re: Please convert init scripts to upstart.
Ill fix up all of these mistakes and resubmit the debdiff, I did test them but I guess I didnt hit these problems while testng them. chuck -- Please convert init scripts to upstart. https://bugs.launchpad.net/bugs/612975 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to dhcp3 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 612975] Re: Please convert init scripts to upstart.
Thanks for the patch. A number of comments: --upstart-only is incorrect, as in other bugs. Please see dh_installinit(1) for documentation of --upstart-only. You've deleted invoke-rc.d calls but not replaced them with anything. There are a couple of serious typos (as follows), as well as some minor ones in the changelog and comments: + [ -f /etc/default/dhcp3-relay ] ./etc/default/dhcp3-rlay + exec /sur/sbin/dhcrelay -q $OPTIONS $IFCMD $SERVERS Regarding the first line, as well as the spelling mistake, please note that you need a space after the '.' - this is a shell command, not part of a path. The ntp patch had the same mistake. The dhcp3-relay init script aborts if /etc/default/dhcp3-relay doesn't exist, while the Upstart job carries on anyway. This is unsafe. The same goes for the dhcp3-server job. Something needs to be done about the update-rc.d call in dhcp3-server.postinst. Please port over the /etc/ltsp/dhcpd.conf handling from the init script. If we leave this out we'll likely just get bug reports and have to reintroduce it later - might as well get it right from the start. + [ -e /var/lib/dhcp3/dhcpd.leases~ ] || chown dhcpd:dhcpd /var/lib/dhcp3/dhcpd.leases~ This is backwards - should be not ||. + exec /usr/sbin/dhcpd3 -q -pf /var/run/dhcp3-server/dhcpd.pid-cf $CONFIG_FILE $INTERFACES Missing space between pid and -cf. Can we drop the -pf /var/run/dhcp3-server/dhcpd.pid, please? We shouldn't need pidfiles with Upstart, in general, since it can track daemons itself. -- Please convert init scripts to upstart. https://bugs.launchpad.net/bugs/612975 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to dhcp3 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 612975] Re: Please convert init scripts to upstart.
** Attachment added: dhcpd-upstart.debdiff http://launchpadlibrarian.net/52992658/dhcpd-upstart.debdiff -- Please convert init scripts to upstart. https://bugs.launchpad.net/bugs/612975 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to dhcp3 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 612975] Re: Please convert init scripts to upstart.
** Changed in: dhcp3 (Ubuntu) Importance: Undecided = Wishlist -- Please convert init scripts to upstart. https://bugs.launchpad.net/bugs/612975 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to dhcp3 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
