[Bug 835901] Re: ssh-copy-id: fails to sanitize arguments
This bug was fixed in the package openssh - 1:6.2p1-2 --- openssh (1:6.2p1-2) unstable; urgency=low * Fix build failure on Ubuntu: - Include openbsd-compat/sys-queue.h from consolekit.c. - Fix consolekit mismerges in monitor.c and monitor_wrap.c. -- Colin Watson Thu, 09 May 2013 09:45:57 +0100 ** Changed in: openssh (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to openssh in Ubuntu. https://bugs.launchpad.net/bugs/835901 Title: ssh-copy-id: fails to sanitize arguments To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openssh/+bug/835901/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 835901] Re: ssh-copy-id: fails to sanitize arguments
Yep.
Here's a patch. This catches the case of mistyping the "-i" argument into
anything else, and also catches the generic case of any extra arguments.
$ diff -U 2 /usr/bin/ssh-copy-id /tmp/ssh-copy-id
--- /usr/bin/ssh-copy-id2010-08-10 04:36:09.0 +0100
+++ /tmp/ssh-copy-id2011-08-31 23:38:38.052511425 +0100
@@ -25,4 +25,9 @@
fi
+if [ $# -gt 1 ]; then
+ echo "Usage: ssh-copy-id [-i id_file] [user@]machine" 1>&2
+ exit 1;
+fi
+
if [ -z "`eval $GET_ID`" ] && [ -r "${ID_FILE}" ] ; then
GET_ID="cat ${ID_FILE}"
On 08/31/2011 11:01 PM, Serge Hallyn wrote:
> Thanks for taking the time to report this bug. I trivially confirmed it
> with your example. I was thinking it was corrupting the
> authorized_keys, but as it isn't, and as the garbled response is
> reasonably obviously an indication of an error, I will mark priority
> low.
>
> ** Changed in: openssh (Ubuntu)
> Importance: Undecided => High
>
> ** Changed in: openssh (Ubuntu)
> Status: New => Confirmed
>
> ** Changed in: openssh (Ubuntu)
> Importance: High => Low
>
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to openssh in Ubuntu.
https://bugs.launchpad.net/bugs/835901
Title:
ssh-copy-id: fails to sanitize arguments
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openssh/+bug/835901/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 835901] Re: ssh-copy-id: fails to sanitize arguments
Thanks for taking the time to report this bug. I trivially confirmed it with your example. I was thinking it was corrupting the authorized_keys, but as it isn't, and as the garbled response is reasonably obviously an indication of an error, I will mark priority low. ** Changed in: openssh (Ubuntu) Importance: Undecided => High ** Changed in: openssh (Ubuntu) Status: New => Confirmed ** Changed in: openssh (Ubuntu) Importance: High => Low -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to openssh in Ubuntu. https://bugs.launchpad.net/bugs/835901 Title: ssh-copy-id: fails to sanitize arguments To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openssh/+bug/835901/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 835901] Re: ssh-copy-id: fails to sanitize arguments
-- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to openssh in Ubuntu. https://bugs.launchpad.net/bugs/835901 Title: ssh-copy-id: fails to sanitize arguments To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openssh/+bug/835901/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
