WebView::GetLocationBarContentOffset() returns -nan.
I’m not sure where the root cause of the issue lies
(cc::CompositorFrameMetadata::top_controls_height and
cc::CompositorFrameMetadata::top_controls_shown_ratio having non-number
values), this would require further investigation to determine. The
following patch works around the issue:
float WebView::GetLocationBarContentOffset() const {
float offset = compositor_frame_metadata().top_controls_height *
compositor_frame_metadata().top_controls_shown_ratio;
if (std::isnan(offset)) {
return 0.f;
}
return offset;
}
Note that the code for the location bar controller has been
significantly reworked in oxide since then, so it’s hard to tell whether
the issue (which doesn’t exhibit in master) has been fixed in oxide
itself or whether it was a bug in chromium that has been fixed since
then.
** Also affects: oxide/1.18
Importance: Undecided
Status: New
** Changed in: oxide/1.18
Milestone: None => 1.18.4
** Changed in: oxide/1.18
Importance: Undecided => Critical
** Changed in: oxide/1.18
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1639185
Title:
oxide 1.18.3 crashes when running webbrowser-app tests
Status in Oxide:
New
Status in Oxide 1.18 series:
Confirmed
Bug description:
After upgrading oxide-qt from 1.17.9 to 1.18.3 I’ve started observing
consistent crashes when running both autopilot and unit tests for
webbrowser-app.
Steps to reproduce, on a system running xenial+overlay:
$ bzr branch lp:webbrowser-app
$ cd webbrowser-app
$ cmake . && make
$ ./tests/unittests/qml/tst_QmlTests -input
tests/unittests/qml/tst_UbuntuWebView02.qml -import src
Here is a stacktrace I get:
#0 0x76ffa84a in QV4::Value::as (this=0x7fffd8965e40)
at jsruntime/qv4managed_p.h:192
#1 QV4::RuntimeHelpers::toPrimitive (typeHint=0, value=...) at
jsruntime/qv4runtime_p.h:266
#2 QV4::RuntimeHelpers::addHelper (engine=0x7dd970, left=..., right=...) at
jsruntime/qv4runtime.cpp:516
#3 0x7fffe001f964 in ?? ()
#4 0x7fffc82101c8 in ?? ()
#5 0x77082c45 in QQmlPropertyCapture::registerQmlDependencies
(engine=0x7dd970, compiledFunction=) at
qml/qqmljavascriptexpression.cpp:328
#6 0x76fa0b3b in QV4::SimpleScriptFunction::call (that=, callData=0x7fffd8965d08) at jsruntime/qv4functionobject.cpp:577
#7 0x770817d4 in QV4::Object::call (d=0x7fffd8965dc8,
this=0x7fffe800de58)
at
../../include/QtQml/5.6.1/QtQml/private/../../../../../src/qml/jsruntime/qv4object_p.h:324
#8 QQmlJavaScriptExpression::evaluate (this=this@entry=0x1f283c0,
callData=callData@entry=0x7fffd8965dc8,
isUndefined=isUndefined@entry=0x7fff2a2c)
at qml/qqmljavascriptexpression.cpp:189
#9 0x77081c71 in QQmlJavaScriptExpression::evaluate
(this=this@entry=0x1f283c0, isUndefined=isUndefined@entry=0x7fff2a2c)
at qml/qqmljavascriptexpression.cpp:149
#10 0x7708952e in QQmlBinding::update (this=0x1f283c0, flags=...) at
qml/qqmlbinding.cpp:187
#11 0x77089a3e in QQmlBinding::refresh (this=) at
qml/qqmlbinding.cpp:403
#12 0x77060b7e in QQmlNotifier::emitNotify (endpoint=,
a=a@entry=0x0) at qml/qqmlnotifier.cpp:94
#13 0x7700c55c in QQmlData::signalEmitted (object=0x1f27e70,
index=52, a=0x0) at qml/qqmlengine.cpp:773
#14 0x76a3d2c0 in QMetaObject::activate (sender=0x1f27e70,
signalOffset=, local_signal_index=,
argv=argv@entry=0x0)
at kernel/qobject.cpp:3616
#15 0x77006d25 in QQmlVMEMetaObject::activate
(this=this@entry=0x1f28150, object=, index=,
args=args@entry=0x0)
at qml/qqmlvmemetaobject.cpp:1196
#16 0x77008229 in QQmlVMEMetaObject::metaCall (this=0x1f28150,
o=, c=, _id=, a=)
at qml/qqmlvmemetaobject.cpp:748
#17 0x7708f631 in QV4::QQmlValueTypeWrapper::write
(this=this@entry=0x7fffd8965db8, target=0x1f27e70, propertyIndex=64) at
qml/qqmlvaluetypewrapper.cpp:299
#18 0x770888ac in QQmlBinding::write (this=this@entry=0x1f28580,
core=..., result=..., isUndefined=, flags=...) at
qml/qqmlbinding.cpp:259
#19 0x770895ea in QQmlBinding::update (this=0x1f28580, flags=...) at
qml/qqmlbinding.cpp:191
#20 0x77089a3e in QQmlBinding::refresh (this=) at
qml/qqmlbinding.cpp:403
#21 0x77060b7e in QQmlNotifier::emitNotify (endpoint=,
a=a@entry=0x0) at qml/qqmlnotifier.cpp:94
#22 0x7700c55c in QQmlData::signalEmitted (object=0xacbf40, index=5,
a=0x0) at qml/qqmlengine.cpp:773
#23 0x76a3d2c0 in QMetaObject::activate (sender=0xacbf40,
signalOffset=, local_signal_index=, argv=0x0) at
kernel/qobject.cpp:3616
#24 0x7fffd8126af5 in
OxideQQuickTouchSelectionController::boundsChanged() () from
/usr/lib/x86_64-linux-gnu/libOxideQtQuic
