[Ubuntu-x-swat] [Bug 1675481] Re: Xmir crashes when using the '-fd' option
** Changed in: xorg-server (Ubuntu) Status: Fix Committed => Won't Fix -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg-server in Ubuntu. https://bugs.launchpad.net/bugs/1675481 Title: Xmir crashes when using the '-fd' option To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1675481/+subscriptions ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 1675481] Re: Xmir crashes when using the '-fd' option
https://git.launchpad.net/~xmir-team/xorg- server/+git/xmir/commit/?id=e8435ece23017fb4153487f6157eb11cac985697 ** Changed in: xorg-server (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg-server in Ubuntu. https://bugs.launchpad.net/bugs/1675481 Title: Xmir crashes when using the '-fd' option To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1675481/+subscriptions ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 1675481] Re: Xmir crashes when using the '-fd' option
... and if moving the block is insufficient and the timer is your only option, I pre-approve of that landing too. Makes sense either of those should fix it. ** Changed in: xorg-server (Ubuntu) Assignee: (unassigned) => Christopher Townsend (townsend) ** Changed in: xorg-server (Ubuntu) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg-server in Ubuntu. https://bugs.launchpad.net/bugs/1675481 Title: Xmir crashes when using the '-fd' option To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1675481/+subscriptions ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 1675481] Re: Xmir crashes when using the '-fd' option
Your diff appears to be what I was suggesting in comment #2. Please try just moving that whole block to near the end of the function (without using timers). If that works then please do commit. -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg-server in Ubuntu. https://bugs.launchpad.net/bugs/1675481 Title: Xmir crashes when using the '-fd' option To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1675481/+subscriptions ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 1675481] Re: Xmir crashes when using the '-fd' option
The following diff seems to fix the crash:
http://pastebin.ubuntu.com/24242549/
I haven't committed it yet since I'm really not sure if this method is
valid or if there is a bug.
After a client connects to the X socket and Xmir is started with the fd
returned from accept(), the client just hangs. I got a backtrace of the
client, and it's blocked on xcb_connect_to_fd(). Here is a snippet of
the bt:
(gdb) bt full
#0 0x7fc8426b2b40 in __poll_nocancel () at
../sysdeps/unix/syscall-template.S:84
No locals.
#1 0x7fc83c0a1d0b in poll (__timeout=-1, __nfds=1, __fds=0x7ffcbb227250)
at /usr/include/x86_64-linux-gnu/bits/poll2.h:46
No locals.
#2 read_block (len=8, buf=0x22e6950, fd=4) at ../../src/xcb_in.c:388
pfd = {fd = 4, events = 1, revents = 0}
ret =
done = 0
#3 _xcb_in_read_block (c=c@entry=0x2505cd0, buf=0x22e6950, len=len@entry=8) at
../../src/xcb_in.c:1057
done = 0
#4 0x7fc83c09fa93 in read_setup (c=0x2505cd0) at ../../src/xcb_conn.c:157
No locals.
#5 xcb_connect_to_fd (fd=fd@entry=4, auth_info=auth_info@entry=0x0) at
../../src/xcb_conn.c:339
c =
#6 0x7fc83c0a3679 in xcb_connect_to_display_with_auth_info
(displayname=, auth=0x0, screenp=0x0) at ../../src/xcb_util.c:528
display = 0
host = 0x22c6480 ""
protocol = 0x0
ourauth = {namelen = 1155370049, name = 0x7ffcbb2273bf "", datalen =
-1717986919, data = 0x7fc84297bb20 ""}
c =
parsed =
#7 0x7fc83e74780a in _XConnectXCB () from
target:/usr/lib/x86_64-linux-gnu/libX11.so.6
No symbol table info available.
So it seems it's waiting on the X server to send something back, but the
X server is not. Most likely a bug in the X server...
--
You received this bug notification because you are a member of Ubuntu-X,
which is subscribed to xorg-server in Ubuntu.
https://bugs.launchpad.net/bugs/1675481
Title:
Xmir crashes when using the '-fd' option
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1675481/+subscriptions
___
Mailing list: https://launchpad.net/~ubuntu-x-swat
Post to : ubuntu-x-swat@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-x-swat
More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 1675481] Re: Xmir crashes when using the '-fd' option
I was wrong. What I was reproducing is a different crash with large FDs not specific to Xmir. I'm really not sure how to reproduce your crash or if your use case is valid. Only one theory: the logic for the -fd client connection is executed early before Xmir has started properly. We can try moving it to a lower location after the server has actually initialized. ** Changed in: xorg-server (Ubuntu) Importance: High => Medium ** Changed in: xorg-server (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg-server in Ubuntu. https://bugs.launchpad.net/bugs/1675481 Title: Xmir crashes when using the '-fd' option To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1675481/+subscriptions ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 1675481] Re: Xmir crashes when using the '-fd' option
I'm not familiar with the -fd option myself, but confirm it can be made to crash: Xmir :1 -fd ** Changed in: xorg-server (Ubuntu) Status: New => Confirmed ** Changed in: xorg-server (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg-server in Ubuntu. https://bugs.launchpad.net/bugs/1675481 Title: Xmir crashes when using the '-fd' option To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1675481/+subscriptions ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 1675481] Re: Xmir crashes when using the '-fd' option
** Description changed: I'm trying to use the '-fd' option in Xmir and get a crash when Xmir starts up. This is what I'm doing: I'm using socket()/bind()/listen()/accept() on a AF_UNIX socket at /tmp/.X11-unix/X0 (or whatever available display number). DISPLAY is then set based on this. Then, when an X app accesses that socket, the code then starts Xmir and passes the fd returned in the accept() call to Xmir in the '-fd' option. This is what I get in journalctl when this crash occurs: http://pastebin.ubuntu.com/24235520/ - Also, no Xmir crash file is generated. + I installed the Xmir debug symbols and also passed in '-core' when + starting Xmir and here is the bt: http://pastebin.ubuntu.com/24236088/ -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg-server in Ubuntu. https://bugs.launchpad.net/bugs/1675481 Title: Xmir crashes when using the '-fd' option To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1675481/+subscriptions ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
[Ubuntu-x-swat] [Bug 1675481] Re: Xmir crashes when using the '-fd' option
** Description changed: I'm trying to use the '-fd' option in Xmir and get a crash when Xmir starts up. This is what I'm doing: I'm using socket()/bind()/listen()/accept() on a AF_UNIX socket at /tmp/.X11-unix/X0 (or whatever available display number). DISPLAY is then set based on this. Then, when an X app accesses that socket, the - code then starts Xmir and passes the same fd returned in the socket() - call to Xmir in the '-fd' option. + code then starts Xmir and passes the fd returned in the accept() call to + Xmir in the '-fd' option. This is what I get in journalctl when this crash occurs: http://pastebin.ubuntu.com/24235520/ Also, no Xmir crash file is generated. -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xorg-server in Ubuntu. https://bugs.launchpad.net/bugs/1675481 Title: Xmir crashes when using the '-fd' option To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1675481/+subscriptions ___ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
