Re: [uClinux-dev] [patch ] elf2flt MicroBlaze update
On Saturday 16 May 2009 23:10:42 John Williams wrote:
Tweak configure{.in} to indicate that MicroBlaze needs the
--disable-emit-relocs switch
i dont think it's appropriate to list arch needs in the configure script like
this.
-mike
signature.asc
Description: This is a digitally signed message part.
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [PATCH] elf2flt: always include elf/bfin.h
Jivin Mike Frysinger lays it down ... The header logic for pulling in ELF defines mixes common ELF headers and target specific headers. In the Blackfin case, we always want to pull in the bfin.h since most of the time, the common ELF headers do not have our relocation defines. This fixes building for mingw targets. Signed-off-by: Mike Frysinger vap...@gentoo.org Applied, Thanks, Davidm --- elf2flt.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/elf2flt.c b/elf2flt.c index 9b1ea37..a120cc9 100644 --- a/elf2flt.c +++ b/elf2flt.c @@ -62,12 +62,17 @@ #include cygwin-elf.h /* Cygwin uses a local copy */ #elif defined(TARGET_microblaze) #include elf/microblaze.h /* TARGET_* ELF support for the BFD library */ -#elif defined(TARGET_bfin) -#include elf/bfin.h #else #include elf.h /* TARGET_* ELF support for the BFD library */ #endif +/* Always include Blackfin-specific defines in addition to common ELF stuff + * above as the common elf headers often do not have our relocs. + */ +#ifdef TARGET_bfin +#include elf/bfin.h +#endif + #if defined(__MINGW32__) #include getopt.h #endif -- 1.6.3 ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev -- David McCullough, david_mccullo...@securecomputing.com, Ph:+61 734352815 McAfee - SnapGear http://www.snapgear.comhttp://www.uCdot.org ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [patch ] elf2flt MicroBlaze update
On Mon, May 18, 2009 at 7:19 AM, Mike Frysinger vap...@gentoo.org wrote:
On Saturday 16 May 2009 23:10:42 John Williams wrote:
Tweak configure{.in} to indicate that MicroBlaze needs the
--disable-emit-relocs switch
i dont think it's appropriate to list arch needs in the configure script like
this.
I was inspired by the similar recommendation for H8 in one of the
other configure args.
Any better way of doing this? Fact is, if you don't pass this arg, it
is broken for MicroBlaze.
Ultimately I don't care if that part is dropped, the elf2flt.c changes
are what is important.
Cheers,
John
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
Re: [uClinux-dev] [patch ] elf2flt MicroBlaze update
On Sunday 17 May 2009 23:58:12 John Williams wrote:
On Mon, May 18, 2009 at 7:19 AM, Mike Frysinger vap...@gentoo.org wrote:
On Saturday 16 May 2009 23:10:42 John Williams wrote:
Tweak configure{.in} to indicate that MicroBlaze needs the
--disable-emit-relocs switch
i dont think it's appropriate to list arch needs in the configure script
like this.
I was inspired by the similar recommendation for H8 in one of the
other configure args.
Any better way of doing this? Fact is, if you don't pass this arg, it
is broken for MicroBlaze.
people dont read documentation. if we really want arch checks, make it a
warning in the configure script.
case $emit_relocs:$target_cpu in
yes:microblaze) AC_MSG_WARNING([emitting relocs on your arch will
break]);;
esac
and if you want a sane default, then add support for that:
AC_ARG_ENABLE(emit_relocs,
...
[case $target_cpu in
microblaze) emit_relocs=no;;
*) emit_relocs=yes;;
esac]
)
-mike
signature.asc
Description: This is a digitally signed message part.
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
[uClinux-dev] [PATCH] fix emit relocs/ctor-dtor options
The option given to AC_ARG_ENABLE() have typos in them -- they use an underscore instead of a dash. Signed-off-by: Mike Frysinger vap...@gentoo.org --- configure.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.in b/configure.in index e18e41c..eb9733f 100644 --- a/configure.in +++ b/configure.in @@ -49,13 +49,13 @@ AC_ARG_ENABLE(got-check, [ got_check=yes ] ) -AC_ARG_ENABLE(emit_relocs, +AC_ARG_ENABLE(emit-relocs, [ --disable-emit-relocs - don't use the --emit-relocs (-q) linker option ], [ emit_relocs=$enableval ], [ emit_relocs=yes ] ) -AC_ARG_ENABLE(emit_ctor_dtor, +AC_ARG_ENABLE(emit-ctor-dtor, AS_HELP_STRING([--enable-emit-ctor-dtor], [manually create ctor/dtor list]), [ emit_ctor_dtor=$enableval ], [ emit_ctor_dtor=no ] -- 1.6.3 ___ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
