[uClinux-dev] Re: [PATCH] FLAT: fix unmap len in load error path

[David Howells]

Mike Frysinger vap...@gentoo.org wrote:

 The data chunk is mmaped with 'len' which remains unchanged, so use that
 when unmapping in the error path rather than trying to recalculate (and
 incorrectly so) the value used originally.
 
 Signed-off-by: Mike Frysinger vap...@gentoo.org

Acked-by: David Howells dhowe...@redhat.com
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

[uClinux-dev] Re: [PATCH] FLAT: fix unmap len in load error path

[David McCullough]

Jivin Mike Frysinger lays it down ...
 The data chunk is mmaped with 'len' which remains unchanged, so use that
 when unmapping in the error path rather than trying to recalculate (and
 incorrectly so) the value used originally.
 
 Signed-off-by: Mike Frysinger vap...@gentoo.org

Acked-by: David McCullough david_mccullo...@mcafee.com

Cheers,
Davidm

 ---
  fs/binfmt_flat.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
 index 4959a0a..f7a4059 100644
 --- a/fs/binfmt_flat.c
 +++ b/fs/binfmt_flat.c
 @@ -596,7 +596,7 @@ static int load_flat_file(struct linux_binprm * bprm,
   if (IS_ERR_VALUE(result)) {
   printk(Unable to read data+bss, errno %d\n, 
 (int)-result);
   do_munmap(current-mm, textpos, text_len);
 - do_munmap(current-mm, realdatastart, data_len + extra);
 + do_munmap(current-mm, realdatastart, len);
   ret = result;
   goto err;
   }
 -- 
 1.7.1
 
 
 

-- 
David McCullough,  david_mccullo...@mcafee.com,  Ph:+61 734352815
McAfee - SnapGear  http://www.mcafee.com http://www.uCdot.org
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

[uClinux-dev] Re: [PATCH] FLAT: fix unmap len in load error path

[Greg Ungerer]

Mike Frysinger wrote:

The data chunk is mmaped with 'len' which remains unchanged, so use that
when unmapping in the error path rather than trying to recalculate (and
incorrectly so) the value used originally.

Signed-off-by: Mike Frysinger vap...@gentoo.org


Acked-by: Greg Ungerer g...@uclinux.org



---
 fs/binfmt_flat.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
index 4959a0a..f7a4059 100644
--- a/fs/binfmt_flat.c
+++ b/fs/binfmt_flat.c
@@ -596,7 +596,7 @@ static int load_flat_file(struct linux_binprm * bprm,
if (IS_ERR_VALUE(result)) {
printk(Unable to read data+bss, errno %d\n, 
(int)-result);
do_munmap(current-mm, textpos, text_len);
-   do_munmap(current-mm, realdatastart, data_len + extra);
+   do_munmap(current-mm, realdatastart, len);
ret = result;
goto err;
}



--

Greg Ungerer  --  Principal EngineerEMAIL: g...@snapgear.com
SnapGear Group, McAfee  PHONE:   +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, AustraliaWEB: http://www.SnapGear.com
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev