Re: Beam release 2.5.0 tag SNAPSHOT version
Thank you Kenneth! I thought Maven was removed starting 2.6.0. I will change my build tool to Gradle. On Fri, 19 Jul 2019 at 12:13, Kenneth Knowles wrote: > Good catch. > > The release 2.5.0 was built with gradle, so that pom is left over. The > gradle release plugin does not edit poms, so it did not change that. > Instead, the pom is generated and you can find them on maven central like > https://repo1.maven.org/maven2/org/apache/beam/beam-runners-direct-java/2.5.0/beam-runners-direct-java-2.5.0.pom. > Today > the pom has been removed and it is generated at run time. > > Since you are digging into details, you may also be interested in the RC > vote and verification thread: > https://lists.apache.org/thread.html/dac093378fb27331c5d9d86a3bd03397f7e186d482f0fc8c8ef88feb@%3Cdev.beam.apache.org%3E > > To answer your original question, I do believe the tag v2.5.0 and > v2.5.0-RC2 point to the commit where the released artifacts were built. > > Kenn > > On Wed, Jul 17, 2019 at 10:54 PM Abdul Qadeer > wrote: > >> Hi Kenneth! >> >> But even the tag v2.5.0 points to SNAPSHOT version for Maven: >> https://github.com/apache/beam/blob/v2.5.0/pom.xml#L37 >> >> The same file in v2.4.0: >> https://github.com/apache/beam/blob/v2.4.0/pom.xml#L37 >> >> I am looking to publish v2.5.0 artifacts via maven to a private >> artifactory, and without right versions it will publish it as a SNAPSHOT >> version. Shall I raise a PR for this? >> >> On Wed, Jul 17, 2019 at 3:41 PM Kenneth Knowles wrote: >> >>> What you have pointed to is the tip of the release-2.5.0 branch. The >>> gradle release plugin copies the maven release plugin. So it has rolled >>> back the version change so the branch is always at a snapshot version. >>> >>> The commit before that is tag v2.5.0 and that is the final tag. Here is >>> the gradle properties: >>> https://github.com/apache/beam/blob/v2.5.0/gradle.properties >>> >>> I do believe this should be 2.5.0, not 2.5.0-RC2. But anyhow I think >>> that is the commit that was used to build 2.5.0. >>> >>> Kenn >>> >>> On Wed, Jul 17, 2019 at 3:36 PM Kenneth Knowles wrote: >>> I take that back - misclicked on 0.5.0 (which has a correct tag). On Wed, Jul 17, 2019 at 3:34 PM Kenneth Knowles wrote: > Looks like it is this: > https://github.com/apache/beam/tree/4838ae16c172252bc0a15e3a984e085f82e25c2d > > I believe the release manager created the tag to point to the tip of > the release branch after the maven release plugin rolled that change back > (this is how the maven release plugin works since it does not utilize > git's > branching model). > > I will fix the tag. > > Kenn > > On Wed, Jul 17, 2019 at 3:32 PM Abdul Qadeer > wrote: > >> Hi! >> >> Why is v2.5.0 tag for Beam 2.5.0 release SNAPSHOT version here? >> https://github.com/apache/beam/blob/v2.5.0/pom.xml#L37 >> >> https://github.com/apache/beam/blob/release-2.5.0/gradle.properties#L25 >> >> Please let me know where to find final release 2.5.0 commit. >> >
Re: Beam release 2.5.0 tag SNAPSHOT version
Good catch. The release 2.5.0 was built with gradle, so that pom is left over. The gradle release plugin does not edit poms, so it did not change that. Instead, the pom is generated and you can find them on maven central like https://repo1.maven.org/maven2/org/apache/beam/beam-runners-direct-java/2.5.0/beam-runners-direct-java-2.5.0.pom. Today the pom has been removed and it is generated at run time. Since you are digging into details, you may also be interested in the RC vote and verification thread: https://lists.apache.org/thread.html/dac093378fb27331c5d9d86a3bd03397f7e186d482f0fc8c8ef88feb@%3Cdev.beam.apache.org%3E To answer your original question, I do believe the tag v2.5.0 and v2.5.0-RC2 point to the commit where the released artifacts were built. Kenn On Wed, Jul 17, 2019 at 10:54 PM Abdul Qadeer wrote: > Hi Kenneth! > > But even the tag v2.5.0 points to SNAPSHOT version for Maven: > https://github.com/apache/beam/blob/v2.5.0/pom.xml#L37 > > The same file in v2.4.0: > https://github.com/apache/beam/blob/v2.4.0/pom.xml#L37 > > I am looking to publish v2.5.0 artifacts via maven to a private > artifactory, and without right versions it will publish it as a SNAPSHOT > version. Shall I raise a PR for this? > > On Wed, Jul 17, 2019 at 3:41 PM Kenneth Knowles wrote: > >> What you have pointed to is the tip of the release-2.5.0 branch. The >> gradle release plugin copies the maven release plugin. So it has rolled >> back the version change so the branch is always at a snapshot version. >> >> The commit before that is tag v2.5.0 and that is the final tag. Here is >> the gradle properties: >> https://github.com/apache/beam/blob/v2.5.0/gradle.properties >> >> I do believe this should be 2.5.0, not 2.5.0-RC2. But anyhow I think that >> is the commit that was used to build 2.5.0. >> >> Kenn >> >> On Wed, Jul 17, 2019 at 3:36 PM Kenneth Knowles wrote: >> >>> I take that back - misclicked on 0.5.0 (which has a correct tag). >>> >>> On Wed, Jul 17, 2019 at 3:34 PM Kenneth Knowles wrote: >>> Looks like it is this: https://github.com/apache/beam/tree/4838ae16c172252bc0a15e3a984e085f82e25c2d I believe the release manager created the tag to point to the tip of the release branch after the maven release plugin rolled that change back (this is how the maven release plugin works since it does not utilize git's branching model). I will fix the tag. Kenn On Wed, Jul 17, 2019 at 3:32 PM Abdul Qadeer wrote: > Hi! > > Why is v2.5.0 tag for Beam 2.5.0 release SNAPSHOT version here? > https://github.com/apache/beam/blob/v2.5.0/pom.xml#L37 > https://github.com/apache/beam/blob/release-2.5.0/gradle.properties#L25 > > Please let me know where to find final release 2.5.0 commit. >
Re: Beam release 2.5.0 tag SNAPSHOT version
Hi Kenneth! But even the tag v2.5.0 points to SNAPSHOT version for Maven: https://github.com/apache/beam/blob/v2.5.0/pom.xml#L37 The same file in v2.4.0: https://github.com/apache/beam/blob/v2.4.0/pom.xml#L37 I am looking to publish v2.5.0 artifacts via maven to a private artifactory, and without right versions it will publish it as a SNAPSHOT version. Shall I raise a PR for this? On Wed, Jul 17, 2019 at 3:41 PM Kenneth Knowles wrote: > What you have pointed to is the tip of the release-2.5.0 branch. The > gradle release plugin copies the maven release plugin. So it has rolled > back the version change so the branch is always at a snapshot version. > > The commit before that is tag v2.5.0 and that is the final tag. Here is > the gradle properties: > https://github.com/apache/beam/blob/v2.5.0/gradle.properties > > I do believe this should be 2.5.0, not 2.5.0-RC2. But anyhow I think that > is the commit that was used to build 2.5.0. > > Kenn > > On Wed, Jul 17, 2019 at 3:36 PM Kenneth Knowles wrote: > >> I take that back - misclicked on 0.5.0 (which has a correct tag). >> >> On Wed, Jul 17, 2019 at 3:34 PM Kenneth Knowles wrote: >> >>> Looks like it is this: >>> https://github.com/apache/beam/tree/4838ae16c172252bc0a15e3a984e085f82e25c2d >>> >>> I believe the release manager created the tag to point to the tip of the >>> release branch after the maven release plugin rolled that change back (this >>> is how the maven release plugin works since it does not utilize git's >>> branching model). >>> >>> I will fix the tag. >>> >>> Kenn >>> >>> On Wed, Jul 17, 2019 at 3:32 PM Abdul Qadeer >>> wrote: >>> Hi! Why is v2.5.0 tag for Beam 2.5.0 release SNAPSHOT version here? https://github.com/apache/beam/blob/v2.5.0/pom.xml#L37 https://github.com/apache/beam/blob/release-2.5.0/gradle.properties#L25 Please let me know where to find final release 2.5.0 commit. >>>
Re: Beam release 2.5.0 tag SNAPSHOT version
What you have pointed to is the tip of the release-2.5.0 branch. The gradle release plugin copies the maven release plugin. So it has rolled back the version change so the branch is always at a snapshot version. The commit before that is tag v2.5.0 and that is the final tag. Here is the gradle properties: https://github.com/apache/beam/blob/v2.5.0/gradle.properties I do believe this should be 2.5.0, not 2.5.0-RC2. But anyhow I think that is the commit that was used to build 2.5.0. Kenn On Wed, Jul 17, 2019 at 3:36 PM Kenneth Knowles wrote: > I take that back - misclicked on 0.5.0 (which has a correct tag). > > On Wed, Jul 17, 2019 at 3:34 PM Kenneth Knowles wrote: > >> Looks like it is this: >> https://github.com/apache/beam/tree/4838ae16c172252bc0a15e3a984e085f82e25c2d >> >> I believe the release manager created the tag to point to the tip of the >> release branch after the maven release plugin rolled that change back (this >> is how the maven release plugin works since it does not utilize git's >> branching model). >> >> I will fix the tag. >> >> Kenn >> >> On Wed, Jul 17, 2019 at 3:32 PM Abdul Qadeer >> wrote: >> >>> Hi! >>> >>> Why is v2.5.0 tag for Beam 2.5.0 release SNAPSHOT version here? >>> https://github.com/apache/beam/blob/v2.5.0/pom.xml#L37 >>> https://github.com/apache/beam/blob/release-2.5.0/gradle.properties#L25 >>> >>> Please let me know where to find final release 2.5.0 commit. >>> >>
Re: Beam release 2.5.0 tag SNAPSHOT version
I take that back - misclicked on 0.5.0 (which has a correct tag). On Wed, Jul 17, 2019 at 3:34 PM Kenneth Knowles wrote: > Looks like it is this: > https://github.com/apache/beam/tree/4838ae16c172252bc0a15e3a984e085f82e25c2d > > I believe the release manager created the tag to point to the tip of the > release branch after the maven release plugin rolled that change back (this > is how the maven release plugin works since it does not utilize git's > branching model). > > I will fix the tag. > > Kenn > > On Wed, Jul 17, 2019 at 3:32 PM Abdul Qadeer > wrote: > >> Hi! >> >> Why is v2.5.0 tag for Beam 2.5.0 release SNAPSHOT version here? >> https://github.com/apache/beam/blob/v2.5.0/pom.xml#L37 >> https://github.com/apache/beam/blob/release-2.5.0/gradle.properties#L25 >> >> Please let me know where to find final release 2.5.0 commit. >> >
Re: Beam release 2.5.0 tag SNAPSHOT version
Looks like it is this: https://github.com/apache/beam/tree/4838ae16c172252bc0a15e3a984e085f82e25c2d I believe the release manager created the tag to point to the tip of the release branch after the maven release plugin rolled that change back (this is how the maven release plugin works since it does not utilize git's branching model). I will fix the tag. Kenn On Wed, Jul 17, 2019 at 3:32 PM Abdul Qadeer wrote: > Hi! > > Why is v2.5.0 tag for Beam 2.5.0 release SNAPSHOT version here? > https://github.com/apache/beam/blob/v2.5.0/pom.xml#L37 > https://github.com/apache/beam/blob/release-2.5.0/gradle.properties#L25 > > Please let me know where to find final release 2.5.0 commit. >
Beam release 2.5.0 tag SNAPSHOT version
Hi! Why is v2.5.0 tag for Beam 2.5.0 release SNAPSHOT version here? https://github.com/apache/beam/blob/v2.5.0/pom.xml#L37 https://github.com/apache/beam/blob/release-2.5.0/gradle.properties#L25 Please let me know where to find final release 2.5.0 commit.
