Re: Max with retract aggregate function does not support type: ''CHAR''.

2021-02-03 Thread Timo Walther

Hi Yuval,

yes this is rather a bug. If we support VARCHAR here we should also 
support CHAR. Feel free to open an issue.


Regards,
Timo

On 03.02.21 11:46, Yuval Itzchakov wrote:
I can understand that in some sense it's nonsensical to MAX on a CHAR, 
since Blink will only determine a CHAR when there's a constant in the 
SQL, but I was surprised that it didn't work with just an identity 
implementation.


On Wed, Feb 3, 2021 at 12:33 PM Till Rohrmann <mailto:trohrm...@apache.org>> wrote:


Thanks for reaching out to the Flink community Yuval. I am pulling
in Timo and Jark who might be able to answer this question. From
what I can tell, it looks a bit like an oversight because VARCHAR is
also supported.

Cheers,
Till

On Tue, Feb 2, 2021 at 6:12 PM Yuval Itzchakov mailto:yuva...@gmail.com>> wrote:

Hi,
I'm trying to use MAX on a field that is statically known from
another table (let's ignore why for a moment). While running the
SQL query, I receive an error:

    Max with retract aggregate function does not support type: ''CHAR''.

Looking at the code for creating the max function:

image.png

It does seem like all primitives are supported. Is there a
particular reason why a CHAR would not be supported? Is this an
oversight?
-- 
Best Regards,

Yuval Itzchakov.



--
Best Regards,
Yuval Itzchakov.




Re: Max with retract aggregate function does not support type: ''CHAR''.

2021-02-03 Thread Yuval Itzchakov
I can understand that in some sense it's nonsensical to MAX on a CHAR,
since Blink will only determine a CHAR when there's a constant in the SQL,
but I was surprised that it didn't work with just an identity
implementation.

On Wed, Feb 3, 2021 at 12:33 PM Till Rohrmann  wrote:

> Thanks for reaching out to the Flink community Yuval. I am pulling in Timo
> and Jark who might be able to answer this question. From what I can tell,
> it looks a bit like an oversight because VARCHAR is also supported.
>
> Cheers,
> Till
>
> On Tue, Feb 2, 2021 at 6:12 PM Yuval Itzchakov  wrote:
>
>> Hi,
>> I'm trying to use MAX on a field that is statically known from another
>> table (let's ignore why for a moment). While running the SQL query, I
>> receive an error:
>>
>> Max with retract aggregate function does not support type: ''CHAR''.
>>
>> Looking at the code for creating the max function:
>>
>> [image: image.png]
>>
>> It does seem like all primitives are supported. Is there a particular
>> reason why a CHAR would not be supported? Is this an oversight?
>> --
>> Best Regards,
>> Yuval Itzchakov.
>>
>

-- 
Best Regards,
Yuval Itzchakov.


Re: Max with retract aggregate function does not support type: ''CHAR''.

2021-02-03 Thread Till Rohrmann
Thanks for reaching out to the Flink community Yuval. I am pulling in Timo
and Jark who might be able to answer this question. From what I can tell,
it looks a bit like an oversight because VARCHAR is also supported.

Cheers,
Till

On Tue, Feb 2, 2021 at 6:12 PM Yuval Itzchakov  wrote:

> Hi,
> I'm trying to use MAX on a field that is statically known from another
> table (let's ignore why for a moment). While running the SQL query, I
> receive an error:
>
> Max with retract aggregate function does not support type: ''CHAR''.
>
> Looking at the code for creating the max function:
>
> [image: image.png]
>
> It does seem like all primitives are supported. Is there a particular
> reason why a CHAR would not be supported? Is this an oversight?
> --
> Best Regards,
> Yuval Itzchakov.
>


Max with retract aggregate function does not support type: ''CHAR''.

2021-02-02 Thread Yuval Itzchakov
Hi,
I'm trying to use MAX on a field that is statically known from another
table (let's ignore why for a moment). While running the SQL query, I
receive an error:

Max with retract aggregate function does not support type: ''CHAR''.

Looking at the code for creating the max function:

[image: image.png]

It does seem like all primitives are supported. Is there a particular
reason why a CHAR would not be supported? Is this an oversight?
-- 
Best Regards,
Yuval Itzchakov.