Re: CAPS lock is not working in XRDP version 0.9.5 with Ubuntu 16.0.4 [ Guacamole RDP ]

2018-03-06 Thread Nick Couchman 
On Mon, Mar 5, 2018 at 12:57 PM, Amarjeet Singh 
wrote:

> Hi Nick,
>
>
> I tried the above and took the fresh code using git clone
> https://github.com/apache/guacamole-client to a fresh directory and BUILD
> was success without any errors.
>
> git fetch upstream might have caused something which I need to figure out.
> There are no merge conflicts though.
>
> *The above issue still persists.   Caps lock is not working as expected in
> XRDP version 0.9.5 with Ubuntu.*
>
>
Can you confirm that Caps Lock works as expected with XRDP and other RDP
clients - xfreerdp, Microsoft RDP Client, etc.?

-Nick

Re: CAPS lock is not working in XRDP version 0.9.5 with Ubuntu 16.0.4 [ Guacamole RDP ]

2018-03-05 Thread Mike Jumper 
On Mon, Mar 5, 2018 at 8:42 PM, Amarjeet Singh  wrote:

> @Mike,
>
> I have tested with the fresh code form the GIT. Can I report a bug in JIRA
> for the above issue ?
>
>
You don't need to ask permission before opening a JIRA issue. As long as
you have done what you can to look into things on your end, I will not be
irritated to see a new issue pop up in JIRA.

- Mike

Re: CAPS lock is not working in XRDP version 0.9.5 with Ubuntu 16.0.4 [ Guacamole RDP ]

2018-03-05 Thread Amarjeet Singh 
I have also compiled the latest code of guacamole-server and still the
issue persists.

Caps lock is not working as expected in XRDP version 0.9.5 with Ubuntu

On Mon, Mar 5, 2018 at 8:01 PM, Amarjeet Singh  wrote:

> Hi Nick,
>
> I took the latest code from the git and it failed at the below point :-
>
> [ERROR] Failed to execute goal org.apache.maven.plugins:
> maven-compiler-plugin:3.3:compile (default-compile) on project
> guacamole-auth-jdbc-mysql: Compilation failure: Compilation failure:
> [ERROR] /root/Guacamole/guacamole-client/extensions/guacamole-
> auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/
> org/apache/guacamole/auth/mysql/MySQLSharedAuthenticationProvider.java:[31,7]
> error: MySQLSharedAuthenticationProvider is not abstract and does not
> override abstract method redecorate(UserContext,
> UserContext,AuthenticatedUser,Credentials) in AuthenticationProvider
> [ERROR] /root/Guacamole/guacamole-client/extensions/guacamole-
> auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/
> org/apache/guacamole/auth/mysql/MySQLAuthenticationProvider.java:[30,7]
> error: MySQLAuthenticationProvider is not abstract and does not override
> abstract method 
> redecorate(UserContext,UserContext,AuthenticatedUser,Credentials)
> in AuthenticationProvider
>
>
> Though it created the war file which I required.
> I tested with the latest code and the issue still persists.
>
> Is there any changes in guacamole-server also related to the above fix ?
>
> Regards,
> Amarjeet Singh
>
>
>
> On Mon, Mar 5, 2018 at 7:42 PM, Amarjeet Singh 
> wrote:
>
>> Ok Nick, I will look into it.
>>
>> On Mon, Mar 5, 2018 at 7:41 PM, Amarjeet Singh 
>> wrote:
>>
>>> I also tried to change the following code in *guacamole.js* and changed*
>>> index.html* file to load guacamole.js file instead app.js?varsion :-
>>>
>>> Browser is loading the guacamole.js and the below change as well which I
>>> verified through debugger as well.
>>>
>>> var no_repeat = {
>>> 0xFE03: true, // ISO Level 3 Shift (AltGr)
>>> 0xFFE1: true, // Left shift
>>> 0xFFE2: true, // Right shift
>>> 0xFFE3: true, // Left ctrl
>>> 0xFFE4: true, // Right ctrl
>>> 0xFFE5: true, // Caps Lock
>>> 0xFFE7: true, // Left meta
>>> 0xFFE8: true, // Right meta
>>> 0xFFE9: true, // Left alt
>>> 0xFFEA: true, // Right alt
>>> 0xFFEB: true, // Left hyper
>>> 0xFFEC: true  // Right hyper
>>> };
>>>
>>>   if (!no_repeat[keysym])
 key_repeat_timeout = window.setTimeout(function() {
 key_repeat_interval =
 window.setInterval(function() {
 guac_keyboard.onkeyup(keysym);
 guac_keyboard.onkeydown(keysym);
 }, 50);
 }, 500);
>>>
>>>
>>> *My Analyzations are as follows :-*
>>>
>>> if* no_repeat* is true ( as  0xFFE5  : true )  in the case of above it
>>> never enters into the loop.
>>>
>>> and  if I remove the above change , *no_repeat* will return false and
>>>  it will continuosly sends the CapsLock which is a BUG and it is fixed in
>>> 1.0.0
>>>
>>> GUACAMOLE-161: Merge changes adding Caps Lock to the do-not-auto-repeat
 list.
>>>
>>>
>>>
>>> Both the changes doesn't affect and fix the issue of *changing text
>>> from lowercase to uppercase*.
>>>
>>> On Mon, Mar 5, 2018 at 7:19 PM, Amarjeet Singh 
>>> wrote:
>>>
 Hi Team,


 I have been writing in Libre Office Writer on Guacamole RDP . I clicked
 CAPS lock and started writing but the text was still in lowercase.

 Guacamole-Server version : 0.9.14
 Guacamole-Client version : 0.9.14
 XRDP Version : 0.9.5
 Remote O.S. : Ubuntu 16.04.3 LTS 64-bit

 I have not done any modifications in the code.


 If I reconnect the RDP session with CAPS lock on, then it starts
 printing uppercase but if I again click CAPS lock to set it to lowercase,
 it still prints the uppercase.



 Regards,
 Amarjeet Singh



>>>
>>
>

Re: CAPS lock is not working in XRDP version 0.9.5 with Ubuntu 16.0.4 [ Guacamole RDP ]

2018-03-05 Thread Amarjeet Singh 
Hi Nick,

I took the latest code from the git and it failed at the below point :-

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.3:compile
(default-compile) on project guacamole-auth-jdbc-mysql: Compilation
failure: Compilation failure:
[ERROR]
/root/Guacamole/guacamole-client/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLSharedAuthenticationProvider.java:[31,7]
error: MySQLSharedAuthenticationProvider is not abstract and does not
override abstract method
redecorate(UserContext,UserContext,AuthenticatedUser,Credentials) in
AuthenticationProvider
[ERROR]
/root/Guacamole/guacamole-client/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLAuthenticationProvider.java:[30,7]
error: MySQLAuthenticationProvider is not abstract and does not override
abstract method
redecorate(UserContext,UserContext,AuthenticatedUser,Credentials) in
AuthenticationProvider


Though it created the war file which I required.
I tested with the latest code and the issue still persists.

Is there any changes in guacamole-server also related to the above fix ?

Regards,
Amarjeet Singh



On Mon, Mar 5, 2018 at 7:42 PM, Amarjeet Singh  wrote:

> Ok Nick, I will look into it.
>
> On Mon, Mar 5, 2018 at 7:41 PM, Amarjeet Singh 
> wrote:
>
>> I also tried to change the following code in *guacamole.js* and changed*
>> index.html* file to load guacamole.js file instead app.js?varsion :-
>>
>> Browser is loading the guacamole.js and the below change as well which I
>> verified through debugger as well.
>>
>> var no_repeat = {
>> 0xFE03: true, // ISO Level 3 Shift (AltGr)
>> 0xFFE1: true, // Left shift
>> 0xFFE2: true, // Right shift
>> 0xFFE3: true, // Left ctrl
>> 0xFFE4: true, // Right ctrl
>> 0xFFE5: true, // Caps Lock
>> 0xFFE7: true, // Left meta
>> 0xFFE8: true, // Right meta
>> 0xFFE9: true, // Left alt
>> 0xFFEA: true, // Right alt
>> 0xFFEB: true, // Left hyper
>> 0xFFEC: true  // Right hyper
>> };
>>
>>   if (!no_repeat[keysym])
>>> key_repeat_timeout = window.setTimeout(function() {
>>> key_repeat_interval =
>>> window.setInterval(function() {
>>> guac_keyboard.onkeyup(keysym);
>>> guac_keyboard.onkeydown(keysym);
>>> }, 50);
>>> }, 500);
>>
>>
>> *My Analyzations are as follows :-*
>>
>> if* no_repeat* is true ( as  0xFFE5  : true )  in the case of above it
>> never enters into the loop.
>>
>> and  if I remove the above change , *no_repeat* will return false and
>>  it will continuosly sends the CapsLock which is a BUG and it is fixed in
>> 1.0.0
>>
>> GUACAMOLE-161: Merge changes adding Caps Lock to the do-not-auto-repeat
>>> list.
>>
>>
>>
>> Both the changes doesn't affect and fix the issue of *changing text from
>> lowercase to uppercase*.
>>
>> On Mon, Mar 5, 2018 at 7:19 PM, Amarjeet Singh 
>> wrote:
>>
>>> Hi Team,
>>>
>>>
>>> I have been writing in Libre Office Writer on Guacamole RDP . I clicked
>>> CAPS lock and started writing but the text was still in lowercase.
>>>
>>> Guacamole-Server version : 0.9.14
>>> Guacamole-Client version : 0.9.14
>>> XRDP Version : 0.9.5
>>> Remote O.S. : Ubuntu 16.04.3 LTS 64-bit
>>>
>>> I have not done any modifications in the code.
>>>
>>>
>>> If I reconnect the RDP session with CAPS lock on, then it starts
>>> printing uppercase but if I again click CAPS lock to set it to lowercase,
>>> it still prints the uppercase.
>>>
>>>
>>>
>>> Regards,
>>> Amarjeet Singh
>>>
>>>
>>>
>>
>

Re: CAPS lock is not working in XRDP version 0.9.5 with Ubuntu 16.0.4 [ Guacamole RDP ]

2018-03-05 Thread Amarjeet Singh 
Ok Nick, I will look into it.

On Mon, Mar 5, 2018 at 7:41 PM, Amarjeet Singh  wrote:

> I also tried to change the following code in *guacamole.js* and changed*
> index.html* file to load guacamole.js file instead app.js?varsion :-
>
> Browser is loading the guacamole.js and the below change as well which I
> verified through debugger as well.
>
> var no_repeat = {
> 0xFE03: true, // ISO Level 3 Shift (AltGr)
> 0xFFE1: true, // Left shift
> 0xFFE2: true, // Right shift
> 0xFFE3: true, // Left ctrl
> 0xFFE4: true, // Right ctrl
> 0xFFE5: true, // Caps Lock
> 0xFFE7: true, // Left meta
> 0xFFE8: true, // Right meta
> 0xFFE9: true, // Left alt
> 0xFFEA: true, // Right alt
> 0xFFEB: true, // Left hyper
> 0xFFEC: true  // Right hyper
> };
>
>   if (!no_repeat[keysym])
>> key_repeat_timeout = window.setTimeout(function() {
>> key_repeat_interval =
>> window.setInterval(function() {
>> guac_keyboard.onkeyup(keysym);
>> guac_keyboard.onkeydown(keysym);
>> }, 50);
>> }, 500);
>
>
> *My Analyzations are as follows :-*
>
> if* no_repeat* is true ( as  0xFFE5  : true )  in the case of above it
> never enters into the loop.
>
> and  if I remove the above change , *no_repeat* will return false and
>  it will continuosly sends the CapsLock which is a BUG and it is fixed in
> 1.0.0
>
> GUACAMOLE-161: Merge changes adding Caps Lock to the do-not-auto-repeat
>> list.
>
>
>
> Both the changes doesn't affect and fix the issue of *changing text from
> lowercase to uppercase*.
>
> On Mon, Mar 5, 2018 at 7:19 PM, Amarjeet Singh 
> wrote:
>
>> Hi Team,
>>
>>
>> I have been writing in Libre Office Writer on Guacamole RDP . I clicked
>> CAPS lock and started writing but the text was still in lowercase.
>>
>> Guacamole-Server version : 0.9.14
>> Guacamole-Client version : 0.9.14
>> XRDP Version : 0.9.5
>> Remote O.S. : Ubuntu 16.04.3 LTS 64-bit
>>
>> I have not done any modifications in the code.
>>
>>
>> If I reconnect the RDP session with CAPS lock on, then it starts printing
>> uppercase but if I again click CAPS lock to set it to lowercase, it still
>> prints the uppercase.
>>
>>
>>
>> Regards,
>> Amarjeet Singh
>>
>>
>>
>

Re: CAPS lock is not working in XRDP version 0.9.5 with Ubuntu 16.0.4 [ Guacamole RDP ]

2018-03-05 Thread Nick Couchman 
On Mon, Mar 5, 2018 at 8:49 AM, Amarjeet Singh  wrote:

> Hi Team,
>
>
> I have been writing in Libre Office Writer on Guacamole RDP . I clicked
> CAPS lock and started writing but the text was still in lowercase.
>
> Guacamole-Server version : 0.9.14
> Guacamole-Client version : 0.9.14
> XRDP Version : 0.9.5
> Remote O.S. : Ubuntu 16.04.3 LTS 64-bit
>
> I have not done any modifications in the code.
>
>
> If I reconnect the RDP session with CAPS lock on, then it starts printing
> uppercase but if I again click CAPS lock to set it to lowercase, it still
> prints the uppercase.
>
>
This may be related to a couple of recently-fixed issues:

https://issues.apache.org/jira/browse/GUACAMOLE-232
https://issues.apache.org/jira/browse/GUACAMOLE-161

The changes for -232 were committed back in mid-January, and the ones for
-161 were finished up this weekend:
https://github.com/apache/guacamole-client/pull/227
https://github.com/apache/guacamole-client/pull/229
https://github.com/apache/guacamole-client/pull/209


None of those changes are present in version 0.9.14, so you'd have to build
from the master branch of the git repo to try it out.

-Nick

CAPS lock is not working in XRDP version 0.9.5 with Ubuntu 16.0.4 [ Guacamole RDP ]

2018-03-05 Thread Amarjeet Singh 
Hi Team,


I have been writing in Libre Office Writer on Guacamole RDP . I clicked
CAPS lock and started writing but the text was still in lowercase.

Guacamole-Server version : 0.9.14
Guacamole-Client version : 0.9.14
XRDP Version : 0.9.5
Remote O.S. : Ubuntu 16.04.3 LTS 64-bit

I have not done any modifications in the code.


If I reconnect the RDP session with CAPS lock on, then it starts printing
uppercase but if I again click CAPS lock to set it to lowercase, it still
prints the uppercase.



Regards,
Amarjeet Singh