Re: 2.8.1 - Loading Plugin Provider - Conflicting documentation
Veena, thanks for the ticket! We’ll take care of it. On Thursday, August 13, 2020, VeenaMithare wrote: > HI , > > Raised a Documentation Improvement jira : > IGNITE-13356 > Documentation Change needed: PluginProvider loading changed from 2.8.1 > regards, > Veena. > > > > -- > Sent from: http://apache-ignite-users.70518.x6.nabble.com/ > -- - Denis
Re: 2.8.1 - Loading Plugin Provider - Conflicting documentation
HI , Raised a Documentation Improvement jira : IGNITE-13356 Documentation Change needed: PluginProvider loading changed from 2.8.1 regards, Veena. -- Sent from: http://apache-ignite-users.70518.x6.nabble.com/
Re: 2.8.1 - Loading Plugin Provider - Conflicting documentation
Hello! You may suggest edits to the documentation pages. Regards, -- Ilya Kasnacheev вт, 11 авг. 2020 г. в 14:58, VeenaMithare : > Hi Ilya, > > I have used the new style. > > It will also mean that this document is no longer the best way to load the > plugin provider: > https://apacheignite.readme.io/docs/plugins > > And this might need a documentation update. > > regards, > Veena. > > > > > > -- > Sent from: http://apache-ignite-users.70518.x6.nabble.com/ >
Re: 2.8.1 - Loading Plugin Provider - Conflicting documentation
Hi Ilya, I have used the new style. It will also mean that this document is no longer the best way to load the plugin provider: https://apacheignite.readme.io/docs/plugins And this might need a documentation update. regards, Veena. -- Sent from: http://apache-ignite-users.70518.x6.nabble.com/
Re: 2.8.1 - Loading Plugin Provider - Conflicting documentation
Hello! I guess you may use the deprecated method or you can pass it directly to your PluginProvider (new style). Regards, -- Ilya Kasnacheev сб, 8 авг. 2020 г. в 17:05, VeenaMithare : > Okay. If I set pluginconfiguration using setPluginConfiguration, how do I > get > it in the plugins ? > > getPluginConfigurations is deprecated in 2.8.1. > > > > > > -- > Sent from: http://apache-ignite-users.70518.x6.nabble.com/ >
Re: 2.8.1 - Loading Plugin Provider - Conflicting documentation
Okay. If I set pluginconfiguration using setPluginConfiguration, how do I get it in the plugins ? getPluginConfigurations is deprecated in 2.8.1. -- Sent from: http://apache-ignite-users.70518.x6.nabble.com/
Re: 2.8.1 - Loading Plugin Provider - Conflicting documentation
Hello! You do this with IgniteConfiguration.setPluginConfiguration(). Regards, -- Ilya Kasnacheev вт, 28 июл. 2020 г. в 13:04, VeenaMithare : > Okay. > > >> The recommended way is to use the service provider as detailed here: > > How do we pass configuration for the provider in this approach. > > regards, > Veena. > > > > -- > Sent from: http://apache-ignite-users.70518.x6.nabble.com/ >
Re: 2.8.1 - Loading Plugin Provider - Conflicting documentation
Okay. >> The recommended way is to use the service provider as detailed here: How do we pass configuration for the provider in this approach. regards, Veena. -- Sent from: http://apache-ignite-users.70518.x6.nabble.com/
Re: 2.8.1 - Loading Plugin Provider - Conflicting documentation
Veena, The recommended way is to use the service provider as detailed here: https://apacheignite.readme.io/docs/plugins Service Provider does not use IgniteConfiguration.getPluginConfiguration inside of itself. Here is a link of the function that does the loading: https://github.com/apache/ignite/blob/45e525865c6c93b999ab5030d7568add0bde96a2/modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java#L1021 Thanks, Alex -- Sent from: http://apache-ignite-users.70518.x6.nabble.com/
Re: 2.8.1 - Loading Plugin Provider - Conflicting documentation
Thanks Alex, There seems to be two conflicting documentation on loading the plugin provider : 1. The first way as shown in this documentation https://apacheignite.readme.io/docs/plugins : uses the Java Service Loader to load the plugin provider . It loads the plugin configurations through the ignite configuration and hence needs to use getPluginConfigurations to get the right configuration for the plugin. /*Concern*/ : igniteconfiguration.getPluginConfigurations is deprecated in 2.8.1 2. The second way : igniteconfiguration.getPluginConfigurations has been deprecated in 2.8.1 . The recommended way of sending configuration is by calling igniteconfiguration.setPluginProvider . Please note there was no 'setPluginProvider' method in the versions prior to 2.8.1. ( https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/configuration/IgniteConfiguration.html#getPluginConfigurations-- ) /*Concern*/ : 2.8.1 plugin documentation talks about using service loader framework. https://apacheignite.readme.io/docs/plugins. If we use setPluginProvider, there is no need to load plugin provider through java service loader. Kindly let me know if this is a documentation bug, or a miss in my understanding, regards, Veena. -- Sent from: http://apache-ignite-users.70518.x6.nabble.com/