Re: CTRL+Z as undo
Hello Andrey, Regarding this undo, maybe this feature could be included in a new Menu Option called: - Revert to last Tree state or a better name indicating that feature concerns the Tree of elements and not real undo (CTRL+Z) Regards Philippe M. UBIK-INGENIERIE on TWITTER https://twitter.com/ubikingenierie UBIK LOAD PACK BLOG http://www.ubik-ingenierie.com/blog/ On Fri, Jan 4, 2013 at 2:03 PM, Philippe Mouawad philippe.moua...@gmail.com wrote: Hello Andrey, I am not the only decider regarding its integration, but in my opinion current patch still needs more work so it seems to me it would be premature to include it in 2.9 as is: - Undo is only enabled on Tree elements, so regarding ergonomics it will be strange for users (I tried to use it for a while to do some tests and I must say I reverted it) that CTRL+Z does not work in fields, inputs , select boxes ... - As I already said, it also consumes much memory and CPU as the whole tree is saved each time a new element is added. - Regarding Marketing presentation of this feature, it seems weird to me to say undo is now supported in 2.9 while in fact it is only very partial. In my opinion introducing it as is could kind of hurt quality perception of JMeter which is important for us I think and for Apache organisation. - Undo needs more work to meet minimum level of acceptance and UndoManager of Swing should be used I think. Maybe current patch could be reworked to use it But again, many thanks for this contribution which is a good basis , but it is true it would need some time to be fully implemented. Regards Philippe On Fri, Jan 4, 2013 at 11:24 AM, apc a...@apc.kg wrote: Philippe, is there a chance to have this patch applied in 2.9? https://issues.apache.org/bugzilla/show_bug.cgi?id=42248 I suppose even short history length will make users happy. Also there can be an option in jmeter.properties to change history length... - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5715712.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org -- Cordialement. Philippe Mouawad. -- Cordialement. Philippe Mouawad. Ubik-Ingénierie UBIK-INGENIERIE on TWITTER https://twitter.com/ubikingenierie UBIK LOAD PACK BLOG http://www.ubik-ingenierie.com/blog/
Re: CTRL+Z as undo
Is there any chances to have this Undo feature in the upcoming 2.8 release? - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5714709.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org
Re: CTRL+Z as undo
Looking forward to see the CTRL+Z feature in Jmeter 2.6.1. Good luck! Shay -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5545780.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org
Re: CTRL+Z as undo
Hello Félix, CAN you explain what you mean by followup patch ? Thanks Regards Philippe On Monday, January 30, 2012, Felix Frank f...@mpexnet.de wrote: Hi, On 01/28/2012 06:48 PM, Philippe Mouawad wrote: Users are welcome to indicate if this is a big drawback. just a minor remark on patch management: Except for Javadocs, shouldn't those changes be a followup patch in its own right? Regards, Felix - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org -- Cordialement. Philippe Mouawad.
Re: CTRL+Z as undo
Hello Andrey, I made some changes to your patch that I reuploaded on BugZilla issue, feel free to check it, modify it Changes are the following: - Added a limit on the history (25 it should be configurable), to avoid OutOfMemoryError when Test Plan is big - Added Pause/Resume methods that are used during loading , closing and merging of Tree, cause if we don't add it (at least for close and loading): 1) It does not seem useful to be able to undo elements that were added during load phase 2) Performance are really bad , a big test plan (6 Mo) takes more than 30 seconds to load - There is one drawback to previous change, it's that we won't be able to undo merged part (right clickmerge) - Added javadocs - patch to r1231672 Users are welcome to indicate if this is a big drawback. Regards Philippe http://www.ubik-ingenierie.com On Fri, Jan 27, 2012 at 12:06 PM, Philippe Mouawad philippe.moua...@gmail.com wrote: Thank you Andrey, We will try to integrate it as soon as possible. Regards Philippe On Fri, Jan 27, 2012 at 11:29 AM, Shay Ginsbourg sginsbo...@gmail.comwrote: Very well done! --Original Message-- From: Oliver Lloyd To: jmeter-u...@jakarta.apache.org ReplyTo: JMeter Users List Subject: Re: CTRL+Z as undo Sent: Jan 27, 2012 12:13 Andrey, thanks for this, you're a superstar. - http://www.http503.com/ -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5434931.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org Sent from my BlackBerry® smartphone from orange -- Cordialement. Philippe Mouawad. -- Cordialement. Philippe Mouawad.
Re: CTRL+Z as undo
Andrey, thanks for this, you're a superstar. - http://www.http503.com/ -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5434931.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org
Re: CTRL+Z as undo
Very well done! --Original Message-- From: Oliver Lloyd To: jmeter-u...@jakarta.apache.org ReplyTo: JMeter Users List Subject: Re: CTRL+Z as undo Sent: Jan 27, 2012 12:13 Andrey, thanks for this, you're a superstar. - http://www.http503.com/ -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5434931.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org Sent from my BlackBerry® smartphone from orange
Re: CTRL+Z as undo
Thank you Andrey, We will try to integrate it as soon as possible. Regards Philippe On Fri, Jan 27, 2012 at 11:29 AM, Shay Ginsbourg sginsbo...@gmail.comwrote: Very well done! --Original Message-- From: Oliver Lloyd To: jmeter-u...@jakarta.apache.org ReplyTo: JMeter Users List Subject: Re: CTRL+Z as undo Sent: Jan 27, 2012 12:13 Andrey, thanks for this, you're a superstar. - http://www.http503.com/ -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5434931.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org Sent from my BlackBerry® smartphone from orange -- Cordialement. Philippe Mouawad.
Re: CTRL+Z as undo
Ok, here's modified JAR and instructions: http://code.google.com/p/jmeter-plugins/issues/detail?id=118 After successfull testing i will send patch to Bugzilla. - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5164045.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org
Re: CTRL+Z as undo
Hello Andrey, Why not submit the patch now so we can look at it and participate to tests ? Thank Regards Philippe On Sun, Jan 22, 2012 at 2:44 PM, Shay Ginsbourg sginsbo...@gmail.comwrote: Sanity test shows that the new UNDO/REDO functions are always available and never grayed-out. This situation often leads to functional bugs, but extensive QA testing is still required. Bottom line: It's great to have this feature in JMETER. Thank you for the invested efforts ! Shay On Sun, Jan 22, 2012 at 3:29 PM, apc a...@apc.kg wrote: Ok, here's modified JAR and instructions: http://code.google.com/p/jmeter-plugins/issues/detail?id=118 After successfull testing i will send patch to Bugzilla. - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5164045.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org -- *Shay Ginsbourg* Regulatory Testing Affairs Consultant Formerly QA Manager of LoadRunner at Mercury Interactive M.Sc. cum laude in Bio-Medical Engineering M.Sc. in Mechanical Engineering *Work:* 035185873 *Mobile:* 0546690915 *Email:* sginsbo...@gmail.com *http://il.linkedin.com/in/shayginsbourg* *GINSBOURG.COM* http://www.ginsbourg.com/ -- *P** **Please consider your environmental responsibility before printing this e-mail*. -- Cordialement. Philippe Mouawad.
Re: CTRL+Z as undo
I believe there's stupud bugs yet, so I ask for simple functional tests. And I still improve and test it. I'll show the code as soon as it will become a little bit stable - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5164457.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org
Re: CTRL+Z as undo
On 20 January 2012 09:01, apc a...@apc.kg wrote: sebb, could you say something to us on this topic? The community ready to participate in implementing Undo feature, but for now we fail to find a way for doing this. Maybe you can offer us some clues or any other help? If it were easy, it would have been done long ago. Sorry, but I don't have any ideas as to how it could be implemented. Any implementation needs to be done in such a way that it does not impact performance when running tests. - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5159840.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org
Re: CTRL+Z as undo
I'm sure it's a lot of work, but how about this simplification for a first stage: 1. user clicks on DELETE. 2. JMETER auto-save filename.JMB 3. JMETER adds UNDO next to DELETE operation UI 4. JMETER actually performs the DELETE operation 5. if user clicks on UNDO then JMETER opens filename.JMB On Fri, Jan 20, 2012 at 3:17 PM, sebb seb...@gmail.com wrote: On 20 January 2012 12:54, Shay Ginsbourg sginsbo...@gmail.com wrote: Total CTRL+Z implementation can be a staged project. Top priority is to allow just an UN-DELETE function for each DELETE operation. Meaning, before deleting anything, save the JMX in the background first. Sounds simple, but it's not. On Fri, Jan 20, 2012 at 1:40 PM, sebb seb...@gmail.com wrote: On 20 January 2012 09:01, apc a...@apc.kg wrote: sebb, could you say something to us on this topic? The community ready to participate in implementing Undo feature, but for now we fail to find a way for doing this. Maybe you can offer us some clues or any other help? If it were easy, it would have been done long ago. Sorry, but I don't have any ideas as to how it could be implemented. Any implementation needs to be done in such a way that it does not impact performance when running tests. - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5159840.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org -- *Shay Ginsbourg* Regulatory Testing Affairs Consultant Formerly QA Manager of LoadRunner at Mercury Interactive M.Sc. cum laude in Bio-Medical Engineering M.Sc. in Mechanical Engineering *Work:* 035185873 *Mobile:* 0546690915 *Email:* sginsbo...@gmail.com *http://il.linkedin.com/in/shayginsbourg* *GINSBOURG.COM* http://www.ginsbourg.com/ -- *P** **Please consider your environmental responsibility before printing this e-mail*. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org -- *Shay Ginsbourg* Regulatory Testing Affairs Consultant Formerly QA Manager of LoadRunner at Mercury Interactive M.Sc. cum laude in Bio-Medical Engineering M.Sc. in Mechanical Engineering *Work:* 035185873 *Mobile:* 0546690915 *Email:* sginsbo...@gmail.com *http://il.linkedin.com/in/shayginsbourg* *GINSBOURG.COM* http://www.ginsbourg.com/ -- *P** **Please consider your environmental responsibility before printing this e-mail*.
RE: CTRL+Z as undo
I think if you save the file before deleting anything, you will end up pissing more people off than you will help. I know that I don't want a file saved until I actually save it - this allows me to experiment with all sorts of things - then easily revert to the last saved version. You could save to a temporary file, and that would be better - but it would also be slow and quite costly in terms of performance. Most test cases aren't really that large (in terms of the XML data they store), you could just as easily create an in-memory version of the JMX data, and revert to it when the user hits 'undo' ... And if you're going to do that, you might as well allow multiple levels of undo - just by creating an array of 'checkpoint' objects before every delete operation. Ideally, you would just do this on a per-object basis (instead of the whole test case), and then only revert the object that changed. (But you probably already knew all of this...) -- Robin D. Wilson Sr. Director of Web Development KingsIsle Entertainment, Inc. VOICE: 512-777-1861 www.KingsIsle.com -Original Message- From: Shay Ginsbourg [mailto:sginsbo...@gmail.com] Sent: Friday, January 20, 2012 6:55 AM To: JMeter Users List Subject: Re: CTRL+Z as undo Total CTRL+Z implementation can be a staged project. Top priority is to allow just an UN-DELETE function for each DELETE operation. Meaning, before deleting anything, save the JMX in the background first. On Fri, Jan 20, 2012 at 1:40 PM, sebb seb...@gmail.com wrote: On 20 January 2012 09:01, apc a...@apc.kg wrote: sebb, could you say something to us on this topic? The community ready to participate in implementing Undo feature, but for now we fail to find a way for doing this. Maybe you can offer us some clues or any other help? If it were easy, it would have been done long ago. Sorry, but I don't have any ideas as to how it could be implemented. Any implementation needs to be done in such a way that it does not impact performance when running tests. - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5159840.ht ml Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org -- *Shay Ginsbourg* Regulatory Testing Affairs Consultant Formerly QA Manager of LoadRunner at Mercury Interactive M.Sc. cum laude in Bio-Medical Engineering M.Sc. in Mechanical Engineering *Work:* 035185873 *Mobile:* 0546690915 *Email:* sginsbo...@gmail.com *http://il.linkedin.com/in/shayginsbourg* *GINSBOURG.COM* http://www.ginsbourg.com/ -- *P** **Please consider your environmental responsibility before printing this e-mail*. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org
Re: CTRL+Z as undo
Woohoo, seems I'm 80% there! My programming skills raised since the last try. Now I need to polish and test it thoroughly... Any tester volunteers here? - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5161687.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org
Re: CTRL+Z as undo
Count me in. --Original Message-- From: apc To: jmeter-u...@jakarta.apache.org ReplyTo: JMeter Users List Subject: Re: CTRL+Z as undo Sent: Jan 20, 2012 22:53 Woohoo, seems I'm 80% there! My programming skills raised since the last try. Now I need to polish and test it thoroughly... Any tester volunteers here? - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5161687.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org For additional commands, e-mail: user-h...@jmeter.apache.org Sent from my BlackBerry® smartphone from orange
Re: CTRL+Z as undo
Hi, It is a low priority for me, but I haven't forgotten about this. If someone else wants to volunteer... no arguments from me since this one is rather tough. Thanks, Anthony 2012/1/14 Евгений Казаков yugene1...@gmail.com Hello, Anthony! You have progress in implementation? On 30 September 2011 18:55, Anthony Johnson ans...@gmail.com wrote: I will go for an implementation. Someone stop me if you are already 80% of the way there. On Fri, Sep 30, 2011 at 9:38 AM, sebb seb...@gmail.com wrote: Patches welcome. On 30 September 2011 13:34, apc a...@apc.kg wrote: a lot of code changes... I understand it, but not having an undo in JMeter is really bad experience. - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p4856915.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: jmeter-user-unsubscr...@jakarta.apache.org For additional commands, e-mail: jmeter-user-h...@jakarta.apache.org - To unsubscribe, e-mail: jmeter-user-unsubscr...@jakarta.apache.org For additional commands, e-mail: jmeter-user-h...@jakarta.apache.org - To unsubscribe, e-mail: jmeter-user-unsubscr...@jakarta.apache.org For additional commands, e-mail: jmeter-user-h...@jakarta.apache.org
Re: CTRL+Z as undo
Hello, Anthony! You have progress in implementation? On 30 September 2011 18:55, Anthony Johnson ans...@gmail.com wrote: I will go for an implementation. Someone stop me if you are already 80% of the way there. On Fri, Sep 30, 2011 at 9:38 AM, sebb seb...@gmail.com wrote: Patches welcome. On 30 September 2011 13:34, apc a...@apc.kg wrote: a lot of code changes... I understand it, but not having an undo in JMeter is really bad experience. - -- Andrey Pohilko JP@GC Maintainer -- View this message in context: http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p4856915.html Sent from the JMeter - User mailing list archive at Nabble.com. - To unsubscribe, e-mail: jmeter-user-unsubscr...@jakarta.apache.org For additional commands, e-mail: jmeter-user-h...@jakarta.apache.org - To unsubscribe, e-mail: jmeter-user-unsubscr...@jakarta.apache.org For additional commands, e-mail: jmeter-user-h...@jakarta.apache.org - To unsubscribe, e-mail: jmeter-user-unsubscr...@jakarta.apache.org For additional commands, e-mail: jmeter-user-h...@jakarta.apache.org
