RE: Set tag not working in 6.2.0
That's great news. I've opened: https://issues.apache.org/jira/browse/WW-5331
Wyatt
-Original Message-
From: Lukasz Lenart
Sent: Wednesday, August 16, 2023 6:09 AM
To: Struts Users Mailing List
Subject: Re: Set tag not working in 6.2.0
pon., 14 sie 2023 o 19:52 Tellis, Wyatt
napisał(a):
> Any luck with tracking the cause?
Yeah, I finally found the core issue, it's related to
https://urldefense.com/v3/__https://issues.apache.org/jira/browse/WW-5196__;!!LQC6Cpwp!oJarOfFVy8gW-_jG0qSP13APZ9rvZeUtjI4HJIpl1KjRCQwKyhn-1OCi3_pQFer2HmT5c189FxvOeNQ-gr1S7ukhKxc$
Basically instead of using:
public Object get(final String key) {
return request.getAttribute(key);
}
I just have to use a proper signature which is:
public Object get(final Object key) {
return request.getAttribute(key.toString());
}
Would you mind opening a ticket in our JIRA?
https://urldefense.com/v3/__https://issues.apache.org/jira/projects/WW/issues/__;!!LQC6Cpwp!oJarOfFVy8gW-_jG0qSP13APZ9rvZeUtjI4HJIpl1KjRCQwKyhn-1OCi3_pQFer2HmT5c189FxvOeNQ-gr1SYaY0UDw$
Kind regards
--
Łukasz
+ 48 606 323 122
https://urldefense.com/v3/__http://www.lenart.org.pl/__;!!LQC6Cpwp!oJarOfFVy8gW-_jG0qSP13APZ9rvZeUtjI4HJIpl1KjRCQwKyhn-1OCi3_pQFer2HmT5c189FxvOeNQ-gr1SDOVumKI$
-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org
Re: Set tag not working in 6.2.0
pon., 14 sie 2023 o 19:52 Tellis, Wyatt
napisał(a):
> Any luck with tracking the cause?
Yeah, I finally found the core issue, it's related to
https://issues.apache.org/jira/browse/WW-5196
Basically instead of using:
public Object get(final String key) {
return request.getAttribute(key);
}
I just have to use a proper signature which is:
public Object get(final Object key) {
return request.getAttribute(key.toString());
}
Would you mind opening a ticket in our JIRA?
https://issues.apache.org/jira/projects/WW/issues/
Kind regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org
RE: Set tag not working in 6.2.0
Hi,
Any luck with tracking the cause?
Wyatt
-Original Message-
From: Lukasz Lenart
Sent: Wednesday, August 2, 2023 11:00 PM
To: Struts Users Mailing List
Subject: Re: Set tag not working in 6.2.0
Interesting, what's even more interesting this works:
Set attempt #1:
Set attempt #2:
Need to dig into that
Regards
--
Łukasz
czw., 3 sie 2023 o 02:40 Tellis, Wyatt
napisał(a):
>
> After doing some more debugging it looks like the issue is triggered when
> there are multiple calls to c:set. If you have the following code:
>
> <%@ page contentType="text/html; charset=UTF-8" %>
> <%@taglib uri=" href="https://urldefense.com/v3/__http://java.sun.com/jsp/jstl/core__;!!LQC6Cpwp!vTRVq3N24f5KlWQkb1eqXAfXIPRUlvpVJS1GDEnbZUYbEkFyZVzTq_EGg-seWyi7f7TuIRXKf7F-en-mdNY0f6dcZIA$";>http://java.sun.com/jsp/jstl/core"
> prefix="c" %>
> <%@ taglib prefix="s" uri="/struts-tags" %>
>
>
>
>
>
>
>
> Set attempt #1:
>
>
> Set attempt #2:
>
>
>
>
> On 6.1.2.1 you get:
>
> Set attempt #1: success
> Set attempt #2: success
>
>
> But on 6.2.0 you only get:
>
> Set attempt #1: success
> Set attempt #2:
>
>
>
> Note: the call to returns nothing in
> 6.2.0
>
> Wyatt
>
>
> -Original Message-
> From: Lukasz Lenart
> Sent: Saturday, July 29, 2023 10:48 AM
> To: Struts Users Mailing List
> Subject: Re: Set tag not working in 6.2.0
>
> sob., 29 lip 2023 o 15:38 Tellis, Wyatt
> napisał(a):
> >
> > No, its just the standard JSTL Core set tag:
>
> Just tested the following setup and it just works with Struts 6.2.0
> and Java 8/11/17
>
>
>
> ${listType} / ${lcType}
>
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122
> https://urldefense.com/v3/__http://www.lenart.org.pl/__;!!LQC6Cpwp!oGpVcazX0XRptUnDTirR-XJ4UuG5OFpnK80nZlEJ9UMfPgTA08wlxZnIBHl6-xAnxzscWCRqDnjth8ljfHYvCTUHlvg$
>
>
> -
> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
> For additional commands, e-mail: user-h...@struts.apache.org
-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org
Re: Set tag not working in 6.2.0
Interesting, what's even more interesting this works:
Set attempt #1:
Set attempt #2:
Need to dig into that
Regards
--
Łukasz
czw., 3 sie 2023 o 02:40 Tellis, Wyatt
napisał(a):
>
> After doing some more debugging it looks like the issue is triggered when
> there are multiple calls to c:set. If you have the following code:
>
> <%@ page contentType="text/html; charset=UTF-8" %>
> <%@taglib uri="http://java.sun.com/jsp/jstl/core"; prefix="c" %>
> <%@ taglib prefix="s" uri="/struts-tags" %>
>
>
>
>
>
>
>
> Set attempt #1:
>
>
> Set attempt #2:
>
>
>
>
> On 6.1.2.1 you get:
>
> Set attempt #1: success
> Set attempt #2: success
>
>
> But on 6.2.0 you only get:
>
> Set attempt #1: success
> Set attempt #2:
>
>
>
> Note: the call to returns nothing in
> 6.2.0
>
> Wyatt
>
>
> -Original Message-
> From: Lukasz Lenart
> Sent: Saturday, July 29, 2023 10:48 AM
> To: Struts Users Mailing List
> Subject: Re: Set tag not working in 6.2.0
>
> sob., 29 lip 2023 o 15:38 Tellis, Wyatt
> napisał(a):
> >
> > No, its just the standard JSTL Core set tag:
>
> Just tested the following setup and it just works with Struts 6.2.0
> and Java 8/11/17
>
>
>
> ${listType} / ${lcType}
>
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122
> https://urldefense.com/v3/__http://www.lenart.org.pl/__;!!LQC6Cpwp!oGpVcazX0XRptUnDTirR-XJ4UuG5OFpnK80nZlEJ9UMfPgTA08wlxZnIBHl6-xAnxzscWCRqDnjth8ljfHYvCTUHlvg$
>
>
> -
> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
> For additional commands, e-mail: user-h...@struts.apache.org
-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org
RE: Set tag not working in 6.2.0
After doing some more debugging it looks like the issue is triggered when there
are multiple calls to c:set. If you have the following code:
<%@ page contentType="text/html; charset=UTF-8" %>
<%@taglib uri="http://java.sun.com/jsp/jstl/core"; prefix="c" %>
<%@ taglib prefix="s" uri="/struts-tags" %>
Set attempt #1:
Set attempt #2:
On 6.1.2.1 you get:
Set attempt #1: success
Set attempt #2: success
But on 6.2.0 you only get:
Set attempt #1: success
Set attempt #2:
Note: the call to returns nothing in
6.2.0
Wyatt
-Original Message-
From: Lukasz Lenart
Sent: Saturday, July 29, 2023 10:48 AM
To: Struts Users Mailing List
Subject: Re: Set tag not working in 6.2.0
sob., 29 lip 2023 o 15:38 Tellis, Wyatt
napisał(a):
>
> No, its just the standard JSTL Core set tag:
Just tested the following setup and it just works with Struts 6.2.0
and Java 8/11/17
${listType} / ${lcType}
Regards
--
Łukasz
+ 48 606 323 122
https://urldefense.com/v3/__http://www.lenart.org.pl/__;!!LQC6Cpwp!oGpVcazX0XRptUnDTirR-XJ4UuG5OFpnK80nZlEJ9UMfPgTA08wlxZnIBHl6-xAnxzscWCRqDnjth8ljfHYvCTUHlvg$
-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org
Re: Set tag not working in 6.2.0
sob., 29 lip 2023 o 15:38 Tellis, Wyatt
napisał(a):
>
> No, its just the standard JSTL Core set tag:
Just tested the following setup and it just works with Struts 6.2.0
and Java 8/11/17
${listType} / ${lcType}
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org
RE: Set tag not working in 6.2.0
No, its just the standard JSTL Core set tag: https://www.w3schools.in/jsp/jstl-core-set-tag Wyatt -Original Message- From: Lukasz Lenart Sent: Friday, July 28, 2023 10:26 PM To: Struts Users Mailing List Subject: Re: Set tag not working in 6.2.0 sob., 29 lip 2023 o 02:32 Tellis, Wyatt napisał(a): > > Because "#request." is about accessing Request attributes > > not parameters. > > Understood, but we're using value="requestAttributeValue" scope="request"/> to update the request > attributes Is this your custom function? Could you share its logic with me? Regards -- Łukasz + 48 606 323 122 https://urldefense.com/v3/__http://www.lenart.org.pl/__;!!LQC6Cpwp!qVrzsZNKy_Rkkb8uQRJ0bsN6C4SPoMp9qpczEPu7l-Rf5uUKQkQGnyRPgPtUYlRRwK68V-gA2dUj5EGqWZ7kg6rfU20$ - To unsubscribe, e-mail: user-unsubscr...@struts.apache.org For additional commands, e-mail: user-h...@struts.apache.org
Re: Set tag not working in 6.2.0
sob., 29 lip 2023 o 02:32 Tellis, Wyatt napisał(a): > > Because "#request." is about accessing Request attributes > > not parameters. > > Understood, but we're using value="requestAttributeValue" scope="request"/> to update the request > attributes Is this your custom function? Could you share its logic with me? Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: user-unsubscr...@struts.apache.org For additional commands, e-mail: user-h...@struts.apache.org
RE: Set tag not working in 6.2.0
> In which version this worked for you? 6.1.2.1 > Because "#request." is about accessing Request attributes not > parameters. Understood, but we're using to update the request attributes Wyatt -Original Message- From: Lukasz Lenart Sent: Thursday, July 27, 2023 11:50 AM To: Struts Users Mailing List Subject: Re: Set tag not working in 6.2.0 In which version this worked for you? Because "#request." is about accessing Request attributes not parameters. Regards -- Łukasz + 48 606 323 122 https://urldefense.com/v3/__http://www.lenart.org.pl/__;!!LQC6Cpwp!t-FkGXVUpoDhY0JT_DXx9CZiacmCdFST9eJ_lbbcgkyndMpxpeDzdLO5uaP8-5dRVC8BrGBatlIoAsre4zwTtDBVG-g$ - To unsubscribe, e-mail: user-unsubscr...@struts.apache.org For additional commands, e-mail: user-h...@struts.apache.org - To unsubscribe, e-mail: user-unsubscr...@struts.apache.org For additional commands, e-mail: user-h...@struts.apache.org
Re: Set tag not working in 6.2.0
In which version this worked for you? Because "#request." is about accessing Request attributes not parameters. Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: user-unsubscr...@struts.apache.org For additional commands, e-mail: user-h...@struts.apache.org
Re: Set tag not working in 6.2.0
czw., 20 lip 2023 o 18:28 Tellis, Wyatt napisał(a): > > It doesn't work. Also I was debugging the set tag and noticed the RequestMap > in the ValueStack that gets passed to the set tag doesn't even contain the > listType attribute. This is different behavior from the previous versions of > Struts. It looks like a problem with accessing the #request scope in the tag - please notice this is a potential security vulnerability in your app, accessing the raw request can be dangerous Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: user-unsubscr...@struts.apache.org For additional commands, e-mail: user-h...@struts.apache.org
RE: Set tag not working in 6.2.0
It doesn't work. Also I was debugging the set tag and noticed the RequestMap in the ValueStack that gets passed to the set tag doesn't even contain the listType attribute. This is different behavior from the previous versions of Struts. Wyatt -Original Message- From: Lukasz Lenart Sent: Thursday, July 20, 2023 12:11 AM To: user@struts.apache.org Subject: Re: Set tag not working in 6.2.0 śr., 19 lip 2023 o 20:59 Tellis, Wyatt napisał(a): > We noticed the following snippet of code no longer works in 6.2.0: > > <%@taglib > uri="https://urldefense.com/v3/__http://java.sun.com/jsp/jstl/core__;!!LQC6Cpwp!sAaVbQsQHFppGRFFCwgoPLCY24-S6dBiXz8itMK-5HCV9b8ZtD8B9ahJCpFfLhA5e8iGwRjxxGlHIXwLjjzcdUtNhUc$ > " prefix="c" %> > <%@taglib uri="/struts-tags" prefix="s"%> > > > Could you try to use to access this value? Regards -- Łukasz + 48 606 323 122 https://urldefense.com/v3/__http://www.lenart.org.pl/__;!!LQC6Cpwp!sAaVbQsQHFppGRFFCwgoPLCY24-S6dBiXz8itMK-5HCV9b8ZtD8B9ahJCpFfLhA5e8iGwRjxxGlHIXwLjjzcwiC53q0$ - To unsubscribe, e-mail: user-unsubscr...@struts.apache.org For additional commands, e-mail: user-h...@struts.apache.org - To unsubscribe, e-mail: user-unsubscr...@struts.apache.org For additional commands, e-mail: user-h...@struts.apache.org
Re: Set tag not working in 6.2.0
śr., 19 lip 2023 o 20:59 Tellis, Wyatt napisał(a): > We noticed the following snippet of code no longer works in 6.2.0: > > <%@taglib uri="http://java.sun.com/jsp/jstl/core"; prefix="c" %> > <%@taglib uri="/struts-tags" prefix="s"%> > > > Could you try to use to access this value? Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: user-unsubscr...@struts.apache.org For additional commands, e-mail: user-h...@struts.apache.org
Set tag not working in 6.2.0
Hi,
We noticed the following snippet of code no longer works in 6.2.0:
<%@taglib uri="http://java.sun.com/jsp/jstl/core"; prefix="c" %>
<%@taglib uri="/struts-tags" prefix="s"%>
${listType} / ${lcType}
In the previous version of Struts we would get:
TEST / test
but with 6.2.0 we get:
TEST /
It seems like the set tag is not picking up the value for the listType request
attribute. Any ideas what could be wrong?
Thanks,
Wyatt
