RE: Struts 2.5.x support above Java 8

[Paul Zepernick]

Hi Yasser,

This is great news!  I look forward to the release and testing it.  Thank you 
to you and the team for all your efforts!

Paul

-Original Message-
From: Yasser Zamani  On Behalf Of Yasser Zamani
Sent: Monday, November 19, 2018 7:25 AM
To: Struts Users Mailing List 
Subject: Re: Struts 2.5.x support above Java 8

NOTICE: This email originated from outside of the organization. Do not click 
links or open attachments unless you recognize the sender and know the content 
is safe.

Hi Paul,

I'm pleased to announce it seems we were able to add both java 9 and 11 
supports into Struts 2.5.19. Could you please wait for its release and then 
tests the bits? It currently can pass all tests with all jdks (see [1]) but 
it's so great if you will be able to test it in production also.

Regards.

[1] 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Fapache%2Fstruts%2Fbuilds%2F456910100&data=02%7C01%7CPaul.Zepernick%40healthsmart.com%7Cd492860f926b44e597da08d64e1a0e7c%7C2ce547c5e80a40628a56f25adceefb52%7C0%7C0%7C636782271161049678&sdata=mPufOXGj8wL6epUrthCIgGlMzCTNENDlzbjEL4Yb4yA%3D&reserved=0

>-Original Message-
>From: David Dillard 
>Sent: Monday, November 12, 2018 6:09 PM
>To: Struts Users Mailing List 
>Subject: RE: [EXTERNAL] Re: Struts 2.5.x support above Java 8
>
>True, however just because someone made the choice to use them (knowing
>that they would be supported for six months each) and to continue using
>them doesn’t mean Struts has to support those people.
>
>
>-Original Message-
>From: Dave Newton 
>Sent: Sunday, November 11, 2018 11:17 AM
>To: Struts Users Mailing List 
>Subject: Re: [EXTERNAL] Re: Struts 2.5.x support above Java 8
>
>Determining support is fraught, because people run on all sorts of
>JVMs, including EOLed versions :/
>
>On Sun, Nov 11, 2018 at 10:01 AM David Dillard
>
>wrote:
>
>> > We do plan support JDK 9 and JDK 11 as from Struts 2.6 (in
>> > development),
>> maybe we will be able to port those changes into 2.5.x branch but we
>> will see.
>>
>> Really no point in supporting JDK 9 or 10 as they are now EOL.  JDK
>> 11 support would be great.
>>
>>
>> -
>> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
>> For additional commands, e-mail: user-h...@struts.apache.org
>>
>
>
>--
>em: davelnew...@gmail.com
>mo: 908-380-8699
>tw: @dave_newton
><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitt
>er.com%2Fdave_newton&data=02%7C01%7CPaul.Zepernick%40healthsmart.co
>m%7Cd492860f926b44e597da08d64e1a0e7c%7C2ce547c5e80a40628a56f25adceefb52
>%7C0%7C0%7C636782271161049678&sdata=2sMjQCv78P%2F%2BYfVDJMGGwt4rD8x
>y6Q4GLErRuG6jkBc%3D&reserved=0>
>li: dave-newton
><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.l
>inkedin.com%2Fin%2Fdave-newton%2F&data=02%7C01%7CPaul.Zepernick%40h
>ealthsmart.com%7Cd492860f926b44e597da08d64e1a0e7c%7C2ce547c5e80a40628a5
>6f25adceefb52%7C0%7C0%7C636782271161049678&sdata=pMouKs9wK%2BCjyfmD
>t1tFqhUWetjhyMBKUSdrHjAeh%2FY%3D&reserved=0>
>gh: davelnewton
><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
>b.com%2Fdavelnewton&data=02%7C01%7CPaul.Zepernick%40healthsmart.com
>%7Cd492860f926b44e597da08d64e1a0e7c%7C2ce547c5e80a40628a56f25adceefb52%
>7C0%7C0%7C636782271161049678&sdata=EQ3%2FtoUV1ciJxRNFCuB%2Bpeb%2BqE
>cSP1To%2FCfMMsCyIL8%3D&reserved=0>
>so: Dave Newton
><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fstacko
>verflow.com%2Fusers%2F438992%2Fdave-newton&data=02%7C01%7CPaul.Zepe
>rnick%40healthsmart.com%7Cd492860f926b44e597da08d64e1a0e7c%7C2ce547c5e8
>0a40628a56f25adceefb52%7C0%7C0%7C636782271161049678&sdata=IZK23s22U
>qQuOVAVkhimfIifZiajoKgARulKMCbGPDI%3D&reserved=0>
>bl: Bucky Bits
><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fbuckyb
>its.blogspot.com%2F&data=02%7C01%7CPaul.Zepernick%40healthsmart.com
>%7Cd492860f926b44e597da08d64e1a0e7c%7C2ce547c5e80a40628a56f25adceefb52%
>7C0%7C0%7C636782271161049678&sdata=duzp6N%2FgrjAv5xsV%2BsG6oxEM9uzg
>7u5WJ3evk%2B9HcCY%3D&reserved=0>
>sk: davelnewton_skype
>B
>KK
>KKCB  [  X  ܚX KK[XZ[
>
> \ \ ][  X  ܚX P  ]˘\X K ܙ B  ܈Y][ۘ[  [X[  K[XZ[
>
> \ \ Z[  ]˘\X K ܙ B

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org



Disclaimer: This communication and any files transmi

Re: Struts 2.5.x support above Java 8

[Yasser Zamani]

Hi Paul,

I'm pleased to announce it seems we were able to add both java 9 and 11 
supports into Struts 2.5.19. Could you please wait for its release and then 
tests the bits? It currently can pass all tests with all jdks (see [1]) but 
it's so great if you will be able to test it in production also.

Regards.

[1] https://travis-ci.org/apache/struts/builds/456910100

>-Original Message-
>From: David Dillard 
>Sent: Monday, November 12, 2018 6:09 PM
>To: Struts Users Mailing List 
>Subject: RE: [EXTERNAL] Re: Struts 2.5.x support above Java 8
>
>True, however just because someone made the choice to use them (knowing that
>they would be supported for six months each) and to continue using them doesn’t
>mean Struts has to support those people.
>
>
>-Original Message-
>From: Dave Newton 
>Sent: Sunday, November 11, 2018 11:17 AM
>To: Struts Users Mailing List 
>Subject: Re: [EXTERNAL] Re: Struts 2.5.x support above Java 8
>
>Determining support is fraught, because people run on all sorts of JVMs, 
>including
>EOLed versions :/
>
>On Sun, Nov 11, 2018 at 10:01 AM David Dillard 
>wrote:
>
>> > We do plan support JDK 9 and JDK 11 as from Struts 2.6 (in
>> > development),
>> maybe we will be able to port those changes into 2.5.x branch but we
>> will see.
>>
>> Really no point in supporting JDK 9 or 10 as they are now EOL.  JDK 11
>> support would be great.
>>
>>
>> -
>> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
>> For additional commands, e-mail: user-h...@struts.apache.org
>>
>
>
>--
>em: davelnew...@gmail.com
>mo: 908-380-8699
>tw: @dave_newton <https://twitter.com/dave_newton>
>li: dave-newton <https://www.linkedin.com/in/dave-newton/>
>gh: davelnewton <https://github.com/davelnewton>
>so: Dave Newton <http://stackoverflow.com/users/438992/dave-newton>
>bl: Bucky Bits <http://buckybits.blogspot.com/>
>sk: davelnewton_skype
>B
>KK
>KKCB  [  X  ܚX KK[XZ[
>
> \ \ ][  X  ܚX P  ]˘\X K ܙ B  ܈Y][ۘ[  [X[  K[XZ[
>
> \ \ Z[  ]˘\X K ܙ B

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

RE: [EXTERNAL] Re: Struts 2.5.x support above Java 8

[David Dillard]

True, however just because someone made the choice to use them (knowing that 
they would be supported for six months each) and to continue using them doesn’t 
mean Struts has to support those people.


-Original Message-
From: Dave Newton  
Sent: Sunday, November 11, 2018 11:17 AM
To: Struts Users Mailing List 
Subject: Re: [EXTERNAL] Re: Struts 2.5.x support above Java 8

Determining support is fraught, because people run on all sorts of JVMs, 
including EOLed versions :/

On Sun, Nov 11, 2018 at 10:01 AM David Dillard 
wrote:

> > We do plan support JDK 9 and JDK 11 as from Struts 2.6 (in 
> > development),
> maybe we will be able to port those changes into 2.5.x branch but we 
> will see.
>
> Really no point in supporting JDK 9 or 10 as they are now EOL.  JDK 11 
> support would be great.
>
>
> -
> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
> For additional commands, e-mail: user-h...@struts.apache.org
>


--
em: davelnew...@gmail.com
mo: 908-380-8699
tw: @dave_newton <https://twitter.com/dave_newton>
li: dave-newton <https://www.linkedin.com/in/dave-newton/>
gh: davelnewton <https://github.com/davelnewton>
so: Dave Newton <http://stackoverflow.com/users/438992/dave-newton>
bl: Bucky Bits <http://buckybits.blogspot.com/>
sk: davelnewton_skype

RE: Struts 2.5.x support above Java 8

[Paul Zepernick]

I have taken another run at this with Java 11 ASM 7.0.  I verified that I am 
really running asm 7.0 via the mvn dependency:tree.  I am now getting the 
following stack trace

ERROR DefaultClassFinder Unable to read class 
[com.hs.iws.actions.prizm.PrizmTemplatesAction$1]
 java.lang.UnsupportedOperationException: This feature requires ASM7
at org.objectweb.asm.ClassVisitor.visitNestHost(ClassVisitor.java:150)
at org.objectweb.asm.ClassReader.accept(ClassReader.java:541)
at org.objectweb.asm.ClassReader.accept(ClassReader.java:391)
at 
org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFinder.java:462)

I have traced the problem to the source in 
org.apache.struts2.convention.DefaultClassFinder

public class InfoBuildingVisitor extends ClassVisitor {
private Info info;
private ClassFinder classFinder;

public InfoBuildingVisitor(ClassFinder classFinder) {
super(Opcodes.ASM5);  // This is the issue raising the Exception
this.classFinder = classFinder;
}

I have commented the line above causing the issue.  I assume this would throw 
an exception in ASM using anything above 5.


-Original Message-
From: Lukasz Lenart 
Sent: Sunday, November 11, 2018 3:07 AM
To: Struts Users Mailing List 
Subject: Re: Struts 2.5.x support above Java 8

NOTICE: This email originated from outside of the organization. Do not click 
links or open attachments unless you recognize the sender and know the content 
is safe.

sob., 10 lis 2018 o 01:39 Paul Zepernick  
napisał(a):
>
> Has anyone got Struts 2.5 to work for Java 11 or anything above Java 8?  I 
> have a project that I was trying to migrate to Java 11 using 2.5.18.  I have 
> it compiling, but then ran into an issue with the ASM library.  I am using 
> the REST plugin, which is dependent on the convention plugin.  The convention 
> plugin has the dependency to ASM, and I am getting the error mentioned in 
> this ticket:
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissue
> s.apache.org%2Fjira%2Fprojects%2FWW%2Fissues%2FWW-4866%3Ffilter%3Dallo
> penissues&data=02%7C01%7CPaul.Zepernick%40healthsmart.com%7Cc789d7
> 84442b4141887d08d647acb9f6%7C2ce547c5e80a40628a56f25adceefb52%7C0%7C0%
> 7C636775204519343782&sdata=JFRCeA9TTXRYdn8Yv6MY0ZKccg%2BgkVpuia%2F
> zY381lD0%3D&reserved=0
>
> I have tried Java 10 with ASM 6.0 mentioned in the comments and ASM 7.0 with 
> Java 11.  Both produced the same IllegalArgumentException already mentioned.  
> A quick glance at the source seemed to indicate that ASM changed the 
> constructor on the class that is being called to accept byte[] instead of 
> InputStream.

Could you post more details? As far I see the constructor that accepts 
InputStream is still available.

> My main goal in all of this was to try and ensure we would be running on a 
> supported JDK as support for 8 is about to be up.  From what I understand, no 
> one from the Java community has committed to back porting security patches 
> for 8.  Would anyone be willing to share what they are doing with Java 8 in 
> the enterprise environment if we have to stay on it for Struts applications?  
> Are you purchasing, or already have oracle support?

We do plan support JDK 9 and JDK 11 as from Struts 2.6 (in development), maybe 
we will be able to port those changes into 2.5.x branch but we will see.


Regards
--
Łukasz
+ 48 606 323 122
+ https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.le
+ nart.org.pl%2F&data=02%7C01%7CPaul.Zepernick%40healthsmart.com%7Cc
+ 789d784442b4141887d08d647acb9f6%7C2ce547c5e80a40628a56f25adceefb52%7C0
+ %7C0%7C636775204519343782&sdata=YxFK4LlfpQ6zwAPYDGWRC2jAOGeGPquGdg
+ J4VkUm4q4%3D&reserved=0

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org




Disclaimer: This communication and any files transmitted with it may contain 
information that is privileged, confidential and/or exempt from disclosure 
under applicable law. If you are not the intended recipient, you are hereby 
notified that any disclosure, copying, distribution, or use of the information 
contained herein (including any reliance thereon) is strictly prohibited. If 
you received this communication in error, please immediately contact the sender 
and destroy the material in its entirety, whether in electronic or hard copy 
format. Thank you.

Re: [EXTERNAL] Re: Struts 2.5.x support above Java 8

[Dave Newton]

Determining support is fraught, because people run on all sorts of JVMs,
including EOLed versions :/

On Sun, Nov 11, 2018 at 10:01 AM David Dillard 
wrote:

> > We do plan support JDK 9 and JDK 11 as from Struts 2.6 (in development),
> maybe we will be able to port those changes into 2.5.x branch but we will
> see.
>
> Really no point in supporting JDK 9 or 10 as they are now EOL.  JDK 11
> support would be great.
>
>
> -
> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
> For additional commands, e-mail: user-h...@struts.apache.org
>


-- 
em: davelnew...@gmail.com
mo: 908-380-8699
tw: @dave_newton 
li: dave-newton 
gh: davelnewton 
so: Dave Newton 
bl: Bucky Bits 
sk: davelnewton_skype

RE: [EXTERNAL] Re: Struts 2.5.x support above Java 8

[David Dillard]

> We do plan support JDK 9 and JDK 11 as from Struts 2.6 (in development), 
> maybe we will be able to port those changes into 2.5.x branch but we will see.

Really no point in supporting JDK 9 or 10 as they are now EOL.  JDK 11 support 
would be great.


-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

Re: Struts 2.5.x support above Java 8

[Lukasz Lenart]

sob., 10 lis 2018 o 01:39 Paul Zepernick
 napisał(a):
>
> Has anyone got Struts 2.5 to work for Java 11 or anything above Java 8?  I 
> have a project that I was trying to migrate to Java 11 using 2.5.18.  I have 
> it compiling, but then ran into an issue with the ASM library.  I am using 
> the REST plugin, which is dependent on the convention plugin.  The convention 
> plugin has the dependency to ASM, and I am getting the error mentioned in 
> this ticket:
> https://issues.apache.org/jira/projects/WW/issues/WW-4866?filter=allopenissues
>
> I have tried Java 10 with ASM 6.0 mentioned in the comments and ASM 7.0 with 
> Java 11.  Both produced the same IllegalArgumentException already mentioned.  
> A quick glance at the source seemed to indicate that ASM changed the 
> constructor on the class that is being called to accept byte[] instead of 
> InputStream.

Could you post more details? As far I see the constructor that accepts
InputStream is still available.

> My main goal in all of this was to try and ensure we would be running on a 
> supported JDK as support for 8 is about to be up.  From what I understand, no 
> one from the Java community has committed to back porting security patches 
> for 8.  Would anyone be willing to share what they are doing with Java 8 in 
> the enterprise environment if we have to stay on it for Struts applications?  
> Are you purchasing, or already have oracle support?

We do plan support JDK 9 and JDK 11 as from Struts 2.6 (in
development), maybe we will be able to port those changes into 2.5.x
branch but we will see.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

Struts 2.5.x support above Java 8

[Paul Zepernick]

Has anyone got Struts 2.5 to work for Java 11 or anything above Java 8?  I have 
a project that I was trying to migrate to Java 11 using 2.5.18.  I have it 
compiling, but then ran into an issue with the ASM library.  I am using the 
REST plugin, which is dependent on the convention plugin.  The convention 
plugin has the dependency to ASM, and I am getting the error mentioned in this 
ticket:
https://issues.apache.org/jira/projects/WW/issues/WW-4866?filter=allopenissues

I have tried Java 10 with ASM 6.0 mentioned in the comments and ASM 7.0 with 
Java 11.  Both produced the same IllegalArgumentException already mentioned.  A 
quick glance at the source seemed to indicate that ASM changed the constructor 
on the class that is being called to accept byte[] instead of InputStream.

My main goal in all of this was to try and ensure we would be running on a 
supported JDK as support for 8 is about to be up.  From what I understand, no 
one from the Java community has committed to back porting security patches for 
8.  Would anyone be willing to share what they are doing with Java 8 in the 
enterprise environment if we have to stay on it for Struts applications?  Are 
you purchasing, or already have oracle support?


Paul Zepernick



Disclaimer: This communication and any files transmitted with it may contain 
information that is privileged, confidential and/or exempt from disclosure 
under applicable law. If you are not the intended recipient, you are hereby 
notified that any disclosure, copying, distribution, or use of the information 
contained herein (including any reliance thereon) is strictly prohibited. If 
you received this communication in error, please immediately contact the sender 
and destroy the material in its entirety, whether in electronic or hard copy 
format. Thank you.