[uml-devel] Re: [PATCH 4/9] UML - Better diagnostics for broken configs
>Produce a compile-time error if both MODE_SKAS and MODE_TT are disabled. > What would happen if both were disabled? Say, if the host system does not have SKAS and I did not want any tracing/debugging stuff? Jan Engelhardt -- --- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click ___ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
[uml-devel] Re: [PATCH 4/9] UML - Better diagnostics for broken configs
>> >Produce a compile-time error if both MODE_SKAS and MODE_TT are disabled. >> >> What would happen if both were disabled? >> Say, if the host system does not have SKAS and I did not want any >> tracing/debugging stuff? > >You get a UML that can't run. TT mode isn't tracing/debugging stuff. It's >a basic mode of UML operation. Also, UML doesn't need the skas patch on >the host in order to use skas mode any more. It helps, but is not necessary. config MODE_TT bool "Tracing thread support" default y help This option controls whether tracing thread support is compiled into UML. Normally, this should be set to Y. If you intend to use only skas mode (and the host has the skas patch applied to it), then it is OK to say N here. Then I unfortunately do not quite understand what this is for. Jan Engelhardt -- --- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click ___ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Re: [uml-devel] Re: [PATCH 4/9] UML - Better diagnostics for broken configs
>> Doing both of these things (a seperate host process for each UML process, and >> calling getpid() for all system calls), is what "Tracing Thread" mode did. >> The UML kernel was one thread among several, and it was kinda slow. > >The skas vs tt distinction is the address space part of this. How we nullify >system calls is separate. That's the PTRACE_SYSCALL vs PTRACE_SYSEMU (which >is now in mainline) thing. > ... So there is no way to get UML compile on non-Linux. Jan Engelhardt -- --- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click ___ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
[uml-devel] Re: [PATCH 12/16] UML - Memory hotplug
>> +char buf[sizeof("18446744073709551615\0")];
>
>rofl. We really ought to have a #define for "this architecture's maximum
>length of an asciified int/long/s32/s64". Generally people do
>guess-and-giggle-plus-20%, or they just get it wrong.
And this one seems wrong[*] to me too (making it a rofl²).
It is two chars (or one[*]) too long.
Consider this test:
#include
#include
int main(void) {
printf("%d\n", sizeof("18446744073709551615\0"));
printf("%d\n", sizeof("18446744073709551615"));
printf("%d\n", strlen("18446744073709551615"));
}
Which will print, when executed,
22
21
20 (the "pure string" length)
[*] Depending on what the original author wanted.
Jan Engelhardt
--
