Re: HEADS DOWN: via padlock possibly broken on master
Hi all, The new padlock rng code has now been tested on both i386 and x86_64 (on a Via Nano L2200) and seems stable. Many thanks to Sascha Wildner for helping out with the testing. Cheers, Alex On 18/06/11 01:29, Alex Hornung wrote: Hi all, I just commited something that might well cause a kernel panic if you are using a via cpu with padlock and use the padlock module. I added support to make use of Via's on-chip RNG, but someone needs to test it to confirm that it works as expected; I don't have a VIA CPU for testing. Regards, Alex Hornung
Re: HEADS DOWN: via padlock possibly broken on master
On Sat, Jun 18, 2011 at 01:29:21AM +0100, Alex Hornung wrote: I added support to make use of Via's on-chip RNG, but someone needs to test it to confirm that it works as expected; I don't have a VIA CPU for testing. As someone recently bit by a similar type of issue ( rum(4) not being up-ported for new wifi stuff) this seems like a bad idea - If the code is untested and not 'core' -- why not commit it with some kind of 'options' guard or somesuch until someone is able to test, etc? /2c - Chris
Re: HEADS DOWN: via padlock possibly broken on master
Chris, simply put, because nobody will test it. Padlock is not on by default, it has to be enabled in the kernel config or the module loaded. In any case, with the most recent commit, this should work just fine, I managed to test it on my NAS which has a via nano. Cheers, Alex On 18/06/11 22:03, Chris Turner wrote: On Sat, Jun 18, 2011 at 01:29:21AM +0100, Alex Hornung wrote: I added support to make use of Via's on-chip RNG, but someone needs to test it to confirm that it works as expected; I don't have a VIA CPU for testing. As someone recently bit by a similar type of issue ( rum(4) not being up-ported for new wifi stuff) this seems like a bad idea - If the code is untested and not 'core' -- why not commit it with some kind of 'options' guard or somesuch until someone is able to test, etc? /2c - Chris
HEADS DOWN: via padlock possibly broken on master
Hi all, I just commited something that might well cause a kernel panic if you are using a via cpu with padlock and use the padlock module. I added support to make use of Via's on-chip RNG, but someone needs to test it to confirm that it works as expected; I don't have a VIA CPU for testing. Regards, Alex Hornung
