Some minor comments:
- might be better not to start groovysh, might be mentioned in
Dockerfile comments instead
- Add Dockerfile comments, at least a link to the repo containing the
dockerfiles
- Add a LICENSE file to the github repo
- Add a travis job to the github repo that verifies the Dockerfiles
- check if grapes can be run from containers
- Provide one sample image on top of those images with some hello
world application
On Sun, Dec 11, 2016 at 3:24 PM, Keegan Witt wrote:
> Sorry for the long turnaround on this. I've got some basic Dockerfiles put
> together: https://github.com/keeganwitt/groovy-docker. Please let me know
> what I can improve. One thing I might do is template out the Dockerfiles
> similar to what Ruby did to make it easier to publish images when there's a
> new Groovy version.
>
> I planned on creating both Alpine and non-Alpine images since that seems to
> be the current practice. But we need to get GROOVY-7906 resolved for the
> Alpine images to work.
>
> I'm concerned about whether it'd be legal for us to distribute the Oracle
> JDK with Groovy. I saw this article on the topic:
> http://blog.takipi.com/running-java-on-docker-youre-breaking-the-law/. I
> don't speak legalize though. I haven't seen anyone else (Jruby, etc)
> publishing Oracle JDK, and Oracle has never published Docker images that
> were not OpenJDK. The only images floating out there have been
> community-created. So for the time being, I don't plan to publish Oracle
> based images.
>
> Once we think these look good, I'll move the repo over to groovy org in
> Github and we'll get them published to Docker Hub. Maybe we could also ask
> Apache Infra to get them added to https://hub.docker.com/u/apache/, I
> haven't decided. What do you think?
>
> On Fri, Sep 9, 2016 at 11:19 PM, Corum, Michael wrote:
>>
>> Not related to Groovy as much. We’ve never been able to get OpenJDK (7 or
>> 8) to work properly with Oracle JDBC drivers on Alpine. Always have to use
>> Oracle JDK and in the research we did, we found others with the same issues.
>>
>> Michael Corum
>>
>> VP, Technical Architecture Solutions
>>
>>
>>
>> RGA Reinsurance Company
>>
>> 16600 Swingley Ridge Road
>>
>> Chesterfield, Missouri 6301701706
>>
>> T 636.736.7066
>>
>> www.rgare.com
>>
>>
>>
>>
>> From: Guillaume Laforge
>> Reply-To: "users@groovy.apache.org"
>> Date: Friday, September 9, 2016 at 10:16 PM
>> To: "users@groovy.apache.org"
>> Subject: Re: Groovy Docker images
>>
>> Out of curiosity, what's the problem with OpenJDK?
>> Is it related to Groovy or not at all?
>>
>> On Sat, Sep 10, 2016 at 5:09 AM, Corum, Michael wrote:
>>>
>>>
>>> Either one
>>> Alpine – I suspect others will want other options though
>>> Would most definitely prefer Oracle but I assume other would want OpenJDK
>>> as well. For my purposes OpenJDK just doesn’t work at all.
>>>
>>> Michael Corum
>>>
>>> VP, Technical Architecture Solutions
>>>
>>>
>>>
>>> RGA Reinsurance Company
>>>
>>> 16600 Swingley Ridge Road
>>>
>>> Chesterfield, Missouri 6301701706
>>>
>>> T 636.736.7066
>>>
>>> www.rgare.com
>>>
>>>
>>>
>>>
>>> From: Keegan Witt
>>> Reply-To: "users@groovy.apache.org"
>>> Date: Friday, September 9, 2016 at 9:48 PM
>>> To: "users@groovy.apache.org"
>>> Subject: Groovy Docker images
>>>
>>> I was thinking of putting together some Docker images for Groovy, with
>>> the idea they might be useful to base Grails, Gradle, etc images on and
>>> wondered people's opinions on a few things.
>>>
>>> Should I install Groovy manually in somewhere like /opt? Or use SDKMAN?
>>> Should I have images based on Alpine and Debian? Alpine only?
>>> I presume OpenJDK images are fine as bases? Any reason we'd need an
>>> Oracle based image too?
>>>
>>> Thoughts?
>>>
>>> -Keegan
>>
>>
>>
>>
>> --
>> Guillaume Laforge
>> Apache Groovy committer & PMC Vice-President
>> Developer Advocate @ Google Cloud Platform
>>
>> Blog: http://glaforge.appspot.com/
>> Social: @glaforge / Google+
>
>