Re: Problems with startup since 1.13.0
Thanks for raising this issue, Timothy. I'd like to get to the bottom of it, so I've raised ISIS-1525 [1] referencing this thread. In 1.13.0 I introduced a threadpool in order to perform some of the initialization in parallel. My guess is that the concurrent modification is arising from this. But I need to look at the code again to remind myself; could be something else completely. Thx Dan [1] https://issues.apache.org/jira/browse/ISIS-1525 On 18 October 2016 at 22:01, Simecsek Timothy wrote: > Hi Jeroen, > > Thanks a lot for your input, normally hot deployment works fine. My > problem occurs only sometimes and can persist even after killing and > starting tomcat again. > > By the way: > For issues with hot deployment I like VisualVM which ships with JDK and > helped me a lot to identify thread groups/execution services/... that I > started but not properly stopped on application undeploy. > > Regards Timothy > > -Ursprüngliche Nachricht- > Von: Jeroen van der Wal [mailto:jer...@stromboli.it] > Gesendet: Dienstag, 18. Oktober 2016 21:42 > An: users > Betreff: Re: Problems with startup since 1.13.0 > > Hi Timothy, > > I've had issues when hot-deploying wars and had to kill the process to so > now we have a deployment script that stops the tomcat service, waits until > the service has completely shut down, deploys and starts the service again. > > But you could argue it's a hack ;-) > > HTH > > Jeroen > > On 14 October 2016 at 16:42, Simecsek Timothy < > timothy.simec...@nttdata.com> > wrote: > > > Hey, > > > > Has anyone observed problems with running version 1.13.0? > > > > We upgraded a while ago and a bit after that we saw sometimes this > > error when redeploying our application on tomcat: > > 2016-10-14 14:29:21,690 [IsisWicketApplication http-nio-18080-exec-103 > > ERROR] Failed to initialize > > com.google.inject.ProvisionException: Unable to provision, see the > > following errors: > > > > 1) Error in custom provider, java.util.ConcurrentModificationException > > at org.apache.isis.core.runtime.runner.IsisInjectModule. > > provideIsisSessionFactory(IsisInjectModule.java:109) > > at org.apache.isis.core.runtime.runner.IsisInjectModule. > > provideIsisSessionFactory(IsisInjectModule.java:109) > > while locating org.apache.isis.core.runtime.system.session. > > IsisSessionFactory > > for field at org.apache.isis.viewer.wicket. > > viewer.IsisWicketApplication.isisSessionFactory( > > IsisWicketApplication.java:138) > > while locating domainapp.webapp.A1FulfilllmentApplication > > > > 1 error > > at com.google.inject.internal.Errors. > > throwProvisionExceptionIfErrorsExist(Errors.java:482) > > at > > com.google.inject.internal.MembersInjectorImpl.injectMembers( > > MembersInjectorImpl.java:67) > > at com.google.inject.internal.InjectorImpl.injectMembers( > > InjectorImpl.java:984) > > at org.apache.isis.viewer.wicket.viewer.IsisWicketApplication. > > init(IsisWicketApplication.java:279) > > at domainapp.webapp.A1FulfilllmentApplication.init( > > A1FulfilllmentApplication.java:73) > > at org.apache.wicket.Application.initApplication(Application. > > java:823) > > at org.apache.wicket.protocol.http.WicketFilter.init( > > WicketFilter.java:427) > > at org.apache.wicket.protocol.http.WicketFilter.init( > > WicketFilter.java:351) > > at > > org.apache.catalina.core.ApplicationFilterConfig.initFilter( > > ApplicationFilterConfig.java:279) > > at org.apache.catalina.core.ApplicationFilterConfig.getFilter( > > ApplicationFilterConfig.java:260) > > at org.apache.catalina.core.ApplicationFilterConfig. > > (ApplicationFilterConfig.java:105) > > at org.apache.catalina.core.StandardContext.filterStart( > > StandardContext.java:4561) > > at org.apache.catalina.core.StandardContext.startInternal( > > StandardContext.java:5204) > > at org.apache.catalina.util.LifecycleBase.start( > > LifecycleBase.java:152) > > at org.apache.catalina.core.ContainerBase.addChildInternal( > > ContainerBase.java:726) > > at org.apache.catalina.core.ContainerBase.addChild( > > ContainerBase.java:702) > > at org.apache.catalina.core.StandardHost.addChild( > > StandardHost.java:734) > > at org.apache.catalina.startup.HostConfig.deployWAR( > > HostConfig.java:952) > > at org.apache.catalina.startup.HostConfig.deployApps( > > HostConfig.java:473)
AW: Problems with startup since 1.13.0
Hi Jeroen, Thanks a lot for your input, normally hot deployment works fine. My problem occurs only sometimes and can persist even after killing and starting tomcat again. By the way: For issues with hot deployment I like VisualVM which ships with JDK and helped me a lot to identify thread groups/execution services/... that I started but not properly stopped on application undeploy. Regards Timothy -Ursprüngliche Nachricht- Von: Jeroen van der Wal [mailto:jer...@stromboli.it] Gesendet: Dienstag, 18. Oktober 2016 21:42 An: users Betreff: Re: Problems with startup since 1.13.0 Hi Timothy, I've had issues when hot-deploying wars and had to kill the process to so now we have a deployment script that stops the tomcat service, waits until the service has completely shut down, deploys and starts the service again. But you could argue it's a hack ;-) HTH Jeroen On 14 October 2016 at 16:42, Simecsek Timothy wrote: > Hey, > > Has anyone observed problems with running version 1.13.0? > > We upgraded a while ago and a bit after that we saw sometimes this > error when redeploying our application on tomcat: > 2016-10-14 14:29:21,690 [IsisWicketApplication http-nio-18080-exec-103 > ERROR] Failed to initialize > com.google.inject.ProvisionException: Unable to provision, see the > following errors: > > 1) Error in custom provider, java.util.ConcurrentModificationException > at org.apache.isis.core.runtime.runner.IsisInjectModule. > provideIsisSessionFactory(IsisInjectModule.java:109) > at org.apache.isis.core.runtime.runner.IsisInjectModule. > provideIsisSessionFactory(IsisInjectModule.java:109) > while locating org.apache.isis.core.runtime.system.session. > IsisSessionFactory > for field at org.apache.isis.viewer.wicket. > viewer.IsisWicketApplication.isisSessionFactory( > IsisWicketApplication.java:138) > while locating domainapp.webapp.A1FulfilllmentApplication > > 1 error > at com.google.inject.internal.Errors. > throwProvisionExceptionIfErrorsExist(Errors.java:482) > at > com.google.inject.internal.MembersInjectorImpl.injectMembers( > MembersInjectorImpl.java:67) > at com.google.inject.internal.InjectorImpl.injectMembers( > InjectorImpl.java:984) > at org.apache.isis.viewer.wicket.viewer.IsisWicketApplication. > init(IsisWicketApplication.java:279) > at domainapp.webapp.A1FulfilllmentApplication.init( > A1FulfilllmentApplication.java:73) > at org.apache.wicket.Application.initApplication(Application. > java:823) > at org.apache.wicket.protocol.http.WicketFilter.init( > WicketFilter.java:427) > at org.apache.wicket.protocol.http.WicketFilter.init( > WicketFilter.java:351) > at > org.apache.catalina.core.ApplicationFilterConfig.initFilter( > ApplicationFilterConfig.java:279) > at org.apache.catalina.core.ApplicationFilterConfig.getFilter( > ApplicationFilterConfig.java:260) > at org.apache.catalina.core.ApplicationFilterConfig. > (ApplicationFilterConfig.java:105) > at org.apache.catalina.core.StandardContext.filterStart( > StandardContext.java:4561) > at org.apache.catalina.core.StandardContext.startInternal( > StandardContext.java:5204) > at org.apache.catalina.util.LifecycleBase.start( > LifecycleBase.java:152) > at org.apache.catalina.core.ContainerBase.addChildInternal( > ContainerBase.java:726) > at org.apache.catalina.core.ContainerBase.addChild( > ContainerBase.java:702) > at org.apache.catalina.core.StandardHost.addChild( > StandardHost.java:734) > at org.apache.catalina.startup.HostConfig.deployWAR( > HostConfig.java:952) > at org.apache.catalina.startup.HostConfig.deployApps( > HostConfig.java:473) > at org.apache.catalina.startup.HostConfig.check(HostConfig. > java:1617) > at sun.reflect.GeneratedMethodAccessor3189.invoke(Unknown Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke( > DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.tomcat.util.modeler.BaseModelMBean.invoke( > BaseModelMBean.java:300) > at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke( > DefaultMBeanServerInterceptor.java:819) > at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke( > JmxMBeanServer.java:801) > at org.apache.catalina.manager.ManagerServlet.check( > ManagerServlet.java:1483) > at org.apache.catalina.manager.ManagerServlet.deploy( > ManagerServlet.java:731) > at org.apache.catalina.manager.ManagerServlet.doPut( > ManagerServlet.java:424) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:
Re: Problems with startup since 1.13.0
Hi Timothy, I've had issues when hot-deploying wars and had to kill the process to so now we have a deployment script that stops the tomcat service, waits until the service has completely shut down, deploys and starts the service again. But you could argue it's a hack ;-) HTH Jeroen On 14 October 2016 at 16:42, Simecsek Timothy wrote: > Hey, > > Has anyone observed problems with running version 1.13.0? > > We upgraded a while ago and a bit after that we saw sometimes this error > when redeploying our application on tomcat: > 2016-10-14 14:29:21,690 [IsisWicketApplication http-nio-18080-exec-103 > ERROR] Failed to initialize > com.google.inject.ProvisionException: Unable to provision, see the > following errors: > > 1) Error in custom provider, java.util.ConcurrentModificationException > at org.apache.isis.core.runtime.runner.IsisInjectModule. > provideIsisSessionFactory(IsisInjectModule.java:109) > at org.apache.isis.core.runtime.runner.IsisInjectModule. > provideIsisSessionFactory(IsisInjectModule.java:109) > while locating org.apache.isis.core.runtime.system.session. > IsisSessionFactory > for field at org.apache.isis.viewer.wicket. > viewer.IsisWicketApplication.isisSessionFactory( > IsisWicketApplication.java:138) > while locating domainapp.webapp.A1FulfilllmentApplication > > 1 error > at com.google.inject.internal.Errors. > throwProvisionExceptionIfErrorsExist(Errors.java:482) > at com.google.inject.internal.MembersInjectorImpl.injectMembers( > MembersInjectorImpl.java:67) > at com.google.inject.internal.InjectorImpl.injectMembers( > InjectorImpl.java:984) > at org.apache.isis.viewer.wicket.viewer.IsisWicketApplication. > init(IsisWicketApplication.java:279) > at domainapp.webapp.A1FulfilllmentApplication.init( > A1FulfilllmentApplication.java:73) > at org.apache.wicket.Application.initApplication(Application. > java:823) > at org.apache.wicket.protocol.http.WicketFilter.init( > WicketFilter.java:427) > at org.apache.wicket.protocol.http.WicketFilter.init( > WicketFilter.java:351) > at org.apache.catalina.core.ApplicationFilterConfig.initFilter( > ApplicationFilterConfig.java:279) > at org.apache.catalina.core.ApplicationFilterConfig.getFilter( > ApplicationFilterConfig.java:260) > at org.apache.catalina.core.ApplicationFilterConfig. > (ApplicationFilterConfig.java:105) > at org.apache.catalina.core.StandardContext.filterStart( > StandardContext.java:4561) > at org.apache.catalina.core.StandardContext.startInternal( > StandardContext.java:5204) > at org.apache.catalina.util.LifecycleBase.start( > LifecycleBase.java:152) > at org.apache.catalina.core.ContainerBase.addChildInternal( > ContainerBase.java:726) > at org.apache.catalina.core.ContainerBase.addChild( > ContainerBase.java:702) > at org.apache.catalina.core.StandardHost.addChild( > StandardHost.java:734) > at org.apache.catalina.startup.HostConfig.deployWAR( > HostConfig.java:952) > at org.apache.catalina.startup.HostConfig.deployApps( > HostConfig.java:473) > at org.apache.catalina.startup.HostConfig.check(HostConfig. > java:1617) > at sun.reflect.GeneratedMethodAccessor3189.invoke(Unknown Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke( > DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.tomcat.util.modeler.BaseModelMBean.invoke( > BaseModelMBean.java:300) > at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke( > DefaultMBeanServerInterceptor.java:819) > at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke( > JmxMBeanServer.java:801) > at org.apache.catalina.manager.ManagerServlet.check( > ManagerServlet.java:1483) > at org.apache.catalina.manager.ManagerServlet.deploy( > ManagerServlet.java:731) > at org.apache.catalina.manager.ManagerServlet.doPut( > ManagerServlet.java:424) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:651) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) > at org.apache.catalina.core.ApplicationFilterChain. > internalDoFilter(ApplicationFilterChain.java:230) > at org.apache.catalina.core.ApplicationFilterChain.doFilter( > ApplicationFilterChain.java:165) > at org.apache.tomcat.websocket.server.WsFilter.doFilter( > WsFilter.java:52) > at org.apache.catalina.core.ApplicationFilterChain. > internalDoFilter(ApplicationFilterChain.java:192) > at org.apache.catalina.core.ApplicationFilterChain.doFilter( > ApplicationFilterChain.java:165) > at org.apache.catalina.filters.SetCharacterEncodingFilter. > doFilter(SetCharacterEncodingFilter.java:108) > at org.apache.catalina.core.ApplicationFilterChain. > internalDoFilter(ApplicationFilterChain.java:192) > at org.apache.catalina.core.ApplicationFilt
Problems with startup since 1.13.0
Hey, Has anyone observed problems with running version 1.13.0? We upgraded a while ago and a bit after that we saw sometimes this error when redeploying our application on tomcat: 2016-10-14 14:29:21,690 [IsisWicketApplication http-nio-18080-exec-103 ERROR] Failed to initialize com.google.inject.ProvisionException: Unable to provision, see the following errors: 1) Error in custom provider, java.util.ConcurrentModificationException at org.apache.isis.core.runtime.runner.IsisInjectModule.provideIsisSessionFactory(IsisInjectModule.java:109) at org.apache.isis.core.runtime.runner.IsisInjectModule.provideIsisSessionFactory(IsisInjectModule.java:109) while locating org.apache.isis.core.runtime.system.session.IsisSessionFactory for field at org.apache.isis.viewer.wicket.viewer.IsisWicketApplication.isisSessionFactory(IsisWicketApplication.java:138) while locating domainapp.webapp.A1FulfilllmentApplication 1 error at com.google.inject.internal.Errors.throwProvisionExceptionIfErrorsExist(Errors.java:482) at com.google.inject.internal.MembersInjectorImpl.injectMembers(MembersInjectorImpl.java:67) at com.google.inject.internal.InjectorImpl.injectMembers(InjectorImpl.java:984) at org.apache.isis.viewer.wicket.viewer.IsisWicketApplication.init(IsisWicketApplication.java:279) at domainapp.webapp.A1FulfilllmentApplication.init(A1FulfilllmentApplication.java:73) at org.apache.wicket.Application.initApplication(Application.java:823) at org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:427) at org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:351) at org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:279) at org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:260) at org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:105) at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4561) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5204) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:152) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:726) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:702) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:734) at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:952) at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:473) at org.apache.catalina.startup.HostConfig.check(HostConfig.java:1617) at sun.reflect.GeneratedMethodAccessor3189.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.tomcat.util.modeler.BaseModelMBean.invoke(BaseModelMBean.java:300) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819) at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801) at org.apache.catalina.manager.ManagerServlet.check(ManagerServlet.java:1483) at org.apache.catalina.manager.ManagerServlet.deploy(ManagerServlet.java:731) at org.apache.catalina.manager.ManagerServlet.doPut(ManagerServlet.java:424) at javax.servlet.http.HttpServlet.service(HttpServlet.java:651) at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:230) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) at org.apache.catalina.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:108) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:108) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:632) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) at org.a
