Re: Show route GMap3

2016-02-02 Thread Jeroen van der Wal
Hi Franco,

Thank you for your contribution! It would be very helpful if you follow
this procedure:

- create an issue [1];
- fork the repo into your account [2];
- create a branch;
- apply changes;
- issue a pull request;

This allows us to review your work easily and iterate on it together if
needed. It also registers you as an Isisaddons contributor, how cool is
that! ;-)

Many thanks,

Jeroen


[1] https://github.com/isisaddons/isis-wicket-gmap3/issues/new
[2] https://github.com/isisaddons/isis-wicket-gmap3#fork-destination-box








On 2 February 2016 at 00:26, Franco Chiappano 
wrote:

>
>
>
> -- Forwarded message --
> From: Franco Chiappano 
> Date: 2015-11-20 17:55 GMT-03:00
> Subject: Show route GMap3
> To: users@isis.apache.org
>
>
> Hello,
>
>
> I'm here to ask for your help.
>
>
> The question is I want to use the GMap3 addons to show graphically a
> journey undertaken by a vehicle through GPolyline GMap, but fails to
> succeed.
>
>
> Imitating as done for you with the Location, create a new component with
> corresponding .css and .html files besides the Factory class, but I can not
> display the map in question.
>
>
> I attached, so if they have time to see, the Patch generated with the
> changes in the Addons Isis-Wicket-Gmap3 a trial and also, the .xls file
> from where it currently and provisionally I get, the route I want to show.
>
>
> From already thank you very much for your time and apologize for my very
> bad English.
>
>
> Regards.
>
>
>


Re: Show route GMap3

2015-11-23 Thread Dan Haywood
Hi Franco,

and welcome to the users mailing list!  Sorry not to have replied before
now.

Very nice too to see you've taken the time to put together a patch.

I'll try to take a look at this in the next few days.

Meantime, perhaps you could raise an issue on the isis-wicket-gmap3 issues
page?  I ask only because gmap3 isn't part of the Apache Isis framework
proper, rather we maintain them as separate non-ASF projects on github.
Perhaps you could then also attach a pull request for the change?  I
understand that what's there isn't working yet, but it's less hassle to
apply pull requests than it is to apply patches.

Thanks

Dan




On 20 November 2015 at 20:55, Franco Chiappano 
wrote:

> Hello,
>
>
> I'm here to ask for your help.
>
>
> The question is I want to use the GMap3 addons to show graphically a
> journey undertaken by a vehicle through GPolyline GMap, but fails to
> succeed.
>
>
> Imitating as done for you with the Location, create a new component with
> corresponding .css and .html files besides the Factory class, but I can not
> display the map in question.
>
>
> I attached, so if they have time to see, the Patch generated with the
> changes in the Addons Isis-Wicket-Gmap3 a trial and also, the .xls file
> from where it currently and provisionally I get, the route I want to show.
>
>
> From already thank you very much for your time and apologize for my very
> bad English.
>
>
> Regards.
>
>