Change in email id for Subscription

[Malik, Shibha (GE Renewable Energy, consultant)]

Hi,

I want to change my email id for subscription. Is this the right group to email 
to ?

Thanks,
Shibha

RE: [External] Re: Cannot run the inbuild zookeeper server.

[Yi, Gene]

Run lsof -i:2181  to check? 

-Original Message-
From: Ted Yu [mailto:yuzhih...@gmail.com] 
Sent: Sunday, July 01, 2018 7:52 PM
To: users@kafka.apache.org
Subject: [External] Re: Cannot run the inbuild zookeeper server.

'Address already in use' indicates that there was some (zookeeper) server
running on the same machine.

Can you double check ?

Thanks

On Sun, Jul 1, 2018 at 4:45 AM, Vineet Herenj  wrote:

> Hello,
>
> I am not able to run the inbuild zookeeper server.
> Following error shows:
>
> *java.net.BindException: Address already in use*
>
> Please assist for the issue.
>
> Regards,
> *Vineet Apoorv Herenj*
> M.Tech, IIT Kharagpur
> Department of Computer Science and Engineering
> Kharagpur, India
>
> m: +919679700816
> e: *vinither...@gmail.com  *
>

This email and any attachments are confidential and may also be privileged. If 
you are not the intended recipient, please delete all copies and notify the 
sender immediately. You may wish to refer to the incorporation details of 
Standard Chartered PLC, Standard Chartered Bank and their subsidiaries at 
https://www.sc.com/en/our-locations. Please refer to 
https://www.sc.com/en/privacy-policy.html for Standard Chartered Bank’s Privacy 
Policy.

Re: [kafka-clients] Re: [VOTE] 1.0.2 RC1

[Manikumar]

+1 (non-binding) Verified tests, quick start, producer/consumer perf tests.



On Sun, Jul 1, 2018 at 11:27 PM Ismael Juma  wrote:

> +1 (binding)
>
> Verified signature of source artifact, ran tests and verified quickstart
> on source artifact with Java 7, verified quickstart on binary artifact (Scala
> 2.12) with Java 8, sanity checked release notes and Maven staging
> repository.
>
> Ismael
>
> On Fri, Jun 29, 2018 at 10:02 PM Matthias J. Sax 
> wrote:
>
>> Hello Kafka users, developers and client-developers,
>>
>> This is the second candidate for release of Apache Kafka 1.0.2.
>>
>> This is a bug fix release addressing 27 tickets:
>> https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+1.0.2
>>
>> Release notes for the 1.0.2 release:
>> http://home.apache.org/~mjsax/kafka-1.0.2-rc1/RELEASE_NOTES.html
>>
>> *** Please download, test and vote by end of next week (7/6/18).
>>
>> Kafka's KEYS file containing PGP keys we use to sign the release:
>> http://kafka.apache.org/KEYS
>>
>> * Release artifacts to be voted upon (source and binary):
>> http://home.apache.org/~mjsax/kafka-1.0.2-rc1/
>>
>> * Maven artifacts to be voted upon:
>> https://repository.apache.org/content/groups/staging/
>>
>> * Javadoc:
>> http://home.apache.org/~mjsax/kafka-1.0.2-rc1/javadoc/
>>
>> * Tag to be voted upon (off 1.0 branch) is the 1.0.2 tag:
>> https://github.com/apache/kafka/releases/tag/1.0.2-rc1
>>
>> * Documentation:
>> http://kafka.apache.org/10/documentation.html
>>
>> * Protocol:
>> http://kafka.apache.org/10/protocol.html
>>
>> * Successful Jenkins builds for the 1.0 branch:
>> Unit/integration tests: https://builds.apache.org/job/kafka-1.0-jdk7/214/
>> System tests:
>> https://jenkins.confluent.io/job/system-test-kafka/job/1.0/225/
>>
>> /**
>>
>> Thanks,
>>   -Matthias
>>
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "kafka-clients" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to kafka-clients+unsubscr...@googlegroups.com.
> To post to this group, send email to kafka-clie...@googlegroups.com.
> Visit this group at https://groups.google.com/group/kafka-clients.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/kafka-clients/CAD5tkZZUnorMq4mgKnY5v6t0sAi4TNtMcQPjyYd18R_FC%3DGzzg%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

Re: [kafka-clients] Re: [VOTE] 0.11.0.3 RC0

[Manikumar]

+1 (non-binding)   Verified quick start, ran producer/consumer perf tests,

Thanks


On Sun, Jul 1, 2018 at 8:29 PM Ismael Juma  wrote:

> +1 (binding)
>
> Verified signature of source artifact, ran tests and verified quickstart
> on source artifact with Java 7, verified quickstart on binary artifact (Scala
> 2.11) with Java 7, sanity checked release notes and Maven staging
> repository.
>
> Thanks for running the release!
>
> Ismael
>
> On Fri, Jun 22, 2018 at 3:14 PM Matthias J. Sax 
> wrote:
>
>> Hello Kafka users, developers and client-developers,
>>
>> This is the first candidate for release of Apache Kafka 0.11.0.3.
>>
>> This is a bug fix release closing 27 tickets:
>> https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+0.11.0.3
>>
>> Release notes for the 0.11.0.3 release:
>> http://home.apache.org/~mjsax/kafka-0.11.0.3-rc0/RELEASE_NOTES.html
>>
>> *** Please download, test and vote by Tuesday, 6/26/18 end-of-day, so we
>> can close the vote on Wednesday.
>>
>> Kafka's KEYS file containing PGP keys we use to sign the release:
>> http://kafka.apache.org/KEYS
>>
>> * Release artifacts to be voted upon (source and binary):
>> http://home.apache.org/~mjsax/kafka-0.11.0.3-rc0/
>>
>> * Maven artifacts to be voted upon:
>> https://repository.apache.org/content/groups/staging/
>>
>> * Javadoc:
>> http://home.apache.org/~mjsax/kafka-0.11.0.3-rc0/javadoc/
>>
>> * Tag to be voted upon (off 0.11.0 branch) is the 0.11.0.3 tag:
>> https://github.com/apache/kafka/releases/tag/0.11.0.3-rc0
>>
>> * Documentation:
>> http://kafka.apache.org/0110/documentation.html
>>
>> * Protocol:
>> http://kafka.apache.org/0110/protocol.html
>>
>> * Successful Jenkins builds for the 0.11.0 branch:
>> Unit/integration tests:
>> https://builds.apache.org/job/kafka-0.11.0-jdk7/385/
>> System tests:
>> https://jenkins.confluent.io/job/system-test-kafka/job/0.11.0/217/
>>
>> /**
>>
>> Thanks,
>>   -Matthias
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "kafka-clients" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to kafka-clients+unsubscr...@googlegroups.com.
> To post to this group, send email to kafka-clie...@googlegroups.com.
> Visit this group at https://groups.google.com/group/kafka-clients.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/kafka-clients/CAD5tkZb38rnx99Ab%2BTbK8O3j%3D3xZLuqoPH2%2BdWxOGetzSpCmpQ%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

Re: [VOTE] 1.0.2 RC1

[Ismael Juma]

+1 (binding)

Verified signature of source artifact, ran tests and verified quickstart on
source artifact with Java 7, verified quickstart on binary artifact (Scala
2.12) with Java 8, sanity checked release notes and Maven staging
repository.

Ismael

On Fri, Jun 29, 2018 at 10:02 PM Matthias J. Sax 
wrote:

> Hello Kafka users, developers and client-developers,
>
> This is the second candidate for release of Apache Kafka 1.0.2.
>
> This is a bug fix release addressing 27 tickets:
> https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+1.0.2
>
> Release notes for the 1.0.2 release:
> http://home.apache.org/~mjsax/kafka-1.0.2-rc1/RELEASE_NOTES.html
>
> *** Please download, test and vote by end of next week (7/6/18).
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://kafka.apache.org/KEYS
>
> * Release artifacts to be voted upon (source and binary):
> http://home.apache.org/~mjsax/kafka-1.0.2-rc1/
>
> * Maven artifacts to be voted upon:
> https://repository.apache.org/content/groups/staging/
>
> * Javadoc:
> http://home.apache.org/~mjsax/kafka-1.0.2-rc1/javadoc/
>
> * Tag to be voted upon (off 1.0 branch) is the 1.0.2 tag:
> https://github.com/apache/kafka/releases/tag/1.0.2-rc1
>
> * Documentation:
> http://kafka.apache.org/10/documentation.html
>
> * Protocol:
> http://kafka.apache.org/10/protocol.html
>
> * Successful Jenkins builds for the 1.0 branch:
> Unit/integration tests: https://builds.apache.org/job/kafka-1.0-jdk7/214/
> System tests:
> https://jenkins.confluent.io/job/system-test-kafka/job/1.0/225/
>
> /**
>
> Thanks,
>   -Matthias
>
>
>

Re: [VOTE] 0.11.0.3 RC0

[Ismael Juma]

+1 (binding)

Verified signature of source artifact, ran tests and verified quickstart on
source artifact with Java 7, verified quickstart on binary artifact (Scala
2.11) with Java 7, sanity checked release notes and Maven staging
repository.

Thanks for running the release!

Ismael

On Fri, Jun 22, 2018 at 3:14 PM Matthias J. Sax 
wrote:

> Hello Kafka users, developers and client-developers,
>
> This is the first candidate for release of Apache Kafka 0.11.0.3.
>
> This is a bug fix release closing 27 tickets:
> https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+0.11.0.3
>
> Release notes for the 0.11.0.3 release:
> http://home.apache.org/~mjsax/kafka-0.11.0.3-rc0/RELEASE_NOTES.html
>
> *** Please download, test and vote by Tuesday, 6/26/18 end-of-day, so we
> can close the vote on Wednesday.
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://kafka.apache.org/KEYS
>
> * Release artifacts to be voted upon (source and binary):
> http://home.apache.org/~mjsax/kafka-0.11.0.3-rc0/
>
> * Maven artifacts to be voted upon:
> https://repository.apache.org/content/groups/staging/
>
> * Javadoc:
> http://home.apache.org/~mjsax/kafka-0.11.0.3-rc0/javadoc/
>
> * Tag to be voted upon (off 0.11.0 branch) is the 0.11.0.3 tag:
> https://github.com/apache/kafka/releases/tag/0.11.0.3-rc0
>
> * Documentation:
> http://kafka.apache.org/0110/documentation.html
>
> * Protocol:
> http://kafka.apache.org/0110/protocol.html
>
> * Successful Jenkins builds for the 0.11.0 branch:
> Unit/integration tests:
> https://builds.apache.org/job/kafka-0.11.0-jdk7/385/
> System tests:
> https://jenkins.confluent.io/job/system-test-kafka/job/0.11.0/217/
>
> /**
>
> Thanks,
>   -Matthias
>
>

Re: Cannot run the inbuild zookeeper server.

[Ted Yu]

'Address already in use' indicates that there was some (zookeeper) server
running on the same machine.

Can you double check ?

Thanks

On Sun, Jul 1, 2018 at 4:45 AM, Vineet Herenj  wrote:

> Hello,
>
> I am not able to run the inbuild zookeeper server.
> Following error shows:
>
> *java.net.BindException: Address already in use*
>
> Please assist for the issue.
>
> Regards,
> *Vineet Apoorv Herenj*
> M.Tech, IIT Kharagpur
> Department of Computer Science and Engineering
> Kharagpur, India
>
> m: +919679700816
> e: *vinither...@gmail.com  *
>

Cannot run the inbuild zookeeper server.

[Vineet Herenj]

Hello,

I am not able to run the inbuild zookeeper server.
Following error shows:

*java.net.BindException: Address already in use*

Please assist for the issue.

Regards,
*Vineet Apoorv Herenj*
M.Tech, IIT Kharagpur
Department of Computer Science and Engineering
Kharagpur, India

m: +919679700816
e: *vinither...@gmail.com  *

Re: Partitions reassignment is failing in Kafka 1.1.0

[Ted Yu]

See KAFKA-7124

Cheers

On Sun, Jul 1, 2018 at 3:26 AM, Debraj Manna 
wrote:

> Is there any bug filed for this ?
>
> On Sun, Jul 1, 2018 at 6:37 AM, Ted Yu  wrote:
>
> > Code snippet from ReassignPartitionsCommand.scala :
> >
> >   "log_dirs" -> replicas.map(r =>
> > replicaLogDirAssignment.getOrElse(new TopicPartitionReplica(tp.topic,
> > tp.partition, r), AnyLogDir)).asJava
> >
> > We know that the appearance of "any" was due to the OrElse clause.
> > Arguably there is a bug in the above code that the number of AnyLogDir
> > should match the length of the replicas list, or "log_dirs" should be
> > omitted in such case.
> >
> > On Sat, Jun 30, 2018 at 12:06 AM, Manikumar 
> > wrote:
> >
> > > It will be taken as "any" directory for each replica, which means
> replica
> > > will placed on any one of the
> > > configured directory on that broker.
> > >
> > > Since it is "log_dirs" optional, you can remove from the json.
> > >
> > > On Sat, Jun 30, 2018 at 12:02 PM Debraj Manna <
> subharaj.ma...@gmail.com>
> > > wrote:
> > >
> > > > It is problem on my side. The code was changing the replicas count
> but
> > > not
> > > > the log_dirs. Since I am migrating from 0.10 this part of the code
> was
> > > not
> > > > changed.
> > > >
> > > > I have a follow up question what is the default value of log_dirs if
> I
> > > > don't specify it in reassignment.json ?
> > > >
> > > > On Sat, Jun 30, 2018 at 11:15 AM, Debraj Manna <
> > subharaj.ma...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > I am generating the reassignent.json like below
> > > > >
> > > > > /home/ubuntu/deploy/kafka/bin/kafka-reassign-partitions.sh
> > --zookeeper
> > > > 127.0.0.1:2181 --generate --topics-to-move-json-file
> > > > /home/ubuntu/deploy/kafka/topics_to_move.json --broker-list '%s'
> |tail
> > > -1 >
> > > > /home/ubuntu/deploy/kafka/reassignment.json"
> > > > >
> > > > > Then I am doing the reassignment using the generated file
> > > > >
> > > > > /home/ubuntu/deploy/kafka/bin/kafka-reassign-partitions.sh
> > --zookeeper
> > > > 127.0.0.1:2181 --execute --reassignment-json-file
> > > > /home/ubuntu/deploy/kafka/reassignment.json
> > > > >
> > > > > kafka-reassign-partitions.sh helps states
> > > > >
> > > > > The JSON file with the partition reassignment configurationThe
> format
> > > to
> > > > >> use is -
> > > > >> {"partitions":[{"topic": "foo", "partition": 1, "replicas":
> [1,2,3],
> > > > >> "log_dirs": ["dir1","dir2","dir3"]}], "version":1} Note that
> > > "log_dirs"
> > > > is
> > > > >> optional. When it is specified, its length must equal the length
> of
> > > the
> > > > >> replicas list. The value in this list can be either "any" or the
> > > > absolution
> > > > >> path of the log directory on the broker. If absolute log directory
> > > path
> > > > is
> > > > >> specified, it is currently required that the replica has not
> already
> > > > been
> > > > >> created on that broker. The replica will then be created in the
> > > > specified
> > > > >> log directory on the broker later.
> > > > >
> > > > >
> > > > > So it appears reassignment json that is generated by
> > > > > kafka-reassign-partions.sh is creating an issue with logdirs. Is
> this
> > > > > some issue in kafka-reassign-partitions.sh or some misconfiguration
> > > from
> > > > my
> > > > > side. ?
> > > > >
> > > > > On Sat, Jun 30, 2018 at 10:26 AM, Debraj Manna <
> > > subharaj.ma...@gmail.com
> > > > >
> > > > > wrote:
> > > > >
> > > > >> Please find the server.properties from one of the broker.
> > > > >>
> > > > >> broker.id=0
> > > > >> port=9092
> > > > >> num.network.threads=3
> > > > >> num.io.threads=8
> > > > >> socket.send.buffer.bytes=102400
> > > > >> socket.receive.buffer.bytes=102400
> > > > >> socket.request.max.bytes=104857600
> > > > >> log.dirs=/var/lib/kafka/kafka-logs
> > > > >> num.recovery.threads.per.data.dir=1
> > > > >> log.retention.hours=36
> > > > >> log.retention.bytes=1073741824
> > > > >> log.segment.bytes=536870912
> > > > >> log.retention.check.interval.ms=30
> > > > >> log.cleaner.enable=false
> > > > >> zookeeper.connect=platform1:2181,platform2:2181,platform3:2181
> > > > >> message.max.bytes=1500
> > > > >> replica.fetch.max.bytes=1500
> > > > >> auto.create.topics.enable=true
> > > > >> zookeeper.connection.timeout.ms=6000
> > > > >> unclean.leader.election.enable=false
> > > > >> delete.topic.enable=false
> > > > >> offsets.topic.replication.factor=1
> > > > >> transaction.state.log.replication.factor=1
> > > > >> transaction.state.log.min.isr=1
> > > > >>
> > > > >> I have placed server.log from a broker at
> > https://gist.github.com/deb
> > > > >> raj-manna/4b4bdae8a1c15c36b313a04f37e8776d
> > > > >>
> > > > >> On Sat, Jun 30, 2018 at 8:16 AM, Ted Yu 
> > wrote:
> > > > >>
> > > > >>> Seems to be related to KIP-113.
> > > > >>>
> > > > >>> server.properties didn't go thru. Do you mind pastebin'ing its
> > > content
> > > > ?
> > > > >>>
> > > > >>> If you can pastebin logs from broker, th

Re: Partitions reassignment is failing in Kafka 1.1.0

[Debraj Manna]

Is there any bug filed for this ?

On Sun, Jul 1, 2018 at 6:37 AM, Ted Yu  wrote:

> Code snippet from ReassignPartitionsCommand.scala :
>
>   "log_dirs" -> replicas.map(r =>
> replicaLogDirAssignment.getOrElse(new TopicPartitionReplica(tp.topic,
> tp.partition, r), AnyLogDir)).asJava
>
> We know that the appearance of "any" was due to the OrElse clause.
> Arguably there is a bug in the above code that the number of AnyLogDir
> should match the length of the replicas list, or "log_dirs" should be
> omitted in such case.
>
> On Sat, Jun 30, 2018 at 12:06 AM, Manikumar 
> wrote:
>
> > It will be taken as "any" directory for each replica, which means replica
> > will placed on any one of the
> > configured directory on that broker.
> >
> > Since it is "log_dirs" optional, you can remove from the json.
> >
> > On Sat, Jun 30, 2018 at 12:02 PM Debraj Manna 
> > wrote:
> >
> > > It is problem on my side. The code was changing the replicas count but
> > not
> > > the log_dirs. Since I am migrating from 0.10 this part of the code was
> > not
> > > changed.
> > >
> > > I have a follow up question what is the default value of log_dirs if I
> > > don't specify it in reassignment.json ?
> > >
> > > On Sat, Jun 30, 2018 at 11:15 AM, Debraj Manna <
> subharaj.ma...@gmail.com
> > >
> > > wrote:
> > >
> > > > I am generating the reassignent.json like below
> > > >
> > > > /home/ubuntu/deploy/kafka/bin/kafka-reassign-partitions.sh
> --zookeeper
> > > 127.0.0.1:2181 --generate --topics-to-move-json-file
> > > /home/ubuntu/deploy/kafka/topics_to_move.json --broker-list '%s' |tail
> > -1 >
> > > /home/ubuntu/deploy/kafka/reassignment.json"
> > > >
> > > > Then I am doing the reassignment using the generated file
> > > >
> > > > /home/ubuntu/deploy/kafka/bin/kafka-reassign-partitions.sh
> --zookeeper
> > > 127.0.0.1:2181 --execute --reassignment-json-file
> > > /home/ubuntu/deploy/kafka/reassignment.json
> > > >
> > > > kafka-reassign-partitions.sh helps states
> > > >
> > > > The JSON file with the partition reassignment configurationThe format
> > to
> > > >> use is -
> > > >> {"partitions":[{"topic": "foo", "partition": 1, "replicas": [1,2,3],
> > > >> "log_dirs": ["dir1","dir2","dir3"]}], "version":1} Note that
> > "log_dirs"
> > > is
> > > >> optional. When it is specified, its length must equal the length of
> > the
> > > >> replicas list. The value in this list can be either "any" or the
> > > absolution
> > > >> path of the log directory on the broker. If absolute log directory
> > path
> > > is
> > > >> specified, it is currently required that the replica has not already
> > > been
> > > >> created on that broker. The replica will then be created in the
> > > specified
> > > >> log directory on the broker later.
> > > >
> > > >
> > > > So it appears reassignment json that is generated by
> > > > kafka-reassign-partions.sh is creating an issue with logdirs. Is this
> > > > some issue in kafka-reassign-partitions.sh or some misconfiguration
> > from
> > > my
> > > > side. ?
> > > >
> > > > On Sat, Jun 30, 2018 at 10:26 AM, Debraj Manna <
> > subharaj.ma...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > >> Please find the server.properties from one of the broker.
> > > >>
> > > >> broker.id=0
> > > >> port=9092
> > > >> num.network.threads=3
> > > >> num.io.threads=8
> > > >> socket.send.buffer.bytes=102400
> > > >> socket.receive.buffer.bytes=102400
> > > >> socket.request.max.bytes=104857600
> > > >> log.dirs=/var/lib/kafka/kafka-logs
> > > >> num.recovery.threads.per.data.dir=1
> > > >> log.retention.hours=36
> > > >> log.retention.bytes=1073741824
> > > >> log.segment.bytes=536870912
> > > >> log.retention.check.interval.ms=30
> > > >> log.cleaner.enable=false
> > > >> zookeeper.connect=platform1:2181,platform2:2181,platform3:2181
> > > >> message.max.bytes=1500
> > > >> replica.fetch.max.bytes=1500
> > > >> auto.create.topics.enable=true
> > > >> zookeeper.connection.timeout.ms=6000
> > > >> unclean.leader.election.enable=false
> > > >> delete.topic.enable=false
> > > >> offsets.topic.replication.factor=1
> > > >> transaction.state.log.replication.factor=1
> > > >> transaction.state.log.min.isr=1
> > > >>
> > > >> I have placed server.log from a broker at
> https://gist.github.com/deb
> > > >> raj-manna/4b4bdae8a1c15c36b313a04f37e8776d
> > > >>
> > > >> On Sat, Jun 30, 2018 at 8:16 AM, Ted Yu 
> wrote:
> > > >>
> > > >>> Seems to be related to KIP-113.
> > > >>>
> > > >>> server.properties didn't go thru. Do you mind pastebin'ing its
> > content
> > > ?
> > > >>>
> > > >>> If you can pastebin logs from broker, that should help.
> > > >>>
> > > >>> Thanks
> > > >>>
> > > >>> On Fri, Jun 29, 2018 at 10:37 AM, Debraj Manna <
> > > subharaj.ma...@gmail.com
> > > >>> >
> > > >>> wrote:
> > > >>>
> > > >>> > Hi
> > > >>> >
> > > >>> > I altered a topic like below in kafka 1.1.0
> > > >>> >
> > > >>> > /home/ubuntu/deploy/kafka/bin/kafka-topics.sh --zookeeper
> > > >>> 127.0.0.1:2181
> > > >>> > --alter

Specifying negative number as partition in ProducerRecord prior to 1.1.0

[Debraj Manna]

In Kafka Client 1.1.0 a check is placed to not allow negative as partition
in ProducerRecord.

https://github.com/apache/kafka/blob/1.1/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java#L73

But I don;t see any such check in ProducerRecord in kafka client 0.10.0.
Can someone let me know how does Kafka handle the negative number in
partition in ProducerRecord in 0.10? Will the partition be converted to
positive number ? If yes can some one point me to the code / logic of the
conversion?