Re: GitHub Actions yml

2021-02-13 Thread Cesar Hernandez
Hi Anthony,

I haven't configured yet actions with the specific tasks you described, but
early this week I found this reference for release:prepare release:perform:
https://github.com/wocommunity/wonder/blob/master/.github/workflows/release.yml

I also encourage you to check Actions security best practices like the
usage of persist-credentials: false.

El sáb, 13 feb 2021 a las 21:06, Anthony Whitford ()
escribió:

> I am migrating an open source project from Travis CI to GitHub Actions.
>
> This GitHub documentation provides basic CI guidance:
> https://docs.github.com/en/actions/guides/building-and-testing-java-with-maven
> <
> https://docs.github.com/en/actions/guides/building-and-testing-java-with-maven
> >
>
> However, I would ideally also like to see workflows for running Site (and
> SCM-Publish to GitHub Pages), and a workflow for running Release.
>
> Is there a good reference for a maven.yml file?
>
>

-- 
Atentamente:
César Hernández.


GitHub Actions yml

2021-02-13 Thread Anthony Whitford
I am migrating an open source project from Travis CI to GitHub Actions.

This GitHub documentation provides basic CI guidance:  
https://docs.github.com/en/actions/guides/building-and-testing-java-with-maven 


However, I would ideally also like to see workflows for running Site (and 
SCM-Publish to GitHub Pages), and a workflow for running Release.

Is there a good reference for a maven.yml file?



Re: Maven compiler plugin Unsupported major.minor version

2021-02-13 Thread Benjamin Marwell
Hi Andrea,

best thing is to comment in both Issues I created.
Preferably a code tag with the stack trace in it, so we have the
information where we need it.

Thanks!

Am Do., 11. Feb. 2021 um 12:51 Uhr schrieb Andrea Vacondio
:
>
> Hi Benjamin,
> yes, that simple repo indeed works with version 1.0.6. I also created a
> simple multi module version and it works as well.
> Unfortunately I tested on my real life repo and got:
> Caused by: org.apache.maven.plugin.PluginContainerException: A required
> class was missing while executing
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile:
> org/codehaus/plexus/languages/java/jpms/ResolvePathsResult$ModuleNameSource
>
> From what I can tell that's happening because ModuleNameSource enum has
> been moved between plexus-java version used in maven-compiler 3.8.1 and
> plexus-java 1.0.6. This error doesn't show in the test repos so I assume
> I'm going into an execution path that is not covered in that repos.
>
> Next test I checked out the latest snapshot 3.9.0 of the compiler plugin,
> installed locally and used that in my real life repo together with
> plexus-java 1.0.6 and I got a warning and a compilation error:
> [WARNING] Can't extract module name from classes: Unsupported major.minor
> version 59.65535
> Compilation failure
> [ERROR]
> /home/torakiki/repos/pdf-black/pdfblack-model/src/main/java/module-info.java:[20,22]
> error: module not found: black.pdf.i18n
>
> So I managed to set up a test multi module repo with a parent and 2
> children where child2 depends on child1 https://github.com/torakiki/test
> and I get the same result, using maven compiler 3.9.0-SNAPSHOT and
> plexus-java 1.0.6:
> [WARNING] Can't extract module name from classes: Unsupported major.minor
> version 59.0
> Compilation failure
> [ERROR]
> /home/torakiki/repos/test/testme-child2/src/main/java/module-info.java:[5,17]
> error: module not found: test.me.child
>
> From what I can see from the logs child1 module is actually missing from
> the module path. Is there anything misconfigred?
> Andrea
>
>
>
>
> Il giorno gio 11 feb 2021 alle ore 08:42 Benjamin Marwell <
> bmarw...@apache.org> ha scritto:
>
> > Hi Andrea,
> >
> > Robert was sure the new plexus dependency fixes your issue. He tried
> > it, and it worked. Same for me.
> >
> > Can you please double check you added the dependency to your *compiler
> > plugin*, not to the
> > general dependency section?
> >
> > I created a PR so you can see the changes:
> > https://github.com/torakiki/testme/pull/1
> >
> > This will probably make it into one of the next versions of the
> > compiler plugin, if you would rather want to wait.
> >
> > Best regards,
> > - Ben
> >
> > Am Mi., 10. Feb. 2021 um 14:33 Uhr schrieb Benjamin Marwell
> > :
> > >
> > > Hi Andrea,
> > >
> > > thank you very much! I can confirm that this should not happen.
> > > The error seems to be that the preparePaths method tries to parse the
> > > existing module-info.class, but does not use the Toolchain provided
> > > JDK for this.
> > >
> > > The issue for this: https://issues.apache.org/jira/browse/MCOMPILER-455
> > > cc to the dev mailing list. Issue is free to grab. Probably needs to
> > > be fixed in plexus java, therefore also created
> > > https://github.com/codehaus-plexus/plexus-languages/issues/64.
> > >
> > > Am Mi., 10. Feb. 2021 um 12:51 Uhr schrieb Andrea Vacondio
> > > :
> > > >
> > > > Ok, I created a super simple repo here
> > https://github.com/torakiki/testme
> > > >
> > > > The pom is stripped to the minimum, here are the steps I use to
> > reproduce:
> > > > - git clone https://github.com/torakiki/testme.git
> > > > - mvn compile
> > > > - mvn compile
> > > >
> > > > The first compilation works, the second doesn't unless I clean.
> > > > The error is pretty much the same:
> > > > Execution default-compile of goal
> > > > org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile failed:
> > > > Unsupported major.minor version 59.0
> > > >
> > > > Using Maven 3.6.3
> > > > My toolchain.xml:
> > > > 
> > > >   
> > > > jdk
> > > > 
> > > >   15
> > > >   openjdk
> > > > 
> > > > 
> > > >   /usr/lib/jvm/jdk-15.0.1+9
> > > > 
> > > >   
> > > > 
> > > > My .mavenrc:
> > > > export JAVA_HOME=/usr/lib/jvm/jdk-11
> > > >
> > > >
> > > > I'm on Linux but I tested on Windows 7 and got the same result.
> > > > A side note, while with this simple project the first compile works,
> > the
> > > > second doesn't, in my multi-module project with a parent module plus 8
> > > > child modules it fails on the second module with 'mvn clean compile'
> > from
> > > > the parent.
> > > >
> > > > I hope it helps.
> > > > Andrea
> > > >
> > > > Il giorno mar 9 feb 2021 alle ore 21:46 Benjamin Marwell <
> > > > bmarw...@apache.org> ha scritto:
> > > >
> > > > > Hi,
> > > > >
> > > > > do you have a public repository to share? Have you tried other JVM
> > > > > implementations? Have you tried cooling without preview features?
> > > > >