Re: [SUREFIRE] No JUnit test run when TestNG is in class path
I added a sample maven project to reproduce the issue. Compare to 2.21, 2.22 is awesomely better. This issue is just a corner case with work around -D On Fri, Jun 22, 2018 at 11:49 PM, Enrico Olivelli wrote: > In Surefire 2.22 we integrated junit5 into the core of the plugin so this > was a big refactor. > > I hope Tibor and Chris could help better in this case. > > Do you need some feature in 2.22 ? Or can you stay with 2.21 until we find > the cause? > > Your contribution will be really welcome, with a simple reproducer or a > patch. > > Enrico > > Il sab 23 giu 2018, 01:51 Dan Tran ha scritto: > > > with older surefire 2.21, I had to add junit-platform-surefire-provider > as > > sufirefire dependency, so this issue only shows up at 2.22 > > > > Thanks > > > > -D > > > > On Fri, Jun 22, 2018 at 1:49 PM, Enrico Olivelli > > wrote: > > > > > Hi Dan, > > > Did you have the same problem with an older version of surefire? > > > Enrico > > > > > > Il ven 22 giu 2018, 22:21 Dan Tran ha scritto: > > > > > > > I went ahead to file a jira issue at > > > > https://issues.apache.org/jira/browse/SUREFIRE-1527 > > > > > > > > On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran wrote: > > > > > > > > > and I am using latest surefire 2.22.0 > > > > > > > > > > -D > > > > > > > > > > On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran > wrote: > > > > > > > > > >> > > > > >> Hi > > > > >> > > > > >> I have junit4/5 and testng in the classpath and none of my junit > > tests > > > > >> got invoked > > > > >> > > > > >> I this a correct behavior? > > > > >> > > > > >> I ended up to directly add junit-platform-surefire-provider to > > > > >> surefire's dependency > > > > >> > > > > >> and I cant remove testng since we have legacy none test code uses > > > > testng > > > > >> assert > > > > >> > > > > >> Thanks > > > > >> > > > > >> -Dan > > > > >> > > > > > > > > > > > > > > > > > -- > > > > > > > > > -- Enrico Olivelli > > > > > > -- > > > -- Enrico Olivelli >
Re: [SUREFIRE] No JUnit test run when TestNG is in class path
In Surefire 2.22 we integrated junit5 into the core of the plugin so this was a big refactor. I hope Tibor and Chris could help better in this case. Do you need some feature in 2.22 ? Or can you stay with 2.21 until we find the cause? Your contribution will be really welcome, with a simple reproducer or a patch. Enrico Il sab 23 giu 2018, 01:51 Dan Tran ha scritto: > with older surefire 2.21, I had to add junit-platform-surefire-provider as > sufirefire dependency, so this issue only shows up at 2.22 > > Thanks > > -D > > On Fri, Jun 22, 2018 at 1:49 PM, Enrico Olivelli > wrote: > > > Hi Dan, > > Did you have the same problem with an older version of surefire? > > Enrico > > > > Il ven 22 giu 2018, 22:21 Dan Tran ha scritto: > > > > > I went ahead to file a jira issue at > > > https://issues.apache.org/jira/browse/SUREFIRE-1527 > > > > > > On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran wrote: > > > > > > > and I am using latest surefire 2.22.0 > > > > > > > > -D > > > > > > > > On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran wrote: > > > > > > > >> > > > >> Hi > > > >> > > > >> I have junit4/5 and testng in the classpath and none of my junit > tests > > > >> got invoked > > > >> > > > >> I this a correct behavior? > > > >> > > > >> I ended up to directly add junit-platform-surefire-provider to > > > >> surefire's dependency > > > >> > > > >> and I cant remove testng since we have legacy none test code uses > > > testng > > > >> assert > > > >> > > > >> Thanks > > > >> > > > >> -Dan > > > >> > > > > > > > > > > > > > -- > > > > > > -- Enrico Olivelli > > > -- -- Enrico Olivelli
Re: [SUREFIRE] No JUnit test run when TestNG is in class path
with older surefire 2.21, I had to add junit-platform-surefire-provider as sufirefire dependency, so this issue only shows up at 2.22 Thanks -D On Fri, Jun 22, 2018 at 1:49 PM, Enrico Olivelli wrote: > Hi Dan, > Did you have the same problem with an older version of surefire? > Enrico > > Il ven 22 giu 2018, 22:21 Dan Tran ha scritto: > > > I went ahead to file a jira issue at > > https://issues.apache.org/jira/browse/SUREFIRE-1527 > > > > On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran wrote: > > > > > and I am using latest surefire 2.22.0 > > > > > > -D > > > > > > On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran wrote: > > > > > >> > > >> Hi > > >> > > >> I have junit4/5 and testng in the classpath and none of my junit tests > > >> got invoked > > >> > > >> I this a correct behavior? > > >> > > >> I ended up to directly add junit-platform-surefire-provider to > > >> surefire's dependency > > >> > > >> and I cant remove testng since we have legacy none test code uses > > testng > > >> assert > > >> > > >> Thanks > > >> > > >> -Dan > > >> > > > > > > > > > -- > > > -- Enrico Olivelli >
Re: [SUREFIRE] No JUnit test run when TestNG is in class path
Hi Dan, Did you have the same problem with an older version of surefire? Enrico Il ven 22 giu 2018, 22:21 Dan Tran ha scritto: > I went ahead to file a jira issue at > https://issues.apache.org/jira/browse/SUREFIRE-1527 > > On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran wrote: > > > and I am using latest surefire 2.22.0 > > > > -D > > > > On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran wrote: > > > >> > >> Hi > >> > >> I have junit4/5 and testng in the classpath and none of my junit tests > >> got invoked > >> > >> I this a correct behavior? > >> > >> I ended up to directly add junit-platform-surefire-provider to > >> surefire's dependency > >> > >> and I cant remove testng since we have legacy none test code uses > testng > >> assert > >> > >> Thanks > >> > >> -Dan > >> > > > > > -- -- Enrico Olivelli
Re: [SUREFIRE] No JUnit test run when TestNG is in class path
I went ahead to file a jira issue at https://issues.apache.org/jira/browse/SUREFIRE-1527 On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran wrote: > and I am using latest surefire 2.22.0 > > -D > > On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran wrote: > >> >> Hi >> >> I have junit4/5 and testng in the classpath and none of my junit tests >> got invoked >> >> I this a correct behavior? >> >> I ended up to directly add junit-platform-surefire-provider to >> surefire's dependency >> >> and I cant remove testng since we have legacy none test code uses testng >> assert >> >> Thanks >> >> -Dan >> > >
Re: [SUREFIRE] No JUnit test run when TestNG is in class path
and I am using latest surefire 2.22.0 -D On Wed, Jun 20, 2018 at 8:39 PM, Dan Tran wrote: > > Hi > > I have junit4/5 and testng in the classpath and none of my junit tests got > invoked > > I this a correct behavior? > > I ended up to directly add junit-platform-surefire-provider to > surefire's dependency > > and I cant remove testng since we have legacy none test code uses testng > assert > > Thanks > > -Dan >
[SUREFIRE] No JUnit test run when TestNG is in class path
Hi I have junit4/5 and testng in the classpath and none of my junit tests got invoked I this a correct behavior? I ended up to directly add junit-platform-surefire-provider to surefire's dependency and I cant remove testng since we have legacy none test code uses testng assert Thanks -Dan
