Re: _TOKENSUMMARY_ not working in 3.3.0?

2010-02-02 Thread Mark Martinec 
Chris,

 Thanks Mark, yes that did fix the problem though only after I changed
 the order in which my add_header all statements were placed in my
 local.cf. For instance, with 3.2.5 I had:
 
 add_header all Status _YESNO_, score=_SCORE_ required=_REQD_
 tests=_TESTSSCORES_ _TESTS_ shortcircuit=_SCTYPE_ autolearn=_AUTOLEARN_
 version=_VERSION_
 add_header all Bayes bayes=_BAYES_,
 N=_BAYESTC_(_BAYESTCLEARNED_-_BAYESTCHAMMY_+_BAYESTCSPAMMY_),
 ham=(_HAMMYTOKENS(5,short)_), spam=(_SPAMMYTOKENS(5,short)_)
 
 at the bottom of my list of add_header statements and it worked
 correctly. After installing the patch I was still seeing:
 
 X-spam-token: Summary Bayes not run.
 
 However, as an experiment I placed the above two add_header statements
 as the very first two in my list and:
 
 X-spam-token: Summary Tokens: new, 13; hammy, 67; neutral, 36; spammy,
 1.
 
 Odd that it appears that now the add_header statements need to be in a
 certain order or at least the ones above appear to have to be first. Of
 course I could be wrong and it just worked out that way but at least
 it's working.

Hmm. I'd say thanks for trying swapping the order and catching this,
except ... I can't reproduce the problem here. It tried all combinations
of add_header and clear_header I could think of, to no avail.
I could imagine this were possible somehow if Bayes::check() were
called more than once, but I don't think it happens in reality.

Would you be so kind and repeat your experiment (still with the
patch applied), perhaps with minimalized set of add_header following
a clear_header. Does a debugging output show anything unusual about
the bayes plugin operation? Is a debug line:
  dbg: bayes: corpus size: nspam = ..., nham = ...
perhaps logged twice or none at all?

  Mark

Re: _TOKENSUMMARY_ not working in 3.3.0?

2010-02-02 Thread Chris 
On Tue, 2010-02-02 at 18:52 +0100, Mark Martinec wrote:
 Chris,
 
  Thanks Mark, yes that did fix the problem though only after I changed
  the order in which my add_header all statements were placed in my
  local.cf. For instance, with 3.2.5 I had:
  
  add_header all Status _YESNO_, score=_SCORE_ required=_REQD_
  tests=_TESTSSCORES_ _TESTS_ shortcircuit=_SCTYPE_ autolearn=_AUTOLEARN_
  version=_VERSION_
  add_header all Bayes bayes=_BAYES_,
  N=_BAYESTC_(_BAYESTCLEARNED_-_BAYESTCHAMMY_+_BAYESTCSPAMMY_),
  ham=(_HAMMYTOKENS(5,short)_), spam=(_SPAMMYTOKENS(5,short)_)
  
  at the bottom of my list of add_header statements and it worked
  correctly. After installing the patch I was still seeing:
  
  X-spam-token: Summary Bayes not run.
  
  However, as an experiment I placed the above two add_header statements
  as the very first two in my list and:
  
  X-spam-token: Summary Tokens: new, 13; hammy, 67; neutral, 36; spammy,
  1.
  
  Odd that it appears that now the add_header statements need to be in a
  certain order or at least the ones above appear to have to be first. Of
  course I could be wrong and it just worked out that way but at least
  it's working.
 
 Hmm. I'd say thanks for trying swapping the order and catching this,
 except ... I can't reproduce the problem here. It tried all combinations
 of add_header and clear_header I could think of, to no avail.
 I could imagine this were possible somehow if Bayes::check() were
 called more than once, but I don't think it happens in reality.
 
 Would you be so kind and repeat your experiment (still with the
 patch applied), perhaps with minimalized set of add_header following
 a clear_header. Does a debugging output show anything unusual about
 the bayes plugin operation? Is a debug line:
   dbg: bayes: corpus size: nspam = ..., nham = ...
 perhaps logged twice or none at all?
 
   Mark

OK, used minimal add_headers after clear_headers:

clear_headers
add_header all Status _YESNO_, score=_SCORE_ required=_REQD_
tests=_TESTSSCORES_ _TESTS_ shortcircuit=_SCTYPE_ autolearn=_AUTOLEARN_
version=_VERSION_
# add_header all Bayes bayes=_BAYES_,
N=_BAYESTC_(_BAYESTCLEARNED_-_BAYESTCHAMMY_+_BAYESTCSPAMMY_),
ham=(_HAMMYTOKENS(5,short)_), spam=(_SPAMMYTOKENS(5,short)_)
add_header all Token Summary _TOKENSUMMARY_
add_header all Spammy _SPAMMYTOKENS(2,long)_
add_header all Hammy _HAMMYTOKENS(2,long)_
add_header all Date of Scan _DATE_

This is only noted once:

dbg: bayes: DB journal sync: last sync: 1265152333
dbg: bayes: corpus size: nspam = 154517, nham = 35897
dbg: bayes: score = 0.50460268584
dbg: bayes: DB journal sync: last sync: 1265152333
dbg: bayes: untie-ing

and it works fine:

X-Spam-Token: Summary Tokens: new, 61; hammy, 23; neutral, 67; spammy,
23.

I put back the add_headers statements, re-ran:

X-Spam-Token: Summary Tokens: new, 61; hammy, 23; neutral, 67; spammy,
23.

As a final test I put the 

add_header all Bayes bayes=_BAYES_,
N=_BAYESTC_(_BAYESTCLEARNED_-_BAYESTCHAMMY_+_BAYESTCSPAMMY_),
ham=(_HAMMYTOKENS(5,short)_), spam=(_SPAMMYTOKENS(5,short)_)

back as the last entry in the list of statements and it worked fine
also. So I don't know, it's working now.



-- 
KeyID 0xE372A7DA98E6705C



signature.asc
Description: This is a digitally signed message part

Re: _TOKENSUMMARY_ not working in 3.3.0?

2010-02-01 Thread Mark Martinec 
On Saturday 30 January 2010 23:00:45 Michael Schaap wrote:
 In other words, _TOKENSUMMARY_ is consistently replaced by Bayes not
  run.. Bayes *is* running OK.  Messages are scored correctly, and the
 _HAMMYTOKENS(5)_ and _SPAMMYTOKENS(5)_ placeholders are correctly filled
  in.

Please open a bug report. The following patch should fix it:


--- lib/Mail/SpamAssassin/Plugin/Bayes.pm   (revision 905404)
+++ lib/Mail/SpamAssassin/Plugin/Bayes.pm   (working copy)
@@ -832,7 +832,8 @@
 });
 
   $permsgstatus-set_tag ('TOKENSUMMARY', sub {
-  if( defined $self-{tag_data}{BAYESTC} )
+  my $bayestc = $permsgstatus-get_tag('BAYESTC');
+  if( defined $bayestc || $bayestc ne '' )
 {
   my $tcount_neutral = 
$permsgstatus-{tag_data}{BAYESTCLEARNED}
 - $permsgstatus-{tag_data}{BAYESTCSPAMMY}



  Mark

Re: _TOKENSUMMARY_ not working in 3.3.0?

2010-02-01 Thread Mark Martinec 

Sorry, reposting: the || should have been an ,
the patch below is ok now:


On Saturday 30 January 2010 23:00:45 Michael Schaap wrote:
 In other words, _TOKENSUMMARY_ is consistently replaced by Bayes not
  run.. Bayes *is* running OK.  Messages are scored correctly, and the
 _HAMMYTOKENS(5)_ and _SPAMMYTOKENS(5)_ placeholders are correctly filled
  in.

Please open a bug report. The following patch should fix it:


--- lib/Mail/SpamAssassin/Plugin/Bayes.pm   (revision 905404)
+++ lib/Mail/SpamAssassin/Plugin/Bayes.pm   (working copy)
@@ -832,7 +832,8 @@
 });
 
   $permsgstatus-set_tag ('TOKENSUMMARY', sub {
-  if( defined $self-{tag_data}{BAYESTC} )
+  my $bayestc = $permsgstatus-get_tag('BAYESTC');
+  if( defined $bayestc  $bayestc ne '' )
 {
   my $tcount_neutral = 
$permsgstatus-{tag_data}{BAYESTCLEARNED}
 - $permsgstatus-{tag_data}{BAYESTCSPAMMY}



  Mark

Re: _TOKENSUMMARY_ not working in 3.3.0?

2010-02-01 Thread Chris 
On Mon, 2010-02-01 at 21:44 +0100, Mark Martinec wrote:
 Sorry, reposting: the || should have been an ,
 the patch below is ok now:
 
 
 On Saturday 30 January 2010 23:00:45 Michael Schaap wrote:
  In other words, _TOKENSUMMARY_ is consistently replaced by Bayes not
   run.. Bayes *is* running OK.  Messages are scored correctly, and the
  _HAMMYTOKENS(5)_ and _SPAMMYTOKENS(5)_ placeholders are correctly filled
   in.
 
 Please open a bug report. The following patch should fix it:
 
 
 --- lib/Mail/SpamAssassin/Plugin/Bayes.pm (revision 905404)
 +++ lib/Mail/SpamAssassin/Plugin/Bayes.pm (working copy)
 @@ -832,7 +832,8 @@
  });
  
$permsgstatus-set_tag ('TOKENSUMMARY', sub {
 -  if( defined $self-{tag_data}{BAYESTC} )
 +  my $bayestc = $permsgstatus-get_tag('BAYESTC');
 +  if( defined $bayestc  $bayestc ne '' )
  {
my $tcount_neutral = 
 $permsgstatus-{tag_data}{BAYESTCLEARNED}
  - 
 $permsgstatus-{tag_data}{BAYESTCSPAMMY}
 
 
 
   Mark

Thanks Mark, yes that did fix the problem though only after I changed
the order in which my add_header all statements were placed in my
local.cf. For instance, with 3.2.5 I had:

add_header all Status _YESNO_, score=_SCORE_ required=_REQD_
tests=_TESTSSCORES_ _TESTS_ shortcircuit=_SCTYPE_ autolearn=_AUTOLEARN_
version=_VERSION_
add_header all Bayes bayes=_BAYES_,
N=_BAYESTC_(_BAYESTCLEARNED_-_BAYESTCHAMMY_+_BAYESTCSPAMMY_),
ham=(_HAMMYTOKENS(5,short)_), spam=(_SPAMMYTOKENS(5,short)_)

at the bottom of my list of add_header statements and it worked
correctly. After installing the patch I was still seeing:

X-spam-token: Summary Bayes not run.

However, as an experiment I placed the above two add_header statements
as the very first two in my list and:

X-spam-token: Summary Tokens: new, 13; hammy, 67; neutral, 36; spammy,
1.

Odd that it appears that now the add_header statements need to be in a
certain order or at least the ones above appear to have to be first. Of
course I could be wrong and it just worked out that way but at least
it's working.

Thanks
Chris

-- 
KeyID 0xE372A7DA98E6705C



signature.asc
Description: This is a digitally signed message part