Re: Manager save text command bug giving path parameter

2020-04-21 Thread Mark Thomas
On 20/04/2020 20:25, Mark Thomas wrote:
> On 19/04/2020 18:34, Arnaud Yahoo wrote:
>> Hello,
>>
>> following
>> https://tomcat.apache.org/tomcat-8.5-doc/manager-howto.html#Save_Configuration
>> documentation,
>>
>> calling save with path parameter is failing giving following error:
>> *FAIL - Encountered exception [javax.management.MBeanException: Cannot
>> find operation store] *
>>
>> looking at Manager source code when path parameter is given
>> org.apache.catalina.manager.ManagerServlet.save(PrintWriter, String,
>> StringManager) is wrongly calling *store *operation with
>> *java.lang.String* argument on JMX MBean *Catalina:type=StoreConfig
>> *
>>
>> There is no such method in this MBean which is implemented in
>> *org.apache.catalina.storeconfig.StoreConfig*, the argument
>> *org.apache.catalina.Context *should be called instead (confirmed by the
>> fact that in source code the given argument is not a java.lang.String
>> but a org.apache.catalina.Context)
>>
>> I think even fixing ManagerServlet, it will probably still fail as it
>> seems there is a typo in
>> *org/apache/catalina/storeconfig/mbeans-descriptors.xml *
>> **
>>
>> /> //   description="Store Context"//
>> //   impact="ACTION" returnType="void" >//
>> //  > // description="Context"//
>> // type="org.apache.catalina.context"/>//
>> //    /
>>
>> Type is supposed to be /org.apache.catalina.*C*ontext /I guess (wrong
>> case for type)
> 
> Thanks for reporting this. All confirmed. I think there might be
> additional issues as well. I'm working on fixes.

Fixed. One final fix was required to always save a context.xml file
regardless of whether one existed beforehand.

Thanks again for reporting this.

Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Manager save text command bug giving path parameter

2020-04-20 Thread Mark Thomas
On 19/04/2020 18:34, Arnaud Yahoo wrote:
> Hello,
> 
> following
> https://tomcat.apache.org/tomcat-8.5-doc/manager-howto.html#Save_Configuration
> documentation,
> 
> calling save with path parameter is failing giving following error:
> *FAIL - Encountered exception [javax.management.MBeanException: Cannot
> find operation store] *
> 
> looking at Manager source code when path parameter is given
> org.apache.catalina.manager.ManagerServlet.save(PrintWriter, String,
> StringManager) is wrongly calling *store *operation with
> *java.lang.String* argument on JMX MBean *Catalina:type=StoreConfig
> *
> 
> There is no such method in this MBean which is implemented in
> *org.apache.catalina.storeconfig.StoreConfig*, the argument
> *org.apache.catalina.Context *should be called instead (confirmed by the
> fact that in source code the given argument is not a java.lang.String
> but a org.apache.catalina.Context)
> 
> I think even fixing ManagerServlet, it will probably still fail as it
> seems there is a typo in
> *org/apache/catalina/storeconfig/mbeans-descriptors.xml *
> **
> 
> / //   description="Store Context"//
> //   impact="ACTION" returnType="void" >//
> //   // description="Context"//
> // type="org.apache.catalina.context"/>//
> //    /
> 
> Type is supposed to be /org.apache.catalina.*C*ontext /I guess (wrong
> case for type)

Thanks for reporting this. All confirmed. I think there might be
additional issues as well. I'm working on fixes.

Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org