Re: tomcat 8.5.38 change to catalina.sh
вт, 12 февр. 2019 г. в 00:17, Charles Slivkoff : > > More details. > > CATALINA_PID is being defined before calling catalina.sh. > > The 8.5.37 version is storing a PID value, but it is not the correct PID. > Might this have been the reason for the change? > > The 8.5.38 version does not even create the file. > > I can also see this same behavior on Ubuntu 18.04.1 LTS. > The two most recent changes to catalina.sh in Tomcat 8.5 are http://svn.apache.org/viewvc?view=revision=1850830 http://svn.apache.org/viewvc?view=revision=1848048 I have several thoughts here. I think Bug 63041 is the place to discuss a solution to this issue. https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
Re: tomcat 8.5.38 change to catalina.sh
More details. CATALINA_PID is being defined before calling catalina.sh. The 8.5.37 version is storing a PID value, but it is not the correct PID. Might this have been the reason for the change? The 8.5.38 version does not even create the file. I can also see this same behavior on Ubuntu 18.04.1 LTS. From: Charles Slivkoff Sent: Monday, February 11, 2019 4:00:28 PM To: users@tomcat.apache.org Subject: Fw: tomcat 8.5.38 change to catalina.sh This change in catalina.sh is preventing the PID file from being saved. I don't see this mentioned in the changelog. https://tomcat.apache.org/tomcat-8.5-doc/changelog.html I understand the syntax in both is valid in both cases: single-& verses double-&. I'm observing this on RHEL 6 and 7. RHEL6$ /bin/sh --version GNU bash, version 4.1.2(1)-release (x86_64-redhat-linux-gnu) RHEL7$ /bin/sh --version GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu) Can anyone shed any light on why this might be happening? $ diff -u apache-tomcat-8.5.37/bin/catalina.sh apache-tomcat-8.5.38/bin/catalina.sh --- apache-tomcat-8.5.37/bin/catalina.sh2018-12-12 07:07:49.0 -0500 +++ apache-tomcat-8.5.38/bin/catalina.sh2019-02-05 06:44:05.0 -0500 @@ -476,7 +476,7 @@ -Dcatalina.home="\"$CATALINA_HOME\"" \ -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \ org.apache.catalina.startup.Bootstrap "$@" start \ - 2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&" + 2\>\&1 \&\& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&" else eval \{ $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER $JAVA_OPTS $CATALINA_OPTS \ @@ -486,7 +486,7 @@ -Dcatalina.home="\"$CATALINA_HOME\"" \ -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \ org.apache.catalina.startup.Bootstrap "$@" start \ - 2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&" + 2\>\&1 \&\& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&" fi - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
Fw: tomcat 8.5.38 change to catalina.sh
This change in catalina.sh is preventing the PID file from being saved. I don't see this mentioned in the changelog. https://tomcat.apache.org/tomcat-8.5-doc/changelog.html I understand the syntax in both is valid in both cases: single-& verses double-&. I'm observing this on RHEL 6 and 7. RHEL6$ /bin/sh --version GNU bash, version 4.1.2(1)-release (x86_64-redhat-linux-gnu) RHEL7$ /bin/sh --version GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu) Can anyone shed any light on why this might be happening? $ diff -u apache-tomcat-8.5.37/bin/catalina.sh apache-tomcat-8.5.38/bin/catalina.sh --- apache-tomcat-8.5.37/bin/catalina.sh2018-12-12 07:07:49.0 -0500 +++ apache-tomcat-8.5.38/bin/catalina.sh2019-02-05 06:44:05.0 -0500 @@ -476,7 +476,7 @@ -Dcatalina.home="\"$CATALINA_HOME\"" \ -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \ org.apache.catalina.startup.Bootstrap "$@" start \ - 2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&" + 2\>\&1 \&\& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&" else eval \{ $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER $JAVA_OPTS $CATALINA_OPTS \ @@ -486,7 +486,7 @@ -Dcatalina.home="\"$CATALINA_HOME\"" \ -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \ org.apache.catalina.startup.Bootstrap "$@" start \ - 2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&" + 2\>\&1 \&\& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&" fi - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org