Done!
0.9.20 and 0.10.10 will be soon at Maven Central.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Thu, Oct 6, 2016 at 9:34 AM, Martin Grigorov
wrote:
> I want to do some more changes before the next release.
> Ping me again if you need it sooner.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Thu, Oct 6, 2016 at 8:06 AM, Erik Strid wrote:
>
>> Hi,
>>
>> We have tested the new 0.9.20-SNAPSHOT and it seems to be working as
>> expected.
>> Can we make new release request?
>>
>> Regards
>> Erik Strid
>>
>> On Wed, Oct 5, 2016 at 8:18 AM, Tobias Soloschenko <
>> tobiassolosche...@googlemail.com> wrote:
>>
>> > Hi,
>> >
>> > just wanted to thank you for your contributions! :-)
>> >
>> > kind regards
>> >
>> > Tobias
>> >
>> > > Am 05.10.2016 um 07:17 schrieb Erik Strid :
>> > >
>> > > Hi Martin,
>> > >
>> > > Thank you for the fast release!
>> > >
>> > > Unfortunately did we find another issue in the LessCacheManager
>> before we
>> > > closed this issue on our side, that is related to this issue width the
>> > > importedSources.
>> > > I have created another pull request, see
>> > > https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/638.
>> > >
>> > > Regards
>> > > Erik Strid
>> > >
>> > > On Wed, Sep 28, 2016 at 10:06 AM, Martin Grigorov <
>> mgrigo...@apache.org>
>> > > wrote:
>> > >
>> > >> Done!
>> > >> 0.9.19 and 0.10.9 are on their way to Maven Central!
>> > >> Enjoy!
>> > >>
>> > >> Martin Grigorov
>> > >> Wicket Training and Consulting
>> > >> https://twitter.com/mtgrigorov
>> > >>
>> > >> On Wed, Sep 28, 2016 at 9:46 AM, Martin Grigorov <
>> mgrigo...@apache.org>
>> > >> wrote:
>> > >>
>> > >>> Releases are cheap!
>> > >>> I'll do it today!
>> > >>>
>> > >>> Martin Grigorov
>> > >>> Wicket Training and Consulting
>> > >>> https://twitter.com/mtgrigorov
>> > >>>
>> > >>> On Wed, Sep 28, 2016 at 9:40 AM, Erik Strid
>> > >> wrote:
>> > >>>
>> > Hi Martin,
>> >
>> > Thank you for your fast response to the pull request!
>> >
>> > How often is the wicket-boostrap project released?
>> >
>> > We have tested the snapshot in our test environment and we think
>> the
>> > solution works as intended. We would like to have a correct release
>> > >> before
>> > releasing the whole solution to the real world. This will happen
>> > within
>> > 3-4
>> > weeks. Is it possible to get a release in that time frame?
>> >
>> > Regards
>> > Erik
>> >
>> > On Thu, Sep 22, 2016 at 9:26 PM, Martin Grigorov <
>> > mgrigo...@apache.org>
>> > wrote:
>> >
>> > > Merged!
>> > > Thanks a lot!
>> > >
>> > > Martin Grigorov
>> > > Wicket Training and Consulting
>> > > https://twitter.com/mtgrigorov
>> > >
>> > > On Thu, Sep 22, 2016 at 1:11 PM, Erik Strid > >
>> > wrote:
>> > >
>> > >> Hi Martin,
>> > >>
>> > >> I have created a pull request, see
>> > >> https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/636
>> > >>
>> > >> Regards
>> > >> Erik
>> > >>
>> > >> On Tue, Sep 20, 2016 at 9:08 PM, Martin Grigorov <
>> > mgrigo...@apache.org>
>> > >> wrote:
>> > >>
>> > >>> Hi Erik,
>> > >>>
>> > >>> Many thanks for investigating this!
>> > >>>
>> > >>> Please create a Pull Request!
>> > >>> It seems you already know how to fix it!
>> > >>> Thank you!
>> > >>>
>> > >>> Martin Grigorov
>> > >>> Wicket Training and Consulting
>> > >>> https://twitter.com/mtgrigorov
>> > >>>
>> > >>> On Tue, Sep 20, 2016 at 2:16 PM, Erik Strid <
>> strid.e...@gmail.com
>> > >>>
>> > >> wrote:
>> > >>>
>> > Hi Martin,
>> >
>> > I have finally found some time to investigate this issue
>> > >> further.
>> >
>> > It seems that clearing the cache only will clear the variable
>> > >>> contentCache
>> > and not both the contentCache and urlSourceCache variables in
>> > LessCacheManager. A cleared cache will trigger a recompile in
>> > LessCacheManager.getCss(URLSource) on a cached URLSource, in
>> > >> this
>> > > case
>> > will
>> > the compiler add the imported files to the importedSources
>> list,
>> > >> returned
>> > by AbstractHierarchicalSource.getImportedSources(), once more.
>> > And
>> > > the
>> > importedSources list will grow with imported files after each
>> > call to
>> > clearCache.
>> > The NPE that we get is a result of the shared URLSource and a
>> > >> race
>> > condition in AbstractHierarchicalSource.
>> > > addImportedSource(LessSource)
>> > (importedSources isn't thread safe).
>> >
>> > Furthermore I think there is an