Re: module error

2022-02-20 Thread Martin Grigorov
Hi Jon,

Once you link your ASF account with your GitHub account please read our
"How to release" document -
https://wicket.apache.org/contribute/release.html. It is a bit outdated it
seems.

 I'd let Andrea del Bene make a release. Or at least work closely with him
for my first attempt to release.

On Mon, Feb 21, 2022, 05:12 Locke, Jonathan (Luo Shibo) <
jonath...@telenav.com> wrote:

> Hi Martin,
>
> I have access to my account now, but I get this when I try to push a new
> branch rel/wicket-9.8.1
>
> wicket: remote: Permission to apache/wicket.git denied to jonathanlocke.
> unable to access 'https://github.com/apache/wicket.git/': The requested
> URL returned error: 403
>
> Can someone give me push access?
>
>Jon
>
> 
> From: Martin Grigorov 
> Sent: Sunday, February 20, 2022 5:58 PM
> To: users@wicket.apache.org 
> Subject: Re: module error
>
> You are still a member of the team -
> https://home.apache.org/phonebook.html?uid=jonl
>
> If your login was disabled your id would appear scratched at
> https://home.apache.org/phonebook.html?pmc=wicket
>
> I guess you have forgotten your ID and/or associated email and/or password.
> The quickest way to start using again your account is to contact Infra team
> at JIRA.
>
>
> Once you have access to your Apache account you should go to
> https://gitbox.apache.org/setup/ to link it with your GitHub account.
>
>
>
> On Sun, Feb 20, 2022, 08:00 Locke, Jonathan (Luo Shibo) <
> jonath...@telenav.com> wrote:
>
> > Yes, I checked. I don't.
> > 
> > From: Maxim Solodovnik 
> > Sent: Saturday, February 19, 2022 8:11 PM
> > To: users@wicket.apache.org 
> > Subject: Re: module error
> >
> > from mobile (sorry for typos ;)
> >
> >
> > On Sun, Feb 20, 2022, 02:41 Locke, Jonathan (Luo Shibo) <
> > jonath...@telenav.com> wrote:
> >
> > > I don't think I'm a committer anymore. It's been at least a decade
> since
> > > my last commit.
> > >
> >
> > Commitership shouldn't be dropped due to inactivity
> >
> > Can you check if you have your github login at id.apache.org ?
> >
> >
> > I'm amazed that wicket is still going strong. In two years it will be 20
> > > years of Wicket.
> > >
> > >Jon
> > >
> > > 
> > > From: Maxim Solodovnik 
> > > Sent: Saturday, February 19, 2022 5:57 AM
> > > To: users@wicket.apache.org 
> > > Subject: Re: module error
> > >
> > > from mobile (sorry for typos ;)
> > >
> > >
> > > On Sat, Feb 19, 2022, 19:20 Ernesto Reinaldo Barreiro <
> > reier...@gmail.com>
> > > wrote:
> > >
> > > > No if you are a committer :-)
> > > >
> > >
> > > Commiter will never see 403 :)
> > >
> > > >
> > > > On Fri, Feb 18, 2022 at 11:44 PM Maxim Solodovnik <
> > solomax...@gmail.com>
> > > > wrote:
> > > >
> > > > > On Sat, 19 Feb 2022 at 03:04, Locke, Jonathan (Luo Shibo) <
> > > > > jonath...@telenav.com> wrote:
> > > > >
> > > > > > Hi Martin,
> > > > > >
> > > > > > I was able to fix the problem as you suggested by adding:
> > > > > >
> > > > > > uses org.apache.wicket.IInitializer;
> > > > > >
> > > > > > to
> > >
> >
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmodule-info.java=E,1,WO4T_dAL8ww57jzExgL1QE2YUg9PSzf2JkCUtz233hgGolAnoaigRG7sFCy0R4-qUwC5-Hx7dj3RPzsVYEU2af8Pfa75fVWyNkUJcZk3X0YerNK-FcxQ=1
> > > in wicket-core. I created a pull request, but got
> > > > an
> > > > > > error trying to push it in IntelliJ:
> > > > > >
> > > > > > Can't create a new pull request: Push failed: remote: Permission
> to
> > > > > > apache/wicket.git denied to jonathanlocke. unable to access '
> > > > > > https://github.com/apache/wicket.git/': The requested URL
> returned
> > > > > error:
> > > > > > 403
> > > > > >
> > > > >
> > > > > You need to fork the repo first :)
> > > > >
> > > > >
> > > > > >
> > > > > > Could we add this as a patch release to wicket 9.8.x?
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Jon
> > > > > > 
> > > > > > From: Martin Grigorov 
> > > > > > Sent: Friday, February 18, 2022 2:55 AM
> > > > > > To: users@wicket.apache.org 
> > > > > > Subject: Re: module error
> > > > > >
> > > > > > Hm.
> > > > > > Looking at
> https://github.com/qos-ch/logback/commit/5186d2604b460f
> > I
> > > > > think
> > > > > > we need the 'uses' only in the module where we call
> > > > ServiceLoader.load(),
> > > > > > i.e. in wicket-core.
> > > > > >
> > > > > > On Fri, Feb 18, 2022 at 11:53 AM Martin Grigorov <
> > > mgrigo...@apache.org
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Hi Jon,
> > > > > > >
> > > > > > > According to
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fwww.oracle.com%2fcorporate%2ffeatures%2funderstanding-java-9-modules.html=E,1,AlcuJddqQ1zhtdsihzDbje23huNpDs6zcgn19JZMXP_Y1UGGpZLts-DudDYPcu75JyHkjFHLNGJw3KmnkhBiyTndIjuRNCIVCuhKfLjxxCsCSVE,=1
> > > > > > >
> > > > > > > *provides…with.* A provides…with module directive 

Re: module error

2022-02-20 Thread Maxim Solodovnik
On Mon, 21 Feb 2022 at 10:11, Locke, Jonathan (Luo Shibo) <
jonath...@telenav.com> wrote:

> Hi Martin,
>
> I have access to my account now, but I get this when I try to push a new
> branch rel/wicket-9.8.1
>
> wicket: remote: Permission to apache/wicket.git denied to jonathanlocke.
> unable to access 'https://github.com/apache/wicket.git/': The requested
> URL returned error: 403
>
> Can someone give me push access?
>

please try to add your github username at id.apache.org
or use https://gitbox.apache.org/ 


>Jon
>
> 
> From: Martin Grigorov 
> Sent: Sunday, February 20, 2022 5:58 PM
> To: users@wicket.apache.org 
> Subject: Re: module error
>
> You are still a member of the team -
> https://home.apache.org/phonebook.html?uid=jonl
>
> If your login was disabled your id would appear scratched at
> https://home.apache.org/phonebook.html?pmc=wicket
>
> I guess you have forgotten your ID and/or associated email and/or password.
> The quickest way to start using again your account is to contact Infra team
> at JIRA.
>
>
> Once you have access to your Apache account you should go to
> https://gitbox.apache.org/setup/ to link it with your GitHub account.
>
>
>
> On Sun, Feb 20, 2022, 08:00 Locke, Jonathan (Luo Shibo) <
> jonath...@telenav.com> wrote:
>
> > Yes, I checked. I don't.
> > 
> > From: Maxim Solodovnik 
> > Sent: Saturday, February 19, 2022 8:11 PM
> > To: users@wicket.apache.org 
> > Subject: Re: module error
> >
> > from mobile (sorry for typos ;)
> >
> >
> > On Sun, Feb 20, 2022, 02:41 Locke, Jonathan (Luo Shibo) <
> > jonath...@telenav.com> wrote:
> >
> > > I don't think I'm a committer anymore. It's been at least a decade
> since
> > > my last commit.
> > >
> >
> > Commitership shouldn't be dropped due to inactivity
> >
> > Can you check if you have your github login at id.apache.org ?
> >
> >
> > I'm amazed that wicket is still going strong. In two years it will be 20
> > > years of Wicket.
> > >
> > >Jon
> > >
> > > 
> > > From: Maxim Solodovnik 
> > > Sent: Saturday, February 19, 2022 5:57 AM
> > > To: users@wicket.apache.org 
> > > Subject: Re: module error
> > >
> > > from mobile (sorry for typos ;)
> > >
> > >
> > > On Sat, Feb 19, 2022, 19:20 Ernesto Reinaldo Barreiro <
> > reier...@gmail.com>
> > > wrote:
> > >
> > > > No if you are a committer :-)
> > > >
> > >
> > > Commiter will never see 403 :)
> > >
> > > >
> > > > On Fri, Feb 18, 2022 at 11:44 PM Maxim Solodovnik <
> > solomax...@gmail.com>
> > > > wrote:
> > > >
> > > > > On Sat, 19 Feb 2022 at 03:04, Locke, Jonathan (Luo Shibo) <
> > > > > jonath...@telenav.com> wrote:
> > > > >
> > > > > > Hi Martin,
> > > > > >
> > > > > > I was able to fix the problem as you suggested by adding:
> > > > > >
> > > > > > uses org.apache.wicket.IInitializer;
> > > > > >
> > > > > > to
> > >
> >
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmodule-info.java=E,1,WO4T_dAL8ww57jzExgL1QE2YUg9PSzf2JkCUtz233hgGolAnoaigRG7sFCy0R4-qUwC5-Hx7dj3RPzsVYEU2af8Pfa75fVWyNkUJcZk3X0YerNK-FcxQ=1
> > > in wicket-core. I created a pull request, but got
> > > > an
> > > > > > error trying to push it in IntelliJ:
> > > > > >
> > > > > > Can't create a new pull request: Push failed: remote: Permission
> to
> > > > > > apache/wicket.git denied to jonathanlocke. unable to access '
> > > > > > https://github.com/apache/wicket.git/': The requested URL
> returned
> > > > > error:
> > > > > > 403
> > > > > >
> > > > >
> > > > > You need to fork the repo first :)
> > > > >
> > > > >
> > > > > >
> > > > > > Could we add this as a patch release to wicket 9.8.x?
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Jon
> > > > > > 
> > > > > > From: Martin Grigorov 
> > > > > > Sent: Friday, February 18, 2022 2:55 AM
> > > > > > To: users@wicket.apache.org 
> > > > > > Subject: Re: module error
> > > > > >
> > > > > > Hm.
> > > > > > Looking at
> https://github.com/qos-ch/logback/commit/5186d2604b460f
> > I
> > > > > think
> > > > > > we need the 'uses' only in the module where we call
> > > > ServiceLoader.load(),
> > > > > > i.e. in wicket-core.
> > > > > >
> > > > > > On Fri, Feb 18, 2022 at 11:53 AM Martin Grigorov <
> > > mgrigo...@apache.org
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Hi Jon,
> > > > > > >
> > > > > > > According to
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fwww.oracle.com%2fcorporate%2ffeatures%2funderstanding-java-9-modules.html=E,1,AlcuJddqQ1zhtdsihzDbje23huNpDs6zcgn19JZMXP_Y1UGGpZLts-DudDYPcu75JyHkjFHLNGJw3KmnkhBiyTndIjuRNCIVCuhKfLjxxCsCSVE,=1
> > > > > > >
> > > > > > > *provides…with.* A provides…with module directive specifies
> that
> > a
> > > > > module
> > > > > > > provides a service implementation—making the module a *service
> > > > > provider*.
> > > > > > > The provides part of the 

Re: module error

2022-02-20 Thread Locke, Jonathan (Luo Shibo)
Hi Martin,

I have access to my account now, but I get this when I try to push a new branch 
rel/wicket-9.8.1

wicket: remote: Permission to apache/wicket.git denied to jonathanlocke. unable 
to access 'https://github.com/apache/wicket.git/': The requested URL returned 
error: 403

Can someone give me push access?

   Jon


From: Martin Grigorov 
Sent: Sunday, February 20, 2022 5:58 PM
To: users@wicket.apache.org 
Subject: Re: module error

You are still a member of the team -
https://home.apache.org/phonebook.html?uid=jonl

If your login was disabled your id would appear scratched at
https://home.apache.org/phonebook.html?pmc=wicket

I guess you have forgotten your ID and/or associated email and/or password.
The quickest way to start using again your account is to contact Infra team
at JIRA.


Once you have access to your Apache account you should go to
https://gitbox.apache.org/setup/ to link it with your GitHub account.



On Sun, Feb 20, 2022, 08:00 Locke, Jonathan (Luo Shibo) <
jonath...@telenav.com> wrote:

> Yes, I checked. I don't.
> 
> From: Maxim Solodovnik 
> Sent: Saturday, February 19, 2022 8:11 PM
> To: users@wicket.apache.org 
> Subject: Re: module error
>
> from mobile (sorry for typos ;)
>
>
> On Sun, Feb 20, 2022, 02:41 Locke, Jonathan (Luo Shibo) <
> jonath...@telenav.com> wrote:
>
> > I don't think I'm a committer anymore. It's been at least a decade since
> > my last commit.
> >
>
> Commitership shouldn't be dropped due to inactivity
>
> Can you check if you have your github login at id.apache.org ?
>
>
> I'm amazed that wicket is still going strong. In two years it will be 20
> > years of Wicket.
> >
> >Jon
> >
> > 
> > From: Maxim Solodovnik 
> > Sent: Saturday, February 19, 2022 5:57 AM
> > To: users@wicket.apache.org 
> > Subject: Re: module error
> >
> > from mobile (sorry for typos ;)
> >
> >
> > On Sat, Feb 19, 2022, 19:20 Ernesto Reinaldo Barreiro <
> reier...@gmail.com>
> > wrote:
> >
> > > No if you are a committer :-)
> > >
> >
> > Commiter will never see 403 :)
> >
> > >
> > > On Fri, Feb 18, 2022 at 11:44 PM Maxim Solodovnik <
> solomax...@gmail.com>
> > > wrote:
> > >
> > > > On Sat, 19 Feb 2022 at 03:04, Locke, Jonathan (Luo Shibo) <
> > > > jonath...@telenav.com> wrote:
> > > >
> > > > > Hi Martin,
> > > > >
> > > > > I was able to fix the problem as you suggested by adding:
> > > > >
> > > > > uses org.apache.wicket.IInitializer;
> > > > >
> > > > > to
> >
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmodule-info.java=E,1,WO4T_dAL8ww57jzExgL1QE2YUg9PSzf2JkCUtz233hgGolAnoaigRG7sFCy0R4-qUwC5-Hx7dj3RPzsVYEU2af8Pfa75fVWyNkUJcZk3X0YerNK-FcxQ=1
> > in wicket-core. I created a pull request, but got
> > > an
> > > > > error trying to push it in IntelliJ:
> > > > >
> > > > > Can't create a new pull request: Push failed: remote: Permission to
> > > > > apache/wicket.git denied to jonathanlocke. unable to access '
> > > > > https://github.com/apache/wicket.git/': The requested URL returned
> > > > error:
> > > > > 403
> > > > >
> > > >
> > > > You need to fork the repo first :)
> > > >
> > > >
> > > > >
> > > > > Could we add this as a patch release to wicket 9.8.x?
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Jon
> > > > > 
> > > > > From: Martin Grigorov 
> > > > > Sent: Friday, February 18, 2022 2:55 AM
> > > > > To: users@wicket.apache.org 
> > > > > Subject: Re: module error
> > > > >
> > > > > Hm.
> > > > > Looking at https://github.com/qos-ch/logback/commit/5186d2604b460f
> I
> > > > think
> > > > > we need the 'uses' only in the module where we call
> > > ServiceLoader.load(),
> > > > > i.e. in wicket-core.
> > > > >
> > > > > On Fri, Feb 18, 2022 at 11:53 AM Martin Grigorov <
> > mgrigo...@apache.org
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Jon,
> > > > > >
> > > > > > According to
> > > > > >
> > > > >
> > > >
> > >
> >
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fwww.oracle.com%2fcorporate%2ffeatures%2funderstanding-java-9-modules.html=E,1,AlcuJddqQ1zhtdsihzDbje23huNpDs6zcgn19JZMXP_Y1UGGpZLts-DudDYPcu75JyHkjFHLNGJw3KmnkhBiyTndIjuRNCIVCuhKfLjxxCsCSVE,=1
> > > > > >
> > > > > > *provides…with.* A provides…with module directive specifies that
> a
> > > > module
> > > > > > provides a service implementation—making the module a *service
> > > > provider*.
> > > > > > The provides part of the directive specifies an interface or
> > abstract
> > > > > > class listed in a module’s uses directive and the with part of
> the
> > > > > > directive specifies the name of the service provider class that
> > > > > implements
> > > > > > the interface or extends the abstract class.
> > > > > >
> > > > > > AFAIU it we need to add "uses org.apache.wicket.IInitializer"
> next
> > to
> > > > all
> > > > > > "provides org.apache.wicket.IInitializer with
> > > > x.y.z.SomeImplementation;"
> > > > > >
> > > > > > Please try 

Re: module error

2022-02-20 Thread Martin Grigorov
You are still a member of the team -
https://home.apache.org/phonebook.html?uid=jonl

If your login was disabled your id would appear scratched at
https://home.apache.org/phonebook.html?pmc=wicket

I guess you have forgotten your ID and/or associated email and/or password.
The quickest way to start using again your account is to contact Infra team
at JIRA.


Once you have access to your Apache account you should go to
https://gitbox.apache.org/setup/ to link it with your GitHub account.



On Sun, Feb 20, 2022, 08:00 Locke, Jonathan (Luo Shibo) <
jonath...@telenav.com> wrote:

> Yes, I checked. I don't.
> 
> From: Maxim Solodovnik 
> Sent: Saturday, February 19, 2022 8:11 PM
> To: users@wicket.apache.org 
> Subject: Re: module error
>
> from mobile (sorry for typos ;)
>
>
> On Sun, Feb 20, 2022, 02:41 Locke, Jonathan (Luo Shibo) <
> jonath...@telenav.com> wrote:
>
> > I don't think I'm a committer anymore. It's been at least a decade since
> > my last commit.
> >
>
> Commitership shouldn't be dropped due to inactivity
>
> Can you check if you have your github login at id.apache.org ?
>
>
> I'm amazed that wicket is still going strong. In two years it will be 20
> > years of Wicket.
> >
> >Jon
> >
> > 
> > From: Maxim Solodovnik 
> > Sent: Saturday, February 19, 2022 5:57 AM
> > To: users@wicket.apache.org 
> > Subject: Re: module error
> >
> > from mobile (sorry for typos ;)
> >
> >
> > On Sat, Feb 19, 2022, 19:20 Ernesto Reinaldo Barreiro <
> reier...@gmail.com>
> > wrote:
> >
> > > No if you are a committer :-)
> > >
> >
> > Commiter will never see 403 :)
> >
> > >
> > > On Fri, Feb 18, 2022 at 11:44 PM Maxim Solodovnik <
> solomax...@gmail.com>
> > > wrote:
> > >
> > > > On Sat, 19 Feb 2022 at 03:04, Locke, Jonathan (Luo Shibo) <
> > > > jonath...@telenav.com> wrote:
> > > >
> > > > > Hi Martin,
> > > > >
> > > > > I was able to fix the problem as you suggested by adding:
> > > > >
> > > > > uses org.apache.wicket.IInitializer;
> > > > >
> > > > > to
> >
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmodule-info.java=E,1,WO4T_dAL8ww57jzExgL1QE2YUg9PSzf2JkCUtz233hgGolAnoaigRG7sFCy0R4-qUwC5-Hx7dj3RPzsVYEU2af8Pfa75fVWyNkUJcZk3X0YerNK-FcxQ=1
> > in wicket-core. I created a pull request, but got
> > > an
> > > > > error trying to push it in IntelliJ:
> > > > >
> > > > > Can't create a new pull request: Push failed: remote: Permission to
> > > > > apache/wicket.git denied to jonathanlocke. unable to access '
> > > > > https://github.com/apache/wicket.git/': The requested URL returned
> > > > error:
> > > > > 403
> > > > >
> > > >
> > > > You need to fork the repo first :)
> > > >
> > > >
> > > > >
> > > > > Could we add this as a patch release to wicket 9.8.x?
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Jon
> > > > > 
> > > > > From: Martin Grigorov 
> > > > > Sent: Friday, February 18, 2022 2:55 AM
> > > > > To: users@wicket.apache.org 
> > > > > Subject: Re: module error
> > > > >
> > > > > Hm.
> > > > > Looking at https://github.com/qos-ch/logback/commit/5186d2604b460f
> I
> > > > think
> > > > > we need the 'uses' only in the module where we call
> > > ServiceLoader.load(),
> > > > > i.e. in wicket-core.
> > > > >
> > > > > On Fri, Feb 18, 2022 at 11:53 AM Martin Grigorov <
> > mgrigo...@apache.org
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Jon,
> > > > > >
> > > > > > According to
> > > > > >
> > > > >
> > > >
> > >
> >
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fwww.oracle.com%2fcorporate%2ffeatures%2funderstanding-java-9-modules.html=E,1,AlcuJddqQ1zhtdsihzDbje23huNpDs6zcgn19JZMXP_Y1UGGpZLts-DudDYPcu75JyHkjFHLNGJw3KmnkhBiyTndIjuRNCIVCuhKfLjxxCsCSVE,=1
> > > > > >
> > > > > > *provides…with.* A provides…with module directive specifies that
> a
> > > > module
> > > > > > provides a service implementation—making the module a *service
> > > > provider*.
> > > > > > The provides part of the directive specifies an interface or
> > abstract
> > > > > > class listed in a module’s uses directive and the with part of
> the
> > > > > > directive specifies the name of the service provider class that
> > > > > implements
> > > > > > the interface or extends the abstract class.
> > > > > >
> > > > > > AFAIU it we need to add "uses org.apache.wicket.IInitializer"
> next
> > to
> > > > all
> > > > > > "provides org.apache.wicket.IInitializer with
> > > > x.y.z.SomeImplementation;"
> > > > > >
> > > > > > Please try it and if it fixes the issue then send a PR!
> > > > > >
> > > > > > On Thu, Feb 17, 2022 at 8:16 PM Locke, Jonathan (Luo Shibo) <
> > > > > > jonath...@telenav.com> wrote:
> > > > > >
> > > > > >>
> > > > > >> Does anyone know what this is? Thanks -- Jon
> > > > > >>
> > > > > >> Exception in thread "main" java.util.ServiceConfigurationError:
> > > > > >> org.apache.wicket.IInitializer: module org.apache.wicket.core
> does
> > > not
> > > > > >> declare `uses`
> > > > > >> 

Re: module error

2022-02-20 Thread Chris Colman
I also want to thank you, Jonathan, for Wicket (and the other early devs 
who conceived it and the current devs maintaining it) - we've been using 
it since 2008.


It's always my first choice for any new web app development but on some 
client contracts I have had to work with existing apps using JSP, 
Struts/JSP, Angular JS and other pure JS frameworks but nothing beats 
the amazing developer productivity we gain with Wicket.


All the power of the newer JS frameworks but not having to write any JS 
ourselves means WIcket is simply the best of both worlds!


Regards,
Chris

On 21/02/2022 2:06 am, Ernesto Reinaldo Barreiro wrote:

This is then the problem :-) Thanks to you for Wicket :-)

On Sun, Feb 20, 2022 at 1:00 AM Locke, Jonathan (Luo Shibo) <
jonath...@telenav.com> wrote:


Yes, I checked. I don't.

From: Maxim Solodovnik 
Sent: Saturday, February 19, 2022 8:11 PM
To: users@wicket.apache.org 
Subject: Re: module error

from mobile (sorry for typos ;)


On Sun, Feb 20, 2022, 02:41 Locke, Jonathan (Luo Shibo) <
jonath...@telenav.com> wrote:


I don't think I'm a committer anymore. It's been at least a decade since
my last commit.


Commitership shouldn't be dropped due to inactivity

Can you check if you have your github login at id.apache.org ?


I'm amazed that wicket is still going strong. In two years it will be 20

years of Wicket.

Jon


From: Maxim Solodovnik 
Sent: Saturday, February 19, 2022 5:57 AM
To: users@wicket.apache.org 
Subject: Re: module error

from mobile (sorry for typos ;)


On Sat, Feb 19, 2022, 19:20 Ernesto Reinaldo Barreiro <

reier...@gmail.com>

wrote:


No if you are a committer :-)


Commiter will never see 403 :)


On Fri, Feb 18, 2022 at 11:44 PM Maxim Solodovnik <

solomax...@gmail.com>

wrote:


On Sat, 19 Feb 2022 at 03:04, Locke, Jonathan (Luo Shibo) <
jonath...@telenav.com> wrote:


Hi Martin,

I was able to fix the problem as you suggested by adding:

 uses org.apache.wicket.IInitializer;

to

https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmodule-info.java=E,1,WO4T_dAL8ww57jzExgL1QE2YUg9PSzf2JkCUtz233hgGolAnoaigRG7sFCy0R4-qUwC5-Hx7dj3RPzsVYEU2af8Pfa75fVWyNkUJcZk3X0YerNK-FcxQ=1

in wicket-core. I created a pull request, but got

an

error trying to push it in IntelliJ:

Can't create a new pull request: Push failed: remote: Permission to
apache/wicket.git denied to jonathanlocke. unable to access '
https://github.com/apache/wicket.git/': The requested URL returned

error:

403


You need to fork the repo first :)



Could we add this as a patch release to wicket 9.8.x?

Thanks,

 Jon

From: Martin Grigorov 
Sent: Friday, February 18, 2022 2:55 AM
To: users@wicket.apache.org 
Subject: Re: module error

Hm.
Looking at https://github.com/qos-ch/logback/commit/5186d2604b460f

I

think

we need the 'uses' only in the module where we call

ServiceLoader.load(),

i.e. in wicket-core.

On Fri, Feb 18, 2022 at 11:53 AM Martin Grigorov <

mgrigo...@apache.org

wrote:


Hi Jon,

According to


https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fwww.oracle.com%2fcorporate%2ffeatures%2funderstanding-java-9-modules.html=E,1,AlcuJddqQ1zhtdsihzDbje23huNpDs6zcgn19JZMXP_Y1UGGpZLts-DudDYPcu75JyHkjFHLNGJw3KmnkhBiyTndIjuRNCIVCuhKfLjxxCsCSVE,=1

*provides…with.* A provides…with module directive specifies that

a

module

provides a service implementation—making the module a *service

provider*.

The provides part of the directive specifies an interface or

abstract

class listed in a module’s uses directive and the with part of

the

directive specifies the name of the service provider class that

implements

the interface or extends the abstract class.

AFAIU it we need to add "uses org.apache.wicket.IInitializer"

next

to

all

"provides org.apache.wicket.IInitializer with

x.y.z.SomeImplementation;"

Please try it and if it fixes the issue then send a PR!

On Thu, Feb 17, 2022 at 8:16 PM Locke, Jonathan (Luo Shibo) <
jonath...@telenav.com> wrote:


Does anyone know what this is? Thanks -- Jon

Exception in thread "main" java.util.ServiceConfigurationError:
org.apache.wicket.IInitializer: module org.apache.wicket.core

does

not

declare `uses`
at java.base/

https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fjava.util.ServiceLoader.fail=E,1,2x_TAvfY-cjOXXMq-PK1WQZp3HpRsfitQcisq2lSSdigHB1fuLg4Un_Ch3NVlsHPuGsx1r8PejxwY0JdlGRrY2C2drem7b8IxqPf8rSvijXa9Q,,=1(https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fServiceLoader.java%3a589=E,1,cis_qtCg_hnDhiLzgOVbloD3TvvURxsW_mR8jY_GLJSaBpOtuXQJUWKaJ_JrPr61_00oAuYKmsG399grMpFwMKTC0mk8-ulQZF8Om98TsswwCgflaQ,,=1)

at java.base/java.util.ServiceLoader.checkCaller(

https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fServiceLoader.java%3a575=E,1,9qC3hJZa-Ru3NfQ0Cu_xyUf_1TZj3k6pzwnMObpxVdF9nmaNB2Rc-7lJtCoeo-It3FF8Ycad-exairuNw8NewoRyu6p0DmFxGH3lEQdd=1

)

at java.base/java.util.ServiceLoader.(


Re: module error

2022-02-20 Thread Ernesto Reinaldo Barreiro
This is then the problem :-) Thanks to you for Wicket :-)

On Sun, Feb 20, 2022 at 1:00 AM Locke, Jonathan (Luo Shibo) <
jonath...@telenav.com> wrote:

> Yes, I checked. I don't.
> 
> From: Maxim Solodovnik 
> Sent: Saturday, February 19, 2022 8:11 PM
> To: users@wicket.apache.org 
> Subject: Re: module error
>
> from mobile (sorry for typos ;)
>
>
> On Sun, Feb 20, 2022, 02:41 Locke, Jonathan (Luo Shibo) <
> jonath...@telenav.com> wrote:
>
> > I don't think I'm a committer anymore. It's been at least a decade since
> > my last commit.
> >
>
> Commitership shouldn't be dropped due to inactivity
>
> Can you check if you have your github login at id.apache.org ?
>
>
> I'm amazed that wicket is still going strong. In two years it will be 20
> > years of Wicket.
> >
> >Jon
> >
> > 
> > From: Maxim Solodovnik 
> > Sent: Saturday, February 19, 2022 5:57 AM
> > To: users@wicket.apache.org 
> > Subject: Re: module error
> >
> > from mobile (sorry for typos ;)
> >
> >
> > On Sat, Feb 19, 2022, 19:20 Ernesto Reinaldo Barreiro <
> reier...@gmail.com>
> > wrote:
> >
> > > No if you are a committer :-)
> > >
> >
> > Commiter will never see 403 :)
> >
> > >
> > > On Fri, Feb 18, 2022 at 11:44 PM Maxim Solodovnik <
> solomax...@gmail.com>
> > > wrote:
> > >
> > > > On Sat, 19 Feb 2022 at 03:04, Locke, Jonathan (Luo Shibo) <
> > > > jonath...@telenav.com> wrote:
> > > >
> > > > > Hi Martin,
> > > > >
> > > > > I was able to fix the problem as you suggested by adding:
> > > > >
> > > > > uses org.apache.wicket.IInitializer;
> > > > >
> > > > > to
> >
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmodule-info.java=E,1,WO4T_dAL8ww57jzExgL1QE2YUg9PSzf2JkCUtz233hgGolAnoaigRG7sFCy0R4-qUwC5-Hx7dj3RPzsVYEU2af8Pfa75fVWyNkUJcZk3X0YerNK-FcxQ=1
> > in wicket-core. I created a pull request, but got
> > > an
> > > > > error trying to push it in IntelliJ:
> > > > >
> > > > > Can't create a new pull request: Push failed: remote: Permission to
> > > > > apache/wicket.git denied to jonathanlocke. unable to access '
> > > > > https://github.com/apache/wicket.git/': The requested URL returned
> > > > error:
> > > > > 403
> > > > >
> > > >
> > > > You need to fork the repo first :)
> > > >
> > > >
> > > > >
> > > > > Could we add this as a patch release to wicket 9.8.x?
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Jon
> > > > > 
> > > > > From: Martin Grigorov 
> > > > > Sent: Friday, February 18, 2022 2:55 AM
> > > > > To: users@wicket.apache.org 
> > > > > Subject: Re: module error
> > > > >
> > > > > Hm.
> > > > > Looking at https://github.com/qos-ch/logback/commit/5186d2604b460f
> I
> > > > think
> > > > > we need the 'uses' only in the module where we call
> > > ServiceLoader.load(),
> > > > > i.e. in wicket-core.
> > > > >
> > > > > On Fri, Feb 18, 2022 at 11:53 AM Martin Grigorov <
> > mgrigo...@apache.org
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Jon,
> > > > > >
> > > > > > According to
> > > > > >
> > > > >
> > > >
> > >
> >
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fwww.oracle.com%2fcorporate%2ffeatures%2funderstanding-java-9-modules.html=E,1,AlcuJddqQ1zhtdsihzDbje23huNpDs6zcgn19JZMXP_Y1UGGpZLts-DudDYPcu75JyHkjFHLNGJw3KmnkhBiyTndIjuRNCIVCuhKfLjxxCsCSVE,=1
> > > > > >
> > > > > > *provides…with.* A provides…with module directive specifies that
> a
> > > > module
> > > > > > provides a service implementation—making the module a *service
> > > > provider*.
> > > > > > The provides part of the directive specifies an interface or
> > abstract
> > > > > > class listed in a module’s uses directive and the with part of
> the
> > > > > > directive specifies the name of the service provider class that
> > > > > implements
> > > > > > the interface or extends the abstract class.
> > > > > >
> > > > > > AFAIU it we need to add "uses org.apache.wicket.IInitializer"
> next
> > to
> > > > all
> > > > > > "provides org.apache.wicket.IInitializer with
> > > > x.y.z.SomeImplementation;"
> > > > > >
> > > > > > Please try it and if it fixes the issue then send a PR!
> > > > > >
> > > > > > On Thu, Feb 17, 2022 at 8:16 PM Locke, Jonathan (Luo Shibo) <
> > > > > > jonath...@telenav.com> wrote:
> > > > > >
> > > > > >>
> > > > > >> Does anyone know what this is? Thanks -- Jon
> > > > > >>
> > > > > >> Exception in thread "main" java.util.ServiceConfigurationError:
> > > > > >> org.apache.wicket.IInitializer: module org.apache.wicket.core
> does
> > > not
> > > > > >> declare `uses`
> > > > > >> at java.base/
> > > > >
> > > >
> > >
> >
>