Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-05 Thread James Carman 
-1 from me.  I prefer the wildcards.  It let's the client code be more
flexible

On Mar 5, 2009 1:20 AM, Martijn Reuvers martijn.reuv...@gmail.com wrote:

+1 for me too.

On Tue, Mar 3, 2009 at 9:39 PM, Martijn Dashorst martijn.dasho...@gmail.com
wrote:  Though I hav...

Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-04 Thread Martijn Reuvers 
+1 for me too.

On Tue, Mar 3, 2009 at 9:39 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
 Though I haven't done much work with 1.4, I think DDC and LV need to
 have the same generics semantics. And I prefer the simple version.

 So count my +1.

 Martijn

 On Tue, Mar 3, 2009 at 9:33 PM, Timo Rantalaiho timo.rantala...@ri.fi wrote:
 On Mon, 02 Mar 2009, Johan Compagner wrote:
 If we loose the wildcard is it then still possible to do everything?

 We have it to be able to use a Manager List when we declare it as a
 People
 When you have that you have to copy it over i guess by a helper method.

 I just want to know for sure that i dont miss something that if we remove it
 that then something is not possible anymore

 Right, for example this does not work

  ListSerializable doesntWork = new ArrayListString(Arrays.asList(foo, 
 bar));

 But this does

  ListSerializable works = new ArrayListSerializable(Arrays.asList(foo, 
 bar));

 As Igor says, this might not be a very common scenario(?).

 The case that has come up a couple of times in the last few
 days is that the same model didn't work for DropDownChoice
 and ListView. This seems like a more likely case so it would
 make sense to align them with each other. So far there have
 only been a couple of -1s, so maybe that will happen.

 Best wishes,
 Timo

 --
 Timo Rantalaiho
 Reaktor Innovations Oy    URL: http://www.ri.fi/ 

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org





 --
 Become a Wicket expert, learn from the best: http://wicketinaction.com
 Apache Wicket 1.3.5 is released
 Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org



-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-03 Thread Timo Rantalaiho 
On Mon, 02 Mar 2009, Johan Compagner wrote:
 If we loose the wildcard is it then still possible to do everything?
 
 We have it to be able to use a Manager List when we declare it as a
 People
 When you have that you have to copy it over i guess by a helper method.
 
 I just want to know for sure that i dont miss something that if we remove it
 that then something is not possible anymore

Right, for example this does not work

  ListSerializable doesntWork = new ArrayListString(Arrays.asList(foo, 
bar));

But this does

  ListSerializable works = new ArrayListSerializable(Arrays.asList(foo, 
bar));

As Igor says, this might not be a very common scenario(?). 

The case that has come up a couple of times in the last few
days is that the same model didn't work for DropDownChoice 
and ListView. This seems like a more likely case so it would 
make sense to align them with each other. So far there have 
only been a couple of -1s, so maybe that will happen.

Best wishes,
Timo

-- 
Timo Rantalaiho   
Reaktor Innovations OyURL: http://www.ri.fi/ 

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-02 Thread Daan van Etten 

[X] Yes, change the DropDownChoice constructor to take the
   choices list as IModelListT or ListT without the
   wildcard


Regards,

Daan

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-02 Thread Marat Radchenko 
[X] No, keep DropDownChoice as it is in Wicket 1.4-rc2

2009/3/2 Timo Rantalaiho timo.rantala...@ri.fi:
 Background:

  https://issues.apache.org/jira/browse/WICKET-1512

  https://issues.apache.org/jira/browse/WICKET-2126

  http://www.nabble.com/LDM-with-Generics-for-DropDownChoice-td22155211.html


 This works:
 = clips 
     public static void main(String[] args) {
         Foo foo = new Foo();
         foo.bar().add(new String(quux));
     }

     @SuppressWarnings(unchecked)
     public ListString bar() {
       List? extends String list = new 
 ArrayListString(Arrays.asList(foo, bar));
       return (ListString) list;
     }
 = /clips ===


 This doesn't work:
 = claps 
     public static void main(String[] args) {
         Foo foo = new Foo();
         foo.bar().add(new String(quux));
     }

     public List? extends String bar() {
       List? extends String list = new 
 ArrayListString(Arrays.asList(foo, bar));
       return list;
     }
 = /claps ===



 [ ] Yes, change the DropDownChoice constructor to take the
    choices list as IModelListT or ListT without the
    wildcard

 [ ] No, keep DropDownChoice as it is in Wicket 1.4-rc2



 Best wishes,
 Timo

 --
 Timo Rantalaiho
 Reaktor Innovations Oy    URL: http://www.ri.fi/ 

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org

Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-02 Thread Maarten Bosteels 
[X] Yes, change the DropDownChoice constructor to take the
  choices list as IModelListT or ListT without the
  wildcard

Maarten

On Mon, Mar 2, 2009 at 9:30 AM, Daan van Etten d...@stuq.nl wrote:

 [X] Yes, change the DropDownChoice constructor to take the
   choices list as IModelListT or ListT without the
   wildcard


 Regards,

 Daan


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org

Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-02 Thread Johan Compagner 
If we loose the wildcard is it then still possible to do everything?

We have it to be able to use a Manager List when we declare it as a
People
When you have that you have to copy it over i guess by a helper method.

I just want to know for sure that i dont miss something that if we remove it
that then something is not possible anymore


On Mon, Mar 2, 2009 at 05:26, Timo Rantalaiho timo.rantala...@ri.fi wrote:

 Background:

  https://issues.apache.org/jira/browse/WICKET-1512

  https://issues.apache.org/jira/browse/WICKET-2126


 http://www.nabble.com/LDM-with-Generics-for-DropDownChoice-td22155211.html


 This works:
 = clips 
 public static void main(String[] args) {
 Foo foo = new Foo();
 foo.bar().add(new String(quux));
 }

 @SuppressWarnings(unchecked)
 public ListString bar() {
   List? extends String list = new
 ArrayListString(Arrays.asList(foo, bar));
   return (ListString) list;
 }
 = /clips ===


 This doesn't work:
 = claps 
 public static void main(String[] args) {
 Foo foo = new Foo();
 foo.bar().add(new String(quux));
 }

 public List? extends String bar() {
   List? extends String list = new
 ArrayListString(Arrays.asList(foo, bar));
   return list;
 }
 = /claps ===



 [ ] Yes, change the DropDownChoice constructor to take the
choices list as IModelListT or ListT without the
wildcard

 [ ] No, keep DropDownChoice as it is in Wicket 1.4-rc2



 Best wishes,
 Timo

 --
 Timo Rantalaiho
 Reaktor Innovations OyURL: http://www.ri.fi/ 

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org

[vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-01 Thread Timo Rantalaiho 
Background:

  https://issues.apache.org/jira/browse/WICKET-1512

  https://issues.apache.org/jira/browse/WICKET-2126

  http://www.nabble.com/LDM-with-Generics-for-DropDownChoice-td22155211.html


This works:
= clips 
 public static void main(String[] args) {
 Foo foo = new Foo();
 foo.bar().add(new String(quux));
 }

 @SuppressWarnings(unchecked)
 public ListString bar() {
   List? extends String list = new ArrayListString(Arrays.asList(foo, 
bar));
   return (ListString) list;
 }
= /clips ===


This doesn't work:
= claps 
 public static void main(String[] args) {
 Foo foo = new Foo();
 foo.bar().add(new String(quux));
 }

 public List? extends String bar() {
   List? extends String list = new ArrayListString(Arrays.asList(foo, 
bar));
   return list;
 }
= /claps ===



[ ] Yes, change the DropDownChoice constructor to take the
choices list as IModelListT or ListT without the
wildcard

[ ] No, keep DropDownChoice as it is in Wicket 1.4-rc2



Best wishes,
Timo

-- 
Timo Rantalaiho   
Reaktor Innovations OyURL: http://www.ri.fi/ 

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-01 Thread Timo Rantalaiho 
 [X] Yes, change the DropDownChoice constructor to take the
 choices list as IModelListT or ListT without the
 wildcard


-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-01 Thread Jan Kriesten 

 [X] Yes, change the DropDownChoice constructor to take the
 choices list as IModelListT or ListT without the
 wildcard
 
 [ ] No, keep DropDownChoice as it is in Wicket 1.4-rc2


Best regards, --- Jan.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-01 Thread Martin Makundi 
 [X] Yes, change the DropDownChoice constructor to take the
  choices list as IModelListT or ListT without the
  wildcard

**
Martin

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Re: [vote] In Wicket 1.4 and onwards, remove widening from the list of choices model in DropDownChoice, changing it from IModelList? extends Foo to IModelListFoo

2009-03-01 Thread Erik van Oosten 

[X] Yes, change the DropDownChoice constructor to take the
   choices list as IModelListT or ListT without the
   wildcard



Regards,
Erik.

--
Erik van Oosten
http://day-to-day-stuff.blogspot.com/



-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org