Re: About the Session Leaking Problem
actually, i think it would be more correct for the unset below to be inside
a nested finally block. it's an edge case and probably will never happen,
but technically speaking the try/catch below could fail for Throwables that
are not exceptions (OOM errors, assertion failures, etc.) while finally is
fairly bulletproof.
Iman Rahmatizadeh wrote:
Hi ,
About the session leaking problem described in this thread :
http://www.nabble.com/Invoulentary-session-sharing-leakage-in-Wicket-1.3.x-td16550360.html
I'm getting reports of the same problem from some of my clients. Where can
I
find the fix committed for this problem ? Is it more than just this
try/crach added to WicketFilter.java ?
---
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
2008/04/08
17:23:34 646008
+++
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
2008/04/09
13:18:38 646331
@@ -385,7 +385,16 @@
{
// Close response
if (response != null)
- response.close();
+ {
+ try
+ {
+ response.close();
+ }
+ catch (Exception e)
+ {
+ log.error(closing the buffer
error, e);
+ }
+ }
// Clean up thread local session
Session.unset();
Regards,
Iman
--
View this message in context:
http://www.nabble.com/About-the-Session-Leaking-Problem-tp17043104p17043374.html
Sent from the Wicket - User mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: About the Session Leaking Problem
yes thats better. i changed it
On Sun, May 4, 2008 at 8:50 AM, Jonathan Locke [EMAIL PROTECTED]
wrote:
actually, i think it would be more correct for the unset below to be
inside
a nested finally block. it's an edge case and probably will never happen,
but technically speaking the try/catch below could fail for Throwables
that
are not exceptions (OOM errors, assertion failures, etc.) while finally is
fairly bulletproof.
Iman Rahmatizadeh wrote:
Hi ,
About the session leaking problem described in this thread :
http://www.nabble.com/Invoulentary-session-sharing-leakage-in-Wicket-1.3.x-td16550360.html
I'm getting reports of the same problem from some of my clients. Where
can
I
find the fix committed for this problem ? Is it more than just this
try/crach added to WicketFilter.java ?
---
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
2008/04/08
17:23:34 646008
+++
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
2008/04/09
13:18:38 646331
@@ -385,7 +385,16 @@
{
// Close response
if (response != null)
- response.close();
+ {
+ try
+ {
+ response.close();
+ }
+ catch (Exception e)
+ {
+ log.error(closing the
buffer error, e);
+ }
+ }
// Clean up thread local session
Session.unset();
Regards,
Iman
--
View this message in context:
http://www.nabble.com/About-the-Session-Leaking-Problem-tp17043104p17043374.html
Sent from the Wicket - User mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
About the Session Leaking Problem
Hi ,
About the session leaking problem described in this thread :
http://www.nabble.com/Invoulentary-session-sharing-leakage-in-Wicket-1.3.x-td16550360.html
I'm getting reports of the same problem from some of my clients. Where can I
find the fix committed for this problem ? Is it more than just this
try/crach added to WicketFilter.java ?
---
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
2008/04/08
17:23:34646008
+++
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
2008/04/09
13:18:38646331
@@ -385,7 +385,16 @@
{
// Close response
if (response != null)
- response.close();
+ {
+ try
+ {
+ response.close();
+ }
+ catch (Exception e)
+ {
+ log.error(closing the buffer
error, e);
+ }
+ }
// Clean up thread local session
Session.unset();
Regards,
Iman
