DropDownChoice no selection value

2010-12-22 Thread hok

Hello,
I've noticed that the method
AbstractSingleSelectChoice.getNoSelectionValue() returns the value for no
selection. However in AbstractSingleSelectChoice.getDefaultChoice(final
Object selected) on line 314:
  return \noption selected=\selected\ value=\\ + option +
/option;

and on line 296:
  buffer.append( value=\\).append(option).append(/option);

In those cases the null value option has empty value attribute. Wouldn't it
be more consistent for this option to have the value attribute with the
result provided from getNoSelectionValue() ? I came into this while trying
to use dojo FilteringSelect, which doesn't select the first option if it
has empty value attribute.
Thanks.
-- 
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/DropDownChoice-no-selection-value-tp3160661p3160661.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: DropDownChoice no selection value

2010-12-22 Thread Martin Grigorov
It looks like a bug.
Please file a ticket.

On Wed, Dec 22, 2010 at 2:51 PM, hok ivanvasi...@gmail.com wrote:


 Hello,
 I've noticed that the method
 AbstractSingleSelectChoice.getNoSelectionValue() returns the value for no
 selection. However in AbstractSingleSelectChoice.getDefaultChoice(final
 Object selected) on line 314:
  return \noption selected=\selected\ value=\\ + option +
 /option;

 and on line 296:
  buffer.append( value=\\).append(option).append(/option);

 In those cases the null value option has empty value attribute. Wouldn't it
 be more consistent for this option to have the value attribute with the
 result provided from getNoSelectionValue() ? I came into this while trying
 to use dojo FilteringSelect, which doesn't select the first option if
 it
 has empty value attribute.
 Thanks.
 --
 View this message in context:
 http://apache-wicket.1842946.n4.nabble.com/DropDownChoice-no-selection-value-tp3160661p3160661.html
 Sent from the Users forum mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




Re: DropDownChoice no selection value

2010-12-22 Thread hok

Issue created:
https://issues.apache.org/jira/browse/WICKET-3278
https://issues.apache.org/jira/browse/WICKET-3278 
-- 
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/DropDownChoice-no-selection-value-tp3160661p3160849.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org