Re: Invisible Page Notification?

2010-06-08 Thread Igor Vaynberg
log.warn would be annoying to people who are actually setting the
visibility to false

-igor

On Tue, Jun 8, 2010 at 8:40 AM, jbrookover jbrooko...@cast.org wrote:

 Hey all,

 I just had a long debugging session regarding the difference between these
 two lines in a WebPage:

 add(component).setVisible(getUser() != null); // Typo
 add(component.setVisible(getUser() != null));

 The first processes the page and very silently returns a completely empty
 Response object to the browser.  The second is what I meant to do, but the
 mistake was hard to discover.

 Per a post in 2006
 (http://apache-wicket.1842946.n4.nabble.com/Nice-stupid-thing-page-setVisible-false-td1898368.html),
 the decision was made regarding this behavior, but is setting a Page's
 visibility common enough to do so without warning?  Perhaps a log.warn?

 Thanks!

 Jake
 --
 View this message in context: 
 http://apache-wicket.1842946.n4.nabble.com/Invisible-Page-Notification-tp2247626p2247626.html
 Sent from the Wicket - User mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org



-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Invisible Page Notification?

2010-06-08 Thread jbrookover

That's why I'm wondering how common it is.  Based on that e-mail discussion
from 2006, a WicketRuntimeException was on the table, implying that a Page
object should never be invisible.  I guess a better question would be, what
are the reasons for making a page invisible?

Jake


Igor Vaynberg-2 wrote:
 
 log.warn would be annoying to people who are actually setting the
 visibility to false
 
 -igor
 

-- 
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/Invisible-Page-Notification-tp2247626p2247742.html
Sent from the Wicket - User mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Invisible Page Notification?

2010-06-08 Thread Thomas Matthijs
On Tue, Jun 8, 2010 at 7:28 PM, jbrookover jbrooko...@cast.org wrote:

 That's why I'm wondering how common it is.  Based on that e-mail discussion
 from 2006, a WicketRuntimeException was on the table, implying that a Page
 object should never be invisible.  I guess a better question would be, what
 are the reasons for making a page invisible?

I've spend a few hours trying to find what was wrong when i accidently
set the page invisible aswel, also would be interested to know what a
valid use case would be for that

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org