Re: Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
On 2020/04/10 08:13:40, Maxim Solodovnik wrote: > On Fri, 10 Apr 2020 at 15:06, Francesco Chicchiriccò > wrote: > > > On 2020/04/10 06:59:06, Sven Meier wrote: > > > Hi Francesco, > > > > > > there was a slight difference in the mock setup, which should now be as > > > in Wicket 8: > > > > > > https://issues.apache.org/jira/browse/WICKET-6766 > > > > > > Many thanks for testing with Wicket 9! > > > > Great spot Sven! > > > > Which is the SNAPSHOT version to try such a change? When the related > > artifact will be available? > > > > this is M6-SNAPSHOT > M5 was just released ... Thanks Maxim. By looking at Sven's commit I could simplify my workaround as https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L110-L120 Once 9.0.0-M6 will be out, I'll remove it. Thanks again! > > > On 09.04.20 16:42, Francesco Chicchiriccò wrote: > > > > On 2020/04/09 12:04:00, Sven Meier wrote: > > > >> Hi Francesco, > > > >> > > > >> I'll have to check what has changed here. > > > >> > > > >> I wouldn't expect any problems with MockPageStore, but perhaps it > > > >> changed slightly. > > > >> > > > >> Can you write a testcase that runs in Wicket 8 but fails in 9? > > > > Not sure if I am able, but I'll try. > > > > Meanwhile, should you get an enlightenment, please report. > > > > > > > > Regards. > > > > > > > >> On 09.04.20 12:20, Francesco Chicchiriccò wrote: > > > >>> Hi all, > > > >>> at Syncope we have been upgrading our Console and Enduser web > > applications from Wicket 8 to 9.0.0-M5, in our master branch. > > > >>> > > > >>> The process have been quite smooth effectively, with a single > > noticeable exception: in our tests we largely use WicketTester; we have > > verified, however, that Pages in the MockPageStore are incrementing their > > numericId during tests execution, even though they are still looked up by > > their initial numericId. > > > >>> > > > >>> We are using this workaround: > > > >>> > > > >>> > > https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 > > > >>> > > > >>> which is serving its purpose for the moment; please note that this > > was not needed with Wicket 8. > > > >>> > > > >>> Are we missing something or the one above is effectively a bug? > > > >>> > > > >>> Thanks for your support. > > > >>> Regards. > > > >>> > > > >>> - > > > >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > >>> For additional commands, e-mail: users-h...@wicket.apache.org > > > >>> > > > >> - > > > >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > >> For additional commands, e-mail: users-h...@wicket.apache.org > > > >> > > > >> > > > > - > > > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > > > > > > - > > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > > > > > > - > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > > -- > Best regards, > Maxim > - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
On Fri, 10 Apr 2020 at 15:06, Francesco Chicchiriccò wrote: > On 2020/04/10 06:59:06, Sven Meier wrote: > > Hi Francesco, > > > > there was a slight difference in the mock setup, which should now be as > > in Wicket 8: > > > > https://issues.apache.org/jira/browse/WICKET-6766 > > > > Many thanks for testing with Wicket 9! > > Great spot Sven! > > Which is the SNAPSHOT version to try such a change? When the related > artifact will be available? > this is M6-SNAPSHOT M5 was just released ... > > Regards. > > > On 09.04.20 16:42, Francesco Chicchiriccò wrote: > > > On 2020/04/09 12:04:00, Sven Meier wrote: > > >> Hi Francesco, > > >> > > >> I'll have to check what has changed here. > > >> > > >> I wouldn't expect any problems with MockPageStore, but perhaps it > > >> changed slightly. > > >> > > >> Can you write a testcase that runs in Wicket 8 but fails in 9? > > > Not sure if I am able, but I'll try. > > > Meanwhile, should you get an enlightenment, please report. > > > > > > Regards. > > > > > >> On 09.04.20 12:20, Francesco Chicchiriccò wrote: > > >>> Hi all, > > >>> at Syncope we have been upgrading our Console and Enduser web > applications from Wicket 8 to 9.0.0-M5, in our master branch. > > >>> > > >>> The process have been quite smooth effectively, with a single > noticeable exception: in our tests we largely use WicketTester; we have > verified, however, that Pages in the MockPageStore are incrementing their > numericId during tests execution, even though they are still looked up by > their initial numericId. > > >>> > > >>> We are using this workaround: > > >>> > > >>> > https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 > > >>> > > >>> which is serving its purpose for the moment; please note that this > was not needed with Wicket 8. > > >>> > > >>> Are we missing something or the one above is effectively a bug? > > >>> > > >>> Thanks for your support. > > >>> Regards. > > >>> > > >>> - > > >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > >>> For additional commands, e-mail: users-h...@wicket.apache.org > > >>> > > >> - > > >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > >> For additional commands, e-mail: users-h...@wicket.apache.org > > >> > > >> > > > - > > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > > > - > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > -- Best regards, Maxim
Re: Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
On 2020/04/10 06:59:06, Sven Meier wrote: > Hi Francesco, > > there was a slight difference in the mock setup, which should now be as > in Wicket 8: > > https://issues.apache.org/jira/browse/WICKET-6766 > > Many thanks for testing with Wicket 9! Great spot Sven! Which is the SNAPSHOT version to try such a change? When the related artifact will be available? Regards. > On 09.04.20 16:42, Francesco Chicchiriccò wrote: > > On 2020/04/09 12:04:00, Sven Meier wrote: > >> Hi Francesco, > >> > >> I'll have to check what has changed here. > >> > >> I wouldn't expect any problems with MockPageStore, but perhaps it > >> changed slightly. > >> > >> Can you write a testcase that runs in Wicket 8 but fails in 9? > > Not sure if I am able, but I'll try. > > Meanwhile, should you get an enlightenment, please report. > > > > Regards. > > > >> On 09.04.20 12:20, Francesco Chicchiriccò wrote: > >>> Hi all, > >>> at Syncope we have been upgrading our Console and Enduser web > >>> applications from Wicket 8 to 9.0.0-M5, in our master branch. > >>> > >>> The process have been quite smooth effectively, with a single noticeable > >>> exception: in our tests we largely use WicketTester; we have verified, > >>> however, that Pages in the MockPageStore are incrementing their numericId > >>> during tests execution, even though they are still looked up by their > >>> initial numericId. > >>> > >>> We are using this workaround: > >>> > >>> https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 > >>> > >>> which is serving its purpose for the moment; please note that this was > >>> not needed with Wicket 8. > >>> > >>> Are we missing something or the one above is effectively a bug? > >>> > >>> Thanks for your support. > >>> Regards. > >>> > >>> - > >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > >>> For additional commands, e-mail: users-h...@wicket.apache.org > >>> > >> - > >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > >> For additional commands, e-mail: users-h...@wicket.apache.org > >> > >> > > - > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
Hi Francesco, there was a slight difference in the mock setup, which should now be as in Wicket 8: https://issues.apache.org/jira/browse/WICKET-6766 Many thanks for testing with Wicket 9! Sven On 09.04.20 16:42, Francesco Chicchiriccò wrote: On 2020/04/09 12:04:00, Sven Meier wrote: Hi Francesco, I'll have to check what has changed here. I wouldn't expect any problems with MockPageStore, but perhaps it changed slightly. Can you write a testcase that runs in Wicket 8 but fails in 9? Not sure if I am able, but I'll try. Meanwhile, should you get an enlightenment, please report. Regards. On 09.04.20 12:20, Francesco Chicchiriccò wrote: Hi all, at Syncope we have been upgrading our Console and Enduser web applications from Wicket 8 to 9.0.0-M5, in our master branch. The process have been quite smooth effectively, with a single noticeable exception: in our tests we largely use WicketTester; we have verified, however, that Pages in the MockPageStore are incrementing their numericId during tests execution, even though they are still looked up by their initial numericId. We are using this workaround: https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 which is serving its purpose for the moment; please note that this was not needed with Wicket 8. Are we missing something or the one above is effectively a bug? Thanks for your support. Regards. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
On 2020/04/09 12:04:00, Sven Meier wrote: > Hi Francesco, > > I'll have to check what has changed here. > > I wouldn't expect any problems with MockPageStore, but perhaps it > changed slightly. > > Can you write a testcase that runs in Wicket 8 but fails in 9? Not sure if I am able, but I'll try. Meanwhile, should you get an enlightenment, please report. Regards. > On 09.04.20 12:20, Francesco Chicchiriccò wrote: > > Hi all, > > at Syncope we have been upgrading our Console and Enduser web applications > > from Wicket 8 to 9.0.0-M5, in our master branch. > > > > The process have been quite smooth effectively, with a single noticeable > > exception: in our tests we largely use WicketTester; we have verified, > > however, that Pages in the MockPageStore are incrementing their numericId > > during tests execution, even though they are still looked up by their > > initial numericId. > > > > We are using this workaround: > > > > https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 > > > > which is serving its purpose for the moment; please note that this was not > > needed with Wicket 8. > > > > Are we missing something or the one above is effectively a bug? > > > > Thanks for your support. > > Regards. > > > > - > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
On 2020/04/09 12:01:25, Martin Grigorov wrote: > It is not my day today! :-) > This is the second description of an issue here in users@ which I don't > understand. np Martin, I understand you completely :-) > I'll let someone else try to help you. > > On Thu, Apr 9, 2020 at 2:32 PM Francesco Chicchiriccò > wrote: > > > On 2020/04/09 10:58:13, Martin Grigorov wrote: > > > Hi, > > > > > > Why do you need to use PageManager ? > > > By default WicketTester uses MockPageManager without a backing PageStore. > > > > That was the simplest workaround I could find; for sure, without the > > workaround, e.g. with simple "new WicketTester()" I have the behavior > > described below. > > > > Regards. > > > > > On Thu, Apr 9, 2020 at 1:20 PM Francesco Chicchiriccò < > > ilgro...@apache.org> > > > wrote: > > > > > > > Hi all, > > > > at Syncope we have been upgrading our Console and Enduser web > > applications > > > > from Wicket 8 to 9.0.0-M5, in our master branch. > > > > > > > > The process have been quite smooth effectively, with a single > > noticeable > > > > exception: in our tests we largely use WicketTester; we have verified, > > > > however, that Pages in the MockPageStore are incrementing their > > numericId > > > > during tests execution, even though they are still looked up by their > > > > initial numericId. > > > > > > > > We are using this workaround: > > > > > > > > > > > > > > https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 > > > > > > > > which is serving its purpose for the moment; please note that this was > > not > > > > needed with Wicket 8. > > > > > > > > Are we missing something or the one above is effectively a bug? > > > > > > > > Thanks for your support. > > > > Regards. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
Hi Francesco, I'll have to check what has changed here. I wouldn't expect any problems with MockPageStore, but perhaps it changed slightly. Can you write a testcase that runs in Wicket 8 but fails in 9? Have fun Sven On 09.04.20 12:20, Francesco Chicchiriccò wrote: Hi all, at Syncope we have been upgrading our Console and Enduser web applications from Wicket 8 to 9.0.0-M5, in our master branch. The process have been quite smooth effectively, with a single noticeable exception: in our tests we largely use WicketTester; we have verified, however, that Pages in the MockPageStore are incrementing their numericId during tests execution, even though they are still looked up by their initial numericId. We are using this workaround: https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 which is serving its purpose for the moment; please note that this was not needed with Wicket 8. Are we missing something or the one above is effectively a bug? Thanks for your support. Regards. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
It is not my day today! :-) This is the second description of an issue here in users@ which I don't understand. I'll let someone else try to help you. On Thu, Apr 9, 2020 at 2:32 PM Francesco Chicchiriccò wrote: > On 2020/04/09 10:58:13, Martin Grigorov wrote: > > Hi, > > > > Why do you need to use PageManager ? > > By default WicketTester uses MockPageManager without a backing PageStore. > > That was the simplest workaround I could find; for sure, without the > workaround, e.g. with simple "new WicketTester()" I have the behavior > described below. > > Regards. > > > On Thu, Apr 9, 2020 at 1:20 PM Francesco Chicchiriccò < > ilgro...@apache.org> > > wrote: > > > > > Hi all, > > > at Syncope we have been upgrading our Console and Enduser web > applications > > > from Wicket 8 to 9.0.0-M5, in our master branch. > > > > > > The process have been quite smooth effectively, with a single > noticeable > > > exception: in our tests we largely use WicketTester; we have verified, > > > however, that Pages in the MockPageStore are incrementing their > numericId > > > during tests execution, even though they are still looked up by their > > > initial numericId. > > > > > > We are using this workaround: > > > > > > > > > > https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 > > > > > > which is serving its purpose for the moment; please note that this was > not > > > needed with Wicket 8. > > > > > > Are we missing something or the one above is effectively a bug? > > > > > > Thanks for your support. > > > Regards. > > > > > > - > > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > > > > > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
Re: Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
On 2020/04/09 10:58:13, Martin Grigorov wrote: > Hi, > > Why do you need to use PageManager ? > By default WicketTester uses MockPageManager without a backing PageStore. That was the simplest workaround I could find; for sure, without the workaround, e.g. with simple "new WicketTester()" I have the behavior described below. Regards. > On Thu, Apr 9, 2020 at 1:20 PM Francesco Chicchiriccò > wrote: > > > Hi all, > > at Syncope we have been upgrading our Console and Enduser web applications > > from Wicket 8 to 9.0.0-M5, in our master branch. > > > > The process have been quite smooth effectively, with a single noticeable > > exception: in our tests we largely use WicketTester; we have verified, > > however, that Pages in the MockPageStore are incrementing their numericId > > during tests execution, even though they are still looked up by their > > initial numericId. > > > > We are using this workaround: > > > > > > https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 > > > > which is serving its purpose for the moment; please note that this was not > > needed with Wicket 8. > > > > Are we missing something or the one above is effectively a bug? > > > > Thanks for your support. > > Regards. > > > > - > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
Hi, Why do you need to use PageManager ? By default WicketTester uses MockPageManager without a backing PageStore. On Thu, Apr 9, 2020 at 1:20 PM Francesco Chicchiriccò wrote: > Hi all, > at Syncope we have been upgrading our Console and Enduser web applications > from Wicket 8 to 9.0.0-M5, in our master branch. > > The process have been quite smooth effectively, with a single noticeable > exception: in our tests we largely use WicketTester; we have verified, > however, that Pages in the MockPageStore are incrementing their numericId > during tests execution, even though they are still looked up by their > initial numericId. > > We are using this workaround: > > > https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 > > which is serving its purpose for the moment; please note that this was not > needed with Wicket 8. > > Are we missing something or the one above is effectively a bug? > > Thanks for your support. > Regards. > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
Upgrade to Wicket 9: troubles with WicketTester and MockPageStore
Hi all, at Syncope we have been upgrading our Console and Enduser web applications from Wicket 8 to 9.0.0-M5, in our master branch. The process have been quite smooth effectively, with a single noticeable exception: in our tests we largely use WicketTester; we have verified, however, that Pages in the MockPageStore are incrementing their numericId during tests execution, even though they are still looked up by their initial numericId. We are using this workaround: https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/console/AbstractConsoleITCase.java#L107-L125 which is serving its purpose for the moment; please note that this was not needed with Wicket 8. Are we missing something or the one above is effectively a bug? Thanks for your support. Regards. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
