[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Comment #12 on issue 3345 by js...@chromium.org: i18n: Make break iterator use optional https://code.google.com/p/v8/issues/detail?id=3345 Thank you for the reminder. I've just uploaded a CL at https://codereview.chromium.org/902313002/. The patch has to be a bit changed because runtime.cc has changed since. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Updates: Status: PendingFurtherInfo Comment #11 on issue 3345 by habl...@chromium.org: i18n: Make break iterator use optional https://code.google.com/p/v8/issues/detail?id=3345 I have not found your CL. Have you submitted the code? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Comment #10 on issue 3345 by js...@chromium.org: i18n: Make break iterator use optional https://code.google.com/p/v8/issues/detail?id=3345 The patch should work. I'll submit it to the codereview. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Updates: Owner: c...@chromium.org Comment #9 on issue 3345 by joc...@chromium.org: i18n: Make break iterator use optional https://code.google.com/p/v8/issues/detail?id=3345 not sure, if we want to support it, it would require some work anyways -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Updates: Owner: joc...@chromium.org Comment #8 on issue 3345 by dslo...@chromium.org: i18n: Make break iterator use optional https://code.google.com/p/v8/issues/detail?id=3345 Are we still pursuing this? Please submit patches via V8 code review tools: https://code.google.com/p/v8/wiki/Contributing -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Comment #7 on issue 3345 by srl...@gmail.com: i18n: Make break iterator use optional http://code.google.com/p/v8/issues/detail?id=3345 To test this patch: * add "#define UCONFIG_NO_BREAK_ITERATION 1" to the top of ./third_party/icu/source/common/unicode/uconfig.h * build v8 * run "d8 btest402.js" ( from https://github.com/srl295/btest402 ) you will see "illegal access" for the disabled functions. But, v8 will build. Attachments: patch-3345.patch 4.7 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Comment #6 on issue 3345 by srl...@gmail.com: i18n: Make break iterator use optional http://code.google.com/p/v8/issues/detail?id=3345 I can separate out my patch and post it here against svn trunk, if you like. ICU already has config switches that say whether breakiter is available, this just uses those. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Comment #5 on issue 3345 by c...@chromium.org: i18n: Make break iterator use optional http://code.google.com/p/v8/issues/detail?id=3345 Break iterator is not part of the standard but it's part of Intl from day one (internal projects needed it). If embedders don't need it (Chrome does) we could let them cut it out. Jungshik would know better if the aforementioned approach would work with ICU. Break iterator is part of ES 402 v2.0 proposal but for now that is not moving so I wouldn't expect any updates from that front. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Updates: Cc: joc...@chromium.org Comment #4 on issue 3345 by joc...@chromium.org: i18n: Make break iterator use optional http://code.google.com/p/v8/issues/detail?id=3345 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Updates: Cc: c...@chromium.org js...@chromium.org Comment #3 on issue 3345 by joc...@chromium.org: i18n: Make break iterator use optional http://code.google.com/p/v8/issues/detail?id=3345 cira@, can you comment on this? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Comment #2 on issue 3345 by srl...@gmail.com: i18n: Make break iterator use optional http://code.google.com/p/v8/issues/detail?id=3345 space: about 1M of code (linux x86_64) and about 4M of data (which we can save without this change, but then the code is really dead) Intl object: break iteration isn't part of ES402, at least not yet. That's why this aspect is ripe for the picking in my mind. Was successful at doing this change in v8, will post diffs. Intl.v8BreakIterator.supportedLocalesOf("en") -> [] if disabled, ['en'] if enabled new Intl.v8BreakIterator("en").first() -> undefined if disabled, 0 if enabled. A tweak would be to make the 'new' return undefined or illegal or something. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional
Comment #1 on issue 3345 by pmue...@gmail.com: i18n: Make break iterator use optional http://code.google.com/p/v8/issues/detail?id=3345 Some questions: - how much space are we saving? - re: "notify .js side that no break iterators are available". Seems like the "Intl" object is the right place for this. Circle back to the Intl standard to get it in? How important is it that the .js side have this info available right now? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.