Re: [v8-users] Evaluate ES6-Module with undefined function

2020-07-30 Thread Hans Maier
Hi Ben,

the Status before evaluate is "kInstantiated" and after "kErrored", 
"--harmony_top_level_await" is not used.

I didn't check for the kErrored before, so I will just do that to get the 
old behaviour.

Thanks for the hint!

Am Mittwoch, 29. Juli 2020 12:41:06 UTC+2 schrieb Ben Noordhuis:
>
> On Wed, Jul 29, 2020 at 10:24 AM Hans Maier  > wrote: 
> > 
> > Hi, 
> > 
> > im upgrading from 8.0.426.26 to 8.4.371.22. 
> > 
> > I've a small test case where I evalute (using v8::Module::Evaluate) a 
> ES6-Module with the following content: 
> >  
> > hello(); 
> >  
> > 
> > In 8.0.x I get an exception: 
> > HelloWorld1.js:1:  
> > hello(); 
> > ^ 
> > ReferenceError: hello is not defined 
> > at HelloWorld1.js:1:1 
> > 
> > In 8.4.x there is no exception (it succeddes). 
> > 
> > It this expected? 
> > 
> > Thanks. 
>
> It depends. What does module->GetStatus() return before and after and 
> what does module->Evaluate() itself return? Do you set the 
> --harmony_top_level_await flag? 
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/v8-users/47d92380-fca6-4169-b00b-a4aba677a423o%40googlegroups.com.


[v8-users] Evaluate ES6-Module with undefined function

2020-07-29 Thread Hans Maier
Hi,

im upgrading from 8.0.426.26 to 8.4.371.22.

I've a small test case where I evalute (using v8::Module::Evaluate) a 
ES6-Module with the following content:

hello();


In 8.0.x I get an exception:
HelloWorld1.js:1: 
hello();
^
ReferenceError: hello is not defined
at HelloWorld1.js:1:1

In 8.4.x there is no exception (it succeddes).

It this expected?

Thanks.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/v8-users/f4bfa5c7-71a4-4b8e-ad30-c5d66db9700fo%40googlegroups.com.


[v8-users] Re: Compiling V8 8.4 on Windows using using_custom_libcxx=false

2020-07-28 Thread Hans Maier
With your patches and a patch for ICU (see attach.) I was able to build the 
version 8.4.

Thanks!

Am Montag, 27. Juli 2020 17:10:50 UTC+2 schrieb Rodrigo Hernandez:
>
> See the patches I posted on this thread 
> <https://groups.google.com/forum/#!topic/v8-users/TgJIIIWsy20>, you need 
> to add "-Wno-range-loop-construct" and maybe "-Wno-invalid-offsetof" to 
> your compilation flags if you're using clang.
> The patches are for the 8.3 branch head, but the changes needed are about 
> the same.
>
> On Monday, July 27, 2020 at 3:45:28 AM UTC-6, Hans Maier wrote:
>>
>> Hi,
>>
>> I'm trying to compile the branch head of 8.4 under windows using msvc.
>> Unfortunatly I get compile errors:
>>
>> ../../src/compiler/backend/register-allocator-verifier.cc(355,19): error: 
>> loop variable 'pair' creates a copy from type 'const std::pair> v8::internal::compiler::InstructionOperand, 
>> v8::internal::compiler::Assessment *>' [-Werror,-Wrange-loop-construct]
>>   for (const auto pair : map()) {
>>   ^
>> ../../src/compiler/backend/register-allocator-verifier.cc(355,8): note: 
>> use reference type 'const std::pair> v8::internal::compiler::InstructionOperand, 
>> v8::internal::compiler::Assessment *> &' to prevent copying
>>   for (const auto pair : map()) {
>>^
>>   &
>> 1 error generated.
>>
>> For complete log see attach
>>
>> Any ideas where the error comes from are appreciated,
>> thanks.
>>
>> >cl
>> Microsoft (R) C/C++-Optimierungscompiler Version 19.16.27042 für x86
>>
>> >git log -n 1
>> commit 483421e9549adbf4a65d54d43fbffb250a577e5c (HEAD, tag: 8.4.371.22, 
>> origin/8.4-lkgr, branch-heads/8.4)
>>
>>
>> >gn gen out/x64-win.release --args="is_debug=false target_cpu=\"x64\" 
>> v8_target_cpu=\"x64\" use_goma=false is_clang=true v8_static_library=false 
>> is_component_build=true use_custom_libcxx=false 
>> v8_untrusted_code_mitigations=true"
>>
>> >>ninja -C out/x64-win.release
>>
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/v8-users/6140a4f2-c879-475d-98a5-8aa0dc4a29cco%40googlegroups.com.
diff --git a/source/i18n/numrange_impl.h b/source/i18n/numrange_impl.h
index 8f4c8a40..182b747c 100644
--- a/source/i18n/numrange_impl.h
+++ b/source/i18n/numrange_impl.h
@@ -1,4 +1,4 @@
-// © 2018 and later: Unicode, Inc. and others.
+// © 2018 and later: Unicode, Inc. and others.
 // License & terms of use: http://www.unicode.org/copyright.html
 
 #include "unicode/utypes.h"
@@ -109,5 +109,7 @@ class NumberRangeFormatterImpl : public UMemory {
 } // namespace number
 U_NAMESPACE_END
 
+template struct U_I18N_API std::atomic< U_NAMESPACE_QUALIFIER number::impl::NumberRangeFormatterImpl*>;
+
 #endif //__SOURCE_NUMRANGE_TYPES_H__
 #endif /* #if !UCONFIG_NO_FORMATTING */
diff --git a/source/i18n/unicode/numberrangeformatter.h b/source/i18n/unicode/numberrangeformatter.h
index 4d436a76..cae4c655 100644
--- a/source/i18n/unicode/numberrangeformatter.h
+++ b/source/i18n/unicode/numberrangeformatter.h
@@ -1,4 +1,4 @@
-// © 2018 and later: Unicode, Inc. and others.
+// © 2018 and later: Unicode, Inc. and others.
 // License & terms of use: http://www.unicode.org/copyright.html
 
 #ifndef __NUMBERRANGEFORMATTER_H__
@@ -194,8 +194,6 @@ class NumberRangeFormatterImpl;
 } // namespace icu::number
 U_NAMESPACE_END
 
-template struct U_I18N_API std::atomic< U_NAMESPACE_QUALIFIER number::impl::NumberRangeFormatterImpl*>;
-
 U_NAMESPACE_BEGIN
 namespace number {  // icu::number
 #endif


[v8-users] Compiling V8 8.4 on Windows using using_custom_libcxx=false

2020-07-27 Thread Hans Maier
Hi,

I'm trying to compile the branch head of 8.4 under windows using msvc.
Unfortunatly I get compile errors:

../../src/compiler/backend/register-allocator-verifier.cc(355,19): error: 
loop variable 'pair' creates a copy from type 'const std::pair' [-Werror,-Wrange-loop-construct]
  for (const auto pair : map()) {
  ^
../../src/compiler/backend/register-allocator-verifier.cc(355,8): note: use 
reference type 'const std::pair &' to prevent copying
  for (const auto pair : map()) {
   ^
  &
1 error generated.

For complete log see attach

Any ideas where the error comes from are appreciated,
thanks.

>cl
Microsoft (R) C/C++-Optimierungscompiler Version 19.16.27042 für x86

>git log -n 1
commit 483421e9549adbf4a65d54d43fbffb250a577e5c (HEAD, tag: 8.4.371.22, 
origin/8.4-lkgr, branch-heads/8.4)


>gn gen out/x64-win.release --args="is_debug=false target_cpu=\"x64\" 
v8_target_cpu=\"x64\" use_goma=false is_clang=true v8_static_library=false 
is_component_build=true use_custom_libcxx=false 
v8_untrusted_code_mitigations=true"

>>ninja -C out/x64-win.release

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/v8-users/e61db0c0-4856-4eff-b3b2-b189d1bef8b3o%40googlegroups.com.
ninja: Entering directory `out/x64-win.release'
[1/1540] CXX obj/v8_compiler_opt/opcodes.obj
[2/1540] CXX obj/v8_compiler/register-allocator-verifier.obj
FAILED: obj/v8_compiler/register-allocator-verifier.obj 
..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.exe /nologo 
/showIncludes:user "-imsvcC:\Program Files (x86)\Microsoft Visual 
Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\ATLMFC\include" 
"-imsvcC:\Program Files (x86)\Microsoft Visual 
Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include" "-imsvcC:\Program 
Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" "-imsvcC:\Program Files 
(x86)\Windows Kits\10\include\10.0.19041.0\ucrt" "-imsvcC:\Program Files 
(x86)\Windows Kits\10\include\10.0.19041.0\shared" "-imsvcC:\Program Files 
(x86)\Windows Kits\10\include\10.0.19041.0\um" "-imsvcC:\Program Files 
(x86)\Windows Kits\10\include\10.0.19041.0\winrt" "-imsvcC:\Program Files 
(x86)\Windows Kits\10\include\10.0.19041.0\cppwinrt" "-imsvcC:\Program Files 
(x86)\Microsoft Visual 
Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\ATLMFC\include" 
"-imsvcC:\Program Files (x86)\Microsoft Visual 
Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include" "-imsvcC:\Program 
Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" "-imsvcC:\Program Files 
(x86)\Windows Kits\10\include\10.0.19041.0\ucrt" "-imsvcC:\Program Files 
(x86)\Windows Kits\10\include\10.0.19041.0\shared" "-imsvcC:\Program Files 
(x86)\Windows Kits\10\include\10.0.19041.0\um" "-imsvcC:\Program Files 
(x86)\Windows Kits\10\include\10.0.19041.0\winrt" "-imsvcC:\Program Files 
(x86)\Windows Kits\10\include\10.0.19041.0\cppwinrt" -DUSE_AURA=1 
"-DCR_CLANG_REVISION=\"n346557-4e0d9925-3\"" -D_HAS_NODISCARD 
-D_HAS_EXCEPTIONS=0 -DCOMPONENT_BUILD -D__STD_C -D_CRT_RAND_S 
-D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL 
-D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=2 -DWIN32 
-D_SECURE_ATL -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN 
-DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=NTDDI_WIN10_RS2 
-D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND 
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 
-DENABLE_MINOR_MC -DV8_INTL_SUPPORT -DV8_USE_EXTERNAL_STARTUP_DATA 
-DV8_CONCURRENT_MARKING -DV8_ARRAY_BUFFER_EXTENSION 
-DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_WIN64_UNWINDING_INFO 
-DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_SNAPSHOT_COMPRESSION 
-DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_DEPRECATION_WARNINGS 
-DV8_IMMINENT_DEPRECATION_WARNINGS -DV8_TARGET_ARCH_X64 -DV8_HAVE_TARGET_OS 
-DV8_TARGET_OS_WIN -DBUILDING_V8_SHARED -DV8_COMPRESS_POINTERS 
-DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_DEPRECATION_WARNINGS 
-DV8_IMMINENT_DEPRECATION_WARNINGS -DU_USING_ICU_NAMESPACE=0 
-DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 
-DU_ENABLE_RESOURCE_TRACING=0 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE 
-DUCHAR_TYPE=wchar_t -I../.. -Igen -I../.. -I../../include -Igen 
-I../../third_party/icu/source/common -I../../third_party/icu/source/i18n 
-fcolor-diagnostics -fmerge-all-constants 
-fcrash-diagnostics-dir=../../tools/clang/crashreports -Xclang -mllvm -Xclang 
-instcombine-lower-dbg-declare=0 -fcomplete-member-pointers /Gy /FS /bigobj 
/utf-8 /Zc:twoPhase /Zc:sizedDealloc- /X -fmsc-version=1916 /guard:cf,nochecks 
/Zc:dllexportInlines- -m64 /Brepro -Wno-builtin-macro-redefined -D__DAT

Re: [v8-users] Is "is_component_build" expected to work at all in v8 7.8?

2019-11-03 Thread Hans Maier
Hi,

the libc provided together with v8 is incompatible with the msvc-libc.
I had to provide "use_custom_libcxx=false" to be able to link it with my 
own program.


Am Sonntag, 3. November 2019 12:43:57 UTC+1 schrieb Ben Ernst:
>
> Of note, the sample utilities "d8" and "v8_hello_world" build fine, and 
> they don't get this same linker error. I can't see anything I'm doing 
> differently, however.
>
> On Sunday, 3 November 2019 22:08:27 UTC+10:30, Ben Ernst wrote:
>>
>> Thanks Jakob, is there by any chance a correpsonding buildbot for Windows 
>> and MSVC++? I get this linker error from it seems V8 7.2 onwards, although 
>> I'm focussing on 7.8. The "monolith" build seems to be working though. I 
>> wonder if it's an MSVC++ peculiarity that is tripping me up?
>> Regards,
>> Ben
>>
>> On Saturday, 2 November 2019 02:17:38 UTC+10:30, Jakob Kummerow wrote:
>>>
>>> Yes, the component build is expected to work for every version, and our 
>>> buildbot thinks it does: 
>>> https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20shared
>>>
>>> The component build is also the default in Debug mode, which most V8 
>>> developers compile/use every day.
>>>
>>>
>>> On Fri, Nov 1, 2019 at 1:00 AM Ben Ernst  wrote:
>>>
 Is the idea of a "component build", where you specify 
 "is_component_build=true" in the arguments to GN, actually supposed to 
 work 
 at all in V8 (v7.8)?

 In particular, I am getting this unresolved external symbol:

 1>ezv8_platform.obj : error LNK2019: unresolved external symbol 
 "__declspec(dllimport) class std::unique_ptr>>> std::default_delete > __cdecl 
 v8::platform::NewDefaultPlatform(int,enum 
 v8::platform::IdleTaskSupport,enum 
 v8::platform::InProcessStackDumping,class std::unique_ptr>>> v8::TracingController,struct std::default_delete>>> v8::TracingController> >)" 
 (__imp_?NewDefaultPlatform@platform@v8@@YA?AV?$unique_ptr@VPlatform@v8@@U?$default_delete@VPlatform@v8@@@std@@@std@@HW4IdleTaskSupport@12@W4InProcessStackDumping@12@V?$unique_ptr@VTracingController@v8@@U?$default_delete@VTracingController@v8@@@std@@@4@@Z)
  
 referenced in function "public: __cdecl ezv8::Platform::Impl::Impl(void)" 
 (??0Impl@Platform@ezv8@@QEAA@XZ)

 The function "NewDefaultPlatform" seems to be exported from 
 v8_libplatform.

 V8_PLATFORM_EXPORT std::unique_ptr NewDefaultPlatform(
 int thread_pool_size = 0,
 IdleTaskSupport idle_task_support = IdleTaskSupport::kDisabled,
 InProcessStackDumping in_process_stack_dumping =
 InProcessStackDumping::kDisabled,
 std::unique_ptr tracing_controller = {});

 But the destructor of the base class, v8::Platform is not exported.

 /**
  * V8 Platform abstraction layer.
  *
  * The embedder has to provide an implementation of this interface 
 before
  * initializing the rest of V8.
  */
 class Platform {
  public:
   virtual ~Platform() = default;


 I think that's the cause of the error above, although I may have 
 misinterpreted the error message.

 Am I barking up the wrong tree by trying to use the component build at 
 all?

 Thanks in advance for any advice.





-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/v8-users/90d39cd7-0fc1-4730-9da9-9e0cc37bca3c%40googlegroups.com.


Re: [v8-users] Re: Building with MSVC & GN - Where do the static files go?

2017-06-26 Thread Hans Maier
I just tried it with 5.9.211.38 under Windows with VS2015 and the following 
args:
is_debug = false
target_cpu = "x64"
v8_static_library = true
is_component_build = false

Result: *No LIB files*

Doing the same as component build
is_debug = false
target_cpu = "x64"
v8_static_library = true
is_component_build = true

Result: DLL and LIB files are generated, but *unresolved externals in D8 
regarding v8 inspector*.

Unfortunately I want LIB files and v8 inspector.

What debug build everything works fine, the issue exists only in Release 
builds.

What to do?

Thanks 

On Monday, February 20, 2017 at 5:13:55 PM UTC+1, Brendan Bates wrote:
>
> Just tried this again in Win32 beta (5.7.492.44) it seems to work fine on 
> a shared component build.  However, when I add the static library flag it 
> doesn't seem to output anything useful unfortunately.  The DLL's are fine 
> for now, I'm honestly just happy that I can get it building using GN with 
> the latest versions.
>
> On Wednesday, January 11, 2017 at 4:53:09 AM UTC-5, Hans Maier wrote:
>>
>> Ok, thanks for the Info. I will be using it as soon 5.7 becomes stable.
>>
>> Am Mittwoch, 11. Januar 2017 10:46:05 UTC+1 schrieb Jochen Eisinger:
>>>
>>> With the latest dev version of V8 (5.7), you should be able to get 
>>> static libraries using the gn flag v8_static_library = true
>>>
>>> On Tue, Jan 10, 2017 at 4:26 PM Hans Maier  wrote:
>>>
>>>> Hi,
>>>>
>>>> I had the same issue. I ended up creating the static libs from the 
>>>> obj-files using the MSVC lib tool manually.
>>>>
>>>> Unsatisfactory, but it was working for me.
>>>>
>>>> Am Montag, 9. Januar 2017 15:55:40 UTC+1 schrieb Brendan Bates:
>>>>>
>>>>> Hello,
>>>>>
>>>>> I have seen this issue pop up a couple times on here and wondering 
>>>>> what the current status is.  I was spending the morning trying to get 
>>>>> ahead 
>>>>> of the game and switch from a Gyp build to a GN build.  We are using MSVC 
>>>>> 2015 to perform the build.  I am successfully configuring and building 
>>>>> using the following commands:
>>>>>
>>>>> > gn gen out/x86.debug --args="is_debug=true v8_use_snapshot=false 
>>>>> target_cpu=\"x86\" disable_libfuzzer=true"
>>>>> Done. Made78 targets from 44 files in 1900ms
>>>>>
>>>>> > ninja-C out/x86.debug d8
>>>>> ninja: Entering directory `out.gn/x86.debug'
>>>>> [49/886] LINK mkpeephole.exe mkpeephole.exe.pdb
>>>>> LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/OPT:ICF' 
>>>>> specification
>>>>> [886/886] LINK d8.exe d8.exe.pdb
>>>>> LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/OPT:ICF' 
>>>>> specification
>>>>>
>>>>> The build results are confusing, however.  In the "out" directory, I 
>>>>> find the v8.dll, along with the icu*.dll files.  What seems to be missing 
>>>>> are the static .lib files that were necessary in previous builds 
>>>>> (v8_libbase.lib, v8_libplatform.lib and v8_nosnapshot.lib).  My build 
>>>>> with 
>>>>> new new v8 DLL does not seem to work without these.  So I attempted a 
>>>>> static build, by adding the GN argument `is_component_build=false`.  To 
>>>>> my 
>>>>> surprise, no static libraries were generated at all!  Is this something 
>>>>> that is planning on being supported in the future?  If not, what is the 
>>>>> way 
>>>>> around this?  I certainly don't want to transition my project to use GN.  
>>>>> Thoughts?  Thanks in advance.
>>>>>
>>>> -- 
>>>> -- 
>>>> v8-users mailing list
>>>> v8-u...@googlegroups.com
>>>> http://groups.google.com/group/v8-users
>>>> --- 
>>>> You received this message because you are subscribed to the Google 
>>>> Groups "v8-users" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send 
>>>> an email to v8-users+u...@googlegroups.com.
>>>> For more options, visit https://groups.google.com/d/optout.
>>>>
>>>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [v8-users] Re: Building with MSVC & GN - Where do the static files go?

2017-01-11 Thread Hans Maier
Ok, thanks for the Info. I will be using it as soon 5.7 becomes stable.

Am Mittwoch, 11. Januar 2017 10:46:05 UTC+1 schrieb Jochen Eisinger:
>
> With the latest dev version of V8 (5.7), you should be able to get static 
> libraries using the gn flag v8_static_library = true
>
> On Tue, Jan 10, 2017 at 4:26 PM Hans Maier  > wrote:
>
>> Hi,
>>
>> I had the same issue. I ended up creating the static libs from the 
>> obj-files using the MSVC lib tool manually.
>>
>> Unsatisfactory, but it was working for me.
>>
>> Am Montag, 9. Januar 2017 15:55:40 UTC+1 schrieb Brendan Bates:
>>>
>>> Hello,
>>>
>>> I have seen this issue pop up a couple times on here and wondering what 
>>> the current status is.  I was spending the morning trying to get ahead of 
>>> the game and switch from a Gyp build to a GN build.  We are using MSVC 2015 
>>> to perform the build.  I am successfully configuring and building using the 
>>> following commands:
>>>
>>> > gn gen out/x86.debug --args="is_debug=true v8_use_snapshot=false 
>>> target_cpu=\"x86\" disable_libfuzzer=true"
>>> Done. Made78 targets from 44 files in 1900ms
>>>
>>> > ninja-C out/x86.debug d8
>>> ninja: Entering directory `out.gn/x86.debug'
>>> [49/886] LINK mkpeephole.exe mkpeephole.exe.pdb
>>> LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/OPT:ICF' 
>>> specification
>>> [886/886] LINK d8.exe d8.exe.pdb
>>> LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/OPT:ICF' 
>>> specification
>>>
>>> The build results are confusing, however.  In the "out" directory, I 
>>> find the v8.dll, along with the icu*.dll files.  What seems to be missing 
>>> are the static .lib files that were necessary in previous builds 
>>> (v8_libbase.lib, v8_libplatform.lib and v8_nosnapshot.lib).  My build with 
>>> new new v8 DLL does not seem to work without these.  So I attempted a 
>>> static build, by adding the GN argument `is_component_build=false`.  To my 
>>> surprise, no static libraries were generated at all!  Is this something 
>>> that is planning on being supported in the future?  If not, what is the way 
>>> around this?  I certainly don't want to transition my project to use GN.  
>>> Thoughts?  Thanks in advance.
>>>
>> -- 
>> -- 
>> v8-users mailing list
>> v8-u...@googlegroups.com 
>> http://groups.google.com/group/v8-users
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "v8-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to v8-users+u...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[v8-users] Re: Building with MSVC & GN - Where do the static files go?

2017-01-10 Thread Hans Maier
Hi,

I had the same issue. I ended up creating the static libs from the 
obj-files using the MSVC lib tool manually.

Unsatisfactory, but it was working for me.

Am Montag, 9. Januar 2017 15:55:40 UTC+1 schrieb Brendan Bates:
>
> Hello,
>
> I have seen this issue pop up a couple times on here and wondering what 
> the current status is.  I was spending the morning trying to get ahead of 
> the game and switch from a Gyp build to a GN build.  We are using MSVC 2015 
> to perform the build.  I am successfully configuring and building using the 
> following commands:
>
> > gn gen out/x86.debug --args="is_debug=true v8_use_snapshot=false 
> target_cpu=\"x86\" disable_libfuzzer=true"
> Done. Made78 targets from 44 files in 1900ms
>
> > ninja-C out/x86.debug d8
> ninja: Entering directory `out.gn/x86.debug'
> [49/886] LINK mkpeephole.exe mkpeephole.exe.pdb
> LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/OPT:ICF' 
> specification
> [886/886] LINK d8.exe d8.exe.pdb
> LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/OPT:ICF' 
> specification
>
> The build results are confusing, however.  In the "out" directory, I find 
> the v8.dll, along with the icu*.dll files.  What seems to be missing are 
> the static .lib files that were necessary in previous builds 
> (v8_libbase.lib, v8_libplatform.lib and v8_nosnapshot.lib).  My build with 
> new new v8 DLL does not seem to work without these.  So I attempted a 
> static build, by adding the GN argument `is_component_build=false`.  To my 
> surprise, no static libraries were generated at all!  Is this something 
> that is planning on being supported in the future?  If not, what is the way 
> around this?  I certainly don't want to transition my project to use GN. 
>  Thoughts?  Thanks in advance.
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.