Re: [vbox-dev] [PATCH resend] VBoxGuest.h Fix VBGL_IOCTL_WAIT_FOR_EVENTS definition

2017-10-04 Thread Michael Thayer 
03.10.2017 15:34, Michael Thayer wrote:
> Hello Hans,
> 
> Terribly sorry.  I admit that I never got round to looking at this, but
> it does looks very sensible.  Just doing a sanity build now before I
> push it to our internal repository, and I will make it publicly visible
> as soon after that as I have a stable Internet connection.

https://www.virtualbox.org/changeset/68963/vbox

Regards
Michael

> 
> Regards
> Michael
>
> 03.10.2017 09:50, Hans de Goede wrote:
>> The size argument to VBGL_IOCTL_CODE_SIZE should be
>> VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE. This fixes VBGL_IOCTL_WAIT_FOR_EVENTS
>> always failing with EINVAL. Which in turn fixes seamless mode not
>> working under Linux.
>>
>> Signed-off-by: Hans de Goede 
>> ---
>>  include/VBox/VBoxGuest.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/VBox/VBoxGuest.h b/include/VBox/VBoxGuest.h
>> index 28313e4e..9283a15d 100644
>> --- a/include/VBox/VBoxGuest.h
>> +++ b/include/VBox/VBoxGuest.h
>> @@ -387,7 +387,7 @@ typedef struct VBGLIOCLOG
>>   * Wait for a VMMDev host event notification.
>>   * @{
>>   */
>> -#define VBGL_IOCTL_WAIT_FOR_EVENTS  
>> VBGL_IOCTL_CODE_SIZE(10, VBGL_IOCTL_GET_VMMDEV_IO_INFO_SIZE)
>> +#define VBGL_IOCTL_WAIT_FOR_EVENTS  
>> VBGL_IOCTL_CODE_SIZE(10, VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE)
>>  #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE 
>> sizeof(VBGLIOCWAITFOREVENTS)
>>  #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE_IN  
>> sizeof(VBGLIOCWAITFOREVENTS)
>>  #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE_OUT 
>> RT_UOFFSET_AFTER(VBGLIOCWAITFOREVENTS, u.Out)
>>
> 

-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] [PATCH resend] VBoxGuest.h Fix VBGL_IOCTL_WAIT_FOR_EVENTS definition

2017-10-03 Thread Michael Thayer 
Hello Hans,

Terribly sorry.  I admit that I never got round to looking at this, but
it does looks very sensible.  Just doing a sanity build now before I
push it to our internal repository, and I will make it publicly visible
as soon after that as I have a stable Internet connection.

Regards
Michael

03.10.2017 09:50, Hans de Goede wrote:
> The size argument to VBGL_IOCTL_CODE_SIZE should be
> VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE. This fixes VBGL_IOCTL_WAIT_FOR_EVENTS
> always failing with EINVAL. Which in turn fixes seamless mode not
> working under Linux.
> 
> Signed-off-by: Hans de Goede 
> ---
>  include/VBox/VBoxGuest.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/VBox/VBoxGuest.h b/include/VBox/VBoxGuest.h
> index 28313e4e..9283a15d 100644
> --- a/include/VBox/VBoxGuest.h
> +++ b/include/VBox/VBoxGuest.h
> @@ -387,7 +387,7 @@ typedef struct VBGLIOCLOG
>   * Wait for a VMMDev host event notification.
>   * @{
>   */
> -#define VBGL_IOCTL_WAIT_FOR_EVENTS  VBGL_IOCTL_CODE_SIZE(10, 
> VBGL_IOCTL_GET_VMMDEV_IO_INFO_SIZE)
> +#define VBGL_IOCTL_WAIT_FOR_EVENTS  VBGL_IOCTL_CODE_SIZE(10, 
> VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE)
>  #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE 
> sizeof(VBGLIOCWAITFOREVENTS)
>  #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE_IN  
> sizeof(VBGLIOCWAITFOREVENTS)
>  #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE_OUT 
> RT_UOFFSET_AFTER(VBGLIOCWAITFOREVENTS, u.Out)
> 

-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

[vbox-dev] [PATCH resend] VBoxGuest.h Fix VBGL_IOCTL_WAIT_FOR_EVENTS definition

2017-10-03 Thread Hans de Goede 
The size argument to VBGL_IOCTL_CODE_SIZE should be
VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE. This fixes VBGL_IOCTL_WAIT_FOR_EVENTS
always failing with EINVAL. Which in turn fixes seamless mode not
working under Linux.

Signed-off-by: Hans de Goede 
---
 include/VBox/VBoxGuest.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/VBox/VBoxGuest.h b/include/VBox/VBoxGuest.h
index 28313e4e..9283a15d 100644
--- a/include/VBox/VBoxGuest.h
+++ b/include/VBox/VBoxGuest.h
@@ -387,7 +387,7 @@ typedef struct VBGLIOCLOG
  * Wait for a VMMDev host event notification.
  * @{
  */
-#define VBGL_IOCTL_WAIT_FOR_EVENTS  VBGL_IOCTL_CODE_SIZE(10, 
VBGL_IOCTL_GET_VMMDEV_IO_INFO_SIZE)
+#define VBGL_IOCTL_WAIT_FOR_EVENTS  VBGL_IOCTL_CODE_SIZE(10, 
VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE)
 #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE 
sizeof(VBGLIOCWAITFOREVENTS)
 #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE_IN  
sizeof(VBGLIOCWAITFOREVENTS)
 #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE_OUT 
RT_UOFFSET_AFTER(VBGLIOCWAITFOREVENTS, u.Out)
-- 
2.14.2

___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev