Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Gianfranco Costamagna]

Hello,

>For what it is worth:
>https://www.virtualbox.org/changeset/69083/vbox


I think I need an iso file, and to clean up the artful machine from my kernel.

I don't want to custom tweak the iso image to include that changeset, 
remembering/intercepting
the build process might be time consuming, this is why I'm waiting for the next 
drop
(I could import the RC into my debian packaging and use dkms, but I prefer to 
stick with
the official iso image until the 5.2.* is released and then package it)

G.



16.10.2017 08:38, Gianfranco Costamagna wrote:
> Hello Michael,
> 
>> Hans was faster than me.  Here is the same fix against our internal tree
>> in case you are interested in sanity testing that.
> 
> 
> the kernel one worked in Ubuntu too, and on the next RC I'll be happy to test 
> your one!
> 
> G.
> 

-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Michael Thayer]

Hello Both,

For what it is worth:

https://www.virtualbox.org/changeset/69083/vbox

Regards
Michael

16.10.2017 08:38, Gianfranco Costamagna wrote:
> Hello Michael,
> 
>> Hans was faster than me.  Here is the same fix against our internal tree
>> in case you are interested in sanity testing that.
> 
> 
> the kernel one worked in Ubuntu too, and on the next RC I'll be happy to test 
> your one!
> 
> G.
> 

-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Gianfranco Costamagna]

Hello Michael,

>Hans was faster than me.  Here is the same fix against our internal tree
>in case you are interested in sanity testing that.


the kernel one worked in Ubuntu too, and on the next RC I'll be happy to test 
your one!

G.
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Michael Thayer]

Hello Both,

12.10.2017 22:53, Gianfranco Costamagna wrote:
> Hello,
> 
>> Attached is a fix, which I've already submitted for inclusion into the
>> mainline kernel. I believe this fix should also be applied to the VirtualBox
>> 5.2 Guest Additions version of the driver too, as the bug seems to originally
> 
>> come from there and to be present there too.
> 
> I'm already building an Ubuntu kernel, will test it tomorrow and report back!
> 
> thanks a lot,

Hans was faster than me.  Here is the same fix against our internal tree
in case you are interested in sanity testing that.

Regards
Michael
-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
Index: src/VBox/Additions/linux/drm/vbox_drv.h
===
--- src/VBox/Additions/linux/drm/vbox_drv.h	(revision 118326)
+++ src/VBox/Additions/linux/drm/vbox_drv.h	(working copy)
@@ -178,8 +178,8 @@
 	char name[32];
 	struct vbox_crtc *vbox_crtc;
 	struct {
-		u16 width;
-		u16 height;
+		u32 width;
+		u32 height;
 		bool disconnected;
 	} mode_hint;
 };
@@ -191,8 +191,8 @@
 	unsigned int crtc_id;
 	u32 fb_offset;
 	bool cursor_enabled;
-	u16 x_hint;
-	u16 y_hint;
+	u32 x_hint;
+	u32 y_hint;
 };
 
 struct vbox_encoder {
Index: src/VBox/Additions/linux/drm/vbox_irq.c
===
--- src/VBox/Additions/linux/drm/vbox_irq.c	(revision 118326)
+++ src/VBox/Additions/linux/drm/vbox_irq.c	(working copy)
@@ -160,8 +160,8 @@
 			flags = VBVA_SCREEN_F_ACTIVE
 			| (disconnected ? VBVA_SCREEN_F_DISABLED :
 			   VBVA_SCREEN_F_BLANK);
-			vbox_connector->mode_hint.width = hints->cx & 0x8fff;
-			vbox_connector->mode_hint.height = hints->cy & 0x8fff;
+			vbox_connector->mode_hint.width = hints->cx;
+			vbox_connector->mode_hint.height = hints->cy;
 			vbox_connector->vbox_crtc->x_hint = hints->dx;
 			vbox_connector->vbox_crtc->y_hint = hints->dy;
 			vbox_connector->mode_hint.disconnected = disconnected;
Index: src/VBox/Additions/linux/drm/vbox_mode.c
===
--- src/VBox/Additions/linux/drm/vbox_mode.c	(revision 118326)
+++ src/VBox/Additions/linux/drm/vbox_mode.c	(working copy)
@@ -592,13 +592,23 @@
 		++num_modes;
 	}
 	vbox_set_edid(connector, preferred_width, preferred_height);
+
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 19, 0) || defined(RHEL_73)
-	drm_object_property_set_value(
-		>base, vbox->dev->mode_config.suggested_x_property,
-		vbox_connector->vbox_crtc->x_hint);
-	drm_object_property_set_value(
-		>base, vbox->dev->mode_config.suggested_y_property,
-		vbox_connector->vbox_crtc->y_hint);
+	if (vbox_connector->vbox_crtc->x_hint != -1)
+		drm_object_property_set_value(>base,
+			vbox->dev->mode_config.suggested_x_property,
+			vbox_connector->vbox_crtc->x_hint);
+	else
+		drm_object_property_set_value(>base,
+			vbox->dev->mode_config.suggested_x_property, 0);
+
+	if (vbox_connector->vbox_crtc->y_hint != -1)
+		drm_object_property_set_value(>base,
+			vbox->dev->mode_config.suggested_y_property,
+			vbox_connector->vbox_crtc->y_hint);
+	else
+		drm_object_property_set_value(>base,
+			vbox->dev->mode_config.suggested_y_property, 0);
 #endif
 
 	return num_modes;
@@ -690,9 +700,9 @@
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 19, 0) || defined(RHEL_73)
 	drm_mode_create_suggested_offset_properties(dev);
 	drm_object_attach_property(>base,
-   dev->mode_config.suggested_x_property, -1);
+   dev->mode_config.suggested_x_property, 0);
 	drm_object_attach_property(>base,
-   dev->mode_config.suggested_y_property, -1);
+   dev->mode_config.suggested_y_property, 0);
 #endif
 #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0) && !defined(RHEL_73)
 	drm_sysfs_connector_add(connector);
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Gianfranco Costamagna]

Hello,

>Attached is a fix, which I've already submitted for inclusion into the
>mainline kernel. I believe this fix should also be applied to the VirtualBox
>5.2 Guest Additions version of the driver too, as the bug seems to originally

>come from there and to be present there too.

I'm already building an Ubuntu kernel, will test it tomorrow and report back!

thanks a lot,

Gianfranco
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Hans de Goede]

HI,

On 12-10-17 14:44, Hans de Goede wrote:

Hi,

On 12-10-17 11:17, Michael Thayer wrote:

Hello Both,

11.10.2017 17:41, Hans de Goede wrote:

Hi,

On 11-10-17 07:26, Michael Thayer wrote:

Hello Gianfranco,

02.10.2017 12:11, Gianfranco Costamagna wrote:

Thanks for the heads-up.  I am gradually adjusting our in-tree code to
match vboxvideo in staging, so at some point, when things stop turning
up to stop me, I will probably hit the crucial difference.  Gianfranco,
if you have time could you please give the Additions from the next beta
release a try, when it is available, since I have already started the
process?  I would be very grateful if you could.  I will too of course
when I find a moment, moments are just in short supply.



RC1 is now broken too

I haven't taken a look at the in-kernel version, but in RC1 the reason
was that the arguments to out*() calls got swapped: the Linux kernel
reverses them compared to everyone else I know of, and I failed to do
that during clean-up to match kernel style.  Will be committing soon.


Ok, so I double checked and this is not the same problem as people using
the driver from the upstream kernel's driver/staging are seeing, the
outl/w/b operands there are all in the right order.


That does not surprise me greatly.  The question is who if anyone will
instrument the staging version with printk commands to see what is going
wrong.  Hans, if you can answer without wasting time researching, can
you think of a simple way to send printk output straight to the
VirtualBox debug I/O port?  That could be simpler than setting up a
virtual serial port.  (I wonder how much work it would be to send
virtual serial port output straight to the log file...)  I do not
immediately plan to do the instrumentation - it is lower priority for me
than getting our code in a state to be submitted to the kernel, and that
is already going slowly enough.





But I've just managed to reproduce this using F27 / gnome-shell 3.26,
so I'm looking into a fix now.


Attached is a fix, which I've already submitted for inclusion into the
mainline kernel. I believe this fix should also be applied to the VirtualBox
5.2 Guest Additions version of the driver too, as the bug seems to originally
come from there and to be present there too.

>From 3b40f521aa2f42862203497a94ae77536f41ade2 Mon Sep 17 00:00:00 2001
From: Hans de Goede 
Date: Thu, 12 Oct 2017 19:44:48 +0200
Subject: [PATCH] staging: vboxvideo: Fix reporting invalid
 suggested-offset-properties

The x and y hints receives from the host are unsigned 32 bit integers and
they get set to -1 (0x) when invalid. Before this commit the
vboxvideo driver was storing them in an u16 causing the -1 to be truncated
to 65535 which, once reported to userspace, was breaking gnome 3.26+
in Wayland mode.

This commit stores the host values in 32 bit variables, removing the
truncation and checks for -1, replacing it with 0 as -1 is not a valid
suggested-offset-property value. Likewise the properties are now
initialized to 0 instead of -1, since -1 is not a valid value.
This fixes gnome 3.26+ in Wayland mode not working with the vboxvideo
driver.

Reported-by: Gianfranco Costamagna 
Cc: sta...@vger.kernel.org
Cc: Michael Thayer 
Signed-off-by: Hans de Goede 
---
 drivers/staging/vboxvideo/vbox_drv.h  |  8 
 drivers/staging/vboxvideo/vbox_irq.c  |  4 ++--
 drivers/staging/vboxvideo/vbox_mode.c | 26 ++
 3 files changed, 24 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/vboxvideo/vbox_drv.h b/drivers/staging/vboxvideo/vbox_drv.h
index 4b9302703b36..eeac4f0cb2c6 100644
--- a/drivers/staging/vboxvideo/vbox_drv.h
+++ b/drivers/staging/vboxvideo/vbox_drv.h
@@ -137,8 +137,8 @@ struct vbox_connector {
 	char name[32];
 	struct vbox_crtc *vbox_crtc;
 	struct {
-		u16 width;
-		u16 height;
+		u32 width;
+		u32 height;
 		bool disconnected;
 	} mode_hint;
 };
@@ -150,8 +150,8 @@ struct vbox_crtc {
 	unsigned int crtc_id;
 	u32 fb_offset;
 	bool cursor_enabled;
-	u16 x_hint;
-	u16 y_hint;
+	u32 x_hint;
+	u32 y_hint;
 };
 
 struct vbox_encoder {
diff --git a/drivers/staging/vboxvideo/vbox_irq.c b/drivers/staging/vboxvideo/vbox_irq.c
index 3ca8bec62ac4..74abdf02d9fd 100644
--- a/drivers/staging/vboxvideo/vbox_irq.c
+++ b/drivers/staging/vboxvideo/vbox_irq.c
@@ -150,8 +150,8 @@ static void vbox_update_mode_hints(struct vbox_private *vbox)
 
 		disconnected = !(hints->enabled);
 		crtc_id = vbox_conn->vbox_crtc->crtc_id;
-		vbox_conn->mode_hint.width = hints->cx & 0x8fff;
-		vbox_conn->mode_hint.height = hints->cy & 0x8fff;
+		vbox_conn->mode_hint.width = hints->cx;
+		vbox_conn->mode_hint.height = hints->cy;
 		vbox_conn->vbox_crtc->x_hint = hints->dx;
 		vbox_conn->vbox_crtc->y_hint = hints->dy;
 		vbox_conn->mode_hint.disconnected = disconnected;
diff --git a/drivers/staging/vboxvideo/vbox_mode.c 

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Michael Thayer]

Hello,

12.10.2017 15:41, Michael Thayer wrote:
[Discussion of debugging operating systems in virtual machines.]>
Actually there is another handy trick there (can't remember now if
> it works in non-debug builds of VirtualBox) - the machine debugger,
> which can detect the dmesg ring buffer in Linux guests without
> address-space randomisation, which often means that you can take a look
> at it on a hung guest.
No, it is available in all builds.

Regards
Michael
-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Michael Thayer]

Hello,

12.10.2017 14:44, Hans de Goede wrote:
[Discussion of getting at guest log data inside a virtual machine.]
> Adding this code from the vboxguest driver I'm upstreaming:
> 
> To some .h file:
> 
> /**
>  * vboxguest logging functions, these log both to the backdoor and call
>  * the equivalent kernel pr_foo function.
>  */
> __printf(1, 2) void vbg_info(const char *fmt, ...);
> __printf(1, 2) void vbg_warn(const char *fmt, ...);
> __printf(1, 2) void vbg_err(const char *fmt, ...);
> 
> To a .c file:
> 
> #define VBG_LOG(name, pr_func) \
> void name(const char *fmt, ...) \
> {   \
>     unsigned long flags;    \
>     va_list args;   \
>     int i, count;   \
>     \
>     va_start(args, fmt);    \
>     spin_lock_irqsave(_log_lock, flags);    \
>     \
>     count = vscnprintf(vbg_log_buf, sizeof(vbg_log_buf), fmt, args);\
>     for (i = 0; i < count; i++) \
>     outb(vbg_log_buf[i], VBG_DEBUG_PORT);   \
>     \
>     pr_func("%s", vbg_log_buf); \
>     \
>     spin_unlock_irqrestore(_log_lock, flags);   \
>     va_end(args);   \
> }   \
> EXPORT_SYMBOL(name)
> 
> VBG_LOG(vbg_info, pr_info);
> VBG_LOG(vbg_warn, pr_warn);
> VBG_LOG(vbg_err, pr_err);
> 
> And then calling vbg_info / whatever to log should do the trick.
[...]Actually there is another handy trick there (can't remember now if
it works in non-debug builds of VirtualBox) - the machine debugger,
which can detect the dmesg ring buffer in Linux guests without
address-space randomisation, which often means that you can take a look
at it on a hung guest.

Regards
Michael
-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Hans de Goede]

Hi,

On 12-10-17 11:17, Michael Thayer wrote:

Hello Both,

11.10.2017 17:41, Hans de Goede wrote:

Hi,

On 11-10-17 07:26, Michael Thayer wrote:

Hello Gianfranco,

02.10.2017 12:11, Gianfranco Costamagna wrote:

Thanks for the heads-up.  I am gradually adjusting our in-tree code to
match vboxvideo in staging, so at some point, when things stop turning
up to stop me, I will probably hit the crucial difference.  Gianfranco,
if you have time could you please give the Additions from the next beta
release a try, when it is available, since I have already started the
process?  I would be very grateful if you could.  I will too of course
when I find a moment, moments are just in short supply.



RC1 is now broken too

I haven't taken a look at the in-kernel version, but in RC1 the reason
was that the arguments to out*() calls got swapped: the Linux kernel
reverses them compared to everyone else I know of, and I failed to do
that during clean-up to match kernel style.  Will be committing soon.


Ok, so I double checked and this is not the same problem as people using
the driver from the upstream kernel's driver/staging are seeing, the
outl/w/b operands there are all in the right order.


That does not surprise me greatly.  The question is who if anyone will
instrument the staging version with printk commands to see what is going
wrong.  Hans, if you can answer without wasting time researching, can
you think of a simple way to send printk output straight to the
VirtualBox debug I/O port?  That could be simpler than setting up a
virtual serial port.  (I wonder how much work it would be to send
virtual serial port output straight to the log file...)  I do not
immediately plan to do the instrumentation - it is lower priority for me
than getting our code in a state to be submitted to the kernel, and that
is already going slowly enough.


Adding this code from the vboxguest driver I'm upstreaming:

To some .h file:

/**
 * vboxguest logging functions, these log both to the backdoor and call
 * the equivalent kernel pr_foo function.
 */
__printf(1, 2) void vbg_info(const char *fmt, ...);
__printf(1, 2) void vbg_warn(const char *fmt, ...);
__printf(1, 2) void vbg_err(const char *fmt, ...);

To a .c file:

#define VBG_LOG(name, pr_func) \
void name(const char *fmt, ...) \
{   \
unsigned long flags;\
va_list args;   \
int i, count;   \
\
va_start(args, fmt);\
spin_lock_irqsave(_log_lock, flags);\
\
count = vscnprintf(vbg_log_buf, sizeof(vbg_log_buf), fmt, args);\
for (i = 0; i < count; i++) \
outb(vbg_log_buf[i], VBG_DEBUG_PORT);   \
\
pr_func("%s", vbg_log_buf); \
\
spin_unlock_irqrestore(_log_lock, flags);   \
va_end(args);   \
}   \
EXPORT_SYMBOL(name)

VBG_LOG(vbg_info, pr_info);
VBG_LOG(vbg_warn, pr_warn);
VBG_LOG(vbg_err, pr_err);

And then calling vbg_info / whatever to log should do the trick.

But I've just managed to reproduce this using F27 / gnome-shell 3.26,
so I'm looking into a fix now.

Regards,

Hans
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Hans de Goede]

Hi,

On 11-10-17 07:26, Michael Thayer wrote:

Hello Gianfranco,

02.10.2017 12:11, Gianfranco Costamagna wrote:

Thanks for the heads-up.  I am gradually adjusting our in-tree code to
match vboxvideo in staging, so at some point, when things stop turning
up to stop me, I will probably hit the crucial difference.  Gianfranco,
if you have time could you please give the Additions from the next beta
release a try, when it is available, since I have already started the
process?  I would be very grateful if you could.  I will too of course
when I find a moment, moments are just in short supply.



RC1 is now broken too

I haven't taken a look at the in-kernel version, but in RC1 the reason
was that the arguments to out*() calls got swapped: the Linux kernel
reverses them compared to everyone else I know of, and I failed to do
that during clean-up to match kernel style.  Will be committing soon.


Ok, so I double checked and this is not the same problem as people using
the driver from the upstream kernel's driver/staging are seeing, the
outl/w/b operands there are all in the right order.

Regards,

Hans
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Michael Thayer]

Hello,

11.10.2017 10:57, Gianfranco Costamagna wrote:
> Hello,
>> I haven't taken a look at the in-kernel version, but in RC1 the reason
>> was that the arguments to out*() calls got swapped: the Linux kernel
>> reverses them compared to everyone else I know of, and I failed to do
>> that during clean-up to match kernel style.  Will be committing soon.
> 
> 
> thanks, please ping when you have a patch or something to test!

Please see change set 69034.[1]

[1] https://www.virtualbox.org/changeset/69034/vbox

Regards
Michael
-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Gianfranco Costamagna]

Hello,
>I haven't taken a look at the in-kernel version, but in RC1 the reason
>was that the arguments to out*() calls got swapped: the Linux kernel
>reverses them compared to everyone else I know of, and I failed to do
>that during clean-up to match kernel style.  Will be committing soon.


thanks, please ping when you have a patch or something to test!

G.
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Michael Thayer]

Hello Gianfranco,

02.10.2017 12:11, Gianfranco Costamagna wrote:
>> Thanks for the heads-up.  I am gradually adjusting our in-tree code to
>> match vboxvideo in staging, so at some point, when things stop turning
>> up to stop me, I will probably hit the crucial difference.  Gianfranco,
>> if you have time could you please give the Additions from the next beta
>> release a try, when it is available, since I have already started the
>> process?  I would be very grateful if you could.  I will too of course
>> when I find a moment, moments are just in short supply.
> 
> 
> RC1 is now broken too
I haven't taken a look at the in-kernel version, but in RC1 the reason
was that the arguments to out*() calls got swapped: the Linux kernel
reverses them compared to everyone else I know of, and I failed to do
that during clean-up to match kernel style.  Will be committing soon.

Regards
Michael
-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Gianfranco Costamagna]

Hello Michael,


>Thanks for the heads-up.  I am gradually adjusting our in-tree code to
>match vboxvideo in staging, so at some point, when things stop turning
>up to stop me, I will probably hit the crucial difference.  Gianfranco,
>if you have time could you please give the Additions from the next beta
>release a try, when it is available, since I have already started the
>process?  I would be very grateful if you could.  I will too of course
>when I find a moment, moments are just in short supply.


RC1 is now broken too

G.
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Sérgio Basto]

Hi, adding cc to rpmfusion-devel , maybe someone could suggests or  
teach something ...

On Sat, 2017-09-30 at 16:34 +0200, Hans de Goede wrote:
> Hi,
> 
> On 29-09-17 19:38, Sérgio Basto wrote:
> > On Fri, 2017-09-29 at 19:27 +0200, Hans de Goede wrote:
> > > Hi,
> > > 
> > > On 28-09-17 15:00, Sérgio Basto wrote:
> > > > On Wed, 2017-09-27 at 18:16 +0200, Hans de Goede wrote:
> > > > > I just tried Fedora kernel 4.13.1-303.fc27, which has the
> > > > > vboxvideo
> > > > > driver enabled,
> > > > 
> > > > This is enabled in Fedora kernels or vanilla kernels , do you
> > > > mean
> > > > since 4.13.1 vbox guestaditionals drives are in main kernel ?
> > > 
> > > What I mean is that I've tested with the Fedora 4.13.1-303.fc27
> > > kernel which has the vboxvideo driver from staging/mainline
> > > enabled,
> > > without any additional out of tree drivers and things work fine
> > > with
> > > that kernel.
> > 
> > ok , Have you the kernel in copr or in koji or some other place ? ,
> > where I can download src.rpm and test it my self .
> 
> It simply is a standard Fedora kernel built (all Fedora 4.13 kernels
> have
> the vboxvideo driver from staging enabled), you can find the specific
> version I used during testing here:
> 
> https://koji.fedoraproject.org/koji/buildinfo?buildID=970235


Very cool ! thanks, I want learn how enable staging kernel things in
the kernel , also I think we got staging-kmod in RPMFusion for that [1]
but I don't know how this work , I know that is not updated for a very
long time . 

[1]
https://pkgs.rpmfusion.org/cgit/free/staging-kmod.git/tree/staging-kmod
.spec


> Regards,
> 
> Hans
-- 
Sérgio M. B.
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Hans de Goede]

Hi,

On 29-09-17 19:38, Sérgio Basto wrote:

On Fri, 2017-09-29 at 19:27 +0200, Hans de Goede wrote:

Hi,

On 28-09-17 15:00, Sérgio Basto wrote:

On Wed, 2017-09-27 at 18:16 +0200, Hans de Goede wrote:

I just tried Fedora kernel 4.13.1-303.fc27, which has the
vboxvideo
driver enabled,


This is enabled in Fedora kernels or vanilla kernels , do you mean
since 4.13.1 vbox guestaditionals drives are in main kernel ?


What I mean is that I've tested with the Fedora 4.13.1-303.fc27
kernel which has the vboxvideo driver from staging/mainline enabled,
without any additional out of tree drivers and things work fine with
that kernel.


ok , Have you the kernel in copr or in koji or some other place ? ,
where I can download src.rpm and test it my self .


It simply is a standard Fedora kernel built (all Fedora 4.13 kernels have
the vboxvideo driver from staging enabled), you can find the specific
version I used during testing here:

https://koji.fedoraproject.org/koji/buildinfo?buildID=970235

Regards,

Hans
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Sérgio Basto]

On Fri, 2017-09-29 at 19:27 +0200, Hans de Goede wrote:
> Hi,
> 
> On 28-09-17 15:00, Sérgio Basto wrote:
> > On Wed, 2017-09-27 at 18:16 +0200, Hans de Goede wrote:
> > > I just tried Fedora kernel 4.13.1-303.fc27, which has the
> > > vboxvideo
> > > driver enabled,
> > 
> > This is enabled in Fedora kernels or vanilla kernels , do you mean
> > since 4.13.1 vbox guestaditionals drives are in main kernel ?
> 
> What I mean is that I've tested with the Fedora 4.13.1-303.fc27
> kernel which has the vboxvideo driver from staging/mainline enabled,
> without any additional out of tree drivers and things work fine with
> that kernel.

ok , Have you the kernel in copr or in koji or some other place ? ,
where I can download src.rpm and test it my self . 

Thanks

> Regards,
> 
> Hans
> ___
> vbox-dev mailing list
> vbox-dev@virtualbox.org
> https://www.virtualbox.org/mailman/listinfo/vbox-dev
-- 
Sérgio M. B.
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Hans de Goede]

Hi,

On 28-09-17 15:00, Sérgio Basto wrote:

On Wed, 2017-09-27 at 18:16 +0200, Hans de Goede wrote:

I just tried Fedora kernel 4.13.1-303.fc27, which has the vboxvideo
driver enabled,


This is enabled in Fedora kernels or vanilla kernels , do you mean
since 4.13.1 vbox guestaditionals drives are in main kernel ?


What I mean is that I've tested with the Fedora 4.13.1-303.fc27
kernel which has the vboxvideo driver from staging/mainline enabled,
without any additional out of tree drivers and things work fine with
that kernel.

Regards,

Hans
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Michael Thayer]

Hello All,

29.09.2017 12:30, Gianfranco Costamagna wrote:
> Hello Hans, Sergio,
> 
>> I just tried Fedora kernel 4.13.1-303.fc27, which has the vboxvideo driver 
>> enabled,
>> with gnome 3.24 from Fedora 26 with both X11 and Wayland and both work fine 
>> for me,
>> not sure what is going on? Is this with gnome-3.26? I can give that a try if 
>> you want,
>> but that would point to a gnome bug, not a bug in the vboxvideo.
> 
> 
> yep gnome-shell 3.26, but I don't see why it should be a gnome-shell bug.
> 
> The dkms driver works, as well as the virtualbox one. Just the linux driver 
> fails
>> Is there anything special about the setup of the users seeing this ? Have 
>> you tried
>> to reproduce this yourself?
> 
> 
> Install ubuntu artful beta2 and download the old kernel from launchpad is 
> enough to trigger the issue.
> the new kernel in artful has that staging driver disabled, so it can't see it
> 
>> This is enabled in Fedora kernels or vanilla kernels , do you mean
>> since 4.13.1 vbox guestaditionals drives are in main kernel ?
> 
> 
> exactly enabling/disabling 3D acceleration seems to be not helping
> 
> 
>> Gianfranco, since kernel 3.11 , vboxvideo_drv.so for xorg-X11 should be
>> removed from the system and we start use just vboxvideo.ko (kernel
> 
> I removed that file looong time ago, when Debian switched to rootless X server
> (I grabbed also the xorg patch that is merged in vbox 5.2 I think)
> https://anonscm.debian.org/cgit/pkg-virtualbox/virtualbox.git/tree/debian/patches/new-xorg-1.19.patch
> 
> BTW apt-get install virtualbox-guest-dkms grabs the virtualbox guest driver, 
> and loading
> that one works, this is why I'm actually blaming the mainline staging driver 
> :)
Thanks for the heads-up.  I am gradually adjusting our in-tree code to
match vboxvideo in staging, so at some point, when things stop turning
up to stop me, I will probably hit the crucial difference.  Gianfranco,
if you have time could you please give the Additions from the next beta
release a try, when it is available, since I have already started the
process?  I would be very grateful if you could.  I will too of course
when I find a moment, moments are just in short supply.

Regards
Michael
-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Sérgio Basto]

On Wed, 2017-09-27 at 18:16 +0200, Hans de Goede wrote:
> I just tried Fedora kernel 4.13.1-303.fc27, which has the vboxvideo
> driver enabled,

This is enabled in Fedora kernels or vanilla kernels , do you mean
since 4.13.1 vbox guestaditionals drives are in main kernel ? 

Gianfranco, since kernel 3.11 , vboxvideo_drv.so for xorg-X11 should be
removed from the system and we start use just vboxvideo.ko (kernel
module) 

Thanks, 
-- 
Sérgio M. B.
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Hans de Goede]

Hi,

On 27-09-17 08:46, Gianfranco Costamagna wrote:

Hello, we tried in Ubuntu to use the new shiny vboxvideo mainline kernel driver

with the new shiny CONFIG_DRM_VBOXVIDEO config key, and we had to quickly 
disable
it to use the old working kernel module.

Reason: it breaks with wayland.

see:

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1718679

Right now it will be kept disabled until somebody sorts this out, but the 
question
for now is:

did anybody check/test or had to patch wayland to make it work, or
has been only tested with X11 server?


I just tried Fedora kernel 4.13.1-303.fc27, which has the vboxvideo driver 
enabled,
with gnome 3.24 from Fedora 26 with both X11 and Wayland and both work fine for 
me,
not sure what is going on? Is this with gnome-3.26? I can give that a try if 
you want,
but that would point to a gnome bug, not a bug in the vboxvideo.

Is there anything special about the setup of the users seeing this ? Have you 
tried
to reproduce this yourself?

Regards,

Hans
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

[vbox-dev] New virtualbox vboxvideo mainline kernel broken in Ubuntu

[Gianfranco Costamagna]

Hello, we tried in Ubuntu to use the new shiny vboxvideo mainline kernel driver

with the new shiny CONFIG_DRM_VBOXVIDEO config key, and we had to quickly 
disable
it to use the old working kernel module.

Reason: it breaks with wayland.

see:

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1718679

Right now it will be kept disabled until somebody sorts this out, but the 
question
for now is:

did anybody check/test or had to patch wayland to make it work, or
has been only tested with X11 server?

thanks,

Gianfranco
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev