Re: [vdr] VDR 1.7 and no subtitles with old PES recordings

2009-11-18 Thread jjtt 
On Tue, Nov 17, 2009 at 06:42:28PM +0200, Rolf Ahrenberg wrote:
 On Tue, 6 Oct 2009, j...@mbnet.fi wrote:
 
  Subtitles are shown corretly both when viewing live tv and
  when viewing new recordings, but when viewing old PES
  recordings VDR just says that no subtitles are available.
 
 Zimiq did all the hard work to pinpoint the faulty method: 
 http://www.linuxtv.fi/viewtopic.php?p=24394#24394
 
 At least this patch did help on my few old recordings:
 
 --- dvbsubtitle.c.orig   2009-11-17 18:29:16.0 +0200
 +++ dvbsubtitle.c   2009-11-17 18:30:44.0 +0200
 @@ -699,7 +699,7 @@
   }
 
if (Length  PayloadOffset + SubstreamHeaderLength) {
 -int64_t pts = PesGetPts(Data);
 +int64_t pts = PesHasPts(Data) ? PesGetPts(Data) : 0;
   if (pts)
  dbgconverter(Converter PTS: %lld\n, pts);
   const uchar *data = Data + PayloadOffset + SubstreamHeaderLength; 
 // skip substream header


I applied the patch and 1.7.9 now shows subtitles from
old recordings correctly.

Thank you.




___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.7 and no subtitles with old PES recordings

2009-11-17 Thread Rolf Ahrenberg 

On Tue, 6 Oct 2009, j...@mbnet.fi wrote:


I'm contemplating updating my trusty 1.6.0 to the latest
development version, but I can't seem to get DVB subtitles
from old recordings to work.

Subtitles are shown corretly both when viewing live tv and
when viewing new recordings, but when viewing old PES
recordings VDR just says that no subtitles are available.

I'm using vanilla VDR and the xineliboutput plugin.


Zimiq did all the hard work to pinpoint the faulty method: 
http://www.linuxtv.fi/viewtopic.php?p=24394#24394


At least this patch did help on my few old recordings:

--- dvbsubtitle.c.orig   2009-11-17 18:29:16.0 +0200
+++ dvbsubtitle.c   2009-11-17 18:30:44.0 +0200
@@ -699,7 +699,7 @@
 }

  if (Length  PayloadOffset + SubstreamHeaderLength) {
-int64_t pts = PesGetPts(Data);
+int64_t pts = PesHasPts(Data) ? PesGetPts(Data) : 0;
 if (pts)
dbgconverter(Converter PTS: %lld\n, pts);
 const uchar *data = Data + PayloadOffset + SubstreamHeaderLength; // 
skip substream header


BR,
--
rofa

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.7 and no subtitles with old PES recordings

2009-10-06 Thread Rolf Ahrenberg 

On Tue, 6 Oct 2009, j...@mbnet.fi wrote:


I searched through the archives and the only mention of a
similar problem I could find is the one below, but
unfortunately no solution.


I debugged this a while ago and the problem is that the difference of 
PTS and STC is way off in old PES recordings and therefore VDR discards 
all subtitles. I wasn't keen enough to fix it, so if somebody has plenty 
of free time.. :)


BR,
--
rofa

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr