[vdsm] vdsm sync meeting minutes Feb 24th, 2014
vdsm sync call Feb 24th 2014 = - Toni to add Douglas to the linkPool patch so it can go into the build. - Try and give karma to iscsiadm bug https://bugzilla.redhat.com/1057761 https://admin.fedoraproject.org/updates/selinux-policy-3.12.1-74.19.fc19 Needs to be backported as well. Douglas offers to help with the testing for karma giving. - TLV meeting: - Design and architecture discussion: Nir proposes to go over the general design. Dispatcher, tasks. Adam agrees with the design request and warns about Python constructs for the possibility of hidden pitfalls. - Style guide discussion: Documentation, idioms, etc. Nir, Adam and Toni subscribe that. Adam proposes pushing for smaller patches. Toni pushes for topic branches of smaller patches that are considered in the context of the branch and not as self-standing patches. - JSON rpc discussion: Revive? plan etc. Adam wants to talk about the needs to make the engine start using JSON and get rid of the hacks. AMQP plans. Find ways to deprecate XMLRPC and get the API consistent in its representations. - Task creation: Nir proposes to discuss the way in which tasks are handled between engine and vdsm, so that the task uuid is pushed from the engine. - Get some presentation about SLA side of thinks. Adam asks if maybe Martin or Doron could do that? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm sync meeting minutes Feb 24th, 2014
- Original Message - From: ybronhei ybron...@redhat.com To: Antoni Segura Puimedon asegu...@redhat.com, VDSM Project Development vdsm-devel@lists.fedorahosted.org, Piotr Kliczewski piotr.kliczew...@gmail.com, Doron Fediuck dfedi...@redhat.com Sent: Monday, February 24, 2014 6:33:56 PM Subject: Re: [vdsm] vdsm sync meeting minutes Feb 24th, 2014 On 02/24/2014 05:06 PM, Antoni Segura Puimedon wrote: vdsm sync call Feb 24th 2014 = - Toni to add Douglas to the linkPool patch so it can go into the build. - Try and give karma to iscsiadm bug https://bugzilla.redhat.com/1057761 https://admin.fedoraproject.org/updates/selinux-policy-3.12.1-74.19.fc19 Needs to be backported as well. Douglas offers to help with the testing for karma giving. - TLV meeting: - Design and architecture discussion: Nir proposes to go over the general design. Dispatcher, tasks. Adam agrees with the design request and warns about Python constructs for the possibility of hidden pitfalls. - Style guide discussion: Documentation, idioms, etc. Nir, Adam and Toni subscribe that. Adam proposes pushing for smaller patches. Toni pushes for topic branches of smaller patches that are considered in the context of the branch and not as self-standing patches. - JSON rpc discussion: Revive? plan etc. Adam wants to talk about the needs to make the engine start using JSON and get rid of the hacks. AMQP plans. Find ways to deprecate XMLRPC and get the API consistent in its representations. - Task creation: Nir proposes to discuss the way in which tasks are handled between engine and vdsm, so that the task uuid is pushed from the engine. - Get some presentation about SLA side of thinks. Adam asks if maybe Martin or Doron could do that? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel Hey, sorry to miss the call today, I was at first but dropped after we started the discussion and failed to join back the json rpc part is merged to vdsm, pushed by saggi and Piotr, maybe Piotr can add more plan's details about that part? about the design and architecture discussion, i also think we should talk how we can improve\refactor mainly the tasks infrastructure, i know that some groups have stable roadmap plans (not only SLA) that can be shared for discussion and review (mostly storage parts - e.g. removing the pool concept), and we'll discuss about more suggestions for improvement that will be raised. -- Yaniv Bronhaim. Hi guys, Martin is joining you to help where possible. Please let me know what are you aiming for and we'll make sure you have the SLA view for it. In general I can tell you we have a few things planned for the next 2++ versions, so we need to focus on the relevant parts of your meetup. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm sync meeting minutes Feb 24th, 2014
On 02/24/2014 10:06 AM, Antoni Segura Puimedon wrote: vdsm sync call Feb 24th 2014 = - Toni to add Douglas to the linkPool patch so it can go into the build. Hey Toni, please get it approved/backported for the ovirt-3.4 branch. - Try and give karma to iscsiadm bug https://bugzilla.redhat.com/1057761 https://admin.fedoraproject.org/updates/selinux-policy-3.12.1-74.19.fc19 Needs to be backported as well. Douglas offers to help with the testing for karma giving. Added karma/updated bug since during my tests the selinux permission error is gone. https://admin.fedoraproject.org/updates/selinux-policy-3.12.1-74.19.fc19 https://bugzilla.redhat.com/show_bug.cgi?id=1057761#c4 - TLV meeting: - Design and architecture discussion: Nir proposes to go over the general design. Dispatcher, tasks. Adam agrees with the design request and warns about Python constructs for the possibility of hidden pitfalls. - Style guide discussion: Documentation, idioms, etc. Nir, Adam and Toni subscribe that. Adam proposes pushing for smaller patches. Toni pushes for topic branches of smaller patches that are considered in the context of the branch and not as self-standing patches. - JSON rpc discussion: Revive? plan etc. Adam wants to talk about the needs to make the engine start using JSON and get rid of the hacks. AMQP plans. Find ways to deprecate XMLRPC and get the API consistent in its representations. - Task creation: Nir proposes to discuss the way in which tasks are handled between engine and vdsm, so that the task uuid is pushed from the engine. - Get some presentation about SLA side of thinks. Adam asks if maybe Martin or Doron could do that? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel -- Cheers Douglas ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] Fwd: Fwd: suggested patch for python-pthreading
back to the topic I would like to continue pushing the fix in. Nir, iirc you suggested a patch to validate that pthreading.monkey_patch() is being called before using the native thread and pthreading module, right? any comments about that part? Original Message Subject: Fwd: [vdsm] suggested patch for python-pthreading Date: Tue, 18 Feb 2014 09:32:59 -0500 (EST) From: Nir Soffer nsof...@redhat.com To: Yaniv Bronheim ybron...@redhat.com - Forwarded Message - From: Yaniv Bronheim ybron...@redhat.com To: Nir Soffer nsof...@redhat.com Cc: Dan Kenigsberg dan...@redhat.com, VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Wednesday, February 5, 2014 6:41:28 PM Subject: Re: [vdsm] suggested patch for python-pthreading - Original Message - From: Nir Soffer nsof...@redhat.com To: Dan Kenigsberg dan...@redhat.com Cc: Yaniv Bronheim ybron...@redhat.com, VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Tuesday, February 4, 2014 4:39:55 PM Subject: Re: [vdsm] suggested patch for python-pthreading - Original Message - From: Dan Kenigsberg dan...@redhat.com To: Nir Soffer nsof...@redhat.com Cc: Yaniv Bronheim ybron...@redhat.com, VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Tuesday, February 4, 2014 3:51:02 PM Subject: Re: [vdsm] suggested patch for python-pthreading On Tue, Feb 04, 2014 at 05:14:51AM -0500, Nir Soffer wrote: - Original Message - From: Yaniv Bronheim ybron...@redhat.com To: Nir Soffer nsof...@redhat.com Cc: VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Tuesday, February 4, 2014 11:53:52 AM Subject: Re: [vdsm] suggested patch for python-pthreading - Original Message - From: Nir Soffer nsof...@redhat.com To: Yaniv Bronheim ybron...@redhat.com Cc: VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Tuesday, February 4, 2014 11:39:56 AM Subject: Re: [vdsm] suggested patch for python-pthreading - Original Message - From: Yaniv Bronheim ybron...@redhat.com To: VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Tuesday, February 4, 2014 11:04:37 AM Subject: [vdsm] suggested patch for python-pthreading according to coredumps we found in the scope of the bug [1] we opened [2] that suggested to override python's implementation of thread.allocate_lock in each coredump we saw few threads stuck with the bt: #16 0x7fcb69288c93 in PyEval_CallObjectWithKeywords (func=0x2527820, arg=0x7fcb6972f050, kw=value optimized out) at Python/ceval.c:3663 #17 0x7fcb692ba7ba in t_bootstrap (boot_raw=0x250a820) at Modules/threadmodule.c:428 #18 0x7fcb68fa3851 in start_thread (arg=0x7fcb1bfff700) at pthread_create.c:301 #19 0x7fcb6866694d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:115 in pystack the threads were stuck in /usr/lib64/python2.6/threading.py (513): __bootstrap_inner in bootstrap_inner we use thread.allocate_lock which python-pthreading does not override. we suggest the following commit: From 9d89e9be1a379b3d93b23dd54a381b9ca0973ebc Mon Sep 17 00:00:00 2001 From: Yaniv Bronhaim ybron...@redhat.com Date: Mon, 3 Feb 2014 19:24:30 +0200 Subject: [PATCH] Mocking thread.allocate_lock with Lock imp Signed-off-by: Yaniv Bronhaim ybron...@redhat.com --- pthreading.py | 4 1 file changed, 4 insertions(+) diff --git a/pthreading.py b/pthreading.py index 916ca7f..96df42c 100644 --- a/pthreading.py +++ b/pthreading.py @@ -132,6 +132,10 @@ def monkey_patch(): Thus, Queue and SocketServer can easily enjoy them. +import thread + +thread.allocate_lock = Lock + import threading threading.Condition = Condition -- 1.8.3.1 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1022036 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1060749 Replacing allocate_lock in thread is correct. However, since threading copies thread.allocate_lock, and you don't control import order, you have to monkeypatch threading.allocate_lock as well. The full should be: import thread thread.allocate_lock = Lock import threading threading.allocate_lock = Lock threading.Lock = Lock Nir thanks Nir for the reply and review I guess you meant threading._allocate_lock, but we monkey patch it in an order so we do control the import order.. not sure its necessary Correct, threading._allocate_lock. And we also have to
